@intentius/chant 0.69.1 → 0.70.0

package/dist/cli/handlers/lifecycle.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"lifecycle.d.ts","sourceRoot":"","sources":["../../../src/cli/handlers/lifecycle.ts"],"names":[],"mappings":"AA6CA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAKlD,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,aAAa,CAAC;AAC9C,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,cAAc,CAAC;AAEhD;;;;;;;GAOG;AACH,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,UAAU,EAAE,MAAM,EAAE,WAAW,GAAG,MAAM,CAE9E;AAmCD;;GAEG;AACH,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAyH/E;AAED;;GAEG;AACH,wBAAsB,gBAAgB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CA4C3E;AAED;;;;;;GAMG;AACH,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CA8B/E;AAED;;GAEG;AACH,wBAAsB,gBAAgB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAmL3E;AAmrBD;;;;;;;;;GASG;AACH,wBAAsB,gBAAgB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAwQ3E;AAED;;;;;;;;;;;GAWG;AACH,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CA2L/E;AAsBD;;GAEG;AACH,wBAAsB,eAAe,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAiB1E;AAgBD;;;;;;;;GAQG;AACH,wBAAsB,kBAAkB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAmE7E;AAiCD;;GAEG;AACH,wBAAsB,mBAAmB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAM9E;AAkBD;;;;;;GAMG;AACH,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CA+C/E"}
+{"version":3,"file":"lifecycle.d.ts","sourceRoot":"","sources":["../../../src/cli/handlers/lifecycle.ts"],"names":[],"mappings":"AA6CA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAKlD,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,aAAa,CAAC;AAC9C,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,cAAc,CAAC;AAEhD;;;;;;;GAOG;AACH,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,UAAU,EAAE,MAAM,EAAE,WAAW,GAAG,MAAM,CAE9E;AAmCD;;GAEG;AACH,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAyH/E;AAED;;GAEG;AACH,wBAAsB,gBAAgB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CA4C3E;AAED;;;;;;GAMG;AACH,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CA8B/E;AAED;;GAEG;AACH,wBAAsB,gBAAgB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAmL3E;AAmrBD;;;;;;;;;GASG;AACH,wBAAsB,gBAAgB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAqR3E;AAED;;;;;;;;;;;GAWG;AACH,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CA2L/E;AAsBD;;GAEG;AACH,wBAAsB,eAAe,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAiB1E;AAgBD;;;;;;;;GAQG;AACH,wBAAsB,kBAAkB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAmE7E;AAiCD;;GAEG;AACH,wBAAsB,mBAAmB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CAM9E;AAkBD;;;;;;GAMG;AACH,wBAAsB,oBAAoB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,MAAM,CAAC,CA+C/E"}

package/dist/cli/main.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"main.d.ts","sourceRoot":"","sources":["../../src/cli/main.ts"],"names":[],"mappings":";AAMA,OAAO,EAAkB,KAAK,UAAU,EAAE,KAAK,UAAU,EAAE,MAAM,YAAY,CAAC;AAwF9E;;GAEG;AACH,wBAAgB,SAAS,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,UAAU,CA6VpD;AAgbD;;;;;;;;;GASG;AACH,eAAO,MAAM,eAAe,EAAE,UAAU,EAkGvC,CAAC;AAgIF;;;;;;;;GAQG;AACH,wBAAgB,kBAAkB,CAAC,MAAM,EAAE,MAAM,CAAC,WAAW,GAAG,OAAO,CAAC,IAAI,CAAC,CAuB5E"}
+{"version":3,"file":"main.d.ts","sourceRoot":"","sources":["../../src/cli/main.ts"],"names":[],"mappings":";AAMA,OAAO,EAAkB,KAAK,UAAU,EAAE,KAAK,UAAU,EAAE,MAAM,YAAY,CAAC;AAwF9E;;GAEG;AACH,wBAAgB,SAAS,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,UAAU,CA6VpD;AAqbD;;;;;;;;;GASG;AACH,eAAO,MAAM,eAAe,EAAE,UAAU,EAkGvC,CAAC;AAgIF;;;;;;;;GAQG;AACH,wBAAgB,kBAAkB,CAAC,MAAM,EAAE,MAAM,CAAC,WAAW,GAAG,OAAO,CAAC,IAAI,CAAC,CAuB5E"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@intentius/chant",
-  "version": "0.69.1",
+  "version": "0.70.0",
   "description": "Declarative infrastructure-as-code toolkit — TypeScript on Node.js",
   "license": "Apache-2.0",
   "homepage": "https://intentius.io/chant",

package/src/cli/handlers/lifecycle.test.ts

@@ -916,6 +916,71 @@ describe("runLifecyclePlan", () => {
   // #2162 — a held property is not an action, so the plan carries it beside
   // `entries` rather than inside one, attributed to its lexicon the same way
   // an entry is.
+  test("without --deep the pass does not run, and the entries are unchanged (#2405)", async () => {
+    // The property that makes `--deep` safe to default off: a held property is
+    // never a proposal, so the change set is identical either way and the only
+    // thing the flag buys is the HELD section. If that stops being true, this
+    // is where it shows.
+    const makeBuild = () => {
+      const b = makeBuildResult({ k8s: ["web"] });
+      b.entities.set("web", {
+        lexicon: "k8s",
+        entityType: "K8s::Apps::Deployment",
+        props: { spec: { replicas: heldElsewhere<number>({ by: "hpa", reason: "the autoscaler owns replicas after the first apply" }) } },
+      } as never);
+      return b;
+    };
+    let deepCalls = 0;
+    const makePlugins = (): LexiconPlugin[] => {
+      const inner = staticDeepObservation({
+        web: { type: "K8s::Apps::Deployment", properties: { spec: { replicas: 5 } } },
+      });
+      return [
+        createMockPlugin({
+          name: "k8s",
+          describeResources: staticObservation({ web: meta({ type: "K8s::Apps::Deployment" }) }),
+          // Counting wrapper: the helper's return type is the plugin member's,
+          // which is optional, so it is narrowed once here rather than at the
+          // call.
+          observeResourcesDeep: ((opts: never) => {
+            deepCalls += 1;
+            return inner!(opts);
+          }) as never,
+        }),
+      ];
+    };
+
+    const run = async (deep: boolean) => {
+      stdoutBuf.length = 0;
+      buildMock.mockResolvedValue(makeBuild());
+      const plugins = makePlugins();
+      const exit = await runLifecyclePlan({
+        args: makeArgs({ path: "plan", extraPositional: "prod", json: true, ...(deep ? { deep: true } : {}) }),
+        plugins,
+        serializers: plugins.map((p) => p.serializer),
+      } as never);
+      expect(exit).toBe(0);
+      return JSON.parse(stdoutBuf.join("\n"));
+    };
+
+    deepCalls = 0;
+    const shallow = await run(false);
+    const callsWithoutDeep = deepCalls;
+
+    deepCalls = 0;
+    const deep = await run(true);
+
+    // The cost: the pass is not run at all without the flag.
+    expect(callsWithoutDeep).toBe(0);
+    expect(deepCalls).toBeGreaterThan(0);
+
+    // The correctness: the same proposals either way, and the held section
+    // only when it was asked for.
+    expect(shallow.entries).toEqual(deep.entries);
+    expect(shallow.held).toBeUndefined();
+    expect(deep.held).toBeDefined();
+  });
+
   test("--json carries the held set beside entries, attributed to its lexicon", async () => {
     const build = makeBuildResult({ k8s: ["web"] });
     build.entities.set("web", {
@@ -934,7 +999,7 @@ describe("runLifecyclePlan", () => {
       }),
     ];
     const exit = await runLifecyclePlan({
-      args: makeArgs({ path: "plan", extraPositional: "prod", json: true }),
+      args: makeArgs({ path: "plan", extraPositional: "prod", json: true, deep: true }),
       plugins,
       serializers: plugins.map((p) => p.serializer),
     });
@@ -971,7 +1036,7 @@ describe("runLifecyclePlan", () => {
       }),
     ];
     const exit = await runLifecyclePlan({
-      args: makeArgs({ path: "plan", extraPositional: "prod" }),
+      args: makeArgs({ path: "plan", extraPositional: "prod", deep: true }),
       plugins,
       serializers: plugins.map((p) => p.serializer),
     });

package/src/cli/handlers/lifecycle.ts

@@ -1319,11 +1319,24 @@ export async function runLifecyclePlan(ctx: CommandContext): Promise<number> {
 
       Object.assign(allObservedResources, observed.resources);
 
-      // Held properties (#2162): opt-in on the same capability the deep diff
-      // path gates on. A held property is never a proposal, so it is
-      // computed here (once per lexicon, against this same observation) and
-      // carried on the plan beside `entries` rather than folded into one.
-      if (plugin.observeResourcesDeep) {
+      // Held properties (#2162), behind `--deep` since #2405.
+      //
+      // A held property is never a proposal: it is computed against this same
+      // observation and carried on the plan beside `entries`, never folded
+      // into one. So the entries a plan proposes are identical whether this
+      // ran or not, and the only thing `--deep` buys is the HELD section.
+      //
+      // It used to run whenever the lexicon could, which made the read's cost
+      // a function of how many resources an estate holds rather than how it is
+      // organised. Measured on 528 resources across 8 stacks: 24 stack-shaped
+      // calls, and 496 from this pass. At ten thousand resources that is
+      // roughly twenty thousand calls against eighty, for a section the caller
+      // did not ask for.
+      //
+      // `--deep` is the flag `lifecycle snapshot` already uses for the same
+      // choice, and `lifecycle diff` still runs the pass unconditionally
+      // because property drift is the question it exists to answer.
+      if (args.deep && plugin.observeResourcesDeep) {
         const deep = await deepDiffForLexicon(plugin, {
           environment,
           buildOutput,

package/src/cli/main.ts

@@ -593,6 +593,11 @@ Lifecycle (alias: lc):
                             property-level drift; --update-baseline records
                             what it reports as accepted so it stops alerting)
   lifecycle plan <env>      Typed change set (create/update/delete/adopt) vs live
+                            --deep: also report properties declared
+                            heldElsewhere(). Never changes what the plan
+                            proposes; costs a provider call pair per readable
+                            resource, so the read's cost becomes a function of
+                            estate size rather than stack count (#2405)
   lifecycle affected        Stacks a change affects (--base <ref> [--include-dependents])
                             --json: emit the ChangeSet as JSON
   lifecycle whoami <env>    Who chant would act as in each configured lexicon,