@intentius/chant 0.49.0 → 0.51.0

package/src/op/step-output-ref.ts

@@ -0,0 +1,453 @@
+/**
+ * Step-output references — chant #1290 ("A step cannot reference a prior
+ * step's output, so values leave an Op only as search attributes").
+ *
+ * An Op's steps run in a fixed sequence chant already knows: phases in
+ * order, and (within a non-parallel phase) steps in order. Today the only
+ * way a value escapes a step is `outcomeAttribute`, which stringifies it
+ * into a Temporal search attribute — a UI filter, not something a later
+ * step can consume. `StepOutputRef` is the mechanism that lets a later
+ * step's `args` hold a *reference* to an earlier step's declared return
+ * value instead.
+ *
+ * Deliberately a reference, not an expression: `diff.out.driftedStacks` is
+ * a value placeholder the build resolves and the serializer compiles into a
+ * real local variable in the generated workflow — never `diff.out.count >
+ * 0` or a `.map()` over a reference. That property (an Op is data you can
+ * read and know what it does, not a program) is exactly what makes it safe
+ * to add this without Ops becoming programs; see the issue's "line not to
+ * cross".
+ *
+ * Scope, kept deliberately tight (see the issue's "Open questions"):
+ *  - same-Op only — no cross-Op plumbing (that needs a durable place to put
+ *    the value, which #1290 explicitly defers).
+ *  - main `phases` only — a step inside `onFailure` or nested inside an
+ *    `EffectStep` can neither produce nor consume a step-output reference.
+ *    `onFailure` compensation runs only when something upstream already
+ *    failed, so a main-phase step's captured result isn't reliably
+ *    available there; an effect step's nested steps run only when the
+ *    receipt comparison mismatches, so a value it produces isn't reliably
+ *    available to anything outside it either. Both are conditional
+ *    execution paths, which is exactly the class of thing #1290 keeps out
+ *    of an Op's inert-data model.
+ *  - producer must run to completion before the consumer starts: an earlier
+ *    phase, or an earlier step within the same non-parallel phase. Two
+ *    steps in the same parallel phase run concurrently (`Promise.all`) with
+ *    no ordering guarantee, so neither may reference the other.
+ *  - the producer needs a registered `ActivityContract` with a `returns`
+ *    schema — without one there is nothing to validate the reference
+ *    against, and it degrades into the same stringly path `outcomeAttribute`
+ *    already had (chant #1288 comment on this issue).
+ *
+ * Cross-contract type compatibility (chant #1950 pre-merge review, finding
+ * 3): `validateStepOutputRefs` checks the producer side (a registered
+ * contract with a `returns` schema, and — when `path` is set — that the path
+ * resolves on it) and, separately, `validateActivitySteps`/TMP012 checks a
+ * step's `args` against its own contract's `args` schema — but a
+ * {@link StepOutputRef} sitting in `args` is a placeholder object at build
+ * time, not the value it resolves to, so TMP012 skips it (see
+ * `activity-contract.ts`'s `isStepOutputRefValue` guard) rather than
+ * false-positive on it. Nothing before this compared the *consumer's*
+ * declared type at that position against the *producer's* declared type at
+ * `path` — a string-returning path could feed a number-typed arg and both
+ * checks would pass. `validateStepOutputRefs` now adds one more check for
+ * exactly this: when `path` is set, and both the producer's and the
+ * consumer's contracts are registered, it compares the zod schema at the
+ * producer's `path` against the zod schema at the consumer's arg position by
+ * primitive shape (`string`/`number`/`boolean`/`object`/`array` — see
+ * `activity-contract.ts`'s `primitiveKindOf`) and flags a mismatch. This is
+ * deliberately shallow, the same "hard stop rather than guess" posture
+ * `pathExistsInSchema`'s doc above takes for a record/array root: a union, an
+ * enum, a literal, `z.any()`/`z.unknown()`, a transform, or a ref sitting
+ * inside an array in `args` (no stable position to look up an arg schema
+ * against) all bail silently — no issue raised, not a false negative
+ * reported as clean, just genuinely out of this check's reach. A more
+ * complete version (real zod-schema subtyping/union-aware comparison) is
+ * exactly the kind of thing #1288 Stage 2 (typed step builders, deriving
+ * from contracts instead of restating them) would need anyway; deferred
+ * there rather than grown ad hoc here. A whole-value reference (no `path`)
+ * is skipped by this check for the same reason it's skipped by the
+ * path-existence check: there's no single field to compare.
+ *
+ * References only, no expressions: the issue asks for this to be "enforced
+ * by a lint rule rather than left as a convention." What's here instead is
+ * a runtime-on-load guard — `diff.out.count > 0` or a template literal over
+ * a reference coerces it to a primitive, and the reference throws when that
+ * happens, at the moment chant loads the `.op.ts` module to build the
+ * entity graph (i.e. still before anything runs). A real static lint rule
+ * would need to parse-inspect the author's TypeScript for expression syntax
+ * around a reference — a genuine ESLint-rule-shaped feature, and a bigger
+ * one than this issue's scope. The coercion guard catches the same misuse
+ * (arithmetic, comparisons, template literals, `String(...)`) without it;
+ * a `.map()`-style structural misuse already throws on its own (`StepOutputRef`
+ * has no array methods).
+ */
+
+import { z } from "zod";
+import type { ActivityStep, OpConfig, PhaseDefinition } from "./types";
+import { pathExistsInSchema, schemaAtPath, primitiveKindOf, type ActivityContract, type ActivityContractIssue } from "./activity-contract";
+
+const STEP_OUTPUT_REF_BRAND = Symbol.for("chant.op.stepOutputRef");
+
+/**
+ * A typed reference to a prior step's declared return value. Inert by
+ * construction — it carries a producer step id and an optional dot-path
+ * into that producer's return schema, resolved by `chant build`
+ * (`validateStepOutputRefs`) and compiled by the temporal serializer into a
+ * local variable holding the awaited activity result.
+ */
+export interface StepOutputRef {
+  readonly [STEP_OUTPUT_REF_BRAND]: true;
+  readonly kind: "step-output-ref";
+  /** `ActivityStep.id` of the producing step. */
+  readonly step: string;
+  /**
+   * Dot-path into the producer's declared return value (e.g.
+   * `"driftedStacks"`, `"result.healthy"`). Omitted references the whole
+   * return value.
+   */
+  readonly path?: string;
+}
+
+/**
+ * `T` with every own property additionally accepting a {@link StepOutputRef}
+ * in its place (chant #1288 Stage 2) — the authoring-time counterpart of
+ * `args` accepting a reference anywhere in the structure (#1290): a typed
+ * step-builder wrapper whose opts type is `WithStepRefs<SomeActivityArgs>`
+ * lets an author pass `diff.out.driftedStacks` for any field without an
+ * `as` cast, while runtime validation of the reference itself is still
+ * `validateStepOutputRefs`' job, not this type's.
+ */
+export type WithStepRefs<T> = { [K in keyof T]: T[K] | StepOutputRef };
+
+/** Structural guard for a value produced by {@link stepOutput} (or `activity()`'s `.out`). */
+export function isStepOutputRef(value: unknown): value is StepOutputRef {
+  return typeof value === "object" && value !== null && (value as Record<symbol, unknown>)[STEP_OUTPUT_REF_BRAND] === true;
+}
+
+function makeStepOutputRef(step: string, path?: string): StepOutputRef {
+  const ref = { [STEP_OUTPUT_REF_BRAND]: true, kind: "step-output-ref", step, ...(path ? { path } : {}) } as StepOutputRef;
+  // References only, no expressions (see module doc): coercing a reference
+  // to a primitive — `diff.out.count > 0`, `` `${diff.out.name}` ``,
+  // `String(diff.out.x)` — is exactly the "Op becomes a program" failure
+  // mode the issue calls out, so it throws immediately on load instead of
+  // silently producing a wrong value (NaN comparisons, "[object Object]").
+  const rejectExpression = (): never => {
+    throw new Error(
+      `step-output reference (step "${step}"${path ? `, path "${path}"` : ""}) was coerced to a primitive — ` +
+        "references only, no expressions: use it as a plain arg value, never inside a comparison, arithmetic, or template literal.",
+    );
+  };
+  Object.defineProperty(ref, Symbol.toPrimitive, { value: rejectExpression, enumerable: false });
+  Object.defineProperty(ref, "toString", { value: rejectExpression, enumerable: false });
+  Object.defineProperty(ref, "valueOf", { value: rejectExpression, enumerable: false });
+  return ref;
+}
+
+/**
+ * Reference a named step's output from a later step's `args`. Works with
+ * any step that has an `id` — an `activity()` builder result (which also
+ * gets the `.out` proxy sugar below) or a plain `{ kind: "activity", ...,
+ * id: "..." }` object literal, the shape composites author directly.
+ *
+ * `stepOutput(diff, "driftedStacks")` and `diff.out.driftedStacks` produce
+ * an identical reference; `stepOutput` is the explicit form for authors who
+ * build steps as object literals, or whose return schema has a top-level
+ * field literally named `step`, `path`, or `kind` (the `.out` proxy
+ * reserves those three property names for its own introspection).
+ */
+export function stepOutput(step: string | Pick<ActivityStep, "id">, path?: string): StepOutputRef {
+  const id = typeof step === "string" ? step : step.id;
+  if (!id) {
+    throw new Error(
+      "stepOutput(): the step has no `id` — pass one via activity(fn, args, { id: \"...\" }) or set `id` on the step object literal first.",
+    );
+  }
+  return makeStepOutputRef(id, path);
+}
+
+/**
+ * `.out` proxy attached to `activity()`'s result: `diff.out.driftedStacks`
+ * builds a {@link StepOutputRef} without the explicit `stepOutput()` call.
+ *
+ * A single property-access level, matching `outcomeAttribute.from`'s
+ * existing convention — the property name IS the dot-path, so a nested
+ * field is `diff.out["result.healthy"]`, not `diff.out.result.healthy`.
+ * `kind`, `step`, and `path` are reserved (the ref's own introspection
+ * fields); a return schema with a top-level field by one of those names
+ * needs `stepOutput(diff, "step")` instead.
+ */
+export function makeOutProxy(stepId: string): Record<string, StepOutputRef> {
+  const whole = makeStepOutputRef(stepId);
+  return new Proxy(whole as unknown as Record<string, StepOutputRef>, {
+    get(target, prop, receiver) {
+      if (typeof prop === "symbol" || prop === "kind" || prop === "step" || prop === "path" || prop === "toString" || prop === "valueOf") {
+        return Reflect.get(target, prop, receiver);
+      }
+      return makeStepOutputRef(stepId, prop);
+    },
+  });
+}
+
+/** Every {@link StepOutputRef} found anywhere inside `value` (recursing through plain objects and arrays). */
+export function collectStepOutputRefs(value: unknown): StepOutputRef[] {
+  if (isStepOutputRef(value)) return [value];
+  if (Array.isArray(value)) return value.flatMap(collectStepOutputRefs);
+  if (value && typeof value === "object") return Object.values(value).flatMap(collectStepOutputRefs);
+  return [];
+}
+
+/**
+ * The property-key path from `value`'s root down to `target` (found by
+ * reference identity), or `undefined` if it isn't found or sits inside an
+ * array — an array index isn't a stable position to look up a declared arg
+ * schema against (chant #1950-3's cross-contract type check skips these,
+ * same "bail on anything fancier" policy as the rest of that check).
+ */
+function locateStepOutputRefPath(value: unknown, target: StepOutputRef, path: string[] = []): string[] | undefined {
+  if (value === target) return path;
+  if (Array.isArray(value)) return undefined;
+  if (value && typeof value === "object" && !isStepOutputRef(value)) {
+    for (const [k, v] of Object.entries(value)) {
+      const found = locateStepOutputRefPath(v, target, [...path, k]);
+      if (found) return found;
+    }
+  }
+  return undefined;
+}
+
+// ── Validation ──────────────────────────────────────────────────────────────
+
+interface StepLocation {
+  phaseIndex: number;
+  stepIndex: number;
+  parallel: boolean;
+  step: ActivityStep;
+}
+
+/** Top-level `ActivityStep`s of `phases`, in authored (phase, then step) order — gates, effects, and steps nested inside an effect are not producers or consumers (see the module doc's scope note). */
+function locateActivitySteps(phases: PhaseDefinition[]): StepLocation[] {
+  const locations: StepLocation[] = [];
+  phases.forEach((phase, phaseIndex) => {
+    let stepIndex = 0;
+    for (const step of phase.steps) {
+      if (step.kind !== "activity") continue;
+      locations.push({ phaseIndex, stepIndex, parallel: phase.parallel === true, step });
+      stepIndex++;
+    }
+  });
+  return locations;
+}
+
+/** True when `producer` is guaranteed to have completed before `consumer` starts. */
+function producerPrecedes(producer: StepLocation, consumer: StepLocation): boolean {
+  if (producer.phaseIndex !== consumer.phaseIndex) return producer.phaseIndex < consumer.phaseIndex;
+  if (producer.parallel) return false; // same parallel phase — Promise.all, no ordering guarantee
+  return producer.stepIndex < consumer.stepIndex;
+}
+
+function effectNestedActivitySteps(phase: PhaseDefinition): ActivityStep[] {
+  return phase.steps.flatMap((s) => (s.kind === "effect" ? s.steps.filter((n) => n.kind === "activity") : []));
+}
+
+/** `byId`/`duplicateIds` over an Op's top-level main-phase activity steps — shared by {@link validateStepOutputRefScope} and {@link validateStepOutputRefs}. */
+function indexById(locations: StepLocation[]): { byId: Map<string, StepLocation>; duplicateIds: Set<string> } {
+  const byId = new Map<string, StepLocation>();
+  const duplicateIds = new Set<string>();
+  for (const loc of locations) {
+    if (!loc.step.id) continue;
+    if (byId.has(loc.step.id)) duplicateIds.add(loc.step.id);
+    else byId.set(loc.step.id, loc);
+  }
+  return { byId, duplicateIds };
+}
+
+/**
+ * Validate every step-output reference in an Op against scope and ordering
+ * alone — no contract needed. This is the subset of {@link
+ * validateStepOutputRefs}'s checks that don't depend on a contract map, kept
+ * as its own export so a caller with no contracts on hand (or that wants to
+ * defend against exactly this class of bug regardless of what contracts are
+ * registered) can still refuse a scope-invalid reference. The temporal
+ * lexicon's serializer (`serializeOps`) is exactly this caller: TMP013 (which
+ * calls the fuller {@link validateStepOutputRefs}) protects `chant build`,
+ * but `serializeOps` is a public export a caller can invoke directly,
+ * bypassing that lint pass — this is its own defense-in-depth.
+ *
+ * Flags:
+ *  - a reference authored inside `onFailure`, or inside an `EffectStep`'s
+ *    nested steps — out of scope by design (see the module doc); flagged
+ *    explicitly here rather than left to fall through as "unknown producer",
+ *  - a reference to an unregistered step id (no step in scope declares it),
+ *  - a duplicate step id (ambiguous producer),
+ *  - a reference to a step that does not precede the referencing step
+ *    (a later phase, a later step in the same phase, itself, or a step in
+ *    the same parallel phase).
+ */
+export function validateStepOutputRefScope(
+  config: Pick<OpConfig, "name" | "phases" | "onFailure">,
+): ActivityContractIssue[] {
+  const issues: ActivityContractIssue[] = [];
+
+  const flagOutOfScope = (steps: ActivityStep[], phaseName: string, reason: string) => {
+    for (const step of steps) {
+      for (const ref of collectStepOutputRefs(step.args)) {
+        issues.push({
+          opName: config.name,
+          phase: phaseName,
+          fn: step.fn,
+          message: `references step "${ref.step}"'s output, but ${reason}`,
+        });
+      }
+    }
+  };
+  for (const phase of config.onFailure ?? []) {
+    const steps = phase.steps.filter((s): s is ActivityStep => s.kind === "activity").concat(effectNestedActivitySteps(phase));
+    flagOutOfScope(steps, phase.name, "step-output references are not supported in onFailure compensation phases");
+  }
+  for (const phase of config.phases) {
+    flagOutOfScope(effectNestedActivitySteps(phase), phase.name, "step-output references are not supported for a step nested inside an effect step");
+  }
+
+  const locations = locateActivitySteps(config.phases);
+  const { byId, duplicateIds } = indexById(locations);
+  const phaseNameOf = (loc: StepLocation): string => config.phases[loc.phaseIndex]!.name;
+
+  for (const consumer of locations) {
+    const refs = collectStepOutputRefs(consumer.step.args);
+    for (const ref of refs) {
+      if (duplicateIds.has(ref.step)) {
+        issues.push({
+          opName: config.name,
+          phase: phaseNameOf(consumer),
+          fn: consumer.step.fn,
+          message: `references step id "${ref.step}", but that id is used by more than one step in this Op — ids must be unique`,
+        });
+        continue;
+      }
+
+      const producer = byId.get(ref.step);
+      if (!producer) {
+        issues.push({
+          opName: config.name,
+          phase: phaseNameOf(consumer),
+          fn: consumer.step.fn,
+          message: `references unknown step id "${ref.step}" — no step in this Op's main phases declares that id`,
+        });
+        continue;
+      }
+
+      if (!producerPrecedes(producer, consumer)) {
+        const reason =
+          producer.phaseIndex > consumer.phaseIndex
+            ? `step "${ref.step}" is in a later phase`
+            : producer.parallel
+              ? `step "${ref.step}" is in the same parallel phase (steps there run concurrently, with no ordering guarantee)`
+              : `step "${ref.step}" does not run before this step`;
+        issues.push({
+          opName: config.name,
+          phase: phaseNameOf(consumer),
+          fn: consumer.step.fn,
+          message: `references ${reason} — a step can only reference an earlier step's output`,
+        });
+      }
+    }
+  }
+
+  return issues;
+}
+
+/**
+ * Validate every step-output reference in an Op's main phases against a
+ * contract map and the Op's own step ordering. Scope: `config.phases` only
+ * (never `onFailure`, never a step nested inside an `EffectStep` — see the
+ * module doc). Layers contract-based checks on top of {@link
+ * validateStepOutputRefScope}'s scope/ordering checks.
+ *
+ * Flags everything {@link validateStepOutputRefScope} does, plus:
+ *  - a reference into a step whose `fn` has no registered
+ *    {@link ActivityContract}, or whose contract declares no `returns`
+ *    schema — nothing to validate the reference against,
+ *  - a `path` that does not resolve on the producer's declared return
+ *    schema (an empty `path` — the whole return value — is always valid).
+ */
+export function validateStepOutputRefs(
+  config: Pick<OpConfig, "name" | "phases" | "onFailure">,
+  contracts: ReadonlyMap<string, ActivityContract>,
+): ActivityContractIssue[] {
+  const issues = validateStepOutputRefScope(config);
+
+  const locations = locateActivitySteps(config.phases);
+  const { byId, duplicateIds } = indexById(locations);
+  const phaseNameOf = (loc: StepLocation): string => config.phases[loc.phaseIndex]!.name;
+
+  for (const consumer of locations) {
+    const refs = collectStepOutputRefs(consumer.step.args);
+    for (const ref of refs) {
+      // Already flagged by validateStepOutputRefScope — nothing to validate
+      // a contract-based check against.
+      if (duplicateIds.has(ref.step)) continue;
+      const producer = byId.get(ref.step);
+      if (!producer || !producerPrecedes(producer, consumer)) continue;
+
+      const producerContract = contracts.get(producer.step.fn);
+      if (!producerContract) {
+        issues.push({
+          opName: config.name,
+          phase: phaseNameOf(consumer),
+          fn: consumer.step.fn,
+          message: `references step "${ref.step}"'s output, but "${producer.step.fn}" has no registered activity contract to validate the reference against`,
+        });
+        continue;
+      }
+      if (!producerContract.returns) {
+        issues.push({
+          opName: config.name,
+          phase: phaseNameOf(consumer),
+          fn: consumer.step.fn,
+          message: `references step "${ref.step}"'s output, but "${producer.step.fn}"'s contract declares no return schema`,
+        });
+        continue;
+      }
+      if (ref.path && !pathExistsInSchema(producerContract.returns as z.ZodTypeAny, ref.path)) {
+        issues.push({
+          opName: config.name,
+          phase: phaseNameOf(consumer),
+          fn: consumer.step.fn,
+          message: `references step "${ref.step}"'s output path "${ref.path}", which does not exist on "${producer.step.fn}"'s declared return type`,
+        });
+        continue;
+      }
+
+      // Finding #1950-3: cross-contract primitive-type compatibility. Only
+      // meaningful for a field reference (`ref.path` set) against a
+      // registered consumer contract's arg schema at the same position in
+      // `args` — a whole-value reference (no path) is intentionally left
+      // unchecked (see the "whole-value reference... passes even without
+      // checking the producer's return shape" test/doc above). Bails
+      // silently (no issue) on anything not a plain string/number/boolean/
+      // object/array — a union, enum, literal, transform, `z.any()`, etc. —
+      // there's no cheap structural comparison for those.
+      if (ref.path) {
+        const consumerContract = contracts.get(consumer.step.fn);
+        const argPath = consumerContract && locateStepOutputRefPath(consumer.step.args, ref);
+        if (consumerContract && argPath) {
+          const consumerFieldSchema = schemaAtPath(consumerContract.args as z.ZodTypeAny, argPath);
+          const producerFieldSchema = schemaAtPath(producerContract.returns as z.ZodTypeAny, ref.path.split("."));
+          const consumerKind = consumerFieldSchema && primitiveKindOf(consumerFieldSchema);
+          const producerKind = producerFieldSchema && primitiveKindOf(producerFieldSchema);
+          if (consumerKind && producerKind && consumerKind !== producerKind) {
+            issues.push({
+              opName: config.name,
+              phase: phaseNameOf(consumer),
+              fn: consumer.step.fn,
+              message: `references step "${ref.step}"'s output path "${ref.path}" (${producerKind}), but arg "${argPath.join(".")}" on "${consumer.step.fn}" declares ${consumerKind} — type mismatch`,
+            });
+          }
+        }
+      }
+    }
+  }
+
+  return issues;
+}

package/src/op/types.ts

@@ -39,9 +39,26 @@ export type StepDefinition = ActivityStep | GateStep | EffectStep;
 
 export interface ActivityStep {
   kind: "activity";
+  /**
+   * Identifies this step so a later step can reference its output (#1290)
+   * via `stepOutput(id, path?)` or, when built with `activity()`, the
+   * `.out` proxy sugar. Only steps in an Op's main `phases` — not
+   * `onFailure`, not one nested inside an `EffectStep` — can be referenced.
+   */
+  id?: string;
   /** Name of the exported activity function in the pre-built activity library. */
   fn: string;
-  /** Arguments passed to the activity function. */
+  /**
+   * Arguments passed to the activity function. A value may be a
+   * {@link StepOutputRef} (anywhere in the structure, including nested
+   * inside a plain object or array) — a reference to an earlier step's
+   * declared return value, resolved at build time and compiled by the
+   * serializer into a local variable holding that step's result. Never an
+   * expression over one: `diff.out.count > 0` or a template literal
+   * coerces the reference to a primitive, which throws (see
+   * `step-output-ref.ts`'s module doc for why this is a runtime-on-load
+   * guard, not a static lint rule).
+   */
   args?: Record<string, unknown>;
   /**
    * Key from TEMPORAL_ACTIVITY_PROFILES controlling timeout + retry.

package/src/provenance.test.ts

@@ -1,11 +1,19 @@
 import { describe, expect, test } from "vitest";
-import { setProvenance, getProvenance } from "./provenance";
-import { Composite, expandComposite } from "./composite";
+import {
+  describePathOrigin,
+  getPathProvenance,
+  getProvenance,
+  originOfPath,
+  setPathProvenance,
+  setProvenance,
+  type PathOrigin,
+} from "./provenance";
+import { Composite, expandComposite, propagate } from "./composite";
 import { collectEntities } from "./discovery/collect";
 import { DECLARABLE_MARKER, type Declarable } from "./declarable";
 
-const decl = (entityType: string): Declarable =>
-  ({ [DECLARABLE_MARKER]: true, lexicon: "test", entityType, kind: "resource", props: {} }) as unknown as Declarable;
+const decl = (entityType: string, props: Record<string, unknown> = {}): Declarable =>
+  ({ [DECLARABLE_MARKER]: true, lexicon: "test", entityType, kind: "resource", props }) as unknown as Declarable;
 
 const Pair = Composite<{ n: string }>((props) => ({
   first: decl(`Test::First:${props.n}`),
@@ -77,3 +85,142 @@ describe("collectEntities stamps the source file", () => {
     expect(prov?.composite).toBe("Pair");
   });
 });
+
+describe("path provenance storage (#1443)", () => {
+  test("first writer wins per path, independently of other paths", () => {
+    const e = decl("Test::Thing");
+    setPathProvenance(e, "spec.replicas", { kind: "build-param", params: ["tier"] });
+    setPathProvenance(e, "spec.replicas", { kind: "authored" });
+    setPathProvenance(e, "", { kind: "authored" });
+    expect(getPathProvenance(e)).toEqual({
+      "": { kind: "authored" },
+      "spec.replicas": { kind: "build-param", params: ["tier"] },
+    });
+  });
+
+  test("keys come back sorted, whatever order they were written in", () => {
+    const e = decl("Test::Thing");
+    setPathProvenance(e, "spec.z", { kind: "authored" });
+    setPathProvenance(e, "metadata.a", { kind: "authored" });
+    setPathProvenance(e, "", { kind: "authored" });
+    expect(Object.keys(getPathProvenance(e)!)).toEqual(["", "metadata.a", "spec.z"]);
+  });
+
+  test("path origins stay off the serialized entity", () => {
+    const e = decl("Test::Thing");
+    setPathProvenance(e, "spec.replicas", { kind: "authored" });
+    expect(JSON.stringify(e)).not.toContain("replicas");
+  });
+
+  test("nothing recorded reads as undefined, not an empty record", () => {
+    expect(getPathProvenance(decl("Test::Thing"))).toBeUndefined();
+    expect(originOfPath(undefined, "spec.replicas")).toBeUndefined();
+  });
+});
+
+describe("originOfPath resolution", () => {
+  const paths: Record<string, PathOrigin> = {
+    "": { kind: "authored" },
+    spec: { kind: "composite", composite: "WebService", instance: "web" },
+    "spec.template.spec.containers": { kind: "build-param", params: ["image", "tier"] },
+  };
+
+  test("the longest matching prefix wins", () => {
+    expect(originOfPath(paths, "spec.template.spec.containers")).toEqual(paths["spec.template.spec.containers"]);
+    expect(originOfPath(paths, "spec.replicas")).toEqual(paths.spec);
+    expect(originOfPath(paths, "metadata.name")).toEqual(paths[""]);
+  });
+
+  test("a keyed list element inherits the origin recorded for the list (#1441 grammar)", () => {
+    expect(originOfPath(paths, "spec.template.spec.containers[#app].image")).toEqual(
+      paths["spec.template.spec.containers"],
+    );
+    expect(originOfPath(paths, "spec.template.spec.containers[0].image")).toEqual(
+      paths["spec.template.spec.containers"],
+    );
+  });
+
+  test("prefixes only match on a segment boundary", () => {
+    // `spec` must not claim `specialCase`, and a deeper recorded key must not
+    // claim a shallower query.
+    expect(originOfPath(paths, "specialCase")).toEqual(paths[""]);
+    expect(originOfPath({ "spec.containers.image": { kind: "authored" } }, "spec.containers")).toBeUndefined();
+  });
+});
+
+describe("describePathOrigin", () => {
+  test("renders each kind", () => {
+    expect(describePathOrigin({ kind: "authored" })).toBe("authored");
+    expect(describePathOrigin({ kind: "composite", composite: "WebService", instance: "web" })).toBe(
+      "composite WebService (web)",
+    );
+    expect(describePathOrigin({ kind: "build-param", params: ["region", "tier"] })).toBe("param region, tier");
+  });
+});
+
+describe("composite expansion records path origins (#1443)", () => {
+  test("each member's whole-entity origin names the composite and the instance", () => {
+    const expanded = expandComposite("web", Pair({ n: "x" }));
+    for (const [, entity] of expanded) {
+      expect(originOfPath(getPathProvenance(entity), "anything.at.all")).toEqual({
+        kind: "composite",
+        composite: "Pair",
+        instance: "web",
+      });
+    }
+  });
+
+  test("a nested member keeps the innermost composite but the outer instance", () => {
+    const Wrapper = Composite<{ n: string }>((props) => ({
+      inner: Pair({ n: props.n }) as unknown as Declarable,
+    }), "Wrapper");
+    const expanded = expandComposite("stack", Wrapper({ n: "y" }));
+    for (const [, entity] of expanded) {
+      expect(getPathProvenance(entity)?.[""]).toEqual({
+        kind: "composite",
+        composite: "Pair",
+        instance: "stack",
+      });
+    }
+  });
+
+  test("a propagated key the member never set is attributed to the instance", () => {
+    const Tagged = Composite<{ n: string }>(() => ({
+      only: decl("Test::Only", { name: "fixed" }),
+    }), "Tagged");
+    const expanded = expandComposite("env", propagate(Tagged({ n: "x" }), { tags: [{ key: "env", value: "prod" }] }));
+    const entity = expanded.get("envOnly")!;
+    expect(getPathProvenance(entity)?.tags).toEqual({
+      kind: "composite",
+      composite: "Tagged",
+      instance: "env",
+    });
+  });
+
+  test("a key both the member and the propagation wrote is left to the whole-entity origin", () => {
+    const Tagged = Composite<{ n: string }>(() => ({
+      only: decl("Test::Only", { tags: [{ key: "own", value: "1" }] }),
+    }), "Tagged");
+    const expanded = expandComposite("env", propagate(Tagged({ n: "x" }), { tags: [{ key: "env", value: "prod" }] }));
+    const paths = getPathProvenance(expanded.get("envOnly")!);
+    expect(paths?.tags).toBeUndefined();
+    expect(paths?.[""]).toBeDefined();
+  });
+});
+
+describe("collectEntities records the authored origin", () => {
+  test("a directly exported declarable is authored at the root", () => {
+    const a = decl("Test::A");
+    const entities = collectEntities([{ file: "/proj/src/infra.ts", exports: { a } }]);
+    expect(getPathProvenance(entities.get("a")!)?.[""]).toEqual({ kind: "authored" });
+  });
+
+  test("a composite member is not relabelled authored", () => {
+    const entities = collectEntities([{ file: "/proj/src/pipe.ts", exports: { p: Pair({ n: "z" }) } }]);
+    expect(getPathProvenance(entities.get("pFirst")!)?.[""]).toEqual({
+      kind: "composite",
+      composite: "Pair",
+      instance: "p",
+    });
+  });
+});