@intentius/chant 0.39.0 → 0.41.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (39) hide show
  1. package/dist/apply.d.ts +171 -0
  2. package/dist/apply.d.ts.map +1 -0
  3. package/dist/cli/build-params-cli.d.ts +24 -0
  4. package/dist/cli/build-params-cli.d.ts.map +1 -1
  5. package/dist/cli/commands/doctor.d.ts.map +1 -1
  6. package/dist/cli/handlers/components.d.ts.map +1 -1
  7. package/dist/cli/handlers/lifecycle.d.ts.map +1 -1
  8. package/dist/codegen/naming.d.ts +48 -1
  9. package/dist/codegen/naming.d.ts.map +1 -1
  10. package/dist/codegen/validate.d.ts +31 -0
  11. package/dist/codegen/validate.d.ts.map +1 -1
  12. package/dist/components/deploy-units.d.ts +49 -0
  13. package/dist/components/deploy-units.d.ts.map +1 -0
  14. package/dist/config.d.ts +10 -0
  15. package/dist/config.d.ts.map +1 -1
  16. package/dist/discovery/index.d.ts.map +1 -1
  17. package/dist/index.d.ts +1 -0
  18. package/dist/index.d.ts.map +1 -1
  19. package/package.json +1 -1
  20. package/src/apply.test.ts +169 -0
  21. package/src/apply.ts +249 -0
  22. package/src/cli/build-params-cli.ts +35 -0
  23. package/src/cli/commands/doctor.test.ts +45 -0
  24. package/src/cli/commands/doctor.ts +40 -0
  25. package/src/cli/handlers/components.ts +29 -23
  26. package/src/cli/handlers/graph.test.ts +51 -1
  27. package/src/cli/handlers/graph.ts +16 -1
  28. package/src/cli/handlers/lifecycle.ts +18 -3
  29. package/src/codegen/naming.test.ts +129 -0
  30. package/src/codegen/naming.ts +72 -1
  31. package/src/codegen/validate.test.ts +86 -0
  32. package/src/codegen/validate.ts +74 -0
  33. package/src/components/deploy-units.test.ts +42 -0
  34. package/src/components/deploy-units.ts +82 -0
  35. package/src/config.test.ts +53 -0
  36. package/src/config.ts +41 -3
  37. package/src/discovery/index.ts +59 -0
  38. package/src/discovery/params-cjs-warning.test.ts +75 -0
  39. package/src/index.ts +1 -0
@@ -0,0 +1,169 @@
1
+ import { describe, test, expect } from "vitest";
2
+ import {
3
+ NOT_ATTEMPTED_REASONS,
4
+ isNotAttemptedReason,
5
+ isApplyResult,
6
+ applyResult,
7
+ normalizeApply,
8
+ notAttemptedAll,
9
+ applyRefKey,
10
+ overlappingRefs,
11
+ unaccountedRefs,
12
+ type ApplyRef,
13
+ } from "./apply";
14
+
15
+ const ref = (kind: string, name: string): ApplyRef => ({ kind, name });
16
+
17
+ describe("NotAttemptedReason is total (#1446)", () => {
18
+ test("every reason is recognised, and nothing else is", () => {
19
+ for (const r of NOT_ATTEMPTED_REASONS) expect(isNotAttemptedReason(r)).toBe(true);
20
+ expect(isNotAttemptedReason("skipped")).toBe(false);
21
+ expect(isNotAttemptedReason("")).toBe(false);
22
+ expect(isNotAttemptedReason(undefined)).toBe(false);
23
+ });
24
+
25
+ // The write-side peer of UnobservedReason. Free-form strings are what let the
26
+ // gcp skip say "no mapper for kind X" to stdout and nothing to the caller.
27
+ test("the prune-side reason exists, because it is a different fact", () => {
28
+ expect(NOT_ATTEMPTED_REASONS).toContain("not-prunable");
29
+ expect(NOT_ATTEMPTED_REASONS).toContain("unsupported-kind");
30
+ });
31
+ });
32
+
33
+ describe("the envelope discriminates itself (#1446)", () => {
34
+ test("isApplyResult recognises the versioned shape only", () => {
35
+ expect(isApplyResult(applyResult([]))).toBe(true);
36
+ expect(isApplyResult({ applied: [], pruned: [] })).toBe(false);
37
+ expect(isApplyResult({ apply: "v2" })).toBe(false);
38
+ expect(isApplyResult(null)).toBe(false);
39
+ });
40
+
41
+ test("applyResult omits empty buckets rather than emitting empty arrays", () => {
42
+ expect(applyResult([{ ...ref("Bucket", "a"), action: "created" }])).toEqual({
43
+ apply: "v1",
44
+ applied: [{ kind: "Bucket", name: "a", action: "created" }],
45
+ });
46
+ });
47
+ });
48
+
49
+ describe("normalizeApply (#1446)", () => {
50
+ test("an un-migrated applier's shape means 'everything I was handed, I attempted'", () => {
51
+ // The compatibility path. Nothing is invented on its behalf — an empty
52
+ // notAttempted is exactly the claim that shape implicitly makes.
53
+ const n = normalizeApply({ applied: [{ ...ref("K", "a"), action: "created" }] });
54
+ expect(n.notAttempted).toEqual([]);
55
+ expect(n.pruned).toEqual([]);
56
+ expect(n.applied).toHaveLength(1);
57
+ });
58
+
59
+ test("the envelope's notAttempted survives normalization", () => {
60
+ const n = normalizeApply(
61
+ applyResult([], [], [{ ...ref("SQLInstance", "db"), reason: "unsupported-kind" }]),
62
+ );
63
+ expect(n.notAttempted).toEqual([{ kind: "SQLInstance", name: "db", reason: "unsupported-kind" }]);
64
+ });
65
+
66
+ // The read side has the same rule for the same reason: returning nothing must
67
+ // not be a way to claim success over work that never happened.
68
+ test("undefined normalizes to empty, so 'I could not' must be said explicitly", () => {
69
+ expect(normalizeApply(undefined)).toEqual({ applied: [], pruned: [], notAttempted: [] });
70
+ });
71
+ });
72
+
73
+ describe("notAttemptedAll (#1446)", () => {
74
+ test("marks a whole plan with one reason, for the run-level failure", () => {
75
+ const out = notAttemptedAll([ref("K", "a"), ref("K", "b")], "no-credentials", "no token");
76
+ expect(out).toEqual([
77
+ { kind: "K", name: "a", reason: "no-credentials", detail: "no token" },
78
+ { kind: "K", name: "b", reason: "no-credentials", detail: "no token" },
79
+ ]);
80
+ });
81
+
82
+ test("omits detail when none is given", () => {
83
+ expect(notAttemptedAll([ref("K", "a")], "no-binding")).toEqual([
84
+ { kind: "K", name: "a", reason: "no-binding" },
85
+ ]);
86
+ });
87
+ });
88
+
89
+ describe("the three buckets are disjoint (#1446)", () => {
90
+ test("no overlap is the contract", () => {
91
+ expect(
92
+ overlappingRefs({
93
+ applied: [{ ...ref("K", "a"), action: "created" }],
94
+ pruned: [{ ...ref("K", "b"), deleted: true }],
95
+ notAttempted: [{ ...ref("K", "c"), reason: "unsupported-kind" }],
96
+ }),
97
+ ).toEqual([]);
98
+ });
99
+
100
+ // A resource cannot be both written and skipped. An applier reporting that has
101
+ // a bug the return shape would otherwise hide.
102
+ test("the same resource in two buckets is reported", () => {
103
+ expect(
104
+ overlappingRefs({
105
+ applied: [{ ...ref("K", "a"), action: "created" }],
106
+ pruned: [],
107
+ notAttempted: [{ ...ref("K", "a"), reason: "filtered" }],
108
+ }),
109
+ ).toEqual(["K/a"]);
110
+ });
111
+
112
+ test("same name, different kind, is not an overlap", () => {
113
+ expect(
114
+ overlappingRefs({
115
+ applied: [{ ...ref("Bucket", "x"), action: "created" }],
116
+ pruned: [{ ...ref("Topic", "x"), deleted: true }],
117
+ notAttempted: [],
118
+ }),
119
+ ).toEqual([]);
120
+ });
121
+ });
122
+
123
+ describe("nothing in the plan is dropped (#1446)", () => {
124
+ // The suite's central assertion, and the one gcp failed before #1447: the
125
+ // unmapped kind was in the plan, in no bucket, and the result looked complete.
126
+ test("a plan entry in no bucket is reported", () => {
127
+ const plan = [ref("Bucket", "mapped"), ref("SQLInstance", "unmapped")];
128
+ const dropped = unaccountedRefs(plan, {
129
+ applied: [{ ...ref("Bucket", "mapped"), action: "created" }],
130
+ pruned: [],
131
+ notAttempted: [],
132
+ });
133
+ expect(dropped).toEqual(["SQLInstance/unmapped"]);
134
+ });
135
+
136
+ test("the same plan accounted for in notAttempted passes", () => {
137
+ const plan = [ref("Bucket", "mapped"), ref("SQLInstance", "unmapped")];
138
+ expect(
139
+ unaccountedRefs(plan, {
140
+ applied: [{ ...ref("Bucket", "mapped"), action: "created" }],
141
+ pruned: [],
142
+ notAttempted: [{ ...ref("SQLInstance", "unmapped"), reason: "unsupported-kind" }],
143
+ }),
144
+ ).toEqual([]);
145
+ });
146
+
147
+ test("an empty plan is trivially accounted for", () => {
148
+ expect(unaccountedRefs([], { applied: [], pruned: [], notAttempted: [] })).toEqual([]);
149
+ });
150
+
151
+ // Prune deletes things the plan does not contain, by definition — so a pruned
152
+ // resource being outside the plan is correct, not a drop.
153
+ test("a pruned resource outside the plan is not a drop", () => {
154
+ expect(
155
+ unaccountedRefs([ref("Bucket", "keep")], {
156
+ applied: [{ ...ref("Bucket", "keep"), action: "unchanged" }],
157
+ pruned: [{ ...ref("Bucket", "orphan"), deleted: true }],
158
+ notAttempted: [],
159
+ }),
160
+ ).toEqual([]);
161
+ });
162
+ });
163
+
164
+ describe("applyRefKey", () => {
165
+ test("separates resources by kind and name", () => {
166
+ expect(applyRefKey(ref("Bucket", "x"))).toBe("Bucket/x");
167
+ expect(applyRefKey(ref("Topic", "x"))).not.toBe(applyRefKey(ref("Bucket", "x")));
168
+ });
169
+ });
package/src/apply.ts ADDED
@@ -0,0 +1,249 @@
1
+ /**
2
+ * The apply contract (#1446) — what a lexicon's applier is allowed to mean.
3
+ *
4
+ * The peer of `./observation.ts`, and it exists for the same reason on the other
5
+ * side of the lifecycle.
6
+ *
7
+ * The read path had two ways to return nothing for a declared entity and no way
8
+ * to tell them apart — "the provider says it is absent" versus "I never looked"
9
+ * — and the second was classifying as `create`. #1089 made that a tri-state and
10
+ * #1201 built a conformance suite so a lexicon could not pass by returning a
11
+ * well-shaped result that still proposed a create.
12
+ *
13
+ * The write path had the identical hole. An applier could skip a resource and
14
+ * report nothing:
15
+ *
16
+ * const mapper = MAPPERS[r.kind];
17
+ * if (!mapper) {
18
+ * console.log(`skip: no mapper for kind ${r.kind}`);
19
+ * continue; // never appears in `applied`, or anywhere
20
+ * }
21
+ *
22
+ * A caller receiving `{ applied: [...] }` could not distinguish a complete apply
23
+ * from one that dropped half the manifest, and `ApplyOp` had nothing to gate on.
24
+ * A `console.log` on stdout is not a signal in a result, the same way a warn on
25
+ * stderr was not a signal in a change set (#1447 was the concrete bug; #1457
26
+ * found the same shape in two more appliers).
27
+ *
28
+ * The contract is a tri-state, per resource in the plan:
29
+ *
30
+ * - **APPLIED** — the provider was called and converged. Carries the action
31
+ * (`created` / `updated` / `unchanged`) and the physical id when resolved.
32
+ * - **PRUNED** — owned, no longer declared, deleted.
33
+ * - **NOT-ATTEMPTED** — carrying a total {@link NotAttemptedReason}. Never
34
+ * silent, never inferred from absence.
35
+ *
36
+ * The three are **disjoint and total**: every resource the applier was given
37
+ * appears in exactly one. That is the assertion the conformance suite exists to
38
+ * make, and the one the gcp skip failed.
39
+ *
40
+ * Compatibility: an applier may keep returning its own shape. The envelope is
41
+ * discriminated by its literal `apply: "v1"` field, the same mechanism
42
+ * `observation: "v1"` uses, so an un-migrated applier normalizes to "everything
43
+ * I was handed, I attempted" and nothing breaks. Reporting NOT-ATTEMPTED
44
+ * requires the envelope — which is the point: you cannot claim the guarantee
45
+ * without adopting the shape that can express its absence.
46
+ */
47
+
48
+ /**
49
+ * Why a resource in the plan was not attempted. Total: an applier that skips a
50
+ * resource must pick one of these, and consumers may switch exhaustively.
51
+ *
52
+ * - `unsupported-kind` — the lexicon has no mapper/writer for this type. The
53
+ * resource is declared and simply was not written.
54
+ * - `no-credentials` — no usable credentials/authorization for the target.
55
+ * - `no-binding` — the environment resolves to no concrete target (no cluster
56
+ * context, no subscription, no resource group, no endpoint).
57
+ * - `dependency-failed` — an upstream resource in the same run failed, so this
58
+ * one was never reached. Distinct from a failure of its own.
59
+ * - `filtered` — reached but deliberately withheld by a caller-requested scope.
60
+ * - `not-prunable` — an owned orphan of a kind the applier cannot enumerate or
61
+ * delete. The prune-side shape: not "there was nothing to prune" but "I could
62
+ * not look for anything to prune here".
63
+ */
64
+ export type NotAttemptedReason =
65
+ | "unsupported-kind"
66
+ | "no-credentials"
67
+ | "no-binding"
68
+ | "dependency-failed"
69
+ | "filtered"
70
+ | "not-prunable";
71
+
72
+ /** Every legal {@link NotAttemptedReason}, for validation and conformance checks. */
73
+ export const NOT_ATTEMPTED_REASONS: readonly NotAttemptedReason[] = [
74
+ "unsupported-kind",
75
+ "no-credentials",
76
+ "no-binding",
77
+ "dependency-failed",
78
+ "filtered",
79
+ "not-prunable",
80
+ ];
81
+
82
+ /** True when `value` is a legal {@link NotAttemptedReason}. */
83
+ export function isNotAttemptedReason(value: unknown): value is NotAttemptedReason {
84
+ return typeof value === "string" && (NOT_ATTEMPTED_REASONS as readonly string[]).includes(value);
85
+ }
86
+
87
+ /** What an apply did to a resource that it did reach. */
88
+ export type AppliedAction = "created" | "updated" | "unchanged";
89
+
90
+ /** Every legal {@link AppliedAction}. */
91
+ export const APPLIED_ACTIONS: readonly AppliedAction[] = ["created", "updated", "unchanged"];
92
+
93
+ /** How a resource is named across appliers whose native vocabularies differ. */
94
+ export interface ApplyRef {
95
+ /**
96
+ * The provider's own type name — a CNRM `kind`, an ARM `type`, a
97
+ * CloudFormation resource type, a Fly entity class. Kept verbatim rather than
98
+ * normalized into a chant vocabulary, so an applier stays true to its target.
99
+ */
100
+ kind: string;
101
+ /** The resource's name within its scope. */
102
+ name: string;
103
+ }
104
+
105
+ /** APPLIED — the provider was called and the resource converged. */
106
+ export interface AppliedResource extends ApplyRef {
107
+ action: AppliedAction;
108
+ /** Provider-assigned identifier, when the response carried one. */
109
+ physicalId?: string;
110
+ }
111
+
112
+ /** PRUNED — owned, no longer declared, deleted. */
113
+ export interface PrunedResource extends ApplyRef {
114
+ /**
115
+ * False when the delete was a no-op because the resource was already gone.
116
+ * Still PRUNED: the applier looked, decided, and acted.
117
+ */
118
+ deleted: boolean;
119
+ }
120
+
121
+ /** NOT-ATTEMPTED — no provider call was made, and why. */
122
+ export interface NotAttemptedResource extends ApplyRef {
123
+ reason: NotAttemptedReason;
124
+ /** Detail for the operator: the status and body, the missing binding, the unsupported kind. */
125
+ detail?: string;
126
+ }
127
+
128
+ /**
129
+ * The apply envelope. Explicitly versioned: `apply: "v1"`, which discriminates
130
+ * it from an applier's own return shape.
131
+ */
132
+ export interface ApplyResult {
133
+ /** Discriminant + wire version. */
134
+ readonly apply: "v1";
135
+ applied: AppliedResource[];
136
+ pruned?: PrunedResource[];
137
+ /** Omit or leave empty when everything in the plan was attempted. */
138
+ notAttempted?: NotAttemptedResource[];
139
+ }
140
+
141
+ /** Normalized form every consumer works with. All three arrays always present. */
142
+ export interface NormalizedApply {
143
+ applied: AppliedResource[];
144
+ pruned: PrunedResource[];
145
+ notAttempted: NotAttemptedResource[];
146
+ }
147
+
148
+ /** True when `value` is the versioned {@link ApplyResult} envelope. */
149
+ export function isApplyResult(value: unknown): value is ApplyResult {
150
+ return typeof value === "object" && value !== null && (value as { apply?: unknown }).apply === "v1";
151
+ }
152
+
153
+ /**
154
+ * Build an {@link ApplyResult}. Appliers use this rather than writing the
155
+ * discriminant by hand.
156
+ */
157
+ export function applyResult(
158
+ applied: AppliedResource[],
159
+ pruned?: PrunedResource[],
160
+ notAttempted?: NotAttemptedResource[],
161
+ ): ApplyResult {
162
+ return {
163
+ apply: "v1",
164
+ applied,
165
+ ...(pruned && pruned.length > 0 ? { pruned } : {}),
166
+ ...(notAttempted && notAttempted.length > 0 ? { notAttempted } : {}),
167
+ };
168
+ }
169
+
170
+ /**
171
+ * Normalize an applier's return value.
172
+ *
173
+ * A non-envelope value normalizes to "everything I was handed, I attempted" —
174
+ * an empty `notAttempted`. That is the compatibility path, and it is also
175
+ * exactly the claim an un-migrated applier is implicitly making, so nothing is
176
+ * invented on its behalf.
177
+ *
178
+ * `undefined` normalizes to three empty arrays. An applier that means "I applied
179
+ * nothing because I could not" must say so with {@link notAttemptedAll} rather
180
+ * than returning nothing, for the same reason `unobservedAll` exists on the read
181
+ * side.
182
+ */
183
+ export function normalizeApply(value: ApplyResult | Partial<NormalizedApply> | undefined): NormalizedApply {
184
+ if (!value) return { applied: [], pruned: [], notAttempted: [] };
185
+ return {
186
+ applied: value.applied ?? [],
187
+ pruned: value.pruned ?? [],
188
+ notAttempted: value.notAttempted ?? [],
189
+ };
190
+ }
191
+
192
+ /**
193
+ * Mark every named resource NOT-ATTEMPTED with one reason — the whole-run
194
+ * failure case (no credentials, no binding, the transport never came up). Core
195
+ * applies this when an applier throws, so a thrown apply degrades to an honest
196
+ * "did not attempt" per resource instead of an empty result that reads as a
197
+ * successful no-op.
198
+ */
199
+ export function notAttemptedAll(
200
+ refs: Iterable<ApplyRef>,
201
+ reason: NotAttemptedReason,
202
+ detail?: string,
203
+ ): NotAttemptedResource[] {
204
+ return [...refs].map((ref) => ({ ...ref, reason, ...(detail ? { detail } : {}) }));
205
+ }
206
+
207
+ /** A resource's identity within one apply, for disjointness checks. */
208
+ export function applyRefKey(ref: ApplyRef): string {
209
+ return `${ref.kind}/${ref.name}`;
210
+ }
211
+
212
+ /**
213
+ * Every resource that appears in more than one bucket. Empty is the contract;
214
+ * a non-empty result means the applier both wrote and skipped the same
215
+ * resource, which is not a state that can be true.
216
+ *
217
+ * Pruned is checked against the other two but not against itself: an applier
218
+ * may legitimately apply a resource and prune a different, same-named one only
219
+ * if their kinds differ, and {@link applyRefKey} already separates those.
220
+ */
221
+ export function overlappingRefs(result: NormalizedApply): string[] {
222
+ const seen = new Map<string, Set<string>>();
223
+ const note = (bucket: string, refs: ApplyRef[]): void => {
224
+ for (const ref of refs) {
225
+ const key = applyRefKey(ref);
226
+ (seen.get(key) ?? seen.set(key, new Set()).get(key)!).add(bucket);
227
+ }
228
+ };
229
+ note("applied", result.applied);
230
+ note("pruned", result.pruned);
231
+ note("notAttempted", result.notAttempted);
232
+ return [...seen.entries()].filter(([, buckets]) => buckets.size > 1).map(([key]) => key);
233
+ }
234
+
235
+ /**
236
+ * Resources in `plan` that the result accounts for in no bucket — the silent
237
+ * drop this contract exists to make impossible.
238
+ *
239
+ * The conformance suite's central assertion. Before #1447, gcp's applier failed
240
+ * exactly this: an unmapped kind was in the plan, in no bucket, and the result
241
+ * looked complete.
242
+ */
243
+ export function unaccountedRefs(plan: Iterable<ApplyRef>, result: NormalizedApply): string[] {
244
+ const accounted = new Set<string>();
245
+ for (const bucket of [result.applied, result.pruned, result.notAttempted]) {
246
+ for (const ref of bucket) accounted.add(applyRefKey(ref));
247
+ }
248
+ return [...plan].map(applyRefKey).filter((key) => !accounted.has(key));
249
+ }
@@ -105,3 +105,38 @@ export function resolveCliBuildParams(
105
105
 
106
106
  return { success: true, provenance: resolution.provenance, errors: [] };
107
107
  }
108
+
109
+ /**
110
+ * Resolve a command's declared build-time parameters, the same way `chant
111
+ * build` does, so a `build()`/`discover()` on the declared side sees the values
112
+ * the source will actually read.
113
+ *
114
+ * Every command that reads declared source needs this and only `chant build`
115
+ * had it. `chant graph` was fixed in #1483; the lifecycle family — `diff`,
116
+ * `snapshot`, `plan`, and `components status --live` — built the declared side
117
+ * on parameter *defaults* while the live side was whatever is really deployed.
118
+ *
119
+ * For a project whose parameters choose which resources *exist* that is not a
120
+ * near miss. `chant lifecycle diff dev --live` on kubemicrovm-ops returned
121
+ * byte-identical output at `KMV_TIER=minimal` and `KMV_TIER=prod-ha`, and
122
+ * reported the tier label itself as drift — `minimal → prod-ha`, declared
123
+ * against live — which is the comparison announcing it is against the wrong
124
+ * declaration.
125
+ *
126
+ * Returns `undefined` when resolution failed, having printed why: the caller
127
+ * should stop rather than compare against source that will not build.
128
+ */
129
+ export async function commandBuildParams(
130
+ buildParamsConfig: BuildParamsConfig | undefined,
131
+ args: { param?: string[]; paramsFile?: string },
132
+ ): Promise<BuildParamProvenance[] | undefined> {
133
+ const resolution = resolveCliBuildParams(buildParamsConfig, {
134
+ cli: parseParamFlags(args.param),
135
+ paramsFile: args.paramsFile,
136
+ });
137
+ if (!resolution.success) {
138
+ for (const message of resolution.errors) console.error(message);
139
+ return undefined;
140
+ }
141
+ return resolution.provenance;
142
+ }
@@ -351,3 +351,48 @@ describe("doctorCommand", () => {
351
351
  });
352
352
  });
353
353
  });
354
+
355
+ /**
356
+ * #1421 — the sibling of the `tsconfig-paths` check. Both are project settings
357
+ * that silently break runtime module resolution; this one makes build
358
+ * parameters read as empty in project source on the run path, so declarations
359
+ * conditioned on them take their default branch while chant reports success.
360
+ */
361
+ describe("package-type-module (#1421)", () => {
362
+ const withPkg = async (pkg: object | undefined, assert: (check: { status: string; message?: string } | undefined) => void): Promise<void> => {
363
+ await withTestDir(async (testDir) => {
364
+ if (pkg) writeFileSync(join(testDir, "package.json"), JSON.stringify(pkg));
365
+ const report = await doctorCommand(testDir);
366
+ assert(report.checks.find((c) => c.name === "package-type-module"));
367
+ });
368
+ };
369
+
370
+ test('passes for "type": "module"', async () => {
371
+ await withPkg({ name: "p", type: "module" }, (check) => {
372
+ expect(check?.status).toBe("pass");
373
+ });
374
+ });
375
+
376
+ test('warns for "type": "commonjs", saying what breaks', async () => {
377
+ await withPkg({ name: "p", type: "commonjs" }, (check) => {
378
+ expect(check?.status).toBe("warn");
379
+ expect(check?.message).toContain('"type": "commonjs"');
380
+ expect(check?.message).toContain("build parameters");
381
+ expect(check?.message).toContain('Set "type": "module"');
382
+ });
383
+ });
384
+
385
+ // The easier one to miss: no `type` field is CommonJS too.
386
+ test("warns when no type field is declared at all", async () => {
387
+ await withPkg({ name: "p" }, (check) => {
388
+ expect(check?.status).toBe("warn");
389
+ expect(check?.message).toContain("no `type` field");
390
+ });
391
+ });
392
+
393
+ test("says nothing when there is no package.json to judge", async () => {
394
+ await withPkg(undefined, (check) => {
395
+ expect(check).toBeUndefined();
396
+ });
397
+ });
398
+ });
@@ -169,6 +169,46 @@ export async function doctorCommand(path: string): Promise<DoctorReport> {
169
169
  }
170
170
  }
171
171
 
172
+ // Check 8b: package.json declares "type": "module" (#1421)
173
+ //
174
+ // Sibling of the tsconfig-paths check above, and filed for the same reason:
175
+ // both are project settings that silently break runtime module resolution.
176
+ //
177
+ // chant's core is ESM. When the project is CJS — `"type": "commonjs"`, or no
178
+ // `type` field at all — tsx loads project source through the CommonJS
179
+ // transform, so the project's `require` of `params.ts` and core's `import` of
180
+ // it produce two separate module records. `setBuildParams` mutates one object
181
+ // in place; project source reads the other, and sees `{}`.
182
+ //
183
+ // The result is a silent wrong answer, not a failure: chant prints
184
+ // `[param] tier = "prod" (cli)` and then emits the graph for the default. It
185
+ // hits `chant graph` (always the run path) and `chant build --no-fold`; plain
186
+ // `chant build` escapes only because folding substitutes parameters
187
+ // statically and never reads the shared object.
188
+ const projectPkgPath = join(projectPath, "package.json");
189
+ if (existsSync(projectPkgPath)) {
190
+ try {
191
+ const pkg = JSON.parse(readFileSync(projectPkgPath, "utf-8")) as { type?: string };
192
+ if (pkg.type === "module") {
193
+ checks.push({ name: "package-type-module", status: "pass" });
194
+ } else {
195
+ const found = pkg.type ? `"type": "${pkg.type}"` : "no `type` field";
196
+ checks.push({
197
+ name: "package-type-module",
198
+ status: "warn",
199
+ message:
200
+ `package.json has ${found} — chant is ESM, and a CommonJS project reads build ` +
201
+ `parameters as empty on the run path (\`chant graph\`, \`chant build --no-fold\`). ` +
202
+ `Declarations conditioned on \`params.<name>\` silently take their default branch. ` +
203
+ `Set "type": "module".`,
204
+ });
205
+ }
206
+ } catch (e) {
207
+ debug("project package.json parse failed:", e);
208
+ checks.push({ name: "package-type-module", status: "warn", message: "Could not parse package.json" });
209
+ }
210
+ }
211
+
172
212
  // Check 9: .mcp.json exists and has chant entry
173
213
  const mcpPath = join(projectPath, ".mcp.json");
174
214
  if (!existsSync(mcpPath)) {
@@ -35,6 +35,7 @@ import {
35
35
  InvalidReleaseRecordError,
36
36
  } from "../../lifecycle/release-ledger";
37
37
  import { reconcileStatus, liveEvidenceFromChangeSet, compareAcrossEnvironments, mergeLiveEvidence, type LiveComponentEvidence } from "../../lifecycle/status";
38
+ import { commandBuildParams } from "../build-params-cli";
38
39
  import { buildChangeSet } from "../../lifecycle/change-set";
39
40
  import { buildLedgerEntries, componentBomSummary, type BuildLedgerEntry } from "../../lifecycle/build-ledger";
40
41
  import { findBuildManifestByArtifactDigest } from "../../lifecycle/build-ledger-store";
@@ -48,6 +49,7 @@ import type { CommandContext } from "../registry";
48
49
  import type { LexiconPlugin } from "../../lexicon";
49
50
  import { normalizeObservation, mergeObservations, unobservedAll, type NormalizedObservation } from "../../observation";
50
51
  import type { Phase, Component } from "../../components/component";
52
+ import { deployUnits } from "../../components/deploy-units";
51
53
 
52
54
  /**
53
55
  * chant components release <env> --component <name> --digest <sha256:...>
@@ -228,22 +230,11 @@ interface StatusJsonRow {
228
230
  * observe on a multi-stack, per-component project (`describeResources`'s
229
231
  * single-stack-named-after-the-environment convention never matches one). */
230
232
  export function cfnDeployStacks(deploy: Phase[]): string[] {
231
- const stacks = new Set<string>();
232
- const walkSteps = (steps: Phase["steps"]): void => {
233
- for (const step of steps) {
234
- // A step may itself be a nested Phase (it carries its own `steps`). Step is
235
- // open-typed (capability inputs), so discriminate structurally on `steps`.
236
- const nested = (step as { steps?: unknown }).steps;
237
- if (Array.isArray(nested)) {
238
- walkSteps(nested as Phase["steps"]);
239
- continue;
240
- }
241
- const s = step as { kind?: string; stack?: unknown };
242
- if (s.kind === "cfn-deploy" && typeof s.stack === "string") stacks.add(s.stack);
243
- }
244
- };
245
- for (const phase of deploy) walkSteps(phase.steps);
246
- return [...stacks];
233
+ // The CloudFormation slice of the generic deploy-unit walk (#1495) — kept
234
+ // because `chant graph --live`'s stack enrichment is genuinely CFN-shaped.
235
+ return deployUnits(deploy)
236
+ .filter((u) => u.lexicon === "aws")
237
+ .map((u) => u.unit);
247
238
  }
248
239
 
249
240
  /**
@@ -258,15 +249,22 @@ export function cfnDeployStacks(deploy: Phase[]): string[] {
258
249
  */
259
250
  async function observeComponentStacks(
260
251
  components: Map<string, { component: Component }>,
261
- observer: LexiconPlugin,
252
+ plugins: LexiconPlugin[],
262
253
  environment: string,
263
254
  ): Promise<Map<string, LiveComponentEvidence>> {
255
+ // Observer per unit's own lexicon (#1495): a component's kubectl-apply unit
256
+ // is read by the k8s lexicon, its cfn-deploy stack by aws. A unit whose
257
+ // lexicon ships no describeStackStatus is skipped — the same absent-observer
258
+ // degradation as before, per unit instead of per project.
259
+ const observerFor = (lexicon: string) =>
260
+ plugins.find((p) => p.name === lexicon && p.describeStackStatus);
264
261
  const evidence = new Map<string, LiveComponentEvidence>();
265
262
  for (const [name, { component }] of components) {
266
- const stacks = cfnDeployStacks(component.deploy);
263
+ const units = deployUnits(component.deploy).filter((u) => observerFor(u.lexicon));
264
+ const stacks = units.map((u) => u.unit);
267
265
  if (stacks.length === 0) continue;
268
266
  const observed = await Promise.all(
269
- stacks.map((stack) => observer.describeStackStatus!({ environment, stack }).catch(() => null)),
267
+ units.map((u) => observerFor(u.lexicon)!.describeStackStatus!({ environment, stack: u.unit }).catch(() => null)),
270
268
  );
271
269
  const determinate = observed.filter((o): o is NonNullable<typeof o> => o !== null);
272
270
  if (determinate.length === 0) {
@@ -355,7 +353,15 @@ export async function runComponentsStatus(ctx: CommandContext): Promise<number>
355
353
  if (endpointResult.notice) console.error(formatWarning({ message: endpointResult.notice }));
356
354
  try {
357
355
  const targetSerializers = serializers;
358
- const buildResult = await build(resolve(args.src ?? config.sourceDir ?? "."), targetSerializers);
356
+ // With this invocation's parameters (#1483). Built on defaults, the
357
+ // declared half of the comparison is a different estate from the one
358
+ // deployed, and every resource the real parameter declares reads as
359
+ // absent.
360
+ const statusParams = await commandBuildParams(config.buildParams, args);
361
+ if (!statusParams) return 1;
362
+ const buildResult = await build(resolve(args.src ?? config.sourceDir ?? "."), targetSerializers, undefined, {
363
+ buildParams: statusParams,
364
+ });
359
365
  // Which deployed stack(s) to read the change set from (behold#100).
360
366
  //
361
367
  // `describeResources` defaults to the single-stack convention — the
@@ -431,9 +437,9 @@ export async function runComponentsStatus(ctx: CommandContext): Promise<number>
431
437
  // invisible to the entity-keyed, single-stack `describeResources` above —
432
438
  // observe each component's own cfn-deploy stack directly and overlay it as
433
439
  // the authoritative presence signal (#57).
434
- const stackObserver = plugins.find((p) => p.describeStackStatus);
435
- if (stackObserver) {
436
- const stackEvidence = await observeComponentStacks(discovery.components, stackObserver, environment);
440
+ const anyObserver = plugins.some((p) => p.describeStackStatus);
441
+ if (anyObserver) {
442
+ const stackEvidence = await observeComponentStacks(discovery.components, plugins, environment);
437
443
  liveEvidence = mergeLiveEvidence(liveEvidence, stackEvidence);
438
444
  }
439
445
  } finally {