@intentius/chant 0.124.42 → 0.124.44

package/src/pr-requires.ts

@@ -4,14 +4,16 @@
  * asked of the forge through its {@link PrForge} method. All four must pass.
  *
  * The checks are terragucci's `apply.requires` (comment-apply.ts:781-860 at
- * INTENTIUS/terragucci e6cb431), with no setting to drop one. A check the
+ * INTENTIUS/terragucci e6cb431). A product may leave one out with `only`
+ * (#4336); chant's own `pr-apply --before-merge` passes no `only`, so it asks
+ * all four, as ws-106 requires. A check the
  * forge has not settled, such as GitHub working out whether a pull request
  * can merge, is asked again a few times before it counts as unmet.
  *
  * Like ./pr-forge.ts this imports nothing beyond it, so a product bundles it
  * without the TypeScript toolchain.
  */
-import type { PrForge, PrRequireResult } from "./pr-forge";
+import type { PrApproverFilter, PrForge, PrRequireResult } from "./pr-forge";
 
 /** The four checks, in the order they run and the report lists them. */
 export const PR_APPLY_REQUIRES = ["approved", "mergeable", "undiverged", "checks"] as const;
@@ -24,6 +26,13 @@ export interface PrRequireOutcome extends PrRequireResult {
 }
 
 export interface PrRequiresOptions {
+  /**
+   * The checks to ask (#4336). One left out passes with the reason "not
+   * required" and makes no forge call. Default: all four.
+   */
+  only?: readonly PrApplyRequire[];
+  /** Who counts as an approver for `approved` (#4337). Default: anyone other than the authors. */
+  approvers?: PrApproverFilter;
   /** Status names the `checks` require leaves out: the apply's own. */
   ignore?: readonly string[];
   /** How many times a pending check is asked in all. Default 5. */
@@ -44,13 +53,18 @@ export async function checkPrRequires(forge: PrForge, pr: number, head: string,
   const wait = opts.wait ?? ((ms: number) => new Promise<void>((r) => setTimeout(r, ms)));
   const reads = Math.max(1, opts.reads ?? READS);
   const ask: Record<PrApplyRequire, (() => Promise<PrRequireResult>) | undefined> = {
-    approved: forge.prApproved ? () => forge.prApproved!(pr, head) : undefined,
+    approved: forge.prApproved ? () => forge.prApproved!(pr, head, opts.approvers) : undefined,
     mergeable: forge.prMergeable ? () => forge.prMergeable!(pr, head) : undefined,
     undiverged: forge.prUndiverged ? () => forge.prUndiverged!(pr, head) : undefined,
     checks: forge.prChecksPassed ? () => forge.prChecksPassed!(pr, head, opts.ignore ?? []) : undefined,
   };
   const out: PrRequireOutcome[] = [];
+  const asked = new Set<PrApplyRequire>(opts.only ?? PR_APPLY_REQUIRES);
   for (const name of PR_APPLY_REQUIRES) {
+    if (!asked.has(name)) {
+      out.push({ name, passed: true, reason: "not required" });
+      continue;
+    }
     const call = ask[name];
     if (!call) {
       out.push({ name, passed: false, reason: `this ${forge.kind} client cannot say` });