@intentius/chant 0.124.3 → 0.124.5

package/src/op/index.ts

@@ -66,8 +66,10 @@ export {
   opWaveRecordPath,
   opWaveShare,
 } from "./op-waves";
-export type { OpWave, OpWaveApplyHooksRunner, OpWaveGatePolicy, OpWaveHook, OpWaveHookFailure, OpWaveHookMoment, OpWaveHooks, OpWaveJob, OpWaveRun, OpWavesDigest, OpWavesSpec } from "./op-waves";
+export type { OpWave, OpWaveApplyHooksRunner, OpWaveGatePolicy, OpWaveHook, OpWaveHookFailure, OpWaveHookMoment, OpWaveHooks, OpWaveJob, OpWaveRun, OpWavesDigest, OpWavesOverride, OpWavesSpec } from "./op-waves";
 export {
+  OP_WAVE_APPLY_OUTCOMES,
+  OP_WAVE_MAX_REPLANS,
   opWaveHooksAtBase,
   opWaveNeedsApproval,
   opWavePlansPath,
@@ -84,7 +86,10 @@ export type {
   OpWaveBaseRules,
   OpWaveDecision,
   OpWaveApplyHooksRun,
+  OpWaveApplyOutcome,
   OpWaveExec,
+  OpWaveHeldOn,
+  OpWaveHoldRequest,
   OpWaveHookOutcome,
   OpWaveHookRun,
   OpWaveHooksFile,

package/src/op/op-waves-notify.ts

@@ -5,7 +5,10 @@
  * approval command, the digest and, under `pr-review`, the pull request to
  * review. A share job that refused a run whose plan moved (exit 4) sends
  * `refused`. A wave whose plan, apply or stage hook failed (exit 1) sends
- * `failed`. A share job of a waiting wave sends nothing, since its deciding
+ * `failed`. A wave the product's policy refused (exit 7, #3821) sends
+ * `refused` with the runs it denied, and one whose apply was held by another
+ * run (exit 5) sends `refused` with status `held`; one that stood down for a
+ * newer run (exit 6) sends nothing. A share job of a waiting wave sends nothing, since its deciding
  * job already did, unless a hook in the share job itself held it (#3762). Delivery is `../notify.ts`: it never throws, and the job's exit code
  * is what the wave decided.
  */
@@ -46,13 +49,42 @@ export function opWaveNotifyFields(spec: OpWavesSpec, k: number, outcome: OpWave
       summary: `${label} waits for an approval`,
       targets: decision.members.map((m) => m.member),
       approve: { command: decision.approve ?? `chant approve ${decision.op} ${decision.gate} --plan ${decision.digest}`, ...review },
-      ...(decision.heldBy?.length
+      ...(decision.heldOn
+        ? { reason: `held on ${decision.heldOn.op} / ${decision.heldOn.gate} by ${decision.heldOn.hook}` }
+        : decision.heldBy?.length
         ? { reason: `held by ${decision.heldBy.join(", ")}` }
         : decision.review?.reason
           ? { reason: decision.review.reason }
           : {}),
     };
   }
+  if (result.exitCode === 7 && decision?.refused) {
+    // #3821: the product's policy denied a run, and no override counts for it.
+    return {
+      ...base,
+      event: "refused",
+      status: decision.refused.reason === "override-moved" ? "override-moved" : "denied",
+      summary: `${label} refused: the policy denied ${decision.refused.runs.join(", ")}`,
+      targets: decision.refused.runs,
+      reason:
+        decision.refused.reason === "override-moved"
+          ? "an override stands for an earlier plan or other rules, so it counts for nothing"
+          : "the policy denied these runs, and no override counts for them",
+    };
+  }
+  // #3821: an apply that stood down for a newer run is no news; one held by another run is refused.
+  if (result.exitCode === 6 && result.outcome?.outcome === "stood-down") return undefined;
+  if (result.exitCode === 5 && result.outcome?.outcome === "held") {
+    const holder = result.outcome.holder;
+    return {
+      ...base,
+      event: "refused",
+      status: "held",
+      summary: `${label} applied nothing: another run${holder ? ` (${holder.run})` : ""} holds what it changes`,
+      targets: decision?.members.map((m) => m.member) ?? [],
+      reason: result.outcome.reason ?? `another run${holder ? `, ${holder.run},` : ""} holds what the apply changes; apply again once it is done`,
+    };
+  }
   if (result.exitCode === 4) {
     return {
       ...base,