@intentius/chant-lexicon-github 0.44.14 → 0.46.0

package/src/serializer.test.ts

@@ -180,6 +180,36 @@ describe("githubSerializer.serialize", () => {
     expect(output).toContain("continue-on-error: true");
   });
 
+  test("env / with map keys pass through verbatim (chant #1223)", () => {
+    const entities = new Map<string, Declarable>();
+    entities.set("workflow", new MockWorkflow({
+      name: "CI",
+      on: { push: null },
+    }));
+    entities.set("job", new MockJob({
+      "runs-on": "ubuntu-latest",
+      env: { CHANT_ENV: "pr-1", kubeConfigPath: "/tmp/kc" },
+      steps: [
+        new MockStep({
+          uses: "actions/setup-node@abc",
+          with: { "node-version": "22", checkLatest: "true" },
+          env: { GH_TOKEN: "${{ secrets.GITHUB_TOKEN }}" },
+        }),
+      ],
+    }));
+
+    const output = githubSerializer.serialize(entities) as string;
+    // Env var names are user identifiers — kebab-casing renames what the
+    // script reads. They must survive exactly as written.
+    expect(output).toContain("CHANT_ENV: pr-1");
+    expect(output).toContain("kubeConfigPath: /tmp/kc");
+    expect(output).toContain("GH_TOKEN:");
+    // Action inputs are the action's declared names, also not chant's to touch.
+    expect(output).toContain("checkLatest: 'true'");
+    expect(output).not.toContain("gh-token");
+    expect(output).not.toContain("chant-env");
+  });
+
   test("serializes trigger entities", () => {
     const entities = new Map<string, Declarable>();
     entities.set("workflow", new MockWorkflow({

package/src/serializer.ts

@@ -183,6 +183,15 @@ function buildStandaloneJobsSection(
 
 // ── Key conversion for YAML output ────────────────────────────────
 
+/**
+ * Map keys whose entries are user-named, not schema properties. `env` names
+ * environment variables (`KUBECONFIG_DATA` must stay `KUBECONFIG_DATA`, not
+ * become `kubeconfig_data`), `with` names an action's declared inputs,
+ * `outputs`/`secrets`/`variables` name user identifiers referenced elsewhere
+ * by exact spelling. Kebab-casing inside these silently renames them.
+ */
+const VERBATIM_KEY_MAPS = new Set(["env", "with", "outputs", "secrets", "variables"]);
+
 /**
  * Convert a props object keys from camelCase to kebab-case for job/step properties.
  */
@@ -192,21 +201,22 @@ function convertKeys(obj: Record<string, unknown>): Record<string, unknown> {
     if (value === undefined || value === null) continue;
     // Zero and false are valid values, but undefined/null should be omitted
     const yamlKey = toKebabCase(key);
-    result[yamlKey] = convertValueKeys(value);
+    result[yamlKey] = convertValueKeys(value, VERBATIM_KEY_MAPS.has(yamlKey));
   }
   return result;
 }
 
-function convertValueKeys(value: unknown): unknown {
+function convertValueKeys(value: unknown, verbatim = false): unknown {
   if (value === null || value === undefined) return value;
   if (typeof value !== "object") return value;
-  if (Array.isArray(value)) return value.map(convertValueKeys);
+  if (Array.isArray(value)) return value.map((v) => convertValueKeys(v, verbatim));
 
   const obj = value as Record<string, unknown>;
   const result: Record<string, unknown> = {};
   for (const [key, v] of Object.entries(obj)) {
     if (v === undefined || v === null) continue;
-    result[toKebabCase(key)] = convertValueKeys(v);
+    const yamlKey = verbatim ? key : toKebabCase(key);
+    result[yamlKey] = convertValueKeys(v, verbatim || VERBATIM_KEY_MAPS.has(yamlKey));
   }
   return result;
 }