@intentius/chant-lexicon-aws 0.79.0 → 0.80.0

package/dist/components/apply.d.ts

@@ -124,8 +124,8 @@ export interface EcsUpdateServiceOutput {
  * capability-level compensation for the common case (recorded here so the
  * capability is never rollback-silent); a component whose service swap needs
  * a specific prior task definition/count restored (rather than a re-apply of
- * the same input) supplies its own explicit rollback phase instead, as the
- * ALB/ECS pilot does with `rollback-previous`.
+ * the same input) supplies its own explicit rollback phase instead, such as
+ * `rollback-previous` with that `taskDefinition`.
  */
 export declare function createEcsUpdateServiceCapability(executor?: CloudExecutor): Capability<EcsUpdateServiceInput, EcsUpdateServiceOutput>;
 /** Default `ecs-update-service` capability, backed by the real `CloudExecutor`. */

package/dist/integrity.json

@@ -1,7 +1,7 @@
 {
   "algorithm": "sha256",
   "artifacts": {
-    "manifest.json": "04f2deaead1d0523d682f765b4c3e7f95af5e96de6db8713db3f09acac92c4f6",
+    "manifest.json": "d41955abfee73ff321172c907028877048d322f6305bfd90673ce5768245d5d9",
     "meta.json": "31795ba62a1da7503a8d55192c212ac44c56a56cdb2d4fde47966a1abc8b021b",
     "types/index.d.ts": "1038589dccfc1e690e3373014bff4d319e4ed3b421db2448ed4e70d51eb9d1f2",
     "rules/hardcoded-region.ts": "5a0eaf7ab391231fe6cd51426ece29539cb4b36f31c8dd060956638fed55722a",
@@ -73,5 +73,5 @@
     "skills/chant-aws-eks.md": "8789255709ff004ad0a875fd5999edcdc66fc6e33d710db058d9f42703bcfdfe",
     "skills/chant-aws-carve-terraform.md": "8780b94ce60aded935938d5ef20ea667738354051da1bf9ca6d70d9886f65d21"
   },
-  "composite": "b6f987ad78908ed06fcb7830a9eb7874a4c7a7c141e12dd342371ef704bc7c09"
+  "composite": "76fcd6b2effef2df35ff5e01a3dbd11def617990258cf782bf42774e8d96d320"
 }

package/dist/manifest.json

@@ -1,6 +1,6 @@
 {
   "name": "aws",
-  "version": "0.79.0",
+  "version": "0.80.0",
   "chantVersion": ">=0.1.0",
   "namespace": "AWS",
   "intrinsics": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@intentius/chant-lexicon-aws",
-  "version": "0.79.0",
+  "version": "0.80.0",
   "description": "AWS CloudFormation lexicon for chant — declarative IaC in TypeScript",
   "license": "Apache-2.0",
   "homepage": "https://intentius.io/chant",
@@ -80,7 +80,7 @@
     "typescript": "^5.9.3"
   },
   "peerDependencies": {
-    "@intentius/chant": "^0.79.0",
+    "@intentius/chant": "^0.80.0",
     "typescript": "^5.9.3"
   }
 }

package/src/components/apply.ts

@@ -259,8 +259,8 @@ export interface EcsUpdateServiceOutput {
  * capability-level compensation for the common case (recorded here so the
  * capability is never rollback-silent); a component whose service swap needs
  * a specific prior task definition/count restored (rather than a re-apply of
- * the same input) supplies its own explicit rollback phase instead, as the
- * ALB/ECS pilot does with `rollback-previous`.
+ * the same input) supplies its own explicit rollback phase instead, such as
+ * `rollback-previous` with that `taskDefinition`.
  */
 export function createEcsUpdateServiceCapability(
   executor: CloudExecutor = defaultCloudExecutor(),

package/src/components/pilots-e2e.test.ts

@@ -48,8 +48,9 @@ import {
   createWaitJobCapability,
 } from "./wait-aws";
 import { createEmrStartJobRunCapability } from "./job-submission";
+import { createRollbackPreviousCapability } from "./safety";
 
-/** Build a fresh registry with every real #557/#558/#561 capability wired to one shared mock executor, plus the still-stubbed verbs the pilots also reference (run-migration, health-gate, rollback-previous — none of which #557/#558/#561 scopes). */
+/** Build a fresh registry with every real #557/#558/#561 capability wired to one shared mock executor, plus the still-stubbed verbs the pilots also reference (run-migration, health-gate — neither of which #557/#558/#561 scopes). */
 function buildRegistry(mock: MockCloudExecutor): CapabilityRegistry {
   const registry = new CapabilityRegistry();
   registry.register(createDockerBuildCapability(mock.executor));
@@ -79,10 +80,8 @@ function buildRegistry(mock: MockCloudExecutor): CapabilityRegistry {
   // Non-AWS-leaf / non-pilot-scoped verbs the pilots still reference — out of
   // #557/#558/#561's scope (still typed stubs in ../verbs/*.ts), so faked here
   // to succeed so the happy-path E2E run can reach completion.
-  // `rollback-previous` backs the ALB/ECS pilot's own compensation phase.
   registry.register({ kind: "run-migration", run: async () => ({ applied: true, version: "1" }) });
   registry.register({ kind: "health-gate", run: async () => ({ healthy: true }) });
-  registry.register({ kind: "rollback-previous", run: async () => ({ restored: true }) });
   return registry;
 }
 
@@ -447,11 +446,20 @@ describe("Every mutating #557 capability declares a rollback, or the pilot suppl
     expect(createWaitClusterHealthyCapability(mock.executor).rollback).toBeUndefined();
   });
 
-  it("the ALB/ECS pilot supplies its own explicit rollback phase (rollback-previous) precisely because ecs-update-service's own rollback is a best-effort re-apply, not a true prior-state restore", () => {
-    // Documents the pilot-level opt-out this issue's acceptance criteria asks
-    // for: the component, not the capability, owns the compensation here.
-    expect(searchService.rollback).toBeDefined();
-    expect(searchService.rollback![0]!.steps[0]).toMatchObject({ kind: "rollback-previous" });
+  it("the ALB/ECS pilot declares no rollback-previous phase (#2576): with no taskDefinition it restored nothing", async () => {
+    // The phase it used to declare passed only `service` and `cluster`. The
+    // real capability turns that into `rollbackService` with no task
+    // definition, which the real executor sends as an `aws ecs update-service`
+    // that changes nothing. An earlier release is `chant components rollback`.
+    expect(searchService.rollback).toBeUndefined();
+    const mock = createMockCloudExecutor();
+    await createRollbackPreviousCapability(mock.executor).run(
+      { env: "dev", component: "search-service" },
+      { service: "search", cluster: "prod" },
+    );
+    expect(mock.calls).toEqual([
+      { client: "ecs", method: "rollbackService", args: { cluster: "prod", service: "search", taskDefinition: undefined, desiredCount: undefined } },
+    ]);
   });
 
   it("the DynamoDB pilot declares no component-level rollback — a blocked replacement is a stop, not something to compensate (documented opt-out)", () => {

package/src/components/presets-e2e.test.ts

@@ -25,6 +25,8 @@ import { createDockerBuildCapability } from "@intentius/chant/components/verbs/b
 import { createPublishImageCapability, createLoadImageOnHostCapability } from "./publish";
 import { createCfnDeployCapability, createEcsUpdateServiceCapability, createLambdaDeployCapability } from "./apply";
 import { createWaitSteadyStateCapability } from "./wait-aws";
+import { starterCapabilityPlugin } from "@intentius/chant/components/starter-plugin";
+import { awsCapabilityPlugin } from "./capability-plugin";
 
 /** Same registry-building convention as ../pilots/pilots-e2e.test.ts: real capabilities wired to one shared mock executor, plus fakes for verbs this suite's presets reference but that stay typed stubs (out of scope for #566, matching the pilots' own accounting). */
 function buildRegistry(mock: MockCloudExecutor): CapabilityRegistry {
@@ -37,7 +39,6 @@ function buildRegistry(mock: MockCloudExecutor): CapabilityRegistry {
   registry.register(createLambdaDeployCapability(mock.executor));
   registry.register(createWaitSteadyStateCapability(mock.executor));
   registry.register({ kind: "health-gate", run: async () => ({ healthy: true }) });
-  registry.register({ kind: "rollback-previous", run: async () => ({ restored: true }) });
   registry.register({ kind: "copy-to-host", run: async () => ({ bytesCopied: 128 }) });
   registry.register({ kind: "remote-exec", run: async () => ({ exitCode: 0, stdout: "" }) });
   registry.register({ kind: "wait-endpoint", run: async () => ({ status: 200 }) });
@@ -164,3 +165,40 @@ describe("Preset library end-to-end through the real interpret driver (#566 acce
     expect(callsByClient.some((c) => c.startsWith("ecr."))).toBe(false);
   });
 });
+
+/** Every step kind a component composes, in `deploy` and `rollback`, nested fan-out phases included. */
+function stepKinds(component: DriverComponent): string[] {
+  const kinds: string[] = [];
+  const walk = (steps: unknown[]): void => {
+    for (const step of steps) {
+      const s = step as { kind?: string; steps?: unknown[] };
+      if (Array.isArray(s.steps)) walk(s.steps);
+      else if (s.kind && s.kind !== "gate") kinds.push(s.kind);
+    }
+  };
+  for (const phase of [...component.deploy, ...(component.rollback ?? [])]) walk(phase.steps);
+  return kinds;
+}
+
+describe("presets compose only registered step kinds (#2576)", () => {
+  const registered = new Set(
+    [...starterCapabilityPlugin.capabilities(), ...awsCapabilityPlugin.capabilities()].map((c) => c.kind),
+  );
+  const components: Array<[string, DriverComponent]> = [
+    ["EcsFargateComponent", projectToJson(EcsFargateComponent({ name: "svc", healthPath: "/healthz", sharedAlbStack: "shared-alb" })) as unknown as DriverComponent],
+    ["LambdaComponent", projectToJson(LambdaComponent({ name: "fn", functionName: "fn" })) as unknown as DriverComponent],
+    ["SingleHostComposeComponent", projectToJson(SingleHostComposeComponent({ name: "host", healthPath: "/", healthPort: 80 })) as unknown as DriverComponent],
+    ["the ALB/ECS pilot", projectToJson(searchService) as unknown as DriverComponent],
+  ];
+
+  it.each(components)("%s uses no step kind the starter and aws plugins leave unregistered", (_name, component) => {
+    expect(stepKinds(component).filter((kind) => !registered.has(kind))).toEqual([]);
+  });
+
+  it("the ECS preset and the ALB/ECS pilot declare no rollback-previous step", () => {
+    for (const [, component] of components) {
+      expect(stepKinds(component)).not.toContain("rollback-previous");
+    }
+    expect(components[0]![1].rollback).toBeUndefined();
+  });
+});