@intentius/chant-lexicon-aws 0.57.0 → 0.59.0

package/src/deep-observe.test.ts

@@ -949,12 +949,15 @@ describe("end to end: declared + mutated live + baseline (#1015)", () => {
     // all subtracted.
     expect(result.unchanged).toEqual(["AppRole"]);
 
-    // The platform team's tag is accepted, so it is reported as suppressed
-    // rather than as drift.
-    expect(result.accepted.map((e) => e.name)).toEqual(["Assets"]);
-    expect(result.accepted[0].changes.map((c) => c.path)).toEqual([
-      "Tags[#cost-center].Key",
-      "Tags[#cost-center].Value",
+    // The platform team's tag is on a path source never declared, so since
+    // #2160 the claim answers before the baseline gets a chance to: it is held
+    // elsewhere, at its live value, and it is not drift. AWS records no field
+    // manager, so the claimed-field set is the only source that can answer.
+    expect(result.accepted).toEqual([]);
+    expect(result.unclaimed.map((e) => e.name)).toEqual(["Assets"]);
+    expect(result.unclaimed[0].fields).toEqual([
+      { path: "Tags[#cost-center].Key", live: "cost-center", source: "claimed-fields", baseline: "cost-center" },
+      { path: "Tags[#cost-center].Value", live: "platform", source: "claimed-fields", baseline: "platform" },
     ]);
 
     // An unreadable deep read is a hole with a reason — never silence, never
@@ -976,7 +979,10 @@ describe("end to end: declared + mutated live + baseline (#1015)", () => {
     ]);
   });
 
-  test("without the baseline the platform tag is drift, and accepting it is what silences it", async () => {
+  test("the claim silences the platform tag with no baseline at all (#2160)", async () => {
+    // Before #2160 this tag was drift until somebody accepted it. The
+    // declaration is the table AWS cannot provide, and it answers on the first
+    // read, with nothing recorded anywhere.
     wireMocks();
     const result = await deepDiffForLexicon(awsPlugin, {
       environment: "prod",
@@ -984,15 +990,16 @@ describe("end to end: declared + mutated live + baseline (#1015)", () => {
       entities: declared,
     });
     const assets = result.drifted.find((d) => d.name === "Assets");
-    expect(assets?.changes.map((c) => c.path).sort()).toEqual([
+    expect(assets?.changes.map((c) => c.path)).toEqual(["VersioningConfiguration.Status"]);
+    expect(result.unclaimed[0].fields.map((f) => f.path)).toEqual([
       "Tags[#cost-center].Key",
       "Tags[#cost-center].Value",
-      "VersioningConfiguration.Status",
     ]);
     expect(result.accepted).toEqual([]);
   });
 
   test("an accepted value that later changes is drift again, with all three axes", async () => {
+    // The baseline's value-bound rule, on the path that is actually declared.
     wireMocks();
     const result = await deepDiffForLexicon(awsPlugin, {
       environment: "prod",
@@ -1000,18 +1007,19 @@ describe("end to end: declared + mutated live + baseline (#1015)", () => {
       entities: declared,
       baseline: {
         Assets: {
-          accepted: [{ path: "Tags[#cost-center].Value", value: "someone-elses-team" }],
+          accepted: [{ path: "VersioningConfiguration.Status", value: "Enabled" }],
         },
       },
     });
     const change = result.drifted
       .find((d) => d.name === "Assets")
-      ?.changes.find((c) => c.path === "Tags[#cost-center].Value");
+      ?.changes.find((c) => c.path === "VersioningConfiguration.Status");
     expect(change).toEqual({
-      path: "Tags[#cost-center].Value",
-      kind: "undeclared",
-      live: "platform",
-      baseline: "someone-elses-team",
+      path: "VersioningConfiguration.Status",
+      kind: "changed",
+      declared: "Enabled",
+      live: "Suspended",
+      baseline: "Enabled",
     });
   });
 

package/src/deep-topology.test.ts

@@ -360,7 +360,7 @@ describe("the fold answers (#1269)", () => {
     ]);
   });
 
-  test("an out-of-band MapPublicIpOnLaunch flip reports; the service default does not", async () => {
+  test("an out-of-band MapPublicIpOnLaunch flip reports as unclaimed; the service default does not", async () => {
     const subnetRow = (mapPublic: boolean) => ({
       Subnets: [{ SubnetId: "subnet-01", VpcId: "vpc-01", CidrBlock: "10.0.1.0/24", MapPublicIpOnLaunch: mapPublic }],
     });
@@ -381,11 +381,15 @@ describe("the fold answers (#1269)", () => {
 
     ec2Describes({ "describe-subnets": subnetRow(true) });
     const diff = diffDeepObservation(declared, await observe(), awsDeepNormalizationHooks);
-    expect(diff.drifted).toEqual([
+    // Source never set MapPublicIpOnLaunch, so the flip is somebody else's
+    // (#2160): reported with its value, not counted as drift, and never
+    // proposed for an update.
+    expect(diff.drifted).toEqual([]);
+    expect(diff.unclaimed).toEqual([
       {
         name: "PublicSubnet",
         type: "AWS::EC2::Subnet",
-        changes: [{ path: "MapPublicIpOnLaunch", kind: "undeclared", live: true }],
+        fields: [{ path: "MapPublicIpOnLaunch", live: true, source: "claimed-fields" }],
       },
     ]);
   });