@intentius/chant-lexicon-aws 0.19.1 → 0.21.0

package/src/plugin.ts

@@ -52,17 +52,36 @@ export const awsPlugin: LexiconPlugin = {
     return discoverLintRules(rulesDir, import.meta.url);
   },
 
+  /**
+   * chant #1044 — every plain-call intrinsic below carries
+   * `foldsAsCall: true`, opting its CALL form into `chant build --fold`.
+   *
+   * Audited one at a time against the criterion in `IntrinsicDef.foldsAsCall`
+   * (core's lexicon.ts): the call must be a pure function of its arguments
+   * that builds a deterministic data envelope. Each of these constructs its
+   * `*Intrinsic` class and stores the arguments verbatim (../intrinsics.ts) —
+   * no I/O, no environment, no module state, and no CloudFormation semantics
+   * evaluated locally: `Base64("x")` emits `{"Fn::Base64": "x"}` for the
+   * deployment to encode, it does not encode anything here. Calling one while
+   * folding is therefore indistinguishable from calling it during a real run
+   * of the file.
+   *
+   * `Sub` is the one intrinsic NOT opted in, and cannot be: it is authored as
+   * a tagged template (`isTag: true`), which already folds through
+   * `foldTaggedTemplate`. `Sub(...)` as a plain call is not its authoring
+   * form, and `chant dev check-lexicon` rejects a registration claiming both.
+   */
   intrinsics(): IntrinsicDef[] {
     return [
-      { name: "Sub", description: "Fn::Sub template string interpolation" },
-      { name: "Ref", description: "Reference a parameter or resource" },
-      { name: "GetAtt", description: "Fn::GetAtt — get resource attribute" },
-      { name: "If", description: "Fn::If — conditional value" },
-      { name: "Join", description: "Fn::Join — join values with delimiter" },
-      { name: "Select", description: "Fn::Select — select value by index" },
-      { name: "Split", description: "Fn::Split — split string by delimiter" },
-      { name: "Base64", description: "Fn::Base64 — encode to Base64" },
-      { name: "GetAZs", description: "Fn::GetAZs — list Availability Zones" },
+      { name: "Sub", description: "Fn::Sub template string interpolation", isTag: true },
+      { name: "Ref", description: "Reference a parameter or resource", isTag: false, foldsAsCall: true },
+      { name: "GetAtt", description: "Fn::GetAtt — get resource attribute", isTag: false, foldsAsCall: true },
+      { name: "If", description: "Fn::If — conditional value", isTag: false, foldsAsCall: true },
+      { name: "Join", description: "Fn::Join — join values with delimiter", isTag: false, foldsAsCall: true },
+      { name: "Select", description: "Fn::Select — select value by index", isTag: false, foldsAsCall: true },
+      { name: "Split", description: "Fn::Split — split string by delimiter", isTag: false, foldsAsCall: true },
+      { name: "Base64", description: "Fn::Base64 — encode to Base64", isTag: false, foldsAsCall: true },
+      { name: "GetAZs", description: "Fn::GetAZs — list Availability Zones", isTag: false, foldsAsCall: true },
     ];
   },
 

package/src/serializer.ts

@@ -1,5 +1,5 @@
 import type { Declarable, CoreParameter } from "@intentius/chant/declarable";
-import { isPropertyDeclarable } from "@intentius/chant/declarable";
+import { isPropertyDeclarable, isResourceDeclarable } from "@intentius/chant/declarable";
 import type { Serializer, SerializerResult, SerializeContext } from "@intentius/chant/serializer";
 import { ownershipEntries, type OwnershipMarker } from "@intentius/chant/ownership";
 import { AWS_TAG_OWNERSHIP_KEYS } from "./ownership";
@@ -82,7 +82,7 @@ function cfnVisitor(entityNames: Map<Declarable, string>): SerializerVisitor {
     attrRef: (name, attr) => ({ "Fn::GetAtt": [name, attr] }),
     resourceRef: (name) => ({ Ref: name }),
     propertyDeclarable: (entity, walk) => {
-      if (!("props" in entity) || typeof entity.props !== "object" || entity.props === null) {
+      if (!isResourceDeclarable(entity) || typeof entity.props !== "object" || entity.props === null) {
         return undefined;
       }
       const props = entity.props as Record<string, unknown>;
@@ -136,7 +136,7 @@ function toProperties(
   entity: Declarable,
   entityNames: Map<Declarable, string>
 ): Record<string, unknown> | undefined {
-  if (!("props" in entity) || typeof entity.props !== "object" || entity.props === null) {
+  if (!isResourceDeclarable(entity) || typeof entity.props !== "object" || entity.props === null) {
     return undefined;
   }
 
@@ -281,7 +281,7 @@ function serializeToTemplate(
       };
 
       // Read resource-level attributes from the second constructor arg
-      const attrs = ("attributes" in entity && typeof entity.attributes === "object" && entity.attributes !== null)
+      const attrs = (isResourceDeclarable(entity) && typeof entity.attributes === "object" && entity.attributes !== null)
         ? entity.attributes as Record<string, unknown>
         : undefined;