@intentius/chant-lexicon-aws 0.18.31 → 0.18.32

package/dist/components/safety.d.ts

@@ -27,21 +27,40 @@ export interface SnapshotBeforeOutput {
 export declare function createSnapshotBeforeCapability(executor?: CloudExecutor): Capability<SnapshotBeforeInput, SnapshotBeforeOutput>;
 /** Default `snapshot-before` capability, backed by the real `CloudExecutor`. */
 export declare const snapshotBeforeCapability: Capability<SnapshotBeforeInput, SnapshotBeforeOutput>;
-export interface RollbackPreviousInput {
+/** Restore a resource from a prior `snapshot-before` capture (DynamoDB/RDS/EBS). */
+export interface RollbackPreviousSnapshotInput {
     /** Snapshot identifier to restore (typically `"@snapshot-before.snapshotId"`). */
     snapshotId: string;
     /** Resource identifier being restored. */
     resource: string;
 }
+/** Roll an ECS service back to its previously recorded task definition — the
+ * shape the `ecs-fargate` preset and the ALB/ECS pilot compose (e.g. loomster's
+ * `loom-frontend`). */
+export interface RollbackPreviousEcsInput {
+    /** ECS service name. */
+    service: string;
+    /** ECS cluster (name or ARN). */
+    cluster: string;
+    /** Explicit task definition to roll to; omitted → the executor's recorded previous. */
+    taskDefinition?: string;
+    desiredCount?: number;
+}
+/** `rollback-previous` accepts EITHER a snapshot restore or an ECS service
+ * rollback — the two things components actually compose it for. */
+export type RollbackPreviousInput = RollbackPreviousSnapshotInput | RollbackPreviousEcsInput;
 export interface RollbackPreviousOutput {
-    /** True once the restore completed. */
+    /** True once the restore/rollback completed. */
     restored: boolean;
 }
 /**
- * Restore a resource from a prior `snapshot-before` capture — an explicit,
- * caller-composed rollback (not the auto-triggered per-capability compensation).
- * Dispatches by the snapshot-id shape through the `CloudExecutor` and waits for
- * the restore to become available.
+ * Roll a resource back to its prior state — an explicit, caller-composed
+ * compensation (not the auto-triggered per-capability `rollback`). Dispatches by
+ * the input shape: an ECS service (`{service, cluster}`) rolls to its previous
+ * task definition; a snapshot (`{snapshotId, resource}`) restores that capture.
+ * An unrecognized shape fails with a clear message rather than a cryptic
+ * `undefined` access (chant #990 — an ECS-shaped input used to reach the
+ * snapshot path and throw "reading 'includes'" on the absent snapshotId).
  */
 export declare function createRollbackPreviousCapability(executor?: CloudExecutor): Capability<RollbackPreviousInput, RollbackPreviousOutput>;
 /** Default `rollback-previous` capability, backed by the real `CloudExecutor`. */

package/dist/components/safety.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"safety.d.ts","sourceRoot":"","sources":["../../src/components/safety.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,wCAAwC,CAAC;AACzE,OAAO,EAAwB,KAAK,aAAa,EAAE,MAAM,kBAAkB,CAAC;AAI5E,MAAM,WAAW,mBAAmB;IAClC,wFAAwF;IACxF,QAAQ,EAAE,MAAM,CAAC;IACjB,kEAAkE;IAClE,YAAY,EAAE,gBAAgB,GAAG,cAAc,GAAG,mBAAmB,GAAG,YAAY,CAAC;CACtF;AAED,MAAM,WAAW,oBAAoB;IACnC,oEAAoE;IACpE,UAAU,EAAE,MAAM,CAAC;CACpB;AAED;;;;;GAKG;AACH,wBAAgB,8BAA8B,CAAC,QAAQ,GAAE,aAAsC,GAAG,UAAU,CAAC,mBAAmB,EAAE,oBAAoB,CAAC,CAOtJ;AAED,gFAAgF;AAChF,eAAO,MAAM,wBAAwB,EAAE,UAAU,CAAC,mBAAmB,EAAE,oBAAoB,CACzD,CAAC;AAInC,MAAM,WAAW,qBAAqB;IACpC,kFAAkF;IAClF,UAAU,EAAE,MAAM,CAAC;IACnB,0CAA0C;IAC1C,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,MAAM,WAAW,sBAAsB;IACrC,uCAAuC;IACvC,QAAQ,EAAE,OAAO,CAAC;CACnB;AAED;;;;;GAKG;AACH,wBAAgB,gCAAgC,CAAC,QAAQ,GAAE,aAAsC,GAAG,UAAU,CAAC,qBAAqB,EAAE,sBAAsB,CAAC,CAQ5J;AAED,kFAAkF;AAClF,eAAO,MAAM,0BAA0B,EAAE,UAAU,CAAC,qBAAqB,EAAE,sBAAsB,CAC7D,CAAC"}
+{"version":3,"file":"safety.d.ts","sourceRoot":"","sources":["../../src/components/safety.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,wCAAwC,CAAC;AACzE,OAAO,EAAwB,KAAK,aAAa,EAAE,MAAM,kBAAkB,CAAC;AAI5E,MAAM,WAAW,mBAAmB;IAClC,wFAAwF;IACxF,QAAQ,EAAE,MAAM,CAAC;IACjB,kEAAkE;IAClE,YAAY,EAAE,gBAAgB,GAAG,cAAc,GAAG,mBAAmB,GAAG,YAAY,CAAC;CACtF;AAED,MAAM,WAAW,oBAAoB;IACnC,oEAAoE;IACpE,UAAU,EAAE,MAAM,CAAC;CACpB;AAED;;;;;GAKG;AACH,wBAAgB,8BAA8B,CAAC,QAAQ,GAAE,aAAsC,GAAG,UAAU,CAAC,mBAAmB,EAAE,oBAAoB,CAAC,CAOtJ;AAED,gFAAgF;AAChF,eAAO,MAAM,wBAAwB,EAAE,UAAU,CAAC,mBAAmB,EAAE,oBAAoB,CACzD,CAAC;AAInC,oFAAoF;AACpF,MAAM,WAAW,6BAA6B;IAC5C,kFAAkF;IAClF,UAAU,EAAE,MAAM,CAAC;IACnB,0CAA0C;IAC1C,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED;;uBAEuB;AACvB,MAAM,WAAW,wBAAwB;IACvC,wBAAwB;IACxB,OAAO,EAAE,MAAM,CAAC;IAChB,iCAAiC;IACjC,OAAO,EAAE,MAAM,CAAC;IAChB,uFAAuF;IACvF,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,YAAY,CAAC,EAAE,MAAM,CAAC;CACvB;AAED;mEACmE;AACnE,MAAM,MAAM,qBAAqB,GAAG,6BAA6B,GAAG,wBAAwB,CAAC;AAE7F,MAAM,WAAW,sBAAsB;IACrC,gDAAgD;IAChD,QAAQ,EAAE,OAAO,CAAC;CACnB;AAED;;;;;;;;GAQG;AACH,wBAAgB,gCAAgC,CAAC,QAAQ,GAAE,aAAsC,GAAG,UAAU,CAAC,qBAAqB,EAAE,sBAAsB,CAAC,CAuB5J;AAED,kFAAkF;AAClF,eAAO,MAAM,0BAA0B,EAAE,UAAU,CAAC,qBAAqB,EAAE,sBAAsB,CAC7D,CAAC"}

package/dist/integrity.json

@@ -1,7 +1,7 @@
 {
   "algorithm": "sha256",
   "artifacts": {
-    "manifest.json": "e25bec3d6323be764670c586fffab6adc33895137024397b876a20081dbf0dcc",
+    "manifest.json": "509264d8b032627a9556f6fd025464e90ed042bbf0f8e1ae93d294559c047351",
     "meta.json": "f753beb9ef6a89191cc76afc3be19f4bc7142751ce6b2d37bea8008bc37c7793",
     "types/index.d.ts": "22463a37dc0a2e3dd8baf0ddbb72f9e12ec4e5b6dd33ecfe22a1a8a8cff272b9",
     "rules/hardcoded-region.ts": "5a0eaf7ab391231fe6cd51426ece29539cb4b36f31c8dd060956638fed55722a",
@@ -58,5 +58,5 @@
     "skills/chant-aws.md": "4d65eb160e001f2af42eb7c622a5b498c2fd1f5afbd6c8155615c010fb265c63",
     "skills/chant-aws-eks.md": "8789255709ff004ad0a875fd5999edcdc66fc6e33d710db058d9f42703bcfdfe"
   },
-  "composite": "fee1c2b17ebb822926bb8d501766aac055bd5328fb19bf9cf15209fe4c58784a"
+  "composite": "fbc07b964d4e46751c96e1365a729e61d0bb2c58e6131ef181afca50264ece3f"
 }

package/dist/manifest.json

@@ -1,6 +1,6 @@
 {
   "name": "aws",
-  "version": "0.18.31",
+  "version": "0.18.32",
   "chantVersion": ">=0.1.0",
   "namespace": "AWS",
   "intrinsics": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@intentius/chant-lexicon-aws",
-  "version": "0.18.31",
+  "version": "0.18.32",
   "description": "AWS CloudFormation lexicon for chant \u2014 declarative IaC in TypeScript",
   "license": "Apache-2.0",
   "homepage": "https://intentius.io/chant",
@@ -80,7 +80,7 @@
     "typescript": "^5.9.3"
   },
   "peerDependencies": {
-    "@intentius/chant": "^0.18.31",
+    "@intentius/chant": "^0.18.32",
     "typescript": "^5.9.3"
   }
 }

package/src/components/safety.test.ts

@@ -41,6 +41,27 @@ describe("rollback-previous (#557)", () => {
     ]);
   });
 
+  it("rolls an ECS service back via the executor for the {service, cluster} shape (#990)", async () => {
+    // The ecs-fargate preset / ALB-ECS pilot (and loomster's loom-frontend)
+    // compose rollback-previous with an ECS service, NOT a snapshot id. This
+    // used to reach the snapshot path and throw "Cannot read properties of
+    // undefined (reading 'includes')" on the absent snapshotId.
+    const mock = createMockCloudExecutor();
+    const out = await createRollbackPreviousCapability(mock.executor).run(ctx, {
+      service: "loom-frontend-svc",
+      cluster: "arn:aws:ecs:us-east-1:1:cluster/loom",
+    });
+    expect(out).toEqual({ restored: true });
+    expect(mock.calls).toEqual([
+      { client: "ecs", method: "rollbackService", args: { cluster: "arn:aws:ecs:us-east-1:1:cluster/loom", service: "loom-frontend-svc", taskDefinition: undefined, desiredCount: undefined } },
+    ]);
+  });
+
+  it("fails with a clear message (not a cryptic undefined access) for an unrecognized shape", async () => {
+    const cap = createRollbackPreviousCapability(createMockCloudExecutor().executor);
+    await expect(cap.run(ctx, {} as never)).rejects.toThrow(/expected \{ service, cluster \}|\{ snapshotId, resource \}/);
+  });
+
   it("declares no rollback — it is the rollback", () => {
     expect(createRollbackPreviousCapability(createMockCloudExecutor().executor).rollback).toBeUndefined();
   });

package/src/components/safety.ts

@@ -45,30 +45,66 @@ export const snapshotBeforeCapability: Capability<SnapshotBeforeInput, SnapshotB
 
 // ── rollback-previous ────────────────────────────────────────────────────────
 
-export interface RollbackPreviousInput {
+/** Restore a resource from a prior `snapshot-before` capture (DynamoDB/RDS/EBS). */
+export interface RollbackPreviousSnapshotInput {
   /** Snapshot identifier to restore (typically `"@snapshot-before.snapshotId"`). */
   snapshotId: string;
   /** Resource identifier being restored. */
   resource: string;
 }
 
+/** Roll an ECS service back to its previously recorded task definition — the
+ * shape the `ecs-fargate` preset and the ALB/ECS pilot compose (e.g. loomster's
+ * `loom-frontend`). */
+export interface RollbackPreviousEcsInput {
+  /** ECS service name. */
+  service: string;
+  /** ECS cluster (name or ARN). */
+  cluster: string;
+  /** Explicit task definition to roll to; omitted → the executor's recorded previous. */
+  taskDefinition?: string;
+  desiredCount?: number;
+}
+
+/** `rollback-previous` accepts EITHER a snapshot restore or an ECS service
+ * rollback — the two things components actually compose it for. */
+export type RollbackPreviousInput = RollbackPreviousSnapshotInput | RollbackPreviousEcsInput;
+
 export interface RollbackPreviousOutput {
-  /** True once the restore completed. */
+  /** True once the restore/rollback completed. */
   restored: boolean;
 }
 
 /**
- * Restore a resource from a prior `snapshot-before` capture — an explicit,
- * caller-composed rollback (not the auto-triggered per-capability compensation).
- * Dispatches by the snapshot-id shape through the `CloudExecutor` and waits for
- * the restore to become available.
+ * Roll a resource back to its prior state — an explicit, caller-composed
+ * compensation (not the auto-triggered per-capability `rollback`). Dispatches by
+ * the input shape: an ECS service (`{service, cluster}`) rolls to its previous
+ * task definition; a snapshot (`{snapshotId, resource}`) restores that capture.
+ * An unrecognized shape fails with a clear message rather than a cryptic
+ * `undefined` access (chant #990 — an ECS-shaped input used to reach the
+ * snapshot path and throw "reading 'includes'" on the absent snapshotId).
  */
 export function createRollbackPreviousCapability(executor: CloudExecutor = defaultCloudExecutor()): Capability<RollbackPreviousInput, RollbackPreviousOutput> {
   return {
     kind: "rollback-previous",
     async run(_ctx, input) {
-      await executor.snapshot.restore({ resource: input.resource, snapshotId: input.snapshotId });
-      return { restored: true };
+      if ("service" in input && input.service) {
+        await executor.ecs.rollbackService({
+          cluster: input.cluster,
+          service: input.service,
+          taskDefinition: input.taskDefinition,
+          desiredCount: input.desiredCount,
+        });
+        return { restored: true };
+      }
+      if ("snapshotId" in input && input.snapshotId) {
+        await executor.snapshot.restore({ resource: input.resource, snapshotId: input.snapshotId });
+        return { restored: true };
+      }
+      throw new Error(
+        `rollback-previous: unrecognized input — expected { service, cluster } (ECS service rollback) or ` +
+          `{ snapshotId, resource } (snapshot restore), got keys [${Object.keys(input).join(", ")}]`,
+      );
     },
   };
 }