@intentius/behold 0.29.4 → 0.29.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@intentius/behold",
-  "version": "0.29.4",
+  "version": "0.29.5",
   "license": "Apache-2.0",
   "type": "module",
   "description": "behold — a live control plane on chant. See your whole estate (every substrate in one graph), coloured by drift; act through delegated, gated Ops.",

package/web/kiosk-runs.js

@@ -159,6 +159,22 @@ export function defaultJob(jobs) {
   return started[0] || jobs.find((j) => j.status !== "skipped") || jobs[0] || null;
 }
 
+/** Forgejo's runner line ending a step that exited 3, the code terragucci holds a wave with. */
+const RUNNER_EXIT_3 = /^\s*⚙️\s*\[runner\]: exitcode '3': failure\s*$/u;
+
+/**
+ * A log line as the kiosk shows it under a job: in a job held at the gate,
+ * the runner's `exitcode '3': failure` reads as what it is, a hold waiting for
+ * an approval, never a failure. `{ text, held }`; any other line, and any line
+ * of a job that is not held, is kept as it came.
+ */
+export function logLineWords(jobStatus, line) {
+  if (jobStatus === "waiting" && typeof line === "string" && RUNNER_EXIT_3.test(line)) {
+    return { text: "[runner]: exit code 3: held at the gate, waiting for an approval", held: true };
+  }
+  return { text: line, held: false };
+}
+
 /** The workflow's own steps of a job: not the runner's set-up or trailer, a post step, or an action's (named by its address). */
 function ownSteps(steps) {
   return steps.map((s, i) => ({ s, i })).filter(({ s, i }) => i > 0 && i < steps.length - 1 && !isPostStep(s.name) && !looksLikeAction(s.name));
@@ -384,7 +400,8 @@ export function renderRun(host, answer, ui, { now = new Date(), pickJob = () =>
       if (s.truncated) pre.appendChild(el("div", "r-log-cut", `… ${s.truncated} earlier lines not kept`));
       s.log.forEach((l, n) => {
         const ln = el("div", "r-log-line");
-        ln.append(el("span", "r-ln", String((s.truncated || 0) + n + 1)), el("span", "r-lt", l));
+        const shown = logLineWords(job.status, l);
+        ln.append(el("span", "r-ln", String((s.truncated || 0) + n + 1)), el("span", shown.held ? "r-lt r-wait" : "r-lt", shown.text));
         pre.appendChild(ln);
       });
       if (!s.log.length) pre.appendChild(el("div", "r-log-cut", s.status === "running" ? "waiting for output…" : "no output"));

package/web/kiosk-runs.test.js

@@ -1,7 +1,7 @@
 import { readFileSync } from "node:fs";
 import { join } from "node:path";
 import { describe, expect, it } from "vitest";
-import { FOLLOW_LINES, followsLog, logKey, nearEnd, mergeRun, newerOf, agoWords, defaultJob, defaultStep, durationWords, jobOrder, liveRun, placeWords, sidebarRuns, splitSkipped, STATUS_TONE, triggerWords } from "./kiosk-runs.js";
+import { FOLLOW_LINES, followsLog, logKey, nearEnd, mergeRun, newerOf, agoWords, defaultJob, defaultStep, durationWords, jobOrder, liveRun, logLineWords, placeWords, sidebarRuns, splitSkipped, STATUS_TONE, triggerWords } from "./kiosk-runs.js";
 
 const FIX = join(import.meta.dirname, "..", "src", "__fixtures__", "terragucci-demo", "runs");
 const run = (id) => JSON.parse(readFileSync(join(FIX, `${id}.json`), "utf8"));
@@ -21,6 +21,20 @@ describe("the runs, as a CI page lists them (#569)", () => {
     expect(STATUS_TONE.waiting).toBe("wait");
     expect(STATUS_TONE.waiting).not.toBe(STATUS_TONE.failure);
   });
+  it("shows the runner's exit 3 under a job held at the gate as the hold, not a failure", () => {
+    const line = "⚙️ [runner]: exitcode '3': failure";
+    expect(logLineWords("waiting", line)).toEqual({ text: "[runner]: exit code 3: held at the gate, waiting for an approval", held: true });
+    // The fixture's held job ends its log with that line.
+    const held = run(444).jobs.find((j) => j.status === "waiting");
+    const last = held.steps.find((s) => s.status === "waiting").log.at(-1);
+    expect(logLineWords(held.status, last).held).toBe(true);
+    // A real failure keeps its line, whatever the code.
+    expect(logLineWords("failure", line)).toEqual({ text: line, held: false });
+    expect(logLineWords("failure", "⚙️ [runner]: exitcode '1': failure")).toEqual({ text: "⚙️ [runner]: exitcode '1': failure", held: false });
+    // A held job's other lines, and another code, are kept as they came.
+    expect(logLineWords("waiting", "⚙️ [runner]: exitcode '1': failure").held).toBe(false);
+    expect(logLineWords("waiting", "wave 2 of 3: approval ledger (the default)").held).toBe(false);
+  });
   it("follows the newest run still going, pinned first", () => {
     const runs = index().runs;
     expect(liveRun(runs).id).toBe(448);