@intend-it/core 2.0.6 → 3.0.0

package/dist/index.js

@@ -168837,7 +168837,13 @@ class TypeScriptGenerator {
   }
   generateFunctionSignature(intent) {
     const params = intent.parameters.map((p) => `${p.name}: ${p.type}`).join(", ");
-    const returnType = intent.returnType.generic ? `${intent.returnType.base}<${intent.returnType.generic}>` : intent.returnType.base;
+    let returnType = intent.returnType.base;
+    if (intent.returnType.generic) {
+      returnType += `<${intent.returnType.generic}>`;
+    }
+    if (intent.returnType.isArray) {
+      returnType += "[]";
+    }
     const isAsync = returnType.startsWith("Promise");
     const asyncKeyword = isAsync ? "async " : "";
     return `export ${asyncKeyword}function ${intent.name}(${params}): ${returnType} {`;
@@ -169110,7 +169116,7 @@ ${request.prompt}`;
 // src/ai/prompt-builder.ts
 class PromptBuilder {
   buildContext(intent, fileImports, importedIntents = []) {
-    const returnType = intent.returnType.generic ? `${intent.returnType.base}<${intent.returnType.generic}>` : intent.returnType.base;
+    const returnType = this.formatReturnType(intent.returnType);
     return {
       functionName: intent.name,
       parameters: intent.parameters,
@@ -169122,25 +169128,6 @@ class PromptBuilder {
       importedIntents
     };
   }
-  buildFullPrompt(context) {
-    let contextStr = "";
-    if (context.importedIntents && context.importedIntents.length > 0) {
-      contextStr += `
-
-IMPORTED DEFINITIONS (Strictly adhere to these contracts):
-`;
-      context.importedIntents.forEach((imp) => {
-        const params = imp.parameters.map((p) => `${p.name}: ${p.type}`).join(", ");
-        contextStr += `- Function ${imp.name}(${params}) -> ${imp.returnType.base}
-`;
-        if (imp.body.invariants.length > 0) {
-          imp.body.invariants.forEach((inv) => contextStr += `    Invariant: ${inv.constraint}
-`);
-        }
-      });
-    }
-    return `...` + contextStr;
-  }
   buildSystemPrompt() {
     return `You are an expert TypeScript developer specializing in clean, production-ready code.
 
@@ -169225,7 +169212,7 @@ Generate ONLY the TypeScript code for this step (no explanations, no markdown).`
       lines.push(`IMPORTED DEFINITIONS (Strictly adhere to these contracts):`);
       context.importedIntents.forEach((imp) => {
         const params = this.formatParameters(imp.parameters);
-        const returnType = imp.returnType.generic ? `${imp.returnType.base}<${imp.returnType.generic}>` : imp.returnType.base;
+        const returnType = this.formatReturnType(imp.returnType);
         lines.push(`- Function ${imp.name}(${params}) -> ${returnType}`);
         if (imp.body.invariants.length > 0) {
           imp.body.invariants.forEach((inv) => lines.push(`    Invariant: ${inv.constraint}`));
@@ -169272,6 +169259,73 @@ Return ONLY the function body code (no function signature, no markdown).`);
       return "none";
     return params.map((p) => `${p.name}: ${p.type}`).join(", ");
   }
+  formatReturnType(rt) {
+    let type = rt.base;
+    if (rt.generic) {
+      type += `<${rt.generic}>`;
+    }
+    if (rt.isArray) {
+      type += "[]";
+    }
+    return type;
+  }
+  buildReviewerSystemPrompt() {
+    return `You are a senior code reviewer specializing in detecting logical errors in TypeScript.
+
+Your task is to review generated function implementations for subtle bugs that pass syntax validation but are logically incorrect.
+
+Common issues to detect:
+1. FUNCTION SHADOWING: An inner function with the same name as the outer function, causing the outer to never be called correctly.
+2. UNUSED VARIABLES: Variables declared but never used or returned.
+3. MISSING STEP IMPLEMENTATION: Steps mentioned in requirements but not implemented.
+4. INFINITE LOOPS / RECURSION: Unintended recursive calls or loops with no exit condition.
+5. TYPE MISMATCHES: Returning wrong type or assigning incompatible types.
+6. DEAD CODE: Code that can never be reached.
+
+Response Format:
+- If the code is logically correct, respond with exactly: APPROVED
+- If there are issues, respond with:
+  ISSUES:
+  - [Issue 1 description]
+  - [Issue 2 description]
+  ...
+  FIX: [Brief description of what needs to change]`;
+  }
+  buildReviewerPrompt(context, code) {
+    const lines = [];
+    lines.push(`Review this TypeScript function implementation for logical errors:
+`);
+    lines.push(`Function: ${context.functionName}`);
+    lines.push(`Parameters: ${this.formatParameters(context.parameters)}`);
+    lines.push(`Return Type: ${context.returnType}
+`);
+    lines.push(`Required Steps:`);
+    context.steps.forEach((step, i) => {
+      let line = `${i + 1}. "${step.instruction}"`;
+      if (step.resultVariable) {
+        line += ` => ${step.resultVariable}`;
+        if (step.resultType)
+          line += `: ${step.resultType}`;
+      }
+      lines.push(line);
+    });
+    lines.push(`
+Generated Code:`);
+    lines.push("```typescript");
+    lines.push(code);
+    lines.push("```");
+    lines.push(`
+Verify:`);
+    lines.push(`1. All steps are implemented correctly`);
+    lines.push(`2. No function shadowing or naming conflicts`);
+    lines.push(`3. All declared variables are used`);
+    lines.push(`4. Return value matches required type`);
+    lines.push(`5. No infinite loops or unintended recursion`);
+    lines.push(`
+Respond with APPROVED or ISSUES + FIX as specified.`);
+    return lines.join(`
+`);
+  }
 }
 // src/ai/providers/gemini.ts
 var DEFAULT_MODEL2 = "gemini-flash-latest";
@@ -169657,20 +169711,18 @@ class AICodeGenerator {
       }
       const cleanCode = this.sanitizeAIResponse(response.code);
       const updatedCode = this.injectImplementation(fileContent, cleanCode, functionName);
-      const errors = this.validator.validate(updatedCode);
-      if (errors.length === 0) {
-        return updatedCode;
-      }
-      attempts++;
-      if (attempts < limit) {
-        const errorMsg = errors.slice(0, 5).map((e) => `Line ${e.line}: ${e.message}`).join(`
+      const syntaxErrors = this.validator.validate(updatedCode);
+      if (syntaxErrors.length > 0) {
+        attempts++;
+        if (attempts < limit) {
+          const errorMsg = syntaxErrors.slice(0, 5).map((e) => `Line ${e.line}: ${e.message}`).join(`
 `);
-        console.log(`   ⚠️  Validation failed for ${functionName} (Attempt ${attempts}/${limit}):`);
-        console.log(errorMsg.split(`
+          console.log(`   ⚠️  Validation failed for ${functionName} (Attempt ${attempts}/${limit}):`);
+          console.log(errorMsg.split(`
 `).map((l) => `      ${l}`).join(`
 `));
-        console.log(`      Retrying with AI auto-correction...`);
-        prompt += `
+          console.log(`      Retrying with AI auto-correction...`);
+          prompt += `
 
 Validation Failed (Attempt ${attempts}/${limit}).
 ` + `The code you generated caused errors:
@@ -169684,10 +169736,42 @@ ${errorMsg}
 ` + `CRITICAL INSTRUCTION: Don't just patch the code. 
 ` + `1. First, analyze WHY this error occurred (e.g., mismatching types, undefined variable).
 ` + `2. Then, generate the completely fixed function body wrapped in a \`\`\`typescript block.
+`;
+        } else {
+          console.warn(`   ❌ Validation failed for ${functionName} after ${limit} attempts.`);
+          await this.explainFailure(functionName, updatedCode, syntaxErrors);
+          return updatedCode;
+        }
+        continue;
+      }
+      const logicIssues = await this.verifyLogic(context, cleanCode);
+      if (logicIssues === null) {
+        return updatedCode;
+      }
+      attempts++;
+      if (attempts < limit) {
+        console.log(`   \uD83D\uDD0D Logic review found issues for ${functionName} (Attempt ${attempts}/${limit}):`);
+        console.log(`      ${logicIssues.issues.slice(0, 3).join(`
+      `)}`);
+        console.log(`      Retrying with AI auto-correction...`);
+        prompt += `
+
+Logic Review Failed (Attempt ${attempts}/${limit}).
+` + `The code you generated has logical issues:
+\`\`\`typescript
+${cleanCode}
+\`\`\`
+
+` + `Issues found:
+${logicIssues.issues.join(`
+`)}
+
+` + `Suggested fix: ${logicIssues.fix}
+
+` + `CRITICAL INSTRUCTION: Fix all logical issues and generate the corrected function body.
 `;
       } else {
-        console.warn(`   ❌ Validation failed for ${functionName} after ${limit} attempts.`);
-        await this.explainFailure(functionName, updatedCode, errors);
+        console.warn(`   ❌ Logic verification failed for ${functionName} after ${limit} attempts.`);
         return updatedCode;
       }
     }
@@ -169698,6 +169782,44 @@ ${errorMsg}
     sanitized = sanitized.replace(/^\s*import\s+.*;?\s*$/gm, "");
     return sanitized.trim();
   }
+  async verifyLogic(context, code) {
+    try {
+      const systemPrompt = this.promptBuilder.buildReviewerSystemPrompt();
+      const prompt = this.promptBuilder.buildReviewerPrompt(context, code);
+      const response = await this.provider.generateCode({
+        systemPrompt,
+        prompt
+      });
+      if (!response.success) {
+        console.warn(`   ⚠️  Logic verification skipped (AI error)`);
+        return null;
+      }
+      const reviewResult = response.code.trim();
+      if (reviewResult.toUpperCase().startsWith("APPROVED")) {
+        return null;
+      }
+      const issuesMatch = reviewResult.match(/ISSUES:\s*([\s\S]*?)(?:FIX:|$)/i);
+      const fixMatch = reviewResult.match(/FIX:\s*([\s\S]*?)$/i);
+      if (issuesMatch) {
+        const issueLines = issuesMatch[1].split(`
+`).map((l) => l.trim()).filter((l) => l.startsWith("-") || l.startsWith("*") || l.match(/^\d+\./)).map((l) => l.replace(/^[-*]\s*/, "").replace(/^\d+\.\s*/, ""));
+        const fix = fixMatch ? fixMatch[1].trim() : "Review and fix the issues listed above.";
+        if (issueLines.length > 0) {
+          return { issues: issueLines, fix };
+        }
+      }
+      if (reviewResult.toLowerCase().includes("issue") || reviewResult.toLowerCase().includes("problem")) {
+        return {
+          issues: ["Reviewer found potential issues (see details)"],
+          fix: reviewResult.slice(0, 200)
+        };
+      }
+      return null;
+    } catch (err) {
+      console.warn(`   ⚠️  Logic verification skipped (error)`);
+      return null;
+    }
+  }
   async explainFailure(functionName, code, errors) {
     const errorMsg = errors.map((e) => `Line ${e.line}: ${e.message}`).join(`
 `);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@intend-it/core",
-  "version": "2.0.6",
+  "version": "3.0.0",
   "description": "Core compiler and AI integration for the Intend programming language",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
@@ -35,7 +35,7 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "@intend-it/parser": "^1.1.5",
+    "@intend-it/parser": "^1.2.0",
     "@google/generative-ai": "^0.21.0"
   },
   "devDependencies": {
@@ -43,6 +43,6 @@
     "typescript": "^5.0.0"
   },
   "peerDependencies": {
-    "@intend-it/parser": ">=1.1.5"
+    "@intend-it/parser": ">=1.2.0"
   }
 }