@integrity-labs/agt-cli 0.28.329 → 0.28.331

package/dist/bin/agt.js

@@ -38,7 +38,7 @@ import {
   success,
   table,
   warn
-} from "../chunk-AOSBSVNB.js";
+} from "../chunk-4Y3UPOR2.js";
 import {
   AnchorSessionClient,
   CHANNEL_REGISTRY,
@@ -4827,7 +4827,7 @@ import { execFileSync, execSync } from "child_process";
 import { existsSync as existsSync10, realpathSync as realpathSync2 } from "fs";
 import chalk18 from "chalk";
 import ora16 from "ora";
-var cliVersion = true ? "0.28.329" : "dev";
+var cliVersion = true ? "0.28.331" : "dev";
 async function fetchLatestVersion() {
   const host2 = getHost();
   if (!host2) return null;
@@ -5931,7 +5931,7 @@ function handleError(err) {
 }
 
 // src/bin/agt.ts
-var cliVersion2 = true ? "0.28.329" : "dev";
+var cliVersion2 = true ? "0.28.331" : "dev";
 var program = new Command();
 program.name("agt").description("Augmented CLI \u2014 agent provisioning and management").version(cliVersion2).option("--json", "Emit machine-readable JSON output (suppress spinners and colors)").option("--skip-update-check", "Skip the automatic update check on startup");
 program.hook("preAction", async (thisCommand, actionCommand) => {

package/dist/{chunk-AOSBSVNB.js → chunk-4Y3UPOR2.js}

@@ -2712,9 +2712,13 @@ function provisionStopHook(codeName) {
     "# observed mid-write.",
     "atomic_write_payload() {",
     '  local out_dir="$1" final="$2" jq_expr="$3"; shift 3',
-    '  mkdir -p "$out_dir"',
+    '  if ! mkdir -p "$out_dir" 2>/dev/null; then return 1; fi',
     '  local tmp="$out_dir/.${final##*/}.tmp"',
-    '  jq -n "$jq_expr" "$@" > "$tmp"',
+    "  # ENG-7805 (CodeRabbit): fail (non-zero) on a jq/write fault instead of",
+    "  # mv-ing a half-written tmp - the script has no set -e, so an unguarded jq",
+    "  # error would otherwise ship an empty payload AND let callers believe the",
+    "  # write succeeded (leaving a recovery-ledger entry orphaned until GC).",
+    '  if ! jq -n "$jq_expr" "$@" > "$tmp" 2>/dev/null; then rm -f "$tmp" 2>/dev/null || true; return 1; fi',
     '  chmod 600 "$tmp" 2>/dev/null || true',
     '  mv -f "$tmp" "$out_dir/$final"',
     "}",
@@ -2775,12 +2779,30 @@ function provisionStopHook(codeName) {
     '  marker_name="$(safe_id "$chat_id")__$(safe_id "$msg_id").json"',
     '  local marker_path="${TG_MARKER_DIR}/${marker_name}"',
     '  if [ ! -f "$marker_path" ]; then log_ghost "telegram skip=no_pending_marker chat=$(safe_id "$chat_id")"; return; fi',
+    "  # ENG-7805 (fm2): confirm-before-clear. Cap re-fire with a per-marker ledger and",
+    "  # LEAVE the marker for the consumer to clear on confirmed send. Ledger-first",
+    "  # fail-safe (same as recover_directchat_for / block-turn-end): if the ledger",
+    "  # write fails, log a skip and write no payload rather than re-fire every Stop.",
+    '  if ! mkdir -p "$TG_RECOVERY_LEDGER_DIR" 2>/dev/null; then log_ghost "telegram skip=recovery_ledger_unwritable chat=$(safe_id "$chat_id")"; return; fi',
+    "  # ENG-7805 (CodeRabbit): atomic acquire - noclobber create fails if the entry",
+    "  # already exists (recovery in flight) OR the write faults; the follow-up [ -f ]",
+    '  # disambiguates. Closes the "[ -f ] then : >" TOCTOU where two concurrent Stops',
+    "  # both observe no entry and both enqueue a duplicate payload.",
+    '  if ! ( set -o noclobber; : > "${TG_RECOVERY_LEDGER_DIR}/${marker_name}" ) 2>/dev/null; then',
+    '    if [ -f "${TG_RECOVERY_LEDGER_DIR}/${marker_name}" ]; then log_ghost "telegram skip=recovery_in_flight chat=$(safe_id "$chat_id")"; else log_ghost "telegram skip=recovery_ledger_unwritable chat=$(safe_id "$chat_id")"; fi',
+    "    return",
+    "  fi",
     "  local TS",
     "  TS=$(date -u +%Y%m%dT%H%M%S%N)",
-    '  atomic_write_payload "${AGENT_DIR}/telegram-recovery-outbox" "${TS}.json" \\',
-    `    '{chat_id:$c, message_id:$m, text:$t, source:"ghost-reply-recovery"}' \\`,
-    '    --arg c "$chat_id" --arg m "$msg_id" --arg t "$TEXT"',
-    '  rm -f "$marker_path" 2>/dev/null || true',
+    '  if ! atomic_write_payload "${AGENT_DIR}/telegram-recovery-outbox" "${TS}.json" \\',
+    `    '{chat_id:$c, message_id:$m, text:$t, marker_name:$mn, source:"ghost-reply-recovery"}' \\`,
+    '    --arg c "$chat_id" --arg m "$msg_id" --arg t "$TEXT" --arg mn "$marker_name"; then',
+    "    # ENG-7805 (CodeRabbit): the write faulted after the ledger was acquired -",
+    "    # drop the ledger entry so replay + the next Stop are not suppressed until GC.",
+    '    rm -f "${TG_RECOVERY_LEDGER_DIR}/${marker_name}" 2>/dev/null || true',
+    '    log_ghost "telegram skip=recovery_payload_write_failed chat=$(safe_id "$chat_id")"',
+    "    return",
+    "  fi",
     '  log_ghost "telegram RECOVERED chat=$(safe_id "$chat_id") msg=$(safe_id "$msg_id") text_len=${#TEXT}"',
     "}",
     "recover_slack_for() {",
@@ -2861,13 +2883,29 @@ function provisionStopHook(codeName) {
     "      return",
     "    fi",
     "  fi",
+    '  local marker_name; marker_name="$(basename "$marker_path")"',
+    "  # ENG-7805 (fm2): confirm-before-clear. Cap re-fire with a per-marker ledger and",
+    "  # LEAVE the marker for the consumer to clear on confirmed send (ledger-first fail-safe).",
+    '  if ! mkdir -p "$SL_RECOVERY_LEDGER_DIR" 2>/dev/null; then log_ghost "slack skip=recovery_ledger_unwritable channel=$(safe_id "$channel") thread=$(safe_id "$thread_ts")"; return; fi',
+    "  # ENG-7805 (CodeRabbit): atomic acquire - noclobber create fails if the entry",
+    "  # already exists (recovery in flight) OR the write faults; the follow-up [ -f ]",
+    '  # disambiguates. Closes the "[ -f ] then : >" TOCTOU between concurrent Stops.',
+    '  if ! ( set -o noclobber; : > "${SL_RECOVERY_LEDGER_DIR}/${marker_name}" ) 2>/dev/null; then',
+    '    if [ -f "${SL_RECOVERY_LEDGER_DIR}/${marker_name}" ]; then log_ghost "slack skip=recovery_in_flight channel=$(safe_id "$channel") thread=$(safe_id "$thread_ts")"; else log_ghost "slack skip=recovery_ledger_unwritable channel=$(safe_id "$channel") thread=$(safe_id "$thread_ts")"; fi',
+    "    return",
+    "  fi",
     "  local TS",
     "  TS=$(date -u +%Y%m%dT%H%M%S%N)",
-    '  atomic_write_payload "${AGENT_DIR}/slack-recovery-outbox" "${TS}.json" \\',
-    `    '{channel:$c, thread_ts:$th, text:$t, source:"ghost-reply-recovery"}' \\`,
-    '    --arg c "$channel" --arg th "$thread_ts" --arg t "$TEXT"',
-    '  rm -f "$marker_path" 2>/dev/null || true',
-    '  log_ghost "slack RECOVERED channel=$(safe_id "$channel") thread=$(safe_id "$thread_ts") marker=$(basename "$marker_path") text_len=${#TEXT}"',
+    '  if ! atomic_write_payload "${AGENT_DIR}/slack-recovery-outbox" "${TS}.json" \\',
+    `    '{channel:$c, thread_ts:$th, text:$t, marker_name:$mn, source:"ghost-reply-recovery"}' \\`,
+    '    --arg c "$channel" --arg th "$thread_ts" --arg t "$TEXT" --arg mn "$marker_name"; then',
+    "    # ENG-7805 (CodeRabbit): write faulted after the ledger was acquired - drop",
+    "    # the ledger entry so replay + the next Stop are not suppressed until GC.",
+    '    rm -f "${SL_RECOVERY_LEDGER_DIR}/${marker_name}" 2>/dev/null || true',
+    '    log_ghost "slack skip=recovery_payload_write_failed channel=$(safe_id "$channel") thread=$(safe_id "$thread_ts")"',
+    "    return",
+    "  fi",
+    '  log_ghost "slack RECOVERED channel=$(safe_id "$channel") thread=$(safe_id "$thread_ts") marker=${marker_name} text_len=${#TEXT}"',
     "}",
     "recover_teams_for() {",
     '  local conversation_id="$1" reply_to_id="$2" service_url="$3"',
@@ -2898,12 +2936,28 @@ function provisionStopHook(codeName) {
     '    if [ -z "$marker_path" ]; then marker_path="$f"; fi',
     "  done",
     '  if [ -z "$marker_path" ]; then log_ghost "teams skip=no_pending_marker conv=$(safe_id "$conversation_id")"; return; fi',
+    '  local marker_name; marker_name="$(basename "$marker_path")"',
+    "  # ENG-7805 (fm2): confirm-before-clear. Cap re-fire with a per-marker ledger and",
+    "  # LEAVE the marker for the consumer to clear on confirmed send (ledger-first fail-safe).",
+    '  if ! mkdir -p "$MS_RECOVERY_LEDGER_DIR" 2>/dev/null; then log_ghost "teams skip=recovery_ledger_unwritable conv=$(safe_id "$conversation_id")"; return; fi',
+    "  # ENG-7805 (CodeRabbit): atomic acquire - noclobber create fails if the entry",
+    "  # already exists (recovery in flight) OR the write faults; the follow-up [ -f ]",
+    '  # disambiguates. Closes the "[ -f ] then : >" TOCTOU between concurrent Stops.',
+    '  if ! ( set -o noclobber; : > "${MS_RECOVERY_LEDGER_DIR}/${marker_name}" ) 2>/dev/null; then',
+    '    if [ -f "${MS_RECOVERY_LEDGER_DIR}/${marker_name}" ]; then log_ghost "teams skip=recovery_in_flight conv=$(safe_id "$conversation_id")"; else log_ghost "teams skip=recovery_ledger_unwritable conv=$(safe_id "$conversation_id")"; fi',
+    "    return",
+    "  fi",
     "  local TS",
     "  TS=$(date -u +%Y%m%dT%H%M%S%N)",
-    '  atomic_write_payload "${AGENT_DIR}/msteams-recovery-outbox" "${TS}.json" \\',
-    `    '{conversation_id:$c, reply_to_id:$r, service_url:$s, text:$t, source:"ghost-reply-recovery"}' \\`,
-    '    --arg c "$conversation_id" --arg r "$reply_to_id" --arg s "$service_url" --arg t "$TEXT"',
-    '  rm -f "$marker_path" 2>/dev/null || true',
+    '  if ! atomic_write_payload "${AGENT_DIR}/msteams-recovery-outbox" "${TS}.json" \\',
+    `    '{conversation_id:$c, reply_to_id:$r, service_url:$s, text:$t, marker_name:$mn, source:"ghost-reply-recovery"}' \\`,
+    '    --arg c "$conversation_id" --arg r "$reply_to_id" --arg s "$service_url" --arg t "$TEXT" --arg mn "$marker_name"; then',
+    "    # ENG-7805 (CodeRabbit): write faulted after the ledger was acquired - drop",
+    "    # the ledger entry so replay + the next Stop are not suppressed until GC.",
+    '    rm -f "${MS_RECOVERY_LEDGER_DIR}/${marker_name}" 2>/dev/null || true',
+    '    log_ghost "teams skip=recovery_payload_write_failed conv=$(safe_id "$conversation_id")"',
+    "    return",
+    "  fi",
     '  log_ghost "teams RECOVERED conv=$(safe_id "$conversation_id") text_len=${#TEXT}"',
     "}",
     "# ENG-7814 (ENG-6722 slice E): always-on direct-chat recovery. Re-send the last",
@@ -2981,6 +3035,18 @@ function provisionStopHook(codeName) {
     "# entries here as a backstop, same as the block ledger.",
     'DC_RECOVERY_LEDGER_DIR="${AGENT_DIR}/.agt-direct-chat-recovery-ledger"',
     'if [ -d "$DC_RECOVERY_LEDGER_DIR" ]; then find "$DC_RECOVERY_LEDGER_DIR" -type f -mtime +1 -delete 2>/dev/null || true; fi',
+    "# ENG-7805 (ENG-6722 slice B): per-marker recovery ledgers for slack/telegram/teams.",
+    "# recover_*_for now LEAVES the pending marker in place (confirm-before-clear, fm2)",
+    "# and writes a ledger entry here to cap ONE in-flight recovery per inbound; the",
+    "# channel MCP consumer clears the marker on confirmed send and removes the ledger",
+    "# entry when the recovery resolves (delivered / suppressed / poisoned = re-arm).",
+    "# GC stale entries (>1 day) as a backstop, same as the block + direct-chat ledgers.",
+    'SL_RECOVERY_LEDGER_DIR="${AGENT_DIR}/.agt-slack-recovery-ledger"',
+    'TG_RECOVERY_LEDGER_DIR="${AGENT_DIR}/.agt-telegram-recovery-ledger"',
+    'MS_RECOVERY_LEDGER_DIR="${AGENT_DIR}/.agt-msteams-recovery-ledger"',
+    'for _rl in "$SL_RECOVERY_LEDGER_DIR" "$TG_RECOVERY_LEDGER_DIR" "$MS_RECOVERY_LEDGER_DIR"; do',
+    '  if [ -d "$_rl" ]; then find "$_rl" -type f -mtime +1 -delete 2>/dev/null || true; fi',
+    "done",
     "# Returns 0 (after printing the block JSON to stdout) when it blocked; 1 otherwise.",
     '#   $1 = "yes"/"no" \u2014 did the agent reply to THIS conversation in the final turn?',
     "#        (ENG-6727: per-conversation, computed by the caller via replied_this_conv_*)",
@@ -6797,7 +6863,7 @@ function requireHost() {
 }
 
 // src/lib/api-client.ts
-var agtCliVersion = true ? "0.28.329" : "dev";
+var agtCliVersion = true ? "0.28.331" : "dev";
 var lastConfigHash = null;
 function setConfigHash(hash) {
   lastConfigHash = hash && hash.length > 0 ? hash : null;
@@ -9194,4 +9260,4 @@ export {
   managerInstallSystemUnitCommand,
   managerUninstallSystemUnitCommand
 };
-//# sourceMappingURL=chunk-AOSBSVNB.js.map
+//# sourceMappingURL=chunk-4Y3UPOR2.js.map