@instructure/ui-top-nav-bar 11.2.1-snapshot-3 → 11.2.1-snapshot-4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (7) hide show
  1. package/CHANGELOG.md +5 -2
  2. package/es/TopNavBar/TopNavBarItem/index.js +6 -4
  3. package/lib/TopNavBar/TopNavBarItem/index.js +6 -4
  4. package/package.json +26 -26
  5. package/src/TopNavBar/TopNavBarItem/index.tsx +6 -5
  6. package/tsconfig.build.tsbuildinfo +1 -1
  7. package/types/TopNavBar/TopNavBarItem/index.d.ts.map +1 -1
package/CHANGELOG.md CHANGED
@@ -3,9 +3,12 @@
3
3
  All notable changes to this project will be documented in this file.
4
4
  See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
5
5
 
6
- ## [11.2.1-snapshot-3](https://github.com/instructure/instructure-ui/compare/v11.2.0...v11.2.1-snapshot-3) (2025-11-19)
6
+ ## [11.2.1-snapshot-4](https://github.com/instructure/instructure-ui/compare/v11.2.0...v11.2.1-snapshot-4) (2025-11-21)
7
7
 
8
- **Note:** Version bump only for package @instructure/ui-top-nav-bar
8
+
9
+ ### Bug Fixes
10
+
11
+ * **ui-top-nav-bar:** fix aria-expanded added twice when displaying menus/popups ([b58a1bc](https://github.com/instructure/instructure-ui/commit/b58a1bc8daba596c987dc368d7772e53253c1d77))
9
12
 
10
13
 
11
14
 
package/es/TopNavBar/TopNavBarItem/index.js CHANGED
@@ -473,6 +473,9 @@ let TopNavBarItem = (_dec = withDeterministicId(), _dec2 = withStyle(generateSty
473
473
  withArrow: false,
474
474
  minWidth: ((_renderSubmenu$props2 = renderSubmenu.props) === null || _renderSubmenu$props2 === void 0 ? void 0 : _renderSubmenu$props2.minWidth) || '18.5rem',
475
475
  maxHeight: ((_renderSubmenu$props3 = renderSubmenu.props) === null || _renderSubmenu$props3 === void 0 ? void 0 : _renderSubmenu$props3.maxHeight) || `calc(100vh - 10rem)`,
476
+ // this is needed because the trigger is not a button. `aria-expanded`
477
+ // is set on `get itemProps()`
478
+ shouldSetAriaExpanded: false,
476
479
  ...(status === 'disabled' && {
477
480
  disabled: true,
478
481
  show: false,
@@ -522,10 +525,9 @@ let TopNavBarItem = (_dec = withDeterministicId(), _dec2 = withStyle(generateSty
522
525
  }
523
526
  }),
524
527
  isShowingContent: this.state.isPopoverOpen,
525
- // @ts-expect-error This is a force override for Popover, because it puts
526
- // aria-expanded on the trigger when shouldContainFocus="true",
527
- // even when it should be on the item's <button>
528
- 'aria-expanded': void 0
528
+ // this is needed because the trigger is not a button. `aria-expanded`
529
+ // is set on `get itemProps()`
530
+ shouldSetAriaExpanded: false
529
531
  };
530
532
  return _jsx(Popover, {
531
533
  ...popoverProps,
package/lib/TopNavBar/TopNavBarItem/index.js CHANGED
@@ -485,6 +485,9 @@ let TopNavBarItem = exports.TopNavBarItem = (_dec = (0, _withDeterministicId.wit
485
485
  withArrow: false,
486
486
  minWidth: ((_renderSubmenu$props2 = renderSubmenu.props) === null || _renderSubmenu$props2 === void 0 ? void 0 : _renderSubmenu$props2.minWidth) || '18.5rem',
487
487
  maxHeight: ((_renderSubmenu$props3 = renderSubmenu.props) === null || _renderSubmenu$props3 === void 0 ? void 0 : _renderSubmenu$props3.maxHeight) || `calc(100vh - 10rem)`,
488
+ // this is needed because the trigger is not a button. `aria-expanded`
489
+ // is set on `get itemProps()`
490
+ shouldSetAriaExpanded: false,
488
491
  ...(status === 'disabled' && {
489
492
  disabled: true,
490
493
  show: false,
@@ -534,10 +537,9 @@ let TopNavBarItem = exports.TopNavBarItem = (_dec = (0, _withDeterministicId.wit
534
537
  }
535
538
  }),
536
539
  isShowingContent: this.state.isPopoverOpen,
537
- // @ts-expect-error This is a force override for Popover, because it puts
538
- // aria-expanded on the trigger when shouldContainFocus="true",
539
- // even when it should be on the item's <button>
540
- 'aria-expanded': void 0
540
+ // this is needed because the trigger is not a button. `aria-expanded`
541
+ // is set on `get itemProps()`
542
+ shouldSetAriaExpanded: false
541
543
  };
542
544
  return (0, _jsxRuntime.jsx)(_Popover.Popover, {
543
545
  ...popoverProps,
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@instructure/ui-top-nav-bar",
3
- "version": "11.2.1-snapshot-3",
3
+ "version": "11.2.1-snapshot-4",
4
4
  "description": "A UI component library made by Instructure Inc.",
5
5
  "author": "Instructure, Inc. Engineering and Product Design",
6
6
  "module": "./es/index.js",
@@ -15,37 +15,37 @@
15
15
  "license": "MIT",
16
16
  "dependencies": {
17
17
  "@babel/runtime": "^7.27.6",
18
- "@instructure/console": "11.2.1-snapshot-3",
19
- "@instructure/emotion": "11.2.1-snapshot-3",
20
- "@instructure/shared-types": "11.2.1-snapshot-3",
21
- "@instructure/ui-avatar": "11.2.1-snapshot-3",
22
- "@instructure/ui-a11y-content": "11.2.1-snapshot-3",
23
- "@instructure/ui-breadcrumb": "11.2.1-snapshot-3",
24
- "@instructure/ui-buttons": "11.2.1-snapshot-3",
25
- "@instructure/ui-dialog": "11.2.1-snapshot-3",
26
- "@instructure/ui-dom-utils": "11.2.1-snapshot-3",
27
- "@instructure/ui-link": "11.2.1-snapshot-3",
28
- "@instructure/ui-drilldown": "11.2.1-snapshot-3",
29
- "@instructure/ui-popover": "11.2.1-snapshot-3",
30
- "@instructure/ui-react-utils": "11.2.1-snapshot-3",
31
- "@instructure/ui-icons": "11.2.1-snapshot-3",
32
- "@instructure/ui-responsive": "11.2.1-snapshot-3",
33
- "@instructure/ui-tooltip": "11.2.1-snapshot-3",
34
- "@instructure/ui-tray": "11.2.1-snapshot-3",
35
- "@instructure/ui-truncate-list": "11.2.1-snapshot-3",
36
- "@instructure/ui-utils": "11.2.1-snapshot-3",
37
- "@instructure/ui-view": "11.2.1-snapshot-3"
18
+ "@instructure/shared-types": "11.2.1-snapshot-4",
19
+ "@instructure/emotion": "11.2.1-snapshot-4",
20
+ "@instructure/ui-a11y-content": "11.2.1-snapshot-4",
21
+ "@instructure/ui-avatar": "11.2.1-snapshot-4",
22
+ "@instructure/console": "11.2.1-snapshot-4",
23
+ "@instructure/ui-breadcrumb": "11.2.1-snapshot-4",
24
+ "@instructure/ui-dialog": "11.2.1-snapshot-4",
25
+ "@instructure/ui-buttons": "11.2.1-snapshot-4",
26
+ "@instructure/ui-dom-utils": "11.2.1-snapshot-4",
27
+ "@instructure/ui-drilldown": "11.2.1-snapshot-4",
28
+ "@instructure/ui-icons": "11.2.1-snapshot-4",
29
+ "@instructure/ui-popover": "11.2.1-snapshot-4",
30
+ "@instructure/ui-react-utils": "11.2.1-snapshot-4",
31
+ "@instructure/ui-link": "11.2.1-snapshot-4",
32
+ "@instructure/ui-responsive": "11.2.1-snapshot-4",
33
+ "@instructure/ui-tray": "11.2.1-snapshot-4",
34
+ "@instructure/ui-truncate-list": "11.2.1-snapshot-4",
35
+ "@instructure/ui-utils": "11.2.1-snapshot-4",
36
+ "@instructure/ui-view": "11.2.1-snapshot-4",
37
+ "@instructure/ui-tooltip": "11.2.1-snapshot-4"
38
38
  },
39
39
  "devDependencies": {
40
40
  "@testing-library/jest-dom": "^6.6.3",
41
41
  "@testing-library/react": "15.0.7",
42
42
  "@testing-library/user-event": "^14.6.1",
43
43
  "vitest": "^3.2.2",
44
- "@instructure/ui-axe-check": "11.2.1-snapshot-3",
45
- "@instructure/ui-babel-preset": "11.2.1-snapshot-3",
46
- "@instructure/ui-scripts": "11.2.1-snapshot-3",
47
- "@instructure/ui-color-utils": "11.2.1-snapshot-3",
48
- "@instructure/ui-themes": "11.2.1-snapshot-3"
44
+ "@instructure/ui-axe-check": "11.2.1-snapshot-4",
45
+ "@instructure/ui-babel-preset": "11.2.1-snapshot-4",
46
+ "@instructure/ui-color-utils": "11.2.1-snapshot-4",
47
+ "@instructure/ui-scripts": "11.2.1-snapshot-4",
48
+ "@instructure/ui-themes": "11.2.1-snapshot-4"
49
49
  },
50
50
  "peerDependencies": {
51
51
  "react": ">=18 <=19"
package/src/TopNavBar/TopNavBarItem/index.tsx CHANGED
@@ -636,7 +636,9 @@ class TopNavBarItem extends Component<TopNavBarItemProps, TopNavBarItemState> {
636
636
  withArrow: false,
637
637
  minWidth: renderSubmenu.props?.minWidth || '18.5rem',
638
638
  maxHeight: renderSubmenu.props?.maxHeight || `calc(100vh - 10rem)`,
639
-
639
+ // this is needed because the trigger is not a button. `aria-expanded`
640
+ // is set on `get itemProps()`
641
+ shouldSetAriaExpanded: false,
640
642
  ...(status === 'disabled' && {
641
643
  disabled: true,
642
644
  show: false,
@@ -692,10 +694,9 @@ class TopNavBarItem extends Component<TopNavBarItemProps, TopNavBarItemState> {
692
694
  }
693
695
  ),
694
696
  isShowingContent: this.state.isPopoverOpen,
695
- // @ts-expect-error This is a force override for Popover, because it puts
696
- // aria-expanded on the trigger when shouldContainFocus="true",
697
- // even when it should be on the item's <button>
698
- 'aria-expanded': undefined
697
+ // this is needed because the trigger is not a button. `aria-expanded`
698
+ // is set on `get itemProps()`
699
+ shouldSetAriaExpanded: false
699
700
  }
700
701
 
701
702
  return <Popover {...popoverProps}>{customPopoverConfig.children}</Popover>