@instructure/ui-tag 10.6.1-snapshot-3 → 10.6.1-snapshot-5

package/CHANGELOG.md

@@ -3,9 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [10.6.1-snapshot-3](https://github.com/instructure/instructure-ui/compare/v10.6.0...v10.6.1-snapshot-3) (2024-11-20)
+## [10.6.1-snapshot-5](https://github.com/instructure/instructure-ui/compare/v10.6.0...v10.6.1-snapshot-5) (2024-11-21)
 
-**Note:** Version bump only for package @instructure/ui-tag
+
+### Bug Fixes
+
+* **ui-progress,ui-tag:** remove onClick prop from Tag when callback is not provided. Fix Progress dependency mismatch (test-locator) ([de22f76](https://github.com/instructure/instructure-ui/commit/de22f76fd8fcdf6ef0a25788014da26f5fdfdd0e))
 
 
 

package/es/Tag/index.js

@@ -94,8 +94,10 @@ let Tag = (_dec = withStyle(generateStyle, generateComponentTheme), _dec2 = test
       className: className,
       as: onClick ? 'button' : 'span',
       margin: margin,
-      type: onClick ? 'button' : void 0,
-      onClick: onClick !== null && onClick !== void 0 ? onClick : this.handleClick,
+      type: onClick ? 'button' : void 0
+    }, onClick && {
+      onClick: this.handleClick
+    }, {
       disabled: disabled || readOnly,
       display: void 0,
       title: title || (typeof text === 'string' ? text : void 0)

package/lib/Tag/index.js

@@ -101,8 +101,10 @@ let Tag = exports.Tag = (_dec = (0, _emotion.withStyle)(_styles.default, _theme.
       className: className,
       as: onClick ? 'button' : 'span',
       margin: margin,
-      type: onClick ? 'button' : void 0,
-      onClick: onClick !== null && onClick !== void 0 ? onClick : this.handleClick,
+      type: onClick ? 'button' : void 0
+    }, onClick && {
+      onClick: this.handleClick
+    }, {
       disabled: disabled || readOnly,
       display: void 0,
       title: title || (typeof text === 'string' ? text : void 0)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instructure/ui-tag",
-  "version": "10.6.1-snapshot-3",
+  "version": "10.6.1-snapshot-5",
   "description": "A tag component",
   "author": "Instructure, Inc. Engineering and Product Design",
   "module": "./es/index.js",
@@ -24,22 +24,22 @@
   "license": "MIT",
   "dependencies": {
     "@babel/runtime": "^7.25.6",
-    "@instructure/console": "10.6.1-snapshot-3",
-    "@instructure/emotion": "10.6.1-snapshot-3",
-    "@instructure/shared-types": "10.6.1-snapshot-3",
-    "@instructure/ui-color-utils": "10.6.1-snapshot-3",
-    "@instructure/ui-dom-utils": "10.6.1-snapshot-3",
-    "@instructure/ui-icons": "10.6.1-snapshot-3",
-    "@instructure/ui-react-utils": "10.6.1-snapshot-3",
-    "@instructure/ui-testable": "10.6.1-snapshot-3",
-    "@instructure/ui-view": "10.6.1-snapshot-3",
+    "@instructure/console": "10.6.1-snapshot-5",
+    "@instructure/emotion": "10.6.1-snapshot-5",
+    "@instructure/shared-types": "10.6.1-snapshot-5",
+    "@instructure/ui-color-utils": "10.6.1-snapshot-5",
+    "@instructure/ui-dom-utils": "10.6.1-snapshot-5",
+    "@instructure/ui-icons": "10.6.1-snapshot-5",
+    "@instructure/ui-react-utils": "10.6.1-snapshot-5",
+    "@instructure/ui-testable": "10.6.1-snapshot-5",
+    "@instructure/ui-view": "10.6.1-snapshot-5",
     "prop-types": "^15.8.1"
   },
   "devDependencies": {
-    "@instructure/ui-axe-check": "10.6.1-snapshot-3",
-    "@instructure/ui-babel-preset": "10.6.1-snapshot-3",
-    "@instructure/ui-test-utils": "10.6.1-snapshot-3",
-    "@instructure/ui-themes": "10.6.1-snapshot-3",
+    "@instructure/ui-axe-check": "10.6.1-snapshot-5",
+    "@instructure/ui-babel-preset": "10.6.1-snapshot-5",
+    "@instructure/ui-test-utils": "10.6.1-snapshot-5",
+    "@instructure/ui-themes": "10.6.1-snapshot-5",
     "@testing-library/jest-dom": "^6.4.5",
     "@testing-library/react": "^16.0.1",
     "@testing-library/user-event": "^14.5.2",

package/src/Tag/README.md

@@ -15,7 +15,7 @@ type: example
 
 When the `dismissible` prop is added to a clickable Tag, the button
 renders an X/close icon (the Tag should be dismissed via the `onClick`
-prop).
+prop). When implementing dismissable tags, be sure to add [AccessibleContent](#AccessibleContent) to clarify that the tag is dismissible to screen readers.
 
 ```js
 ---

package/src/Tag/index.tsx

@@ -122,7 +122,7 @@ class Tag extends Component<TagProps> {
         as={onClick ? 'button' : 'span'}
         margin={margin}
         type={onClick ? 'button' : undefined}
-        onClick={onClick ?? this.handleClick}
+        {...(onClick && { onClick: this.handleClick })}
         disabled={disabled || readOnly}
         display={undefined}
         title={title || (typeof text === 'string' ? text : undefined)}

package/src/Tag/props.ts

@@ -42,6 +42,10 @@ import type {
 type TagOwnProps = {
   className?: string
   text: string | React.ReactNode
+  /**
+   * @deprecated since version 10
+   * Use of the title attribute is highly problematic due to accessibility concerns
+   */
   title?: string
   /**
    * Whether or not to disable the tag