@instructure/ui-source-code-editor 10.14.1-snapshot-4 → 10.14.1-snapshot-7
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md
CHANGED
|
@@ -3,9 +3,12 @@
|
|
|
3
3
|
All notable changes to this project will be documented in this file.
|
|
4
4
|
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
|
|
5
5
|
|
|
6
|
-
## [10.14.1-snapshot-
|
|
6
|
+
## [10.14.1-snapshot-7](https://github.com/instructure/instructure-ui/compare/v10.14.0...v10.14.1-snapshot-7) (2025-03-28)
|
|
7
7
|
|
|
8
|
-
|
|
8
|
+
|
|
9
|
+
### Bug Fixes
|
|
10
|
+
|
|
11
|
+
* **ui-source-code-editor:** make scrollview in SourceCodeEditor keyboard accessible ([6b3701c](https://github.com/instructure/instructure-ui/commit/6b3701cf076431ec56e0e5cfc720bbdc2114d885))
|
|
9
12
|
|
|
10
13
|
|
|
11
14
|
|
|
@@ -221,6 +221,14 @@ let SourceCodeEditor = (_dec = withDeterministicId(), _dec2 = withStyle(generate
|
|
|
221
221
|
state,
|
|
222
222
|
parent: this._containerRef
|
|
223
223
|
});
|
|
224
|
+
|
|
225
|
+
// from the a11y team:
|
|
226
|
+
// axe devtools and other automated a11y tests both flagging this issue,
|
|
227
|
+
// which can be observed while navigating with keyboard:
|
|
228
|
+
// Ensure elements that have scrollable content are accessible by keyboard
|
|
229
|
+
// To solve this problem, you need to fix at least (1) of the following:
|
|
230
|
+
// Element should have focusable content, Element should be focusable
|
|
231
|
+
this._editorView.scrollDOM.tabIndex = 0;
|
|
224
232
|
if (autofocus) {
|
|
225
233
|
this.focus();
|
|
226
234
|
}
|
|
@@ -228,6 +228,14 @@ let SourceCodeEditor = exports.SourceCodeEditor = (_dec = (0, _withDeterministic
|
|
|
228
228
|
state,
|
|
229
229
|
parent: this._containerRef
|
|
230
230
|
});
|
|
231
|
+
|
|
232
|
+
// from the a11y team:
|
|
233
|
+
// axe devtools and other automated a11y tests both flagging this issue,
|
|
234
|
+
// which can be observed while navigating with keyboard:
|
|
235
|
+
// Ensure elements that have scrollable content are accessible by keyboard
|
|
236
|
+
// To solve this problem, you need to fix at least (1) of the following:
|
|
237
|
+
// Element should have focusable content, Element should be focusable
|
|
238
|
+
this._editorView.scrollDOM.tabIndex = 0;
|
|
231
239
|
if (autofocus) {
|
|
232
240
|
this.focus();
|
|
233
241
|
}
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@instructure/ui-source-code-editor",
|
|
3
|
-
"version": "10.14.1-snapshot-
|
|
3
|
+
"version": "10.14.1-snapshot-7",
|
|
4
4
|
"description": "A UI component library made by Instructure Inc.",
|
|
5
5
|
"author": "Instructure, Inc. Engineering and Product Design",
|
|
6
6
|
"module": "./es/index.js",
|
|
@@ -23,9 +23,9 @@
|
|
|
23
23
|
},
|
|
24
24
|
"license": "MIT",
|
|
25
25
|
"devDependencies": {
|
|
26
|
-
"@instructure/ui-babel-preset": "10.14.1-snapshot-
|
|
27
|
-
"@instructure/ui-test-queries": "10.14.1-snapshot-
|
|
28
|
-
"@instructure/ui-test-utils": "10.14.1-snapshot-
|
|
26
|
+
"@instructure/ui-babel-preset": "10.14.1-snapshot-7",
|
|
27
|
+
"@instructure/ui-test-queries": "10.14.1-snapshot-7",
|
|
28
|
+
"@instructure/ui-test-utils": "10.14.1-snapshot-7",
|
|
29
29
|
"@testing-library/jest-dom": "^6.6.3",
|
|
30
30
|
"@testing-library/react": "^16.0.1",
|
|
31
31
|
"vitest": "^2.1.8"
|
|
@@ -45,20 +45,20 @@
|
|
|
45
45
|
"@codemirror/search": "^6.5.6",
|
|
46
46
|
"@codemirror/state": "^6.4.1",
|
|
47
47
|
"@codemirror/view": "^6.34.1",
|
|
48
|
-
"@instructure/emotion": "10.14.1-snapshot-
|
|
49
|
-
"@instructure/shared-types": "10.14.1-snapshot-
|
|
50
|
-
"@instructure/ui-a11y-content": "10.14.1-snapshot-
|
|
51
|
-
"@instructure/ui-buttons": "10.14.1-snapshot-
|
|
52
|
-
"@instructure/ui-dom-utils": "10.14.1-snapshot-
|
|
53
|
-
"@instructure/ui-i18n": "10.14.1-snapshot-
|
|
54
|
-
"@instructure/ui-icons": "10.14.1-snapshot-
|
|
55
|
-
"@instructure/ui-prop-types": "10.14.1-snapshot-
|
|
56
|
-
"@instructure/ui-react-utils": "10.14.1-snapshot-
|
|
57
|
-
"@instructure/ui-test-locator": "10.14.1-snapshot-
|
|
58
|
-
"@instructure/ui-testable": "10.14.1-snapshot-
|
|
59
|
-
"@instructure/ui-text-input": "10.14.1-snapshot-
|
|
60
|
-
"@instructure/ui-themes": "10.14.1-snapshot-
|
|
61
|
-
"@instructure/ui-utils": "10.14.1-snapshot-
|
|
48
|
+
"@instructure/emotion": "10.14.1-snapshot-7",
|
|
49
|
+
"@instructure/shared-types": "10.14.1-snapshot-7",
|
|
50
|
+
"@instructure/ui-a11y-content": "10.14.1-snapshot-7",
|
|
51
|
+
"@instructure/ui-buttons": "10.14.1-snapshot-7",
|
|
52
|
+
"@instructure/ui-dom-utils": "10.14.1-snapshot-7",
|
|
53
|
+
"@instructure/ui-i18n": "10.14.1-snapshot-7",
|
|
54
|
+
"@instructure/ui-icons": "10.14.1-snapshot-7",
|
|
55
|
+
"@instructure/ui-prop-types": "10.14.1-snapshot-7",
|
|
56
|
+
"@instructure/ui-react-utils": "10.14.1-snapshot-7",
|
|
57
|
+
"@instructure/ui-test-locator": "10.14.1-snapshot-7",
|
|
58
|
+
"@instructure/ui-testable": "10.14.1-snapshot-7",
|
|
59
|
+
"@instructure/ui-text-input": "10.14.1-snapshot-7",
|
|
60
|
+
"@instructure/ui-themes": "10.14.1-snapshot-7",
|
|
61
|
+
"@instructure/ui-utils": "10.14.1-snapshot-7",
|
|
62
62
|
"@lezer/highlight": "1.2.1",
|
|
63
63
|
"prop-types": "^15.8.1"
|
|
64
64
|
},
|
|
@@ -295,6 +295,14 @@ class SourceCodeEditor extends Component<SourceCodeEditorProps> {
|
|
|
295
295
|
parent: this._containerRef
|
|
296
296
|
})
|
|
297
297
|
|
|
298
|
+
// from the a11y team:
|
|
299
|
+
// axe devtools and other automated a11y tests both flagging this issue,
|
|
300
|
+
// which can be observed while navigating with keyboard:
|
|
301
|
+
// Ensure elements that have scrollable content are accessible by keyboard
|
|
302
|
+
// To solve this problem, you need to fix at least (1) of the following:
|
|
303
|
+
// Element should have focusable content, Element should be focusable
|
|
304
|
+
this._editorView.scrollDOM.tabIndex = 0
|
|
305
|
+
|
|
298
306
|
if (autofocus) {
|
|
299
307
|
this.focus()
|
|
300
308
|
}
|