@instructure/ui-simple-select 8.43.2-snapshot-13 → 8.44.0

package/CHANGELOG.md

@@ -3,9 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [8.43.2-snapshot-13](https://github.com/instructure/instructure-ui/compare/v8.43.1...v8.43.2-snapshot-13) (2023-09-21)
+# [8.44.0](https://github.com/instructure/instructure-ui/compare/v8.43.1...v8.44.0) (2023-09-21)
 
-**Note:** Version bump only for package @instructure/ui-simple-select
+
+### Bug Fixes
+
+* **ui-select,ui-simple-select:** add new tests ([e156baa](https://github.com/instructure/instructure-ui/commit/e156baa29c0d8fe70037057a500f1217bc2d51e5))
 
 
 

package/es/SimpleSelect/__new-tests__/SimpleSelect.test.js

@@ -0,0 +1,63 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2015 - present Instructure, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+import React from 'react';
+import { render } from '@testing-library/react';
+import '@testing-library/jest-dom/extend-expect';
+import SimpleSelect from '../index';
+import * as utils from '@instructure/ui-utils';
+jest.mock('@instructure/ui-utils', () => {
+  const originalModule = jest.requireActual('@instructure/ui-utils');
+  return {
+    __esModule: true,
+    ...originalModule,
+    isSafari: jest.fn(() => true)
+  };
+});
+const mockUtils = utils;
+describe('<SimpleSelect />', () => {
+  const defaultOptions = ['foo', 'bar', 'baz'];
+  const getOptions = disabled => defaultOptions.map(opt => /*#__PURE__*/React.createElement(SimpleSelect.Option, {
+    id: opt,
+    key: opt,
+    value: opt,
+    isDisabled: opt === disabled
+  }, opt));
+  it('should have role button in Safari', async () => {
+    const _render = render( /*#__PURE__*/React.createElement(SimpleSelect, {
+        renderLabel: "Choose an option"
+      }, getOptions())),
+      container = _render.container;
+    const input = container.querySelector('input');
+    expect(input).toHaveAttribute('role', 'button');
+  });
+  it('should have role combobox in different browsers than Safari', async () => {
+    mockUtils.isSafari = jest.fn(() => false);
+    const _render2 = render( /*#__PURE__*/React.createElement(SimpleSelect, {
+        renderLabel: "Choose an option"
+      }, getOptions())),
+      container = _render2.container;
+    const input = container.querySelector('input');
+    expect(input).toHaveAttribute('role', 'combobox');
+  });
+});

package/lib/SimpleSelect/__new-tests__/SimpleSelect.test.js

@@ -0,0 +1,68 @@
+"use strict";
+
+var _interopRequireWildcard = require("@babel/runtime/helpers/interopRequireWildcard").default;
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault").default;
+var _react = _interopRequireDefault(require("react"));
+var _react2 = require("@testing-library/react");
+require("@testing-library/jest-dom/extend-expect");
+var _index = _interopRequireDefault(require("../index"));
+var utils = _interopRequireWildcard(require("@instructure/ui-utils"));
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2015 - present Instructure, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+jest.mock('@instructure/ui-utils', () => {
+  const originalModule = jest.requireActual('@instructure/ui-utils');
+  return {
+    __esModule: true,
+    ...originalModule,
+    isSafari: jest.fn(() => true)
+  };
+});
+const mockUtils = utils;
+describe('<SimpleSelect />', () => {
+  const defaultOptions = ['foo', 'bar', 'baz'];
+  const getOptions = disabled => defaultOptions.map(opt => /*#__PURE__*/_react.default.createElement(_index.default.Option, {
+    id: opt,
+    key: opt,
+    value: opt,
+    isDisabled: opt === disabled
+  }, opt));
+  it('should have role button in Safari', async () => {
+    const _render = (0, _react2.render)( /*#__PURE__*/_react.default.createElement(_index.default, {
+        renderLabel: "Choose an option"
+      }, getOptions())),
+      container = _render.container;
+    const input = container.querySelector('input');
+    expect(input).toHaveAttribute('role', 'button');
+  });
+  it('should have role combobox in different browsers than Safari', async () => {
+    mockUtils.isSafari = jest.fn(() => false);
+    const _render2 = (0, _react2.render)( /*#__PURE__*/_react.default.createElement(_index.default, {
+        renderLabel: "Choose an option"
+      }, getOptions())),
+      container = _render2.container;
+    const input = container.querySelector('input');
+    expect(input).toHaveAttribute('role', 'combobox');
+  });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instructure/ui-simple-select",
-  "version": "8.43.2-snapshot-13",
+  "version": "8.44.0",
   "description": "A component for standard select element behavior.",
   "author": "Instructure, Inc. Engineering and Product Design",
   "module": "./es/index.js",
@@ -24,22 +24,25 @@
   "license": "MIT",
   "dependencies": {
     "@babel/runtime": "^7.22.15",
-    "@instructure/console": "8.43.2-snapshot-13",
-    "@instructure/shared-types": "8.43.2-snapshot-13",
-    "@instructure/ui-form-field": "8.43.2-snapshot-13",
-    "@instructure/ui-position": "8.43.2-snapshot-13",
-    "@instructure/ui-prop-types": "8.43.2-snapshot-13",
-    "@instructure/ui-react-utils": "8.43.2-snapshot-13",
-    "@instructure/ui-select": "8.43.2-snapshot-13",
-    "@instructure/ui-testable": "8.43.2-snapshot-13",
+    "@instructure/console": "8.44.0",
+    "@instructure/shared-types": "8.44.0",
+    "@instructure/ui-form-field": "8.44.0",
+    "@instructure/ui-position": "8.44.0",
+    "@instructure/ui-prop-types": "8.44.0",
+    "@instructure/ui-react-utils": "8.44.0",
+    "@instructure/ui-select": "8.44.0",
+    "@instructure/ui-testable": "8.44.0",
     "prop-types": "^15.8.1"
   },
   "devDependencies": {
-    "@instructure/ui-babel-preset": "8.43.2-snapshot-13",
-    "@instructure/ui-color-utils": "8.43.2-snapshot-13",
-    "@instructure/ui-icons": "8.43.2-snapshot-13",
-    "@instructure/ui-test-locator": "8.43.2-snapshot-13",
-    "@instructure/ui-test-utils": "8.43.2-snapshot-13"
+    "@instructure/ui-babel-preset": "8.44.0",
+    "@instructure/ui-color-utils": "8.44.0",
+    "@instructure/ui-icons": "8.44.0",
+    "@instructure/ui-test-locator": "8.44.0",
+    "@instructure/ui-test-utils": "8.44.0",
+    "@instructure/ui-utils": "8.44.0",
+    "@testing-library/jest-dom": "^5.17.0",
+    "@testing-library/react": "^14.0.0"
   },
   "peerDependencies": {
     "react": ">=16.8 <=18"

package/src/SimpleSelect/__new-tests__/SimpleSelect.test.tsx

@@ -0,0 +1,75 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2015 - present Instructure, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+import React from 'react'
+import { render } from '@testing-library/react'
+import '@testing-library/jest-dom/extend-expect'
+import SimpleSelect from '../index'
+import * as utils from '@instructure/ui-utils'
+
+type ExampleOption = 'foo' | 'bar' | 'baz'
+jest.mock('@instructure/ui-utils', () => {
+  const originalModule = jest.requireActual('@instructure/ui-utils')
+
+  return {
+    __esModule: true,
+    ...originalModule,
+    isSafari: jest.fn(() => true)
+  }
+})
+
+const mockUtils = utils as jest.Mocked<typeof utils>
+
+describe('<SimpleSelect />', () => {
+  const defaultOptions: ExampleOption[] = ['foo', 'bar', 'baz']
+
+  const getOptions = (disabled?: ExampleOption) =>
+    defaultOptions.map((opt) => (
+      <SimpleSelect.Option
+        id={opt}
+        key={opt}
+        value={opt}
+        isDisabled={opt === disabled}
+      >
+        {opt}
+      </SimpleSelect.Option>
+    ))
+
+  it('should have role button in Safari', async () => {
+    const { container } = render(
+      <SimpleSelect renderLabel="Choose an option">{getOptions()}</SimpleSelect>
+    )
+    const input = container.querySelector('input')
+    expect(input).toHaveAttribute('role', 'button')
+  })
+
+  it('should have role combobox in different browsers than Safari', async () => {
+    mockUtils.isSafari = jest.fn(() => false)
+
+    const { container } = render(
+      <SimpleSelect renderLabel="Choose an option">{getOptions()}</SimpleSelect>
+    )
+    const input = container.querySelector('input')
+    expect(input).toHaveAttribute('role', 'combobox')
+  })
+})

package/tsconfig.build.json

@@ -19,6 +19,7 @@
     { "path": "../ui-icons/tsconfig.build.json" },
     { "path": "../ui-test-locator/tsconfig.build.json" },
     { "path": "../ui-test-utils/tsconfig.build.json" },
-    { "path": "../shared-types/tsconfig.build.json" }
+    { "path": "../shared-types/tsconfig.build.json" },
+    { "path": "../ui-utils/tsconfig.build.json" }
   ]
 }