@instructure/ui-pagination 10.6.1-snapshot-9 → 10.6.1-snapshot-13

package/CHANGELOG.md

@@ -3,9 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [10.6.1-snapshot-9](https://github.com/instructure/instructure-ui/compare/v10.6.0...v10.6.1-snapshot-9) (2024-11-22)
+## [10.6.1-snapshot-13](https://github.com/instructure/instructure-ui/compare/v10.6.0...v10.6.1-snapshot-13) (2024-11-26)
 
-**Note:** Version bump only for package @instructure/ui-pagination
+
+### Bug Fixes
+
+* **shared-types,ui-pagination:** pagination indicators have spacing and coded as a list for a11y ([e6e5a7b](https://github.com/instructure/instructure-ui/commit/e6e5a7b6cda158f16cf0d86787130877b9c22a75))
 
 
 

package/es/Pagination/PaginationButton/index.js

@@ -45,14 +45,20 @@ let PaginationButton = (_dec = testable(), _dec(_class = (_PaginationButton = cl
   render() {
     const exclude = this.props.current ? ['onClick', 'href'] : [];
     const props = omitProps(this.props, PaginationButton.allowedProps, exclude);
-    return /*#__PURE__*/React.createElement(BaseButton, Object.assign({
+
+    // wrapped in an unstyled <li> for better a11y
+    return /*#__PURE__*/React.createElement("li", {
+      style: {
+        all: 'unset'
+      }
+    }, /*#__PURE__*/React.createElement(BaseButton, Object.assign({
       color: "primary",
       withBackground: this.props.current,
       withBorder: this.props.current
     }, props, {
       "aria-current": this.props.current ? 'page' : void 0,
       elementRef: this.handleRef
-    }), this.props.children);
+    }), this.props.children));
   }
 }, _PaginationButton.displayName = "PaginationButton", _PaginationButton.componentId = 'Pagination.Page', _PaginationButton.propTypes = propTypes, _PaginationButton.allowedProps = allowedProps, _PaginationButton.defaultProps = {
   current: false

package/es/Pagination/__new-tests__/Pagination.test.js

@@ -99,7 +99,7 @@ describe('<Pagination />', () => {
           variant: "compact",
           labelNext: "Next",
           labelPrev: "Prev"
-        }, buildPages(5))),
+        }, /*#__PURE__*/React.createElement("ul", null, buildPages(5)))),
         container = _render.container;
       const axeCheck = await runAxeCheck(container);
       expect(axeCheck).toBe(true);
@@ -109,7 +109,7 @@ describe('<Pagination />', () => {
           variant: "compact",
           labelNext: "Next",
           labelPrev: "Prev"
-        }, buildPages(8))),
+        }, /*#__PURE__*/React.createElement("ul", null, buildPages(8)))),
         container = _render2.container;
       const axeCheck = await runAxeCheck(container);
       expect(axeCheck).toBe(true);
@@ -122,7 +122,7 @@ describe('<Pagination />', () => {
           labelFirst: "First",
           labelLast: "Last",
           withFirstAndLastButton: true
-        }, buildPages(8))),
+        }, /*#__PURE__*/React.createElement("ul", null, buildPages(8)))),
         container = _render3.container;
       const axeCheck = await runAxeCheck(container);
       expect(axeCheck).toBe(true);
@@ -136,7 +136,7 @@ describe('<Pagination />', () => {
           labelLast: "Last",
           withFirstAndLastButton: true,
           showDisabledButtons: true
-        }, buildPages(8))),
+        }, /*#__PURE__*/React.createElement("ul", null, buildPages(8)))),
         container = _render4.container;
       const axeCheck = await runAxeCheck(container);
       expect(axeCheck).toBe(true);

package/es/Pagination/index.js

@@ -34,6 +34,7 @@ import { PaginationButton } from './PaginationButton';
 import { PaginationArrowButton } from './PaginationArrowButton';
 import { PaginationPageInput } from './PaginationPageInput';
 import generateStyle from './styles';
+import generateComponentTheme from './theme';
 import { propTypes, allowedProps } from './props';
 /** This is an [].findIndex optimized to work on really big, but sparse, arrays */
 const fastFindIndex = (arr, fn) => Number(Object.keys(arr).find(k => fn(arr[Number(k)])));
@@ -53,7 +54,7 @@ function propsHaveCompactView(props) {
 category: components
 ---
 **/
-let Pagination = (_dec = withDeterministicId(), _dec2 = withStyle(generateStyle, null), _dec3 = testable(), _dec(_class = _dec2(_class = _dec3(_class = (_Pagination = class Pagination extends Component {
+let Pagination = (_dec = withDeterministicId(), _dec2 = withStyle(generateStyle, generateComponentTheme), _dec3 = testable(), _dec(_class = _dec2(_class = _dec3(_class = (_Pagination = class Pagination extends Component {
   constructor(props) {
     super(props);
     this._labelId = void 0;
@@ -112,6 +113,7 @@ let Pagination = (_dec = withDeterministicId(), _dec2 = withStyle(generateStyle,
       return pages;
     };
     this.renderDefaultPages = () => {
+      var _this$props$styles;
       const _this$props4 = this.props,
         ellipsis = _this$props4.ellipsis,
         currentPage = _this$props4.currentPage,
@@ -141,7 +143,9 @@ let Pagination = (_dec = withDeterministicId(), _dec2 = withStyle(generateStyle,
       } else {
         pages.push(this.renderPagesInInterval(currentPage + 1, totalPageNumber, currentPage));
       }
-      return pages;
+      return jsx("ul", {
+        css: (_this$props$styles = this.props.styles) === null || _this$props$styles === void 0 ? void 0 : _this$props$styles.pageIndicatorList
+      }, pages);
     };
     this.renderDefaultArrowButton = direction => {
       if (!this.withFirstAndLastButton && (direction === 'first' || direction === 'last')) {
@@ -385,7 +389,7 @@ let Pagination = (_dec = withDeterministicId(), _dec2 = withStyle(generateStyle,
     }) : null;
   }
   render() {
-    var _this$props$styles, _this$props$styles2;
+    var _this$props$styles2, _this$props$styles3;
     const currentPageIndex = fastFindIndex(this.childPages, p => p && p.props && p.props.current);
     const passthroughProps = View.omitViewProps(omitProps(this.props, Pagination.allowedProps), Pagination);
     return jsx(View, Object.assign({}, passthroughProps, {
@@ -393,11 +397,11 @@ let Pagination = (_dec = withDeterministicId(), _dec2 = withStyle(generateStyle,
       as: this.props.as,
       elementRef: this.handleElementRef,
       margin: this.props.margin,
-      css: (_this$props$styles = this.props.styles) === null || _this$props$styles === void 0 ? void 0 : _this$props$styles.pagination,
+      css: (_this$props$styles2 = this.props.styles) === null || _this$props$styles2 === void 0 ? void 0 : _this$props$styles2.pagination,
       "aria-labelledby": this.props.label ? this._labelId : void 0
     }), this.props.label && this.renderLabel(), jsx(View, {
       display: "inline-block",
-      css: (_this$props$styles2 = this.props.styles) === null || _this$props$styles2 === void 0 ? void 0 : _this$props$styles2.pages
+      css: (_this$props$styles3 = this.props.styles) === null || _this$props$styles3 === void 0 ? void 0 : _this$props$styles3.pages
     }, this.renderArrowButton('first', currentPageIndex), this.renderArrowButton('prev', currentPageIndex), this.inputMode ? this.renderPageInput(currentPageIndex) : this.renderPages(currentPageIndex), this.renderArrowButton('next', currentPageIndex), this.renderArrowButton('last', currentPageIndex)));
   }
 }, _Pagination.displayName = "Pagination", _Pagination.componentId = 'Pagination', _Pagination.propTypes = propTypes, _Pagination.allowedProps = allowedProps, _Pagination.defaultProps = {
@@ -413,7 +417,11 @@ let Pagination = (_dec = withDeterministicId(), _dec2 = withStyle(generateStyle,
   currentPage: 1,
   siblingCount: 1,
   boundaryCount: 1,
-  ellipsis: '...',
+  ellipsis: jsx("li", {
+    style: {
+      all: 'unset'
+    }
+  }, "..."),
   renderPageIndicator: page => page
 }, _Pagination.Page = PaginationButton, _Pagination.Navigation = PaginationArrowButton, _Pagination)) || _class) || _class) || _class);
 export default Pagination;

package/es/Pagination/styles.js

@@ -32,8 +32,14 @@
  * @param  {Object} state the state of the component, the style is applied to
  * @return {Object} The final style object, which will be used in the component
  */
-const generateStyle = () => {
+const generateStyle = componentTheme => {
   return {
+    pageIndicatorList: {
+      all: 'unset',
+      display: 'flex',
+      alignItems: 'center',
+      gap: componentTheme.pageIndicatorGap
+    },
     pagination: {
       label: 'pagination',
       textAlign: 'center'

package/es/Pagination/theme.js

@@ -0,0 +1,39 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2015 - present Instructure, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+/**
+ * Generates the theme object for the component from the theme and provided additional information
+ * @param  {Object} theme The actual theme object.
+ * @return {Object} The final theme object with the overrides and component variables
+ */
+const generateComponentTheme = theme => {
+  const spacing = theme.spacing;
+  const componentVariables = {
+    pageIndicatorGap: spacing.xSmall
+  };
+  return {
+    ...componentVariables
+  };
+};
+export default generateComponentTheme;

package/lib/Pagination/PaginationButton/index.js

@@ -51,14 +51,20 @@ let PaginationButton = exports.PaginationButton = (_dec = (0, _testable.testable
   render() {
     const exclude = this.props.current ? ['onClick', 'href'] : [];
     const props = (0, _omitProps.omitProps)(this.props, PaginationButton.allowedProps, exclude);
-    return /*#__PURE__*/_react.default.createElement(_BaseButton.BaseButton, Object.assign({
+
+    // wrapped in an unstyled <li> for better a11y
+    return /*#__PURE__*/_react.default.createElement("li", {
+      style: {
+        all: 'unset'
+      }
+    }, /*#__PURE__*/_react.default.createElement(_BaseButton.BaseButton, Object.assign({
       color: "primary",
       withBackground: this.props.current,
       withBorder: this.props.current
     }, props, {
       "aria-current": this.props.current ? 'page' : void 0,
       elementRef: this.handleRef
-    }), this.props.children);
+    }), this.props.children));
   }
 }, _PaginationButton.displayName = "PaginationButton", _PaginationButton.componentId = 'Pagination.Page', _PaginationButton.propTypes = _props.propTypes, _PaginationButton.allowedProps = _props.allowedProps, _PaginationButton.defaultProps = {
   current: false

package/lib/Pagination/__new-tests__/Pagination.test.js

@@ -101,7 +101,7 @@ describe('<Pagination />', () => {
           variant: "compact",
           labelNext: "Next",
           labelPrev: "Prev"
-        }, buildPages(5))),
+        }, /*#__PURE__*/_react.default.createElement("ul", null, buildPages(5)))),
         container = _render.container;
       const axeCheck = await (0, _runAxeCheck.runAxeCheck)(container);
       expect(axeCheck).toBe(true);
@@ -111,7 +111,7 @@ describe('<Pagination />', () => {
           variant: "compact",
           labelNext: "Next",
           labelPrev: "Prev"
-        }, buildPages(8))),
+        }, /*#__PURE__*/_react.default.createElement("ul", null, buildPages(8)))),
         container = _render2.container;
       const axeCheck = await (0, _runAxeCheck.runAxeCheck)(container);
       expect(axeCheck).toBe(true);
@@ -124,7 +124,7 @@ describe('<Pagination />', () => {
           labelFirst: "First",
           labelLast: "Last",
           withFirstAndLastButton: true
-        }, buildPages(8))),
+        }, /*#__PURE__*/_react.default.createElement("ul", null, buildPages(8)))),
         container = _render3.container;
       const axeCheck = await (0, _runAxeCheck.runAxeCheck)(container);
       expect(axeCheck).toBe(true);
@@ -138,7 +138,7 @@ describe('<Pagination />', () => {
           labelLast: "Last",
           withFirstAndLastButton: true,
           showDisabledButtons: true
-        }, buildPages(8))),
+        }, /*#__PURE__*/_react.default.createElement("ul", null, buildPages(8)))),
         container = _render4.container;
       const axeCheck = await (0, _runAxeCheck.runAxeCheck)(container);
       expect(axeCheck).toBe(true);

package/lib/Pagination/index.js

@@ -26,6 +26,7 @@ var _PaginationButton = require("./PaginationButton");
 var _PaginationArrowButton = require("./PaginationArrowButton");
 var _PaginationPageInput = require("./PaginationPageInput");
 var _styles = _interopRequireDefault(require("./styles"));
+var _theme = _interopRequireDefault(require("./theme"));
 var _props = require("./props");
 var _dec, _dec2, _dec3, _class, _Pagination, _span, _span2;
 /*
@@ -70,7 +71,7 @@ function propsHaveCompactView(props) {
 category: components
 ---
 **/
-let Pagination = exports.Pagination = (_dec = (0, _withDeterministicId.withDeterministicId)(), _dec2 = (0, _emotion.withStyle)(_styles.default, null), _dec3 = (0, _testable.testable)(), _dec(_class = _dec2(_class = _dec3(_class = (_Pagination = class Pagination extends _react.Component {
+let Pagination = exports.Pagination = (_dec = (0, _withDeterministicId.withDeterministicId)(), _dec2 = (0, _emotion.withStyle)(_styles.default, _theme.default), _dec3 = (0, _testable.testable)(), _dec(_class = _dec2(_class = _dec3(_class = (_Pagination = class Pagination extends _react.Component {
   constructor(props) {
     super(props);
     this._labelId = void 0;
@@ -129,6 +130,7 @@ let Pagination = exports.Pagination = (_dec = (0, _withDeterministicId.withDeter
       return pages;
     };
     this.renderDefaultPages = () => {
+      var _this$props$styles;
       const _this$props4 = this.props,
         ellipsis = _this$props4.ellipsis,
         currentPage = _this$props4.currentPage,
@@ -158,7 +160,9 @@ let Pagination = exports.Pagination = (_dec = (0, _withDeterministicId.withDeter
       } else {
         pages.push(this.renderPagesInInterval(currentPage + 1, totalPageNumber, currentPage));
       }
-      return pages;
+      return (0, _emotion.jsx)("ul", {
+        css: (_this$props$styles = this.props.styles) === null || _this$props$styles === void 0 ? void 0 : _this$props$styles.pageIndicatorList
+      }, pages);
     };
     this.renderDefaultArrowButton = direction => {
       if (!this.withFirstAndLastButton && (direction === 'first' || direction === 'last')) {
@@ -402,7 +406,7 @@ let Pagination = exports.Pagination = (_dec = (0, _withDeterministicId.withDeter
     }) : null;
   }
   render() {
-    var _this$props$styles, _this$props$styles2;
+    var _this$props$styles2, _this$props$styles3;
     const currentPageIndex = fastFindIndex(this.childPages, p => p && p.props && p.props.current);
     const passthroughProps = _View.View.omitViewProps((0, _omitProps.omitProps)(this.props, Pagination.allowedProps), Pagination);
     return (0, _emotion.jsx)(_View.View, Object.assign({}, passthroughProps, {
@@ -410,11 +414,11 @@ let Pagination = exports.Pagination = (_dec = (0, _withDeterministicId.withDeter
       as: this.props.as,
       elementRef: this.handleElementRef,
       margin: this.props.margin,
-      css: (_this$props$styles = this.props.styles) === null || _this$props$styles === void 0 ? void 0 : _this$props$styles.pagination,
+      css: (_this$props$styles2 = this.props.styles) === null || _this$props$styles2 === void 0 ? void 0 : _this$props$styles2.pagination,
       "aria-labelledby": this.props.label ? this._labelId : void 0
     }), this.props.label && this.renderLabel(), (0, _emotion.jsx)(_View.View, {
       display: "inline-block",
-      css: (_this$props$styles2 = this.props.styles) === null || _this$props$styles2 === void 0 ? void 0 : _this$props$styles2.pages
+      css: (_this$props$styles3 = this.props.styles) === null || _this$props$styles3 === void 0 ? void 0 : _this$props$styles3.pages
     }, this.renderArrowButton('first', currentPageIndex), this.renderArrowButton('prev', currentPageIndex), this.inputMode ? this.renderPageInput(currentPageIndex) : this.renderPages(currentPageIndex), this.renderArrowButton('next', currentPageIndex), this.renderArrowButton('last', currentPageIndex)));
   }
 }, _Pagination.displayName = "Pagination", _Pagination.componentId = 'Pagination', _Pagination.propTypes = _props.propTypes, _Pagination.allowedProps = _props.allowedProps, _Pagination.defaultProps = {
@@ -430,7 +434,11 @@ let Pagination = exports.Pagination = (_dec = (0, _withDeterministicId.withDeter
   currentPage: 1,
   siblingCount: 1,
   boundaryCount: 1,
-  ellipsis: '...',
+  ellipsis: (0, _emotion.jsx)("li", {
+    style: {
+      all: 'unset'
+    }
+  }, "..."),
   renderPageIndicator: page => page
 }, _Pagination.Page = _PaginationButton.PaginationButton, _Pagination.Navigation = _PaginationArrowButton.PaginationArrowButton, _Pagination)) || _class) || _class) || _class);
 var _default = exports.default = Pagination;

package/lib/Pagination/styles.js

@@ -38,8 +38,14 @@ exports.default = void 0;
  * @param  {Object} state the state of the component, the style is applied to
  * @return {Object} The final style object, which will be used in the component
  */
-const generateStyle = () => {
+const generateStyle = componentTheme => {
   return {
+    pageIndicatorList: {
+      all: 'unset',
+      display: 'flex',
+      alignItems: 'center',
+      gap: componentTheme.pageIndicatorGap
+    },
     pagination: {
       label: 'pagination',
       textAlign: 'center'

package/lib/Pagination/theme.js

@@ -0,0 +1,45 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2015 - present Instructure, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+/**
+ * Generates the theme object for the component from the theme and provided additional information
+ * @param  {Object} theme The actual theme object.
+ * @return {Object} The final theme object with the overrides and component variables
+ */
+const generateComponentTheme = theme => {
+  const spacing = theme.spacing;
+  const componentVariables = {
+    pageIndicatorGap: spacing.xSmall
+  };
+  return {
+    ...componentVariables
+  };
+};
+var _default = exports.default = generateComponentTheme;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instructure/ui-pagination",
-  "version": "10.6.1-snapshot-9",
+  "version": "10.6.1-snapshot-13",
   "description": "A UI component library made by Instructure Inc.",
   "author": "Instructure, Inc. Engineering and Product Design",
   "module": "./es/index.js",
@@ -23,9 +23,9 @@
   },
   "license": "MIT",
   "devDependencies": {
-    "@instructure/ui-axe-check": "10.6.1-snapshot-9",
-    "@instructure/ui-babel-preset": "10.6.1-snapshot-9",
-    "@instructure/ui-test-utils": "10.6.1-snapshot-9",
+    "@instructure/ui-axe-check": "10.6.1-snapshot-13",
+    "@instructure/ui-babel-preset": "10.6.1-snapshot-13",
+    "@instructure/ui-test-utils": "10.6.1-snapshot-13",
     "@testing-library/jest-dom": "^6.4.6",
     "@testing-library/react": "^16.0.1",
     "@testing-library/user-event": "^14.5.2",
@@ -33,23 +33,23 @@
   },
   "dependencies": {
     "@babel/runtime": "^7.25.6",
-    "@instructure/emotion": "10.6.1-snapshot-9",
-    "@instructure/shared-types": "10.6.1-snapshot-9",
-    "@instructure/ui-a11y-content": "10.6.1-snapshot-9",
-    "@instructure/ui-a11y-utils": "10.6.1-snapshot-9",
-    "@instructure/ui-buttons": "10.6.1-snapshot-9",
-    "@instructure/ui-dom-utils": "10.6.1-snapshot-9",
-    "@instructure/ui-icons": "10.6.1-snapshot-9",
-    "@instructure/ui-number-input": "10.6.1-snapshot-9",
-    "@instructure/ui-portal": "10.6.1-snapshot-9",
-    "@instructure/ui-prop-types": "10.6.1-snapshot-9",
-    "@instructure/ui-react-utils": "10.6.1-snapshot-9",
-    "@instructure/ui-testable": "10.6.1-snapshot-9",
-    "@instructure/ui-themes": "10.6.1-snapshot-9",
-    "@instructure/ui-tooltip": "10.6.1-snapshot-9",
-    "@instructure/ui-utils": "10.6.1-snapshot-9",
-    "@instructure/ui-view": "10.6.1-snapshot-9",
-    "@instructure/uid": "10.6.1-snapshot-9",
+    "@instructure/emotion": "10.6.1-snapshot-13",
+    "@instructure/shared-types": "10.6.1-snapshot-13",
+    "@instructure/ui-a11y-content": "10.6.1-snapshot-13",
+    "@instructure/ui-a11y-utils": "10.6.1-snapshot-13",
+    "@instructure/ui-buttons": "10.6.1-snapshot-13",
+    "@instructure/ui-dom-utils": "10.6.1-snapshot-13",
+    "@instructure/ui-icons": "10.6.1-snapshot-13",
+    "@instructure/ui-number-input": "10.6.1-snapshot-13",
+    "@instructure/ui-portal": "10.6.1-snapshot-13",
+    "@instructure/ui-prop-types": "10.6.1-snapshot-13",
+    "@instructure/ui-react-utils": "10.6.1-snapshot-13",
+    "@instructure/ui-testable": "10.6.1-snapshot-13",
+    "@instructure/ui-themes": "10.6.1-snapshot-13",
+    "@instructure/ui-tooltip": "10.6.1-snapshot-13",
+    "@instructure/ui-utils": "10.6.1-snapshot-13",
+    "@instructure/ui-view": "10.6.1-snapshot-13",
+    "@instructure/uid": "10.6.1-snapshot-13",
     "prop-types": "^15.8.1"
   },
   "peerDependencies": {

package/src/Pagination/PaginationButton/index.tsx

@@ -59,17 +59,20 @@ class PaginationButton extends Component<PaginationPageProps> {
 
     const props = omitProps(this.props, PaginationButton.allowedProps, exclude)
 
+    // wrapped in an unstyled <li> for better a11y
     return (
-      <BaseButton
-        color="primary"
-        withBackground={this.props.current}
-        withBorder={this.props.current}
-        {...props}
-        aria-current={this.props.current ? 'page' : undefined}
-        elementRef={this.handleRef}
-      >
-        {this.props.children}
-      </BaseButton>
+      <li style={{ all: 'unset' }}>
+        <BaseButton
+          color="primary"
+          withBackground={this.props.current}
+          withBorder={this.props.current}
+          {...props}
+          aria-current={this.props.current ? 'page' : undefined}
+          elementRef={this.handleRef}
+        >
+          {this.props.children}
+        </BaseButton>
+      </li>
     )
   }
 }

package/src/Pagination/__new-tests__/Pagination.test.tsx

@@ -123,7 +123,9 @@ describe('<Pagination />', () => {
     it('by default', async () => {
       const { container } = render(
         <Pagination variant="compact" labelNext="Next" labelPrev="Prev">
-          {buildPages(5)}
+          <ul>
+            {buildPages(5)}
+          </ul>
         </Pagination>
       )
 
@@ -134,7 +136,7 @@ describe('<Pagination />', () => {
     it('by default with more pages', async () => {
       const { container } = render(
         <Pagination variant="compact" labelNext="Next" labelPrev="Prev">
-          {buildPages(8)}
+          <ul>{buildPages(8)}</ul>
         </Pagination>
       )
       const axeCheck = await runAxeCheck(container)
@@ -151,7 +153,7 @@ describe('<Pagination />', () => {
           labelLast="Last"
           withFirstAndLastButton
         >
-          {buildPages(8)}
+          <ul>{buildPages(8)}</ul>
         </Pagination>
       )
       const axeCheck = await runAxeCheck(container)
@@ -169,7 +171,7 @@ describe('<Pagination />', () => {
           withFirstAndLastButton
           showDisabledButtons
         >
-          {buildPages(8)}
+          <ul>{buildPages(8)}</ul>
         </Pagination>
       )
       const axeCheck = await runAxeCheck(container)

package/src/Pagination/index.tsx

@@ -36,6 +36,7 @@ import { PaginationArrowButton } from './PaginationArrowButton'
 import { PaginationPageInput } from './PaginationPageInput'
 
 import generateStyle from './styles'
+import generateComponentTheme from './theme'
 
 import type { PaginationPageProps } from './PaginationButton/props'
 import type { PaginationArrowDirections } from './PaginationArrowButton/props'
@@ -80,7 +81,7 @@ category: components
 ---
 **/
 @withDeterministicId()
-@withStyle(generateStyle, null)
+@withStyle(generateStyle, generateComponentTheme)
 @testable()
 class Pagination extends Component<PaginationProps> {
   static readonly componentId = 'Pagination'
@@ -103,7 +104,7 @@ class Pagination extends Component<PaginationProps> {
     currentPage: 1,
     siblingCount: 1,
     boundaryCount: 1,
-    ellipsis: '...',
+    ellipsis: <li style={{all: 'unset'}}>...</li>,
     renderPageIndicator: (page: number) => page
   }
 
@@ -408,7 +409,7 @@ class Pagination extends Component<PaginationProps> {
         )
       )
     }
-    return pages
+    return (<ul css={this.props.styles?.pageIndicatorList}>{pages}</ul>)
   }
 
   renderPages(currentPageIndex: number) {

package/src/Pagination/props.ts

@@ -197,7 +197,9 @@ type PaginationProps = PaginationOwnProps &
   OtherHTMLAttributes<PaginationOwnProps> &
   WithDeterministicIdProps
 
-type PaginationStyle = ComponentStyle<'pagination' | 'pages'>
+type PaginationStyle = ComponentStyle<
+  'pagination' | 'pages' | 'pageIndicatorList'
+>
 
 const propTypes: PropValidators<PropKeys> = {
   children: Children.oneOf([PaginationButton]),

package/src/Pagination/styles.ts

@@ -22,6 +22,7 @@
  * SOFTWARE.
  */
 
+import type { PaginationTheme } from '@instructure/shared-types'
 import type { PaginationStyle } from './props'
 
 /**
@@ -34,8 +35,14 @@ import type { PaginationStyle } from './props'
  * @param  {Object} state the state of the component, the style is applied to
  * @return {Object} The final style object, which will be used in the component
  */
-const generateStyle = (): PaginationStyle => {
+const generateStyle = (componentTheme: PaginationTheme): PaginationStyle => {
   return {
+    pageIndicatorList: {
+      all: 'unset',
+      display: 'flex',
+      alignItems: 'center',
+      gap: componentTheme.pageIndicatorGap
+    },
     pagination: {
       label: 'pagination',
       textAlign: 'center'

package/src/Pagination/theme.ts

@@ -0,0 +1,45 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2015 - present Instructure, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+import type { Theme } from '@instructure/ui-themes'
+import { PaginationTheme } from '@instructure/shared-types'
+
+/**
+ * Generates the theme object for the component from the theme and provided additional information
+ * @param  {Object} theme The actual theme object.
+ * @return {Object} The final theme object with the overrides and component variables
+ */
+const generateComponentTheme = (theme: Theme): PaginationTheme => {
+  const { spacing } = theme
+
+  const componentVariables: PaginationTheme = {
+    pageIndicatorGap: spacing.xSmall
+  }
+
+  return {
+    ...componentVariables
+  }
+}
+
+export default generateComponentTheme