@instructure/ui-menu 10.10.1-snapshot-3 → 10.10.1-snapshot-5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md
CHANGED
|
@@ -3,9 +3,12 @@
|
|
|
3
3
|
All notable changes to this project will be documented in this file.
|
|
4
4
|
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
|
|
5
5
|
|
|
6
|
-
## [10.10.1-snapshot-
|
|
6
|
+
## [10.10.1-snapshot-5](https://github.com/instructure/instructure-ui/compare/v10.10.0...v10.10.1-snapshot-5) (2025-01-29)
|
|
7
7
|
|
|
8
|
-
|
|
8
|
+
|
|
9
|
+
### Bug Fixes
|
|
10
|
+
|
|
11
|
+
* **ui-menu:** make Menu.Item apply target prop ([6c85b31](https://github.com/instructure/instructure-ui/commit/6c85b312212edf9f08317d0d6aeb7c28fe1eb3b3))
|
|
9
12
|
|
|
10
13
|
|
|
11
14
|
|
|
@@ -182,13 +182,15 @@ let MenuItem = (_dec = withDeterministicId(), _dec2 = withStyle(generateStyle, g
|
|
|
182
182
|
onKeyDown = _this$props5.onKeyDown,
|
|
183
183
|
onKeyUp = _this$props5.onKeyUp,
|
|
184
184
|
type = _this$props5.type,
|
|
185
|
-
href = _this$props5.href
|
|
185
|
+
href = _this$props5.href,
|
|
186
|
+
target = _this$props5.target;
|
|
186
187
|
const props = omitProps(this.props, MenuItem.allowedProps);
|
|
187
188
|
const ElementType = this.elementType;
|
|
188
189
|
return jsx(ElementType, Object.assign({
|
|
189
190
|
tabIndex: -1 // note: tabIndex can be overridden by Menu or MenuItemGroup components
|
|
190
191
|
}, props, {
|
|
191
192
|
href: href,
|
|
193
|
+
target: target,
|
|
192
194
|
role: this.role,
|
|
193
195
|
"aria-labelledby": this.labelId,
|
|
194
196
|
"aria-disabled": disabled ? 'true' : void 0,
|
|
@@ -195,13 +195,15 @@ let MenuItem = exports.MenuItem = (_dec = (0, _withDeterministicId.withDetermini
|
|
|
195
195
|
onKeyDown = _this$props5.onKeyDown,
|
|
196
196
|
onKeyUp = _this$props5.onKeyUp,
|
|
197
197
|
type = _this$props5.type,
|
|
198
|
-
href = _this$props5.href
|
|
198
|
+
href = _this$props5.href,
|
|
199
|
+
target = _this$props5.target;
|
|
199
200
|
const props = (0, _omitProps.omitProps)(this.props, MenuItem.allowedProps);
|
|
200
201
|
const ElementType = this.elementType;
|
|
201
202
|
return (0, _emotion.jsx)(ElementType, Object.assign({
|
|
202
203
|
tabIndex: -1 // note: tabIndex can be overridden by Menu or MenuItemGroup components
|
|
203
204
|
}, props, {
|
|
204
205
|
href: href,
|
|
206
|
+
target: target,
|
|
205
207
|
role: this.role,
|
|
206
208
|
"aria-labelledby": this.labelId,
|
|
207
209
|
"aria-disabled": disabled ? 'true' : void 0,
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@instructure/ui-menu",
|
|
3
|
-
"version": "10.10.1-snapshot-
|
|
3
|
+
"version": "10.10.1-snapshot-5",
|
|
4
4
|
"description": "A dropdown menu component",
|
|
5
5
|
"author": "Instructure, Inc. Engineering and Product Design",
|
|
6
6
|
"module": "./es/index.js",
|
|
@@ -23,11 +23,11 @@
|
|
|
23
23
|
},
|
|
24
24
|
"license": "MIT",
|
|
25
25
|
"devDependencies": {
|
|
26
|
-
"@instructure/ui-axe-check": "10.10.1-snapshot-
|
|
27
|
-
"@instructure/ui-babel-preset": "10.10.1-snapshot-
|
|
28
|
-
"@instructure/ui-color-utils": "10.10.1-snapshot-
|
|
29
|
-
"@instructure/ui-test-utils": "10.10.1-snapshot-
|
|
30
|
-
"@instructure/ui-themes": "10.10.1-snapshot-
|
|
26
|
+
"@instructure/ui-axe-check": "10.10.1-snapshot-5",
|
|
27
|
+
"@instructure/ui-babel-preset": "10.10.1-snapshot-5",
|
|
28
|
+
"@instructure/ui-color-utils": "10.10.1-snapshot-5",
|
|
29
|
+
"@instructure/ui-test-utils": "10.10.1-snapshot-5",
|
|
30
|
+
"@instructure/ui-themes": "10.10.1-snapshot-5",
|
|
31
31
|
"@testing-library/jest-dom": "^6.6.3",
|
|
32
32
|
"@testing-library/react": "^16.0.1",
|
|
33
33
|
"@testing-library/user-event": "^14.5.2",
|
|
@@ -35,19 +35,19 @@
|
|
|
35
35
|
},
|
|
36
36
|
"dependencies": {
|
|
37
37
|
"@babel/runtime": "^7.26.0",
|
|
38
|
-
"@instructure/console": "10.10.1-snapshot-
|
|
39
|
-
"@instructure/emotion": "10.10.1-snapshot-
|
|
40
|
-
"@instructure/shared-types": "10.10.1-snapshot-
|
|
41
|
-
"@instructure/ui-a11y-utils": "10.10.1-snapshot-
|
|
42
|
-
"@instructure/ui-dom-utils": "10.10.1-snapshot-
|
|
43
|
-
"@instructure/ui-icons": "10.10.1-snapshot-
|
|
44
|
-
"@instructure/ui-popover": "10.10.1-snapshot-
|
|
45
|
-
"@instructure/ui-position": "10.10.1-snapshot-
|
|
46
|
-
"@instructure/ui-prop-types": "10.10.1-snapshot-
|
|
47
|
-
"@instructure/ui-react-utils": "10.10.1-snapshot-
|
|
48
|
-
"@instructure/ui-testable": "10.10.1-snapshot-
|
|
49
|
-
"@instructure/ui-utils": "10.10.1-snapshot-
|
|
50
|
-
"@instructure/ui-view": "10.10.1-snapshot-
|
|
38
|
+
"@instructure/console": "10.10.1-snapshot-5",
|
|
39
|
+
"@instructure/emotion": "10.10.1-snapshot-5",
|
|
40
|
+
"@instructure/shared-types": "10.10.1-snapshot-5",
|
|
41
|
+
"@instructure/ui-a11y-utils": "10.10.1-snapshot-5",
|
|
42
|
+
"@instructure/ui-dom-utils": "10.10.1-snapshot-5",
|
|
43
|
+
"@instructure/ui-icons": "10.10.1-snapshot-5",
|
|
44
|
+
"@instructure/ui-popover": "10.10.1-snapshot-5",
|
|
45
|
+
"@instructure/ui-position": "10.10.1-snapshot-5",
|
|
46
|
+
"@instructure/ui-prop-types": "10.10.1-snapshot-5",
|
|
47
|
+
"@instructure/ui-react-utils": "10.10.1-snapshot-5",
|
|
48
|
+
"@instructure/ui-testable": "10.10.1-snapshot-5",
|
|
49
|
+
"@instructure/ui-utils": "10.10.1-snapshot-5",
|
|
50
|
+
"@instructure/ui-view": "10.10.1-snapshot-5",
|
|
51
51
|
"keycode": "^2",
|
|
52
52
|
"prop-types": "^15.8.1"
|
|
53
53
|
},
|
|
@@ -237,7 +237,8 @@ class MenuItem extends Component<MenuItemProps, MenuItemState> {
|
|
|
237
237
|
}
|
|
238
238
|
|
|
239
239
|
render() {
|
|
240
|
-
const { disabled, controls, onKeyDown, onKeyUp, type, href } =
|
|
240
|
+
const { disabled, controls, onKeyDown, onKeyUp, type, href, target } =
|
|
241
|
+
this.props
|
|
241
242
|
|
|
242
243
|
const props = omitProps(this.props, MenuItem.allowedProps)
|
|
243
244
|
const ElementType = this.elementType
|
|
@@ -247,6 +248,7 @@ class MenuItem extends Component<MenuItemProps, MenuItemState> {
|
|
|
247
248
|
tabIndex={-1} // note: tabIndex can be overridden by Menu or MenuItemGroup components
|
|
248
249
|
{...props}
|
|
249
250
|
href={href}
|
|
251
|
+
target={target}
|
|
250
252
|
role={this.role}
|
|
251
253
|
aria-labelledby={this.labelId}
|
|
252
254
|
aria-disabled={disabled ? 'true' : undefined}
|