@instructure/ui-dialog 8.11.1-snapshot.0 → 8.11.2-snapshot.15

package/CHANGELOG.md

@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [8.11.1](https://github.com/instructure/instructure-ui/compare/v8.11.0...v8.11.1) (2021-10-19)
+
+**Note:** Version bump only for package @instructure/ui-dialog
+
 # [8.11.0](https://github.com/instructure/instructure-ui/compare/v8.10.2...v8.11.0) (2021-10-15)
 
 **Note:** Version bump only for package @instructure/ui-dialog

package/es/Dialog/index.js

@@ -152,9 +152,11 @@ class Dialog extends Component {
   }
 
   render() {
-    const ElementType = getElementType(Dialog, this.props);
+    const ElementType = getElementType(Dialog, this.props); // In case the HTML role attribute is explicitly passed, use props.role
+
+    const role = this.props.role || (this.props.label ? 'dialog' : void 0);
     return this.props.open ? /*#__PURE__*/React.createElement(ElementType, Object.assign({}, omitProps(this.props, Dialog.allowedProps), {
-      role: this.props.label ? 'dialog' : void 0,
+      role: role,
       "aria-label": this.props.label,
       className: this.props.className // eslint-disable-line react/prop-types
       ,

package/lib/Dialog/index.js

@@ -150,9 +150,11 @@ class Dialog extends _react.Component {
   }
 
   render() {
-    const ElementType = (0, _getElementType.getElementType)(Dialog, this.props);
+    const ElementType = (0, _getElementType.getElementType)(Dialog, this.props); // In case the HTML role attribute is explicitly passed, use props.role
+
+    const role = this.props.role || (this.props.label ? 'dialog' : void 0);
     return this.props.open ? /*#__PURE__*/_react.default.createElement(ElementType, Object.assign({}, (0, _omitProps.omitProps)(this.props, Dialog.allowedProps), {
-      role: this.props.label ? 'dialog' : void 0,
+      role: role,
       "aria-label": this.props.label,
       className: this.props.className // eslint-disable-line react/prop-types
       ,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instructure/ui-dialog",
-  "version": "8.11.1-snapshot.0+8536a1c9b",
+  "version": "8.11.2-snapshot.15+4f855a7cf",
   "description": "A utility component for managing keyboard accessibility and screen reader behavior",
   "author": "Instructure, Inc. Engineering and Product Design",
   "type": "commonjs",
@@ -25,18 +25,18 @@
   "license": "MIT",
   "dependencies": {
     "@babel/runtime": "^7.13.10",
-    "@instructure/shared-types": "8.11.1-snapshot.0+8536a1c9b",
-    "@instructure/ui-a11y-utils": "8.11.1-snapshot.0+8536a1c9b",
-    "@instructure/ui-dom-utils": "8.11.1-snapshot.0+8536a1c9b",
-    "@instructure/ui-react-utils": "8.11.1-snapshot.0+8536a1c9b",
-    "@instructure/ui-testable": "8.11.1-snapshot.0+8536a1c9b",
+    "@instructure/shared-types": "8.11.2-snapshot.15+4f855a7cf",
+    "@instructure/ui-a11y-utils": "8.11.2-snapshot.15+4f855a7cf",
+    "@instructure/ui-dom-utils": "8.11.2-snapshot.15+4f855a7cf",
+    "@instructure/ui-react-utils": "8.11.2-snapshot.15+4f855a7cf",
+    "@instructure/ui-testable": "8.11.2-snapshot.15+4f855a7cf",
     "prop-types": "^15"
   },
   "devDependencies": {
-    "@instructure/console": "8.11.1-snapshot.0+8536a1c9b",
-    "@instructure/ui-babel-preset": "8.11.1-snapshot.0+8536a1c9b",
-    "@instructure/ui-prop-types": "8.11.1-snapshot.0+8536a1c9b",
-    "@instructure/ui-test-utils": "8.11.1-snapshot.0+8536a1c9b"
+    "@instructure/console": "8.11.2-snapshot.15+4f855a7cf",
+    "@instructure/ui-babel-preset": "8.11.2-snapshot.15+4f855a7cf",
+    "@instructure/ui-prop-types": "8.11.2-snapshot.15+4f855a7cf",
+    "@instructure/ui-test-utils": "8.11.2-snapshot.15+4f855a7cf"
   },
   "peerDependencies": {
     "react": ">=16.8 <=17"
@@ -45,5 +45,5 @@
     "access": "public"
   },
   "sideEffects": false,
-  "gitHead": "8536a1c9badcd8c1d2ce55dfb462d1899e3ca500"
+  "gitHead": "4f855a7cfb0f347bca6a71b18be9504447ba768f"
 }

package/src/Dialog/index.tsx

@@ -188,11 +188,14 @@ class Dialog extends Component<DialogProps> {
   render() {
     const ElementType = getElementType(Dialog, this.props)
 
+    // In case the HTML role attribute is explicitly passed, use props.role
+    const role = this.props.role || (this.props.label ? 'dialog' : undefined)
+
     return this.props.open ? (
       <ElementType
         // @ts-expect-error TODO: `ref` prop causes: "Expression produces a union type that is too complex to represent.ts(2590)"
         {...omitProps(this.props, Dialog.allowedProps)}
-        role={this.props.label ? 'dialog' : undefined}
+        role={role}
         aria-label={this.props.label}
         className={this.props.className} // eslint-disable-line react/prop-types
         ref={this.getRef}

package/types/Dialog/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/Dialog/index.tsx"],"names":[],"mappings":"AAwBA,OAAO,KAAK,EAAE,EAAE,SAAS,EAAE,MAAM,OAAO,CAAA;AAIxC,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,2BAA2B,CAAA;AAK1E,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,SAAS,CAAA;AAE1C;;;;;GAKG;AAEH,cAAM,MAAO,SAAQ,SAAS,CAAC,WAAW,CAAC;IACzC,MAAM,CAAC,QAAQ,CAAC,WAAW,YAAW;IAEtC,MAAM,CAAC,SAAS;;;;;;;;;;;;;;;;;OAAY;IAC5B,MAAM,CAAC,YAAY;;;;;;;;;;;;;;;;;SAAe;IAClC,MAAM,CAAC,YAAY;;;;;;;;;;;;;MAeT;IAEV,SAAS,EAAE,UAAU,CAAC,OAAO,UAAU,CAAC,EAAE,CAAK;IAC/C,IAAI,EAAE,yBAAyB,EAAE,CAAK;IACtC,YAAY,OAAO;IACnB,GAAG,EAAE,OAAO,GAAG,IAAI,CAAO;IAC1B,KAAK,EAAE,OAAO,GAAG,IAAI,CAAO;IAE5B,iBAAiB;IAOjB,kBAAkB,CAAC,SAAS,KAAA;IAe5B,oBAAoB;IAWpB,IAAI;IAyBJ,KAAK;IAOL,KAAK;IAYL,IAAI;IASJ,MAAM,OAAQ,OAAO,GAAG,IAAI,UAU3B;IAED,IAAI,cAAc,wCAQjB;IAED,IAAI,OAAO,qBAOV;IAED,MAAM;CAgBP;AAED,eAAe,MAAM,CAAA;AACrB,OAAO,EAAE,MAAM,EAAE,CAAA"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/Dialog/index.tsx"],"names":[],"mappings":"AAwBA,OAAO,KAAK,EAAE,EAAE,SAAS,EAAE,MAAM,OAAO,CAAA;AAIxC,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,2BAA2B,CAAA;AAK1E,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,SAAS,CAAA;AAE1C;;;;;GAKG;AAEH,cAAM,MAAO,SAAQ,SAAS,CAAC,WAAW,CAAC;IACzC,MAAM,CAAC,QAAQ,CAAC,WAAW,YAAW;IAEtC,MAAM,CAAC,SAAS;;;;;;;;;;;;;;;;;OAAY;IAC5B,MAAM,CAAC,YAAY;;;;;;;;;;;;;;;;;SAAe;IAClC,MAAM,CAAC,YAAY;;;;;;;;;;;;;MAeT;IAEV,SAAS,EAAE,UAAU,CAAC,OAAO,UAAU,CAAC,EAAE,CAAK;IAC/C,IAAI,EAAE,yBAAyB,EAAE,CAAK;IACtC,YAAY,OAAO;IACnB,GAAG,EAAE,OAAO,GAAG,IAAI,CAAO;IAC1B,KAAK,EAAE,OAAO,GAAG,IAAI,CAAO;IAE5B,iBAAiB;IAOjB,kBAAkB,CAAC,SAAS,KAAA;IAe5B,oBAAoB;IAWpB,IAAI;IAyBJ,KAAK;IAOL,KAAK;IAYL,IAAI;IASJ,MAAM,OAAQ,OAAO,GAAG,IAAI,UAU3B;IAED,IAAI,cAAc,wCAQjB;IAED,IAAI,OAAO,qBAOV;IAED,MAAM;CAmBP;AAED,eAAe,MAAM,CAAA;AACrB,OAAO,EAAE,MAAM,EAAE,CAAA"}