@instructure/ui-date-time-input 10.3.0 → 10.3.1-snapshot-2

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [10.3.1-snapshot-2](https://github.com/instructure/instructure-ui/compare/v10.3.0...v10.3.1-snapshot-2) (2024-10-08)
+
+
+### Bug Fixes
+
+* **ui-calendar:** fix duplicate dates for certain timezones ([f9181aa](https://github.com/instructure/instructure-ui/commit/f9181aa88c35eba1e374240505d32bf618c46b04))
+
+
+
+
+
 # [10.3.0](https://github.com/instructure/instructure-ui/compare/v10.2.2...v10.3.0) (2024-10-03)
 
 **Note:** Version bump only for package @instructure/ui-date-time-input

package/es/DateTimeInput/index.js

@@ -345,7 +345,21 @@ let DateTimeInput = (_dec = testable(), _dec(_class = (_DateTimeInput = class Da
     const currDate = DateTime.getFirstDayOfWeek(renderedDate.startOf('month'));
     const arr = [];
     for (let i = 0; i < Calendar.DAY_COUNT; i++) {
-      arr.push(currDate.clone());
+      // This workaround is needed because moment's `.add({days: 1})` function has a bug that happens when the date added lands perfectly onto the DST cutoff,
+      // in these cases adding 1 day results in 23 hours added instead,
+      // so `moment.tz('2024-09-07T00:00:00', 'America/Santiago').add({days: 1})` results
+      // in "Sat Sep 07 2024 23:00:00 GMT-0400" instead of "Sun Sep 08 2024 00:00:00 GMT-0400".
+      // which would cause duplicate dates in the calendar.
+      // More info on the bug: https://github.com/moment/moment/issues/4743
+      // Please note that this causes one hour of time difference in the affected timezones/dates and to
+      // fully solve this bug we need to change to something like luxon which handles this properly
+      if (currDate.clone().format('HH') === '23') {
+        arr.push(currDate.clone().add({
+          hours: 1
+        }));
+      } else {
+        arr.push(currDate.clone());
+      }
       currDate.add({
         days: 1
       });

package/lib/DateTimeInput/index.js

@@ -353,7 +353,21 @@ let DateTimeInput = exports.DateTimeInput = (_dec = (0, _testable.testable)(), _
     const currDate = _DateTime.DateTime.getFirstDayOfWeek(renderedDate.startOf('month'));
     const arr = [];
     for (let i = 0; i < _Calendar.Calendar.DAY_COUNT; i++) {
-      arr.push(currDate.clone());
+      // This workaround is needed because moment's `.add({days: 1})` function has a bug that happens when the date added lands perfectly onto the DST cutoff,
+      // in these cases adding 1 day results in 23 hours added instead,
+      // so `moment.tz('2024-09-07T00:00:00', 'America/Santiago').add({days: 1})` results
+      // in "Sat Sep 07 2024 23:00:00 GMT-0400" instead of "Sun Sep 08 2024 00:00:00 GMT-0400".
+      // which would cause duplicate dates in the calendar.
+      // More info on the bug: https://github.com/moment/moment/issues/4743
+      // Please note that this causes one hour of time difference in the affected timezones/dates and to
+      // fully solve this bug we need to change to something like luxon which handles this properly
+      if (currDate.clone().format('HH') === '23') {
+        arr.push(currDate.clone().add({
+          hours: 1
+        }));
+      } else {
+        arr.push(currDate.clone());
+      }
       currDate.add({
         days: 1
       });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instructure/ui-date-time-input",
-  "version": "10.3.0",
+  "version": "10.3.1-snapshot-2",
   "description": "A UI component that allows to select date and time.",
   "author": "Instructure, Inc. Engineering and Product Design",
   "module": "./es/index.js",
@@ -23,8 +23,8 @@
   },
   "license": "MIT",
   "devDependencies": {
-    "@instructure/ui-babel-preset": "10.3.0",
-    "@instructure/ui-test-utils": "10.3.0",
+    "@instructure/ui-babel-preset": "10.3.1-snapshot-2",
+    "@instructure/ui-test-utils": "10.3.1-snapshot-2",
     "@testing-library/jest-dom": "^6.4.6",
     "@testing-library/react": "^16.0.1",
     "@testing-library/user-event": "^14.5.2",
@@ -32,20 +32,20 @@
   },
   "dependencies": {
     "@babel/runtime": "^7.25.6",
-    "@instructure/console": "10.3.0",
-    "@instructure/shared-types": "10.3.0",
-    "@instructure/ui-a11y-content": "10.3.0",
-    "@instructure/ui-buttons": "10.3.0",
-    "@instructure/ui-calendar": "10.3.0",
-    "@instructure/ui-date-input": "10.3.0",
-    "@instructure/ui-form-field": "10.3.0",
-    "@instructure/ui-i18n": "10.3.0",
-    "@instructure/ui-icons": "10.3.0",
-    "@instructure/ui-prop-types": "10.3.0",
-    "@instructure/ui-react-utils": "10.3.0",
-    "@instructure/ui-testable": "10.3.0",
-    "@instructure/ui-time-select": "10.3.0",
-    "@instructure/ui-utils": "10.3.0",
+    "@instructure/console": "10.3.1-snapshot-2",
+    "@instructure/shared-types": "10.3.1-snapshot-2",
+    "@instructure/ui-a11y-content": "10.3.1-snapshot-2",
+    "@instructure/ui-buttons": "10.3.1-snapshot-2",
+    "@instructure/ui-calendar": "10.3.1-snapshot-2",
+    "@instructure/ui-date-input": "10.3.1-snapshot-2",
+    "@instructure/ui-form-field": "10.3.1-snapshot-2",
+    "@instructure/ui-i18n": "10.3.1-snapshot-2",
+    "@instructure/ui-icons": "10.3.1-snapshot-2",
+    "@instructure/ui-prop-types": "10.3.1-snapshot-2",
+    "@instructure/ui-react-utils": "10.3.1-snapshot-2",
+    "@instructure/ui-testable": "10.3.1-snapshot-2",
+    "@instructure/ui-time-select": "10.3.1-snapshot-2",
+    "@instructure/ui-utils": "10.3.1-snapshot-2",
     "prop-types": "^15.8.1"
   },
   "peerDependencies": {

package/src/DateTimeInput/index.tsx

@@ -430,8 +430,21 @@ class DateTimeInput extends Component<DateTimeInputProps, DateTimeInputState> {
     const currDate = DateTime.getFirstDayOfWeek(renderedDate.startOf('month'))
     const arr: Moment[] = []
     for (let i = 0; i < Calendar.DAY_COUNT; i++) {
-      arr.push(currDate.clone())
-      currDate.add({ days: 1 })
+      // This workaround is needed because moment's `.add({days: 1})` function has a bug that happens when the date added lands perfectly onto the DST cutoff,
+      // in these cases adding 1 day results in 23 hours added instead,
+      // so `moment.tz('2024-09-07T00:00:00', 'America/Santiago').add({days: 1})` results
+      // in "Sat Sep 07 2024 23:00:00 GMT-0400" instead of "Sun Sep 08 2024 00:00:00 GMT-0400".
+      // which would cause duplicate dates in the calendar.
+      // More info on the bug: https://github.com/moment/moment/issues/4743
+      // Please note that this causes one hour of time difference in the affected timezones/dates and to
+      // fully solve this bug we need to change to something like luxon which handles this properly
+      if (currDate.clone().format('HH') === '23') {
+        arr.push(currDate.clone().add({hours: 1}))
+      } else {
+        arr.push(currDate.clone())
+      }
+
+      currDate.add({days: 1})
     }
     return arr.map((date) => {
       const dateStr = date.toISOString()