@instructure/ui-date-input 10.3.1-snapshot-0 → 10.3.1-snapshot-2

package/CHANGELOG.md

@@ -3,9 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [10.3.1-snapshot-0](https://github.com/instructure/instructure-ui/compare/v10.3.0...v10.3.1-snapshot-0) (2024-10-04)
+## [10.3.1-snapshot-2](https://github.com/instructure/instructure-ui/compare/v10.3.0...v10.3.1-snapshot-2) (2024-10-08)
 
-**Note:** Version bump only for package @instructure/ui-date-input
+
+### Bug Fixes
+
+* **ui-calendar:** fix duplicate dates for certain timezones ([f9181aa](https://github.com/instructure/instructure-ui/commit/f9181aa88c35eba1e374240505d32bf618c46b04))
 
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instructure/ui-date-input",
-  "version": "10.3.1-snapshot-0",
+  "version": "10.3.1-snapshot-2",
   "description": "A UI component library made by Instructure Inc.",
   "author": "Instructure, Inc. Engineering and Product Design",
   "module": "./es/index.js",
@@ -23,11 +23,11 @@
   },
   "license": "MIT",
   "devDependencies": {
-    "@instructure/ui-axe-check": "10.3.1-snapshot-0",
-    "@instructure/ui-babel-preset": "10.3.1-snapshot-0",
-    "@instructure/ui-buttons": "10.3.1-snapshot-0",
-    "@instructure/ui-scripts": "10.3.1-snapshot-0",
-    "@instructure/ui-test-utils": "10.3.1-snapshot-0",
+    "@instructure/ui-axe-check": "10.3.1-snapshot-2",
+    "@instructure/ui-babel-preset": "10.3.1-snapshot-2",
+    "@instructure/ui-buttons": "10.3.1-snapshot-2",
+    "@instructure/ui-scripts": "10.3.1-snapshot-2",
+    "@instructure/ui-test-utils": "10.3.1-snapshot-2",
     "@testing-library/jest-dom": "^6.4.6",
     "@testing-library/react": "^16.0.1",
     "@testing-library/user-event": "^14.5.2",
@@ -35,20 +35,20 @@
   },
   "dependencies": {
     "@babel/runtime": "^7.25.6",
-    "@instructure/emotion": "10.3.1-snapshot-0",
-    "@instructure/shared-types": "10.3.1-snapshot-0",
-    "@instructure/ui-calendar": "10.3.1-snapshot-0",
-    "@instructure/ui-form-field": "10.3.1-snapshot-0",
-    "@instructure/ui-i18n": "10.3.1-snapshot-0",
-    "@instructure/ui-icons": "10.3.1-snapshot-0",
-    "@instructure/ui-popover": "10.3.1-snapshot-0",
-    "@instructure/ui-position": "10.3.1-snapshot-0",
-    "@instructure/ui-prop-types": "10.3.1-snapshot-0",
-    "@instructure/ui-react-utils": "10.3.1-snapshot-0",
-    "@instructure/ui-selectable": "10.3.1-snapshot-0",
-    "@instructure/ui-testable": "10.3.1-snapshot-0",
-    "@instructure/ui-text-input": "10.3.1-snapshot-0",
-    "@instructure/ui-utils": "10.3.1-snapshot-0",
+    "@instructure/emotion": "10.3.1-snapshot-2",
+    "@instructure/shared-types": "10.3.1-snapshot-2",
+    "@instructure/ui-calendar": "10.3.1-snapshot-2",
+    "@instructure/ui-form-field": "10.3.1-snapshot-2",
+    "@instructure/ui-i18n": "10.3.1-snapshot-2",
+    "@instructure/ui-icons": "10.3.1-snapshot-2",
+    "@instructure/ui-popover": "10.3.1-snapshot-2",
+    "@instructure/ui-position": "10.3.1-snapshot-2",
+    "@instructure/ui-prop-types": "10.3.1-snapshot-2",
+    "@instructure/ui-react-utils": "10.3.1-snapshot-2",
+    "@instructure/ui-selectable": "10.3.1-snapshot-2",
+    "@instructure/ui-testable": "10.3.1-snapshot-2",
+    "@instructure/ui-text-input": "10.3.1-snapshot-2",
+    "@instructure/ui-utils": "10.3.1-snapshot-2",
     "moment-timezone": "^0.5.45",
     "prop-types": "^15.8.1"
   },

package/src/DateInput/README.md

@@ -41,8 +41,21 @@ class Example extends React.Component {
 
     return Array.apply(null, Array(Calendar.DAY_COUNT)).map(() => {
       const currentDate = date.clone()
-      date.add(1, 'days')
-      return currentDate
+      date.add({days: 1})
+
+      // This workaround is needed because moment's `.add({days: 1})` function has a bug that happens when the date added lands perfectly onto the DST cutoff,
+      // in these cases adding 1 day results in 23 hours added instead,
+      // so `moment.tz('2024-09-07T00:00:00', 'America/Santiago').add({days: 1})` results
+      // in "Sat Sep 07 2024 23:00:00 GMT-0400" instead of "Sun Sep 08 2024 00:00:00 GMT-0400".
+      // which would cause duplicate dates in the calendar.
+      // More info on the bug: https://github.com/moment/moment/issues/4743
+      // Please note that this causes one hour of time difference in the affected timezones/dates and to
+      // fully solve this bug we need to change to something like luxon which handles this properly
+      if (currentDate.clone().format('HH') === '23') {
+        return currentDate.clone().add({hours: 1})
+      }
+
+      return currentDate.clone()
     })
   }