@instructure/quiz-core 17.44.1-rc.8 → 17.45.0

package/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [17.45.0](https://gerrit.instructure.com/quizzes-ui/compare/v17.44.0...v17.45.0) (2022-12-13)
+
+
+### Bug Fixes
+
+* **browser:** remove aria-expanded from the wrong html element ([fd0d48d](https://gerrit.instructure.com/quizzes-ui/commits/fd0d48d4e424f8161358ac8dc5d91b57aab48660))
+* **core:** scroll into view correctly when scroll keys are null ([f82fb31](https://gerrit.instructure.com/quizzes-ui/commits/f82fb316b37bc8509749707d3a1cce78aa6dc9cc))
+* **RCE5:** set features RCEGlobals until it get fixed ([7d4c5eb](https://gerrit.instructure.com/quizzes-ui/commits/7d4c5eb58cfdc66ccb7a2a4df9f91ee37f88d1f7))
+* **Stimulus:** clear modifications properly on unmount ([5752c86](https://gerrit.instructure.com/quizzes-ui/commits/5752c8638cc3584f3c09e530f80bbb741804fdec))
+
+
+### Features
+
+* **RCE5:** set RCE5 editor height ([fc7d0d1](https://gerrit.instructure.com/quizzes-ui/commits/fc7d0d1f5868bc7a4145fb1202a0ec68be0d3fd0))
+
+
+
+
+
 # [17.44.0](https://gerrit.instructure.com/quizzes-ui/compare/v17.43.0...v17.44.0) (2022-11-30)
 
 

package/es/building/components/resources/ItemFeedbackModal/presenter.js

@@ -11,9 +11,9 @@ import ImmutablePropTypes from 'react-immutable-proptypes';
 import { Button, CloseButton } from '@instructure/ui-buttons';
 import { Heading } from '@instructure/ui-heading';
 import { themeable } from '@instructure/ui-themeable';
-import { RichContentRenderer } from '@instructure/quiz-rce';
+import { RichContentRenderer, RCE_THREE_LINES_HEIGHT } from '@instructure/quiz-rce';
 import { isNewRCEEnabled } from "../../../../common/util/rceChecker.js";
-import RichContentInput from "../../../../common/components/RichContentInput/index.js";
+import { RichContentInput } from "../../../../common/components/RichContentInput/index.js";
 import t from '@instructure/quiz-i18n/es/format-message';
 import { Modal, ModalHeader, ModalBody, ModalFooter, ITEM_FEEDBACK_MODAL, ITEM_FEEDBACK_MODAL_FEEDBACK, XSMALL_SIDE_MARGIN } from '@instructure/quiz-common';
 var styles = {
@@ -108,7 +108,8 @@ export var ItemFeedbackModal = (_dec = themeable(theme, styles), _dec(_class = (
         parentType: this.props.parentType,
         parentId: this.props.parentId,
         importModalCloseOverride: this.returnToFeedback,
-        useNewRce: isNewRCEEnabled()
+        useNewRce: isNewRCEEnabled(),
+        height: RCE_THREE_LINES_HEIGHT
       }));
     }
   }, {

package/es/common/util/RceConfigProvider.js

@@ -9,13 +9,16 @@ import store from "../../reduxStore.js";
 import { setRCEError } from "../actions/rce.js";
 import isNewRCEEnabled from "./rceChecker.js";
 import { QuizzesSpinner as Spinner } from "../components/shared/spinner/Spinner.js";
+import { Card } from "../components/shared/Card/index.js";
 import { RceConfigContext, RceConfigKeys } from '@instructure/quiz-common';
 import { addError } from "../actions/alerts.js";
 import t from '@instructure/quiz-i18n/es/format-message';
 import { extractTextFromHtml } from '@instructure/quiz-interactions';
 import { isDuringQuizTake } from "./windowChecks.js";
 
-var _ref4 = /*#__PURE__*/React.createElement(Spinner, null);
+var _ref4 = /*#__PURE__*/React.createElement(Card, {
+  wrapped: true
+}, /*#__PURE__*/React.createElement(Spinner, null));
 
 export var RceConfigProviderComponent = function RceConfigProviderComponent(props) {
   var _useState = useState(props.rcsJwt),
@@ -120,16 +123,16 @@ export var RceConfigProviderComponent = function RceConfigProviderComponent(prop
         while (1) {
           switch (_context2.prev = _context2.next) {
             case 0:
-              _context2.prev = 0;
-
               if (props.useNewRce) {
-                _context2.next = 3;
+                _context2.next = 2;
                 break;
               }
 
               return _context2.abrupt("return");
 
-            case 3:
+            case 2:
+              _context2.prev = 2;
+
               if (hasAllPropsForRcs()) {
                 _context2.next = 6;
                 break;
@@ -165,7 +168,7 @@ export var RceConfigProviderComponent = function RceConfigProviderComponent(prop
 
             case 21:
               _context2.prev = 21;
-              _context2.t0 = _context2["catch"](0);
+              _context2.t0 = _context2["catch"](2);
               setCanvasConfig(null);
               setErrorIfDuringTaking(t('Error: Full functionality of the Rich Content Editor including accessibility features may not have been available to the user.'));
 
@@ -179,7 +182,7 @@ export var RceConfigProviderComponent = function RceConfigProviderComponent(prop
               return _context2.stop();
           }
         }
-      }, _callee2, null, [[0, 21, 25, 28]]);
+      }, _callee2, null, [[2, 21, 25, 28]]);
     }))();
   }, [props.useNewRce]);
   if (!props.useNewRce) return /*#__PURE__*/React.createElement(React.Fragment, null, props.children);

package/lib/building/components/resources/ItemFeedbackModal/presenter.js

@@ -33,7 +33,7 @@ var _quizRce = require("@instructure/quiz-rce");
 
 var _rceChecker = require("../../../../common/util/rceChecker.js");
 
-var _index = _interopRequireDefault(require("../../../../common/components/RichContentInput/index.js"));
+var _index = require("../../../../common/components/RichContentInput/index.js");
 
 var _formatMessage = _interopRequireDefault(require("@instructure/quiz-i18n/es/format-message"));
 
@@ -126,7 +126,7 @@ var ItemFeedbackModal = (_dec = (0, _uiThemeable.themeable)(_theme.default, styl
       return /*#__PURE__*/_react.default.createElement("div", null, _ref, /*#__PURE__*/_react.default.createElement("label", {
         className: styles.feedbackLabel,
         htmlFor: key
-      }, label), /*#__PURE__*/_react.default.createElement(_index.default, {
+      }, label), /*#__PURE__*/_react.default.createElement(_index.RichContentInput, {
         label: "",
         textareaId: key,
         defaultContent: this.props.feedback.get(key),
@@ -134,7 +134,8 @@ var ItemFeedbackModal = (_dec = (0, _uiThemeable.themeable)(_theme.default, styl
         parentType: this.props.parentType,
         parentId: this.props.parentId,
         importModalCloseOverride: this.returnToFeedback,
-        useNewRce: (0, _rceChecker.isNewRCEEnabled)()
+        useNewRce: (0, _rceChecker.isNewRCEEnabled)(),
+        height: _quizRce.RCE_THREE_LINES_HEIGHT
       }));
     }
   }, {

package/lib/common/util/RceConfigProvider.js

@@ -31,6 +31,8 @@ var _rceChecker = _interopRequireDefault(require("./rceChecker.js"));
 
 var _Spinner = require("../components/shared/spinner/Spinner.js");
 
+var _index = require("../components/shared/Card/index.js");
+
 var _quizCommon = require("@instructure/quiz-common");
 
 var _alerts = require("../actions/alerts.js");
@@ -41,7 +43,9 @@ var _quizInteractions = require("@instructure/quiz-interactions");
 
 var _windowChecks = require("./windowChecks.js");
 
-var _ref4 = /*#__PURE__*/_react.default.createElement(_Spinner.QuizzesSpinner, null);
+var _ref4 = /*#__PURE__*/_react.default.createElement(_index.Card, {
+  wrapped: true
+}, /*#__PURE__*/_react.default.createElement(_Spinner.QuizzesSpinner, null));
 
 var RceConfigProviderComponent = function RceConfigProviderComponent(props) {
   var _useState = (0, _react.useState)(props.rcsJwt),
@@ -146,16 +150,16 @@ var RceConfigProviderComponent = function RceConfigProviderComponent(props) {
         while (1) {
           switch (_context2.prev = _context2.next) {
             case 0:
-              _context2.prev = 0;
-
               if (props.useNewRce) {
-                _context2.next = 3;
+                _context2.next = 2;
                 break;
               }
 
               return _context2.abrupt("return");
 
-            case 3:
+            case 2:
+              _context2.prev = 2;
+
               if (hasAllPropsForRcs()) {
                 _context2.next = 6;
                 break;
@@ -191,7 +195,7 @@ var RceConfigProviderComponent = function RceConfigProviderComponent(props) {
 
             case 21:
               _context2.prev = 21;
-              _context2.t0 = _context2["catch"](0);
+              _context2.t0 = _context2["catch"](2);
               setCanvasConfig(null);
               setErrorIfDuringTaking((0, _formatMessage.default)('Error: Full functionality of the Rich Content Editor including accessibility features may not have been available to the user.'));
 
@@ -205,7 +209,7 @@ var RceConfigProviderComponent = function RceConfigProviderComponent(props) {
               return _context2.stop();
           }
         }
-      }, _callee2, null, [[0, 21, 25, 28]]);
+      }, _callee2, null, [[2, 21, 25, 28]]);
     }))();
   }, [props.useNewRce]);
   if (!props.useNewRce) return /*#__PURE__*/_react.default.createElement(_react.default.Fragment, null, props.children);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instructure/quiz-core",
-  "version": "17.44.1-rc.8+0dcec06cd",
+  "version": "17.45.0",
   "license": "MIT",
   "description": "The Quiz React SDK by Instructure Inc.",
   "author": "Instructure, Inc. Engineering and Product Design",
@@ -41,11 +41,11 @@
   ],
   "dependencies": {
     "@instructure/outcomes-ui": "^2.1.2",
-    "@instructure/quiz-common": "17.44.1-rc.8+0dcec06cd",
-    "@instructure/quiz-i18n": "17.44.1-rc.8+0dcec06cd",
-    "@instructure/quiz-interactions": "17.44.1-rc.8+0dcec06cd",
-    "@instructure/quiz-number-input": "17.44.1-rc.8+0dcec06cd",
-    "@instructure/quiz-rce": "17.44.1-rc.8+0dcec06cd",
+    "@instructure/quiz-common": "^17.45.0",
+    "@instructure/quiz-i18n": "^17.45.0",
+    "@instructure/quiz-interactions": "^17.45.0",
+    "@instructure/quiz-number-input": "^17.45.0",
+    "@instructure/quiz-rce": "^17.45.0",
     "@instructure/ui-a11y-content": "^7.20.0",
     "@instructure/ui-alerts": "^7.20.0",
     "@instructure/ui-avatar": "^7.20.0",
@@ -106,7 +106,7 @@
     "eventemitter3": "^3.1.0",
     "humps": "^2.0.0",
     "immutable": "^3.8.1",
-    "instructure-validations": "17.44.1-rc.8+0dcec06cd",
+    "instructure-validations": "^17.45.0",
     "ipaddr.js": "^1.5.4",
     "isomorphic-fetch": "^2.2.0",
     "isuuid": "^0.1.0",
@@ -137,7 +137,7 @@
     "uuid": "^3.2.1"
   },
   "devDependencies": {
-    "@instructure/quiz-scripts": "17.44.0",
+    "@instructure/quiz-scripts": "^17.45.0",
     "@instructure/ui-axe-check": "^7.20.0",
     "@instructure/ui-babel-preset": "^7.20.0",
     "@instructure/ui-karma-config": "^7.20.0",
@@ -156,7 +156,7 @@
     "intl": "^1.2.4",
     "jquery": "^2.2.3",
     "most-subject": "^5.3.0",
-    "quiz-presets": "17.44.1-rc.8+0dcec06cd",
+    "quiz-presets": "^17.45.0",
     "react": "^16.8.6",
     "react-addons-test-utils": "^15.6.2",
     "react-dom": "^16.8.6",
@@ -172,5 +172,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "0dcec06cde3a1bee42e6d87b9c010e968e1bbda6"
+  "gitHead": "b302aa334b4e096d9df426a2aec7aed00f2ee7a1"
 }