@instructure/canvas-rce 5.9.0 → 5.11.0

package/.mocharc.js

@@ -15,6 +15,13 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
+
+global.MutationObserver = class {
+  disconnect() {}
+
+  observe() {}
+}
+
 module.exports = {
   require: [
     '@instructure/canvas-theme',

package/CHANGELOG.md

@@ -5,23 +5,61 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 5.11.0 - 2023-10-10
+
+### Fixed
+
+- Fix styling on a11y checker why IconButton
+- fix instui8 regression in course link tray (RCE)
+- focus close button on ECL tray launch
+- fix video media comment in speedgrader
+
+### Changed
+
+- Bump instui to 8.45.0
+- update dockerfiles for node 18
+- InstUI 8 upgrade post-work: theme -> themeOverride
+- Allow other users to view media in discussions
+- Revert "Stop rendering title and CC panels on media tray for locked attachments"
+
+### Added
+
+- respond to all postMessages in active RCE
+
+## 5.10.0 - 2023-09-26
+
+### Fixed
+
+- An issue where media controls don't respond in Safari
+- An issue where embedded Studio videos cause unresponsiveness
+- A potential race condition in postMessage forwarding
+
+### Changed
+
+- Ignore a11y check on elements with a background image or gradient
+- Remove math processing percentage indicator
+
 ## 5.9.0 - 2023-08-30
 
 ### Fixed
+
 - An issue where LTI postMessages were not working inside active RCE
 
 ### Changed
+
 - Encrypt auto-saved RCE content
 - Remove dependency on `@instructure/filter-console-messages`
 
 ## 5.8.0 - 2023-08-15
 
 ### Fixed
+
 - An issue where filenames are incorrectly recognized in the accessibility checker
 - An issue where the accessibility checker's color picker would not work with invalid RGBA values
 - An issue where the RCS is required to use the new external tools plugin
 
 ### Changed
+
 - Removed CJS build from package
 - Renamed .js files to .jsx
 - Upgraded react-aria-live dependency to v2.0.5
@@ -30,6 +68,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Reduced amount of console errors when running jest tests by providing missing props, fixing async issues, etc in tests
 
 ### Added
+
 - New translations
 - Improved messaging in the Add Course Link tray when there's no results
 - Explanations for inherited media captions
@@ -37,27 +76,32 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## 5.7.0 - 2023-07-18
 
 ### Fixed
+
 - Some broken translations in the 'Edit Course Link' tray and the word count modal
 - Some Typescript errors
 - An issue where the a11y checker incorrectly shows the issues icon
 
 ### Changed
+
 - Removed the `rce_new_external_tool_dialog_in_canvas` feature flag
 - Removed the deprecated `instructure_external_tools` package code which was not in use
 - Replaced themeable with emotion
 
 ### Added
+
 - Selected link indicator alert for screenreaders in the 'Edit Course Link' tray
 
 ## 5.6.17 - 2023-06-27
 
 ### Fixed
+
 - Added some missing media translations
 - Fixed some a11y/usability issues in the 'Edit Course Link' tray
 - Fixed an icon maker bug related to image compression
 - Fixed some issues related to pasting images in Firefox and embedding media
 
 ### Changed
+
 - Removed the `rce_improved_placeholders`, `rce_better_paste`, `rce_show_studio_media_options`, and
   `buttons_and_icons_cropper` feature flags
 - Improved the accessibility checker's performance
@@ -65,10 +109,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## 5.6.16 - 2023-05-17
 
 ### Fixed
+
 - Fullscreen issues with several select components
 - A significant number of missing translations across various locales
 
 ### Changed
+
 - Restored previous mathjax delimiter config
 - Absorbed the `tinymce-a11y-checker` plugin
 - Updated the placeholders when inserting media, images, files, etc.
@@ -76,6 +122,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Moved MathML to one shared location
 
 ### Added
+
 - Studio Media Options plugin
 - Equilibrium button to the Equation Editor
 - Icon support for iWork files

package/Dockerfile

@@ -1,4 +1,4 @@
-FROM instructure/node:16
+FROM instructure/node:18
 
 ARG NPM_PRIVATE_SCOPE
 ARG NPM_PRIVATE_REGISTRY

package/es/common/mimeClass.js

@@ -42,75 +42,78 @@ export function mimeClass(file) {
   } else {
     const contentType = getContentType(file); // NOTE: Keep this list in sync with what's in canvas-lms/app/models/attachment.rb
 
-    return {
-      'text/html': 'html',
-      'text/x-csharp': 'code',
-      'text/xml': 'code',
-      'text/css': 'code',
-      text: 'text',
-      'text/plain': 'text',
-      'application/rtf': 'doc',
-      'text/rtf': 'doc',
-      'application/vnd.oasis.opendocument.text': 'doc',
-      'application/pdf': 'pdf',
-      'application/vnd.openxmlformats-officedocument.wordprocessingml.document': 'doc',
-      'application/vnd.apple.pages': 'doc',
-      'application/x-docx': 'doc',
-      'application/msword': 'doc',
-      'application/vnd.ms-powerpoint': 'ppt',
-      'application/vnd.openxmlformats-officedocument.presentationml.presentation': 'ppt',
-      'applicatoin/vnd.apple.key': 'ppt',
-      'application/vnd.ms-excel': 'xls',
-      'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet': 'xls',
-      'application/vnd.apple.numbers': 'xls',
-      'application/vnd.oasis.opendocument.spreadsheet': 'xls',
-      'image/jpeg': 'image',
-      'image/pjpeg': 'image',
-      'image/png': 'image',
-      'image/gif': 'image',
-      'image/bmp': 'image',
-      'image/svg+xml': 'image',
-      'image/webp': 'image',
-      'application/x-rar': 'zip',
-      'application/x-rar-compressed': 'zip',
-      'application/x-zip': 'zip',
-      'application/x-zip-compressed': 'zip',
-      'application/xml': 'code',
-      'application/zip': 'zip',
-      'audio/mp3': 'audio',
-      'audio/mpeg': 'audio',
-      'audio/basic': 'audio',
-      'audio/mid': 'audio',
-      'audio/3gpp': 'audio',
-      'audio/x-aiff': 'audio',
-      'audio/x-m4a': 'audio',
-      'audio/x-mpegurl': 'audio',
-      'audio/x-ms-wma': 'audio',
-      'audio/x-pn-realaudio': 'audio',
-      'audio/x-wav': 'audio',
-      'audio/mp4': 'audio',
-      'audio/wav': 'audio',
-      'audio/webm': 'audio',
-      'audio/*': 'audio',
-      audio: 'audio',
-      'video/mpeg': 'video',
-      'video/quicktime': 'video',
-      'video/x-la-asf': 'video',
-      'video/x-ms-asf': 'video',
-      'video/x-ms-wma': 'audio',
-      'video/x-ms-wmv': 'video',
-      'video/x-msvideo': 'video',
-      'video/x-sgi-movie': 'video',
-      'video/3gpp': 'video',
-      'video/mp4': 'video',
-      'video/webm': 'video',
-      'video/avi': 'video',
-      'video/*': 'video',
-      video: 'video',
-      'application/x-shockwave-flash': 'flash'
-    }[contentType] || file.mime_class || 'file';
+    return contentMapping(contentType) || file.mime_class || 'file';
   }
 }
+export function contentMapping(contentType) {
+  return {
+    'text/html': 'html',
+    'text/x-csharp': 'code',
+    'text/xml': 'code',
+    'text/css': 'code',
+    text: 'text',
+    'text/plain': 'text',
+    'application/rtf': 'doc',
+    'text/rtf': 'doc',
+    'application/vnd.oasis.opendocument.text': 'doc',
+    'application/pdf': 'pdf',
+    'application/vnd.openxmlformats-officedocument.wordprocessingml.document': 'doc',
+    'application/vnd.apple.pages': 'doc',
+    'application/x-docx': 'doc',
+    'application/msword': 'doc',
+    'application/vnd.ms-powerpoint': 'ppt',
+    'application/vnd.openxmlformats-officedocument.presentationml.presentation': 'ppt',
+    'applicatoin/vnd.apple.key': 'ppt',
+    'application/vnd.ms-excel': 'xls',
+    'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet': 'xls',
+    'application/vnd.apple.numbers': 'xls',
+    'application/vnd.oasis.opendocument.spreadsheet': 'xls',
+    'image/jpeg': 'image',
+    'image/pjpeg': 'image',
+    'image/png': 'image',
+    'image/gif': 'image',
+    'image/bmp': 'image',
+    'image/svg+xml': 'image',
+    'image/webp': 'image',
+    'application/x-rar': 'zip',
+    'application/x-rar-compressed': 'zip',
+    'application/x-zip': 'zip',
+    'application/x-zip-compressed': 'zip',
+    'application/xml': 'code',
+    'application/zip': 'zip',
+    'audio/mp3': 'audio',
+    'audio/mpeg': 'audio',
+    'audio/basic': 'audio',
+    'audio/mid': 'audio',
+    'audio/3gpp': 'audio',
+    'audio/x-aiff': 'audio',
+    'audio/x-m4a': 'audio',
+    'audio/x-mpegurl': 'audio',
+    'audio/x-ms-wma': 'audio',
+    'audio/x-pn-realaudio': 'audio',
+    'audio/x-wav': 'audio',
+    'audio/mp4': 'audio',
+    'audio/wav': 'audio',
+    'audio/webm': 'audio',
+    'audio/*': 'audio',
+    audio: 'audio',
+    'video/mpeg': 'video',
+    'video/quicktime': 'video',
+    'video/x-la-asf': 'video',
+    'video/x-ms-asf': 'video',
+    'video/x-ms-wma': 'audio',
+    'video/x-ms-wmv': 'video',
+    'video/x-msvideo': 'video',
+    'video/x-sgi-movie': 'video',
+    'video/3gpp': 'video',
+    'video/mp4': 'video',
+    'video/webm': 'video',
+    'video/avi': 'video',
+    'video/*': 'video',
+    video: 'video',
+    'application/x-shockwave-flash': 'flash'
+  }[contentType];
+}
 
 function getContentType(file) {
   return file['content-type'] || file.content_type || file.type;

package/es/enhance-user-content/doc_previews.js

@@ -65,7 +65,7 @@ export function showLoadingImage($link) {
 
   ReactDOM.render( /*#__PURE__*/React.createElement(Spinner, {
     size: "x-small",
-    title: formatMessage('Loading')
+    renderTitle: formatMessage('Loading')
   }), $imageHolder);
   return $link;
 }

package/es/enhance-user-content/enhance_user_content.js

@@ -216,8 +216,16 @@ export function enhanceUserContent() {
           iframeElem.setAttribute('src', addParentFrameContextToUrl(src, containingCanvasLtiToolId));
         }
       });
-    }
+    } // tell LTI tools that they are launching from within the active RCE
+
+
+    unenhanced_elem.querySelectorAll('iframe[src]').forEach(iframeElem => {
+      const src = iframeElem.getAttribute('src');
 
+      if (src.startsWith(canvasOrigin)) {
+        iframeElem.setAttribute('src', src.replace('display=in_rce', 'display=borderless'));
+      }
+    });
     unenhanced_elem.querySelectorAll('a:not(.not_external, .external)').forEach(childLink => {
       if (!isExternalLink(childLink, canvasOrigin)) return;
       if (childLink.tagName === 'IMG' || childLink.querySelectorAll('img').length > 0) return;

package/es/enhance-user-content/mathml.js

@@ -45,7 +45,8 @@ const localConfig = {
       }
     }
   },
-  showMathMenu: true
+  showMathMenu: true,
+  messageStyle: 'none'
 };
 
 class Mathml {
@@ -106,7 +107,7 @@ class Mathml {
           window.MathJax.Hub.Register.MessageHook('Math Processing Error', function (message) {
             var _elem$parentElement;
 
-            const elem = message[1]; // ".math_equation_latex" is the elem we added for MathJax to typeset the image equation
+            const elem = Array.isArray(message[1]) ? message[1][0] : message[1]; // ".math_equation_latex" is the elem we added for MathJax to typeset the image equation
 
             if ((_elem$parentElement = elem.parentElement) !== null && _elem$parentElement !== void 0 && _elem$parentElement.classList.contains('math_equation_latex')) {
               var _elem$parentElement$p;
@@ -123,7 +124,7 @@ class Mathml {
             }
           });
           window.MathJax.Hub.Register.MessageHook('End Math', function (message) {
-            const elem = message[1];
+            const elem = Array.isArray(message[1]) ? message[1][0] : message[1];
             mathImageHelper.removeStrayEquationImages(elem);
             mathImageHelper.nearlyInfiniteStyleFix(elem);
             elem.querySelectorAll('.math_equation_latex').forEach(m => m.classList.add('fade-in-equation'));
@@ -138,7 +139,8 @@ class Mathml {
           // Since we want to ignore <math> in .hidden-readable spans, let's remove the MathJunk™
           // right after MathJax adds it.
           window.MathJax.Hub.Register.MessageHook('End Math', function (message) {
-            $(message[1]).find('.hidden-readable [class^="MathJax"], .hidden-readable [id^="MathJax"]').remove();
+            const elm = Array.isArray(message[1]) ? message[1][0] : message[1];
+            $(elm).find('.hidden-readable [class^="MathJax"], .hidden-readable [id^="MathJax"]').remove();
           });
         } // leaving this here so I don't have to keep looking up how to see all messages
         // window.MathJax.Hub.Startup.signal.Interest(function (message) {
@@ -315,7 +317,8 @@ const mathImageHelper = {
   },
 
   catchEquationImages(refnode) {
-    // find equation images and replace with inline LaTeX
+    refnode = Array.isArray(refnode) ? refnode[0] : refnode; // find equation images and replace with inline LaTeX
+
     const eqimgs = refnode.querySelectorAll('img.equation_image');
 
     if (eqimgs.length > 0) {

package/es/getThemeVars.js

@@ -15,8 +15,7 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-import { ThemeRegistry } from '@instructure/ui-themeable'; // ^^ at InstUI 8, just directly import getRegistry directly from @instructure/theme-registry
-
+import { getRegistry } from '@instructure/theme-registry';
 import { merge, cloneDeep } from 'lodash'; // The running theme is the running theme for this page load, and it never
 // changes, so there's no point in doing the work more than once.
 
@@ -28,13 +27,13 @@ function getThemeVars() {
     defaultThemeKey,
     overrides,
     themes
-  } = ThemeRegistry.getRegistry(); // Just assume the "canvas" theme if the default key is null. This will
+  } = getRegistry(); // Just assume the "canvas" theme if the default key is null. This will
   // never happen in the live app because one way or another a theme gets
   // used, but unit tests don't always do that.
   // Also we have to cloneDeep this because the merge below is about to
   // mutate the whole thing.
 
-  const variables = cloneDeep(themes[defaultThemeKey !== null && defaultThemeKey !== void 0 ? defaultThemeKey : 'canvas'].variables);
+  const variables = cloneDeep(themes[defaultThemeKey !== null && defaultThemeKey !== void 0 ? defaultThemeKey : 'canvas']);
   merge(variables, overrides);
   memoizedVariables = {
     variables,

package/es/rce/RCE.js

@@ -1,5 +1,3 @@
-var _process, _process$env;
-
 // @ts-nocheck
 
 /*
@@ -29,7 +27,7 @@ import tinyRCE from './tinyRCE';
 import getTranslations from '../getTranslations';
 import '@instructure/canvas-theme';
 
-if (!((_process = process) !== null && _process !== void 0 && (_process$env = _process.env) !== null && _process$env !== void 0 && _process$env.BUILD_LOCALE)) {
+if (!process || !process.env || !undefined) {
   formatMessage.setup({
     locale: 'en',
     generateId: require('format-message-generate-id/underscored_crc32'),

package/es/rce/RCEWrapper.js

@@ -2714,48 +2714,9 @@ class RCEWrapper extends React.Component {
 
       this.checkAccessibility();
       this.fixToolbarKeyboardNavigation();
-      this.forwardPostMessages();
       (_this$props$onInitted = (_this$props = this.props).onInitted) === null || _this$props$onInitted === void 0 ? void 0 : _this$props$onInitted.call(_this$props, editor);
     };
 
-    this.forwardPostMessages = () => {
-      const windowReferences = {};
-      const rceWindow = this.editor.getWin(); // explicitly assign name for reference by parent window
-
-      rceWindow.name = `${RCEWrapper.editorFrameName}_${this.id}`;
-      rceWindow.addEventListener('message', this.forwardPostMessagesHandler(rceWindow, windowReferences));
-    };
-
-    this.forwardPostMessagesHandler = (rceWindow, windowReferences) => e => {
-      let message;
-
-      try {
-        message = typeof e.data === 'string' ? JSON.parse(e.data) : e.data;
-      } catch (err) {
-        // unparseable message may not be meant for our handlers
-        return false;
-      }
-
-      if (e.origin === rceWindow.origin) {
-        // message is from Canvas window, forward to tool
-        const targetOrigin = message.toolOrigin;
-
-        if (!targetOrigin) {
-          return false;
-        }
-
-        const targetWindow = windowReferences[targetOrigin];
-        delete message.toolOrigin;
-        targetWindow === null || targetWindow === void 0 ? void 0 : targetWindow.postMessage(message, targetOrigin);
-      } else {
-        // message is from tool, forward to Canvas window
-        windowReferences[e.origin] = e.source;
-        message.toolOrigin = e.origin;
-        message.frameName = rceWindow.name;
-        rceWindow.parent.postMessage(message, rceWindow.origin);
-      }
-    };
-
     this.fixToolbarKeyboardNavigation = () => {
       var _this$_elementRef$cur2;
 
@@ -3181,19 +3142,15 @@ class RCEWrapper extends React.Component {
   getRequiredFeatureStatuses() {
     const {
       new_math_equation_handling = false,
-      rce_ux_improvements = false,
       explicit_latex_typesetting = false,
       rce_transform_loaded_content = false,
-      media_links_use_attachment_id = false,
-      improved_no_results_messaging = false
+      media_links_use_attachment_id = false
     } = this.props.features;
     return {
       new_math_equation_handling,
-      rce_ux_improvements,
       explicit_latex_typesetting,
       rce_transform_loaded_content,
-      media_links_use_attachment_id,
-      improved_no_results_messaging
+      media_links_use_attachment_id
     };
   }
 
@@ -3201,8 +3158,7 @@ class RCEWrapper extends React.Component {
     return {
       locale: normalizeLocale(this.props.language),
       flashAlertTimeout: this.props.flashAlertTimeout,
-      timezone: this.props.timezone,
-      lockedAttachments: this.props.lockedAttachments
+      timezone: this.props.timezone
     };
   }
 
@@ -4238,7 +4194,6 @@ RCEWrapper.defaultProps = {
   canvasOrigin: ''
 };
 RCEWrapper.skinCssInjected = false;
-RCEWrapper.editorFrameName = 'active_rce_frame';
 
 function mergeMenuItems(standard, custom) {
   var _custom$trim;

package/es/rce/RceHtmlEditor.js

@@ -15,10 +15,10 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-import React, { useCallback, useEffect, useRef, useState } from 'react';
+import React, { useEffect, useState } from 'react';
 import { func, string } from 'prop-types';
 import formatMessage from '../format-message';
-import { CodeEditor } from '@instructure/ui-code-editor';
+import { SourceCodeEditor } from '@instructure/ui-source-code-editor';
 import beautify from 'js-beautify';
 const RceHtmlEditor = /*#__PURE__*/React.forwardRef((_ref, editorRef) => {
   let {
@@ -56,25 +56,7 @@ const RceHtmlEditor = /*#__PURE__*/React.forwardRef((_ref, editorRef) => {
 
     setDir(getComputedStyle(editorRef.current || document.body, null).direction);
   }, [dir, editorRef]);
-  useEffect(() => {
-    // scoping querySelector to the container div makes sure we're targeting this CodeEditor
-    // The CodeMirror docs (https://codemirror.net/doc/manual.html#styling)
-    // say this is the element we use to set the editor's height
-    const editor = editorRef.current.querySelector('.CodeMirror');
-    editor.CodeMirror.setSize(null, props.height);
-    editor.style.margin = '0';
-    editor.style.border = '0';
-  }, [props.height, editorRef]);
-  const isFocused = useRef(false); // move cursor to the top of the html code when the editor is focused for the first time
-
-  const handleFocus = useCallback((editor, event) => {
-    if (!isFocused.current) {
-      editor.setCursor(0, 0);
-      isFocused.current = true;
-    }
-
-    onFocus(event);
-  }, [onFocus]); // setting height on the container keeps the RCE toolbar from jumping
+  const direction = ['ltr', 'rtl'].includes(dir) ? dir : 'ltr'; // setting height on the container keeps the RCE toolbar from jumping
 
   return /*#__PURE__*/React.createElement("div", {
     ref: editorRef,
@@ -84,28 +66,28 @@ const RceHtmlEditor = /*#__PURE__*/React.forwardRef((_ref, editorRef) => {
       overflow: 'hidden',
       textAlign: 'start'
     }
-  }, /*#__PURE__*/React.createElement(CodeEditor, {
+  }, /*#__PURE__*/React.createElement(SourceCodeEditor, {
     label: label,
-    language: "html",
-    options: {
-      lineNumbers: true,
-      lineWrapping: true,
-      autofocus: false,
-      spellcheck: true,
-      extraKeys: {
-        Tab: false,
-        'Shift-Tab': false
-      },
-      screenReaderLabel: label,
-      direction: dir,
-      rtlMoveVisually: true
-    },
+    language: "html" // see LF-745 for tracking of the following:
+    // TODO: needs prop for
+    // options={{
+    //   extraKeys: {Tab: false, 'Shift-Tab': false},
+    // }}
+    // TODO: may need
+    // attachment={none | bottom | top}
+    ,
+    lineNumbers: true,
+    lineWrapping: true,
+    autoFocus: false,
+    spellcheck: true,
+    direction: direction,
+    rtlMoveVisually: true,
+    height: props.height,
     value: code,
     onChange: value => {
       setCode(value);
       props.onChange(value);
-    },
-    onFocus: handleFocus
+    }
   }));
 });
 RceHtmlEditor.propTypes = {

package/es/rce/plugins/instructure_equation/EquationEditorModal/parseLatex.js

@@ -68,8 +68,6 @@ export const parseLatex = editor => {
       };
     } catch (ex) {
       // probably failed to create the new URL
-      // eslint-disable-next-line no-console
-      console.error(ex);
       return {};
     }
   } else if (wholeText) {

package/es/rce/plugins/instructure_links/components/Link.js

@@ -31,8 +31,6 @@ import { IconDragHandleLine, IconPublishSolid, IconUnpublishedSolid } from '@ins
 import RCEGlobals from '../../../RCEGlobals';
 import { getIcon } from '../../shared/linkUtils';
 export default function Link(props) {
-  var _RCEGlobals$getFeatur;
-
   const internalLink = { ...props.link
   };
   const [isHovering, setIsHovering] = useState(false);
@@ -43,14 +41,10 @@ export default function Link(props) {
     date_type
   } = props.link;
   const type = props.type === 'quizzes' && props.link.quiz_type === 'quizzes.next' ? 'quizzes.next' : props.type;
+  internalLink['data-course-type'] = type; // Only included published attr if it makes sense for the link type
 
-  if ((_RCEGlobals$getFeatur = RCEGlobals.getFeatures()) !== null && _RCEGlobals$getFeatur !== void 0 && _RCEGlobals$getFeatur.rce_ux_improvements) {
-    internalLink['data-course-type'] = type; // Only included published attr if it makes sense for the link type
-
-    const publishable = !['navigation', 'announcements'].includes(type);
-    internalLink['data-published'] = publishable ? published : null;
-  }
-
+  const publishable = !['navigation', 'announcements'].includes(type);
+  internalLink['data-published'] = publishable ? published : null;
   const Icon = getIcon(type);
   const color = published ? 'success' : 'primary';
   let dateString = null;

package/es/rce/plugins/instructure_links/components/LinkSet.js

@@ -113,7 +113,7 @@ class LinkSet extends Component {
     return /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(ScreenReaderContent, {
       id: this.describedByID
     }, formatMessage('Click to insert a link into the editor.')), /*#__PURE__*/React.createElement(List, {
-      variant: "unstyled",
+      isUnstyled: true,
       as: "ul",
       margin: "0"
     }, this.props.collection.links.map((link, index, array) => {
@@ -137,18 +137,14 @@ class LinkSet extends Component {
   }
 
   renderEmptyIndicator() {
-    var _RCEGlobals$getFeatur, _this$props$searchStr;
+    var _this$props$searchStr;
 
-    return (_RCEGlobals$getFeatur = RCEGlobals.getFeatures()) !== null && _RCEGlobals$getFeatur !== void 0 && _RCEGlobals$getFeatur.improved_no_results_messaging ? /*#__PURE__*/React.createElement(NoResults, {
+    return /*#__PURE__*/React.createElement(NoResults, {
       contextType: this.props.contextType,
       contextId: this.props.contextId,
       collectionType: this.props.type,
       isSearchResult: ((_this$props$searchStr = this.props.searchString) === null || _this$props$searchStr === void 0 ? void 0 : _this$props$searchStr.length) >= 3
-    }) : /*#__PURE__*/React.createElement(View, {
-      as: "div",
-      role: "alert",
-      padding: "medium"
-    }, formatMessage('No results.'));
+    });
   }
 
   renderLoadingError() {