@instructure/canvas-rce 5.6.0 → 5.6.1

package/lib/rce/plugins/instructure_documents/components/Link.js

@@ -111,7 +111,7 @@ export default function Link(props) {
     return callback;
   }
 
-  function dateOrMessage(dateString) {
+  function dateOrMessage(str) {
     if (disabled && disabledMessage) {
       return /*#__PURE__*/React.createElement(View, {
         display: "block"
@@ -122,10 +122,10 @@ export default function Link(props) {
       }, disabledMessage)));
     }
 
-    if (dateString) {
+    if (str) {
       return /*#__PURE__*/React.createElement(View, {
         as: "div"
-      }, dateString);
+      }, str);
     }
   }
 
@@ -179,8 +179,8 @@ export default function Link(props) {
     size: "x-small",
     inline: false
   }) : null), /*#__PURE__*/React.createElement(Flex.Item, {
-    grow: true,
-    shrink: true
+    shouldGrow: true,
+    shouldShrink: true
   }, /*#__PURE__*/React.createElement(Flex, null, /*#__PURE__*/React.createElement(Flex.Item, {
     padding: "0 x-small 0 0"
   }, /*#__PURE__*/React.createElement(Text, {
@@ -189,8 +189,8 @@ export default function Link(props) {
     size: "x-small"
   }))), /*#__PURE__*/React.createElement(Flex.Item, {
     padding: "0 x-small 0 0",
-    grow: true,
-    shrink: true,
+    shouldGrow: true,
+    shouldShrink: true,
     textAlign: "start"
   }, /*#__PURE__*/React.createElement(View, {
     as: "div",

package/lib/rce/plugins/instructure_equation/EquationEditorToolbar/index.js

@@ -64,8 +64,6 @@ function EquationEditorToolbar(props) {
     }, /*#__PURE__*/React.createElement(IconButton, {
       onClick: () => props.executeCommand(command, advancedCommand),
       renderIcon: icon,
-      withBackground: false,
-      withBorder: false,
       screenReaderLabel: `${label}, LaTeX: ${name}`
     }));
   }));

package/lib/rce/plugins/instructure_external_tools/components/LtiToolsModal/ExpandoText.js

@@ -44,7 +44,7 @@ export default function ExpandoText(props) {
     padding: "none none none xx-small",
     "aria-expanded": descExpanded,
     borderRadius: "medium",
-    focused: focused,
+    withFocusOutline: focused,
     onClick: () => {
       setDescExpanded(!descExpanded);
     },

package/lib/rce/plugins/instructure_external_tools/components/LtiToolsModal/LtiTool.js

@@ -32,7 +32,7 @@ export default function LtiTool(props) {
   } = props;
   return /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(View, {
     as: "span",
-    focused: focused,
+    withFocusOutline: focused,
     className: css(styles.appButton),
     padding: "xxx-small xxx-small xx-small",
     borderRadius: "medium",

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageCropper/Modal.js

@@ -68,17 +68,13 @@ const renderBody = (settings, dispatch, message, loading) => {
   })));
 };
 
-const renderFooter = (settings, onSubmit, onClose) => {
+const renderFooter = (settings, onClose) => {
   return /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(Button, {
     onClick: onClose,
     margin: "0 x-small 0 0"
   }, formatMessage('Cancel')), /*#__PURE__*/React.createElement(Button, {
     color: "primary",
-    type: "submit",
-    onClick: e => {
-      e.preventDefault();
-      handleSubmit(onSubmit, settings).then(onClose).catch(onClose);
-    }
+    type: "submit"
   }, formatMessage('Save')));
 };
 
@@ -106,9 +102,16 @@ export const ImageCropperModal = _ref => {
     });
   }, [cropSettings]);
   return /*#__PURE__*/React.createElement(Modal, {
+    "data-mce-component": true,
+    as: "form",
+    label: formatMessage('Crop Image'),
     size: "large",
     open: open,
     onDismiss: onClose,
+    onSubmit: e => {
+      e.preventDefault();
+      handleSubmit(onSubmit, settings).then(onClose).catch(onClose);
+    },
     shouldCloseOnDocumentClick: false
   }, /*#__PURE__*/React.createElement(Modal.Header, {
     id: "imageCropperHeader"
@@ -116,10 +119,10 @@ export const ImageCropperModal = _ref => {
     placement: "end",
     offset: "small",
     onClick: onClose,
-    screenReaderLabel: "Close"
+    screenReaderLabel: formatMessage('Close')
   }), /*#__PURE__*/React.createElement(Heading, null, formatMessage('Crop Image'))), /*#__PURE__*/React.createElement(Modal.Body, null, renderBody(settings, dispatch, message, loading)), !loading && /*#__PURE__*/React.createElement(Modal.Footer, {
     id: "imageCropperFooter"
-  }, renderFooter(settings, onSubmit, onClose)));
+  }, renderFooter(settings, onClose)));
 };
 ImageCropperModal.propTypes = {
   image: PropTypes.string.isRequired,

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageCropper/Preview.js

@@ -15,14 +15,14 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-import React, { useRef, useEffect } from 'react';
+import React, { useEffect, createRef } from 'react';
 import PropTypes from 'prop-types';
 import formatMessage from '../../../../../../format-message';
 import { ImageCropperSettingsPropTypes } from './propTypes';
 import { buildSvg } from './svg';
 import { PREVIEW_WIDTH, PREVIEW_HEIGHT, BACKGROUND_SQUARE_SIZE } from './constants';
 import { useMouseWheel } from './useMouseWheel';
-import { useArrowKeys } from './useArrowKeys';
+import { useKeyMouseEvents } from './useKeyMouseEvents';
 import checkerboardStyle from '../../../../shared/CheckerboardStyling';
 /**
  * Remove the node contents and append the svg element.
@@ -58,7 +58,9 @@ export const Preview = _ref2 => {
     settings,
     dispatch
   } = _ref2;
-  const shapeRef = useRef(null);
+  const previewRef = /*#__PURE__*/createRef();
+  const shapeRef = /*#__PURE__*/createRef();
+  const imgRef = /*#__PURE__*/createRef();
   const {
     image,
     shape,
@@ -68,7 +70,11 @@ export const Preview = _ref2 => {
     translateY
   } = settings;
   const [tempScaleRatio, onWheelCallback] = useMouseWheel(scaleRatio, dispatch);
-  const [tempTranslateX, tempTranslateY] = useArrowKeys(translateX, translateY, dispatch);
+  const [tempTranslateX, tempTranslateY, onMouseDownCallback] = useKeyMouseEvents(translateX, translateY, dispatch, imgRef);
+  useEffect(() => {
+    imgRef.current.ondragstart = () => false; // eslint-disable-next-line react-hooks/exhaustive-deps
+
+  }, []);
   useEffect(() => {
     const svg = buildSvg(shape);
     replaceSvg(svg, shapeRef.current);
@@ -81,7 +87,11 @@ export const Preview = _ref2 => {
   });
   return /*#__PURE__*/React.createElement("div", {
     id: "cropper-preview",
+    ref: previewRef,
     style: {
+      display: 'flex',
+      justifyContent: 'center',
+      alignItems: 'center',
       position: 'relative',
       width: `${PREVIEW_WIDTH}px`,
       height: `${PREVIEW_HEIGHT}px`,
@@ -93,25 +103,24 @@ export const Preview = _ref2 => {
     onWheel: onWheelCallback
   }, /*#__PURE__*/React.createElement("img", {
     src: image,
+    ref: imgRef,
     alt: formatMessage('Image to crop'),
     style: {
-      position: 'absolute',
-      top: 0,
-      left: 0,
       height: '100%',
-      width: '100%',
       objectFit: 'contain',
       textAlign: 'center',
       transform: transformValue
-    }
+    },
+    onMouseDown: e => onMouseDownCallback(e, previewRef.current)
   }), /*#__PURE__*/React.createElement("div", {
     id: "cropShapeContainer",
+    ref: shapeRef,
     style: {
       position: 'absolute',
       top: 0,
-      left: 0
-    },
-    ref: shapeRef
+      left: 0,
+      pointerEvents: 'none'
+    }
   }));
 };
 Preview.propTypes = {

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageCropper/controls/ResetControls.js

@@ -0,0 +1,38 @@
+/*
+ * Copyright (C) 2022 - present Instructure, Inc.
+ *
+ * This file is part of Canvas.
+ *
+ * Canvas is free software: you can redistribute it and/or modify it under
+ * the terms of the GNU Affero General Public License as published by the Free
+ * Software Foundation, version 3 of the License.
+ *
+ * Canvas is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+ * A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU Affero General Public License along
+ * with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Flex } from '@instructure/ui-flex';
+import { Button } from '@instructure/ui-buttons';
+import { IconResetLine } from '@instructure/ui-icons';
+import formatMessage from '../../../../../../../format-message';
+export const ResetControls = _ref => {
+  let {
+    onReset
+  } = _ref;
+  return /*#__PURE__*/React.createElement(Flex.Item, null, /*#__PURE__*/React.createElement(Button, {
+    renderIcon: IconResetLine,
+    onClick: onReset
+  }, formatMessage('Reset')));
+};
+ResetControls.propTypes = {
+  onReset: PropTypes.func
+};
+ResetControls.defaultProps = {
+  onReset: () => {}
+};

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageCropper/controls/RotationControls.js

@@ -20,6 +20,7 @@ import PropTypes from 'prop-types';
 import { IconButton } from '@instructure/ui-buttons';
 import { IconRotateLeftLine, IconRotateRightLine } from '@instructure/ui-icons';
 import { Flex } from '@instructure/ui-flex';
+import { View } from '@instructure/ui-view';
 import { CustomNumberInput } from './CustomNumberInput';
 import { calculateRotation, getNearestRectAngle } from './utils';
 import { BUTTON_ROTATION_DEGREES } from '../constants';
@@ -54,7 +55,13 @@ export const RotationControls = _ref => {
 
   const rotateRightCallback = () => onChange(calculateRotation(getNearestRectAngle(rotation, false) + BUTTON_ROTATION_DEGREES));
 
-  return /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(Flex.Item, {
+  return /*#__PURE__*/React.createElement(Flex.Item, {
+    margin: "0 medium 0 0",
+    title: formatMessage('Rotation'),
+    role: "toolbar",
+    tabindex: "-1"
+  }, /*#__PURE__*/React.createElement(View, {
+    display: "inline-block",
     margin: "0 small 0 0"
   }, /*#__PURE__*/React.createElement(CustomNumberInput, {
     value: rotation,
@@ -63,17 +70,14 @@ export const RotationControls = _ref => {
     processValueCallback: calculateRotation,
     placeholder: formatMessage('Rotation'),
     onChange: value => onChange(value)
-  })), /*#__PURE__*/React.createElement(Flex.Item, {
-    margin: "0 small 0 0"
-  }, /*#__PURE__*/React.createElement(IconButton, {
+  })), /*#__PURE__*/React.createElement(IconButton, {
+    margin: "0 small 0 0",
     onClick: rotateLeftCallback,
     screenReaderLabel: formatMessage('Rotate image -90 degrees')
-  }, /*#__PURE__*/React.createElement(IconRotateLeftLine, null))), /*#__PURE__*/React.createElement(Flex.Item, {
-    margin: "0 medium 0 0"
-  }, /*#__PURE__*/React.createElement(IconButton, {
+  }, /*#__PURE__*/React.createElement(IconRotateLeftLine, null)), /*#__PURE__*/React.createElement(IconButton, {
     onClick: rotateRightCallback,
     screenReaderLabel: formatMessage('Rotate image 90 degrees')
-  }, /*#__PURE__*/React.createElement(IconRotateRightLine, null))));
+  }, /*#__PURE__*/React.createElement(IconRotateRightLine, null)));
 };
 RotationControls.propTypes = {
   rotation: PropTypes.number,

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageCropper/controls/ShapeControls.js

@@ -16,10 +16,10 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 import React from 'react';
+import PropTypes from 'prop-types';
 import { Flex } from '@instructure/ui-flex';
 import formatMessage from '../../../../../../../format-message';
 import { SimpleSelect } from '@instructure/ui-simple-select';
-import PropTypes from 'prop-types';
 import { ZoomControls } from './ZoomControls';
 import { Shape } from '../../../../svg/shape';
 const SHAPE_OPTIONS = [{

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageCropper/controls/ZoomControls.js

@@ -19,6 +19,7 @@ import React from 'react';
 import { IconButton } from '@instructure/ui-buttons';
 import { IconZoomInLine, IconZoomOutLine } from '@instructure/ui-icons';
 import { Flex } from '@instructure/ui-flex';
+import { View } from '@instructure/ui-view';
 import { calculateScaleRatio, calculateScalePercentage } from './utils';
 import round from '../../../../utils/round';
 import { MAX_SCALE_RATIO, MIN_SCALE_RATIO, BUTTON_SCALE_STEP } from '../constants';
@@ -74,7 +75,12 @@ export const ZoomControls = _ref => {
     onZoomChange(newScaleRatio);
   };
 
-  return /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(Flex.Item, {
+  return /*#__PURE__*/React.createElement(Flex.Item, {
+    title: formatMessage('Zoom'),
+    role: "toolbar",
+    tabindex: "-1"
+  }, /*#__PURE__*/React.createElement(View, {
+    display: "inline-block",
     margin: "0 small 0 0"
   }, /*#__PURE__*/React.createElement(CustomNumberInput, {
     value: round(scaleRatio * 100),
@@ -83,17 +89,17 @@ export const ZoomControls = _ref => {
     processValueCallback: calculateScalePercentage,
     placeholder: formatMessage('Zoom'),
     onChange: value => onZoomChange(round(value / 100))
-  })), /*#__PURE__*/React.createElement(Flex.Item, {
-    margin: "0 small 0 0"
-  }, /*#__PURE__*/React.createElement(IconButton, {
+  })), /*#__PURE__*/React.createElement(IconButton, {
+    margin: "0 small 0 0",
     onClick: zoomOutCallback,
     interaction: scaleRatio > MIN_SCALE_RATIO ? 'enabled' : 'disabled',
     screenReaderLabel: formatMessage('Zoom out image')
-  }, /*#__PURE__*/React.createElement(IconZoomOutLine, null))), /*#__PURE__*/React.createElement(Flex.Item, null, /*#__PURE__*/React.createElement(IconButton, {
+  }, /*#__PURE__*/React.createElement(IconZoomOutLine, null)), /*#__PURE__*/React.createElement(IconButton, {
+    "data-testid": "zoom-in-button",
     onClick: zoomInCallback,
     interaction: scaleRatio < MAX_SCALE_RATIO ? 'enabled' : 'disabled',
     screenReaderLabel: formatMessage('Zoom in image')
-  }, /*#__PURE__*/React.createElement(IconZoomInLine, null))));
+  }, /*#__PURE__*/React.createElement(IconZoomInLine, null)));
 };
 ZoomControls.propTypes = {
   scaleRatio: PropTypes.number,

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageCropper/controls/index.js

@@ -21,6 +21,7 @@ import { actions } from '../../../../reducers/imageCropper';
 import { ZoomControls } from './ZoomControls';
 import { RotationControls } from './RotationControls';
 import { ShapeControls } from './ShapeControls';
+import { ResetControls } from './ResetControls';
 export const Controls = _ref => {
   let {
     settings,
@@ -30,7 +31,8 @@ export const Controls = _ref => {
     id: "imageCropperControls",
     direction: "row",
     margin: "x-small",
-    alignItems: "start"
+    alignItems: "start",
+    role: "group"
   }, /*#__PURE__*/React.createElement(ShapeControls, {
     shape: settings.shape,
     onChange: shape => dispatch({
@@ -49,5 +51,11 @@ export const Controls = _ref => {
       type: actions.SET_SCALE_RATIO,
       payload: scaleRatio
     })
+  }), /*#__PURE__*/React.createElement(Flex.Item, {
+    shouldGrow: true
+  }), /*#__PURE__*/React.createElement(ResetControls, {
+    onReset: () => dispatch({
+      type: actions.RESET_SETTINGS
+    })
   }));
 };

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageCropper/{useArrowKeys.js → useKeyMouseEvents.js}

@@ -23,31 +23,12 @@ import round from '../../../utils/round';
 import { KEY_EVENT_DELAY, KEY_EVENT_STEP } from './constants';
 import { actions } from '../../../reducers/imageCropper';
 const EVENT_EXCEPTION_ELEMENT_IDS = ['imageCropperHeader', 'imageCropperFooter', 'imageCropperControls'];
-export function useArrowKeys(translateX, translateY, dispatch) {
-  const [tempTranslateX, _setTempTranslateX] = useState(translateX);
-  const [tempTranslateY, _setTempTranslateY] = useState(translateY);
-  const [isMoving, setIsMoving] = useState(false); // These are used to get the current values when the callback is called from outside.
-
-  const tempTranslateXRef = useRef(tempTranslateX);
-  const tempTranslateYRef = useRef(tempTranslateY); // Refs that manage the keydown acceleration
 
+function useKeysEvents(tempTranslateXRef, tempTranslateYRef, tempTranslateX, tempTranslateY, setTempTranslateX, setTempTranslateY, isMoving, setIsMoving) {
+  // Refs that manage the keydown acceleration
   const direction = useRef(0);
   const elapsedTime = useRef(0);
 
-  const setTempTranslateX = data => {
-    setIsMoving(true);
-    tempTranslateXRef.current = data;
-
-    _setTempTranslateX(data);
-  };
-
-  const setTempTranslateY = data => {
-    setIsMoving(true);
-    tempTranslateYRef.current = data;
-
-    _setTempTranslateY(data);
-  };
-
   const onKeyDownCallback = event => {
     var _context, _context2, _context3;
 
@@ -111,11 +92,81 @@ export function useArrowKeys(translateX, translateY, dispatch) {
     }; // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
   useEffect(() => {
-    if (isMoving) {
+    if (isMoving && direction.current !== 0) {
       stopMovementCallback();
     } // eslint-disable-next-line react-hooks/exhaustive-deps
 
-  }, [tempTranslateX, tempTranslateY]); // Updates the reducer state when user stops moving.
+  }, [tempTranslateX, tempTranslateY]);
+}
+
+function useMouseEvents(tempTranslateX, tempTranslateY, setTempTranslateX, setTempTranslateY, setIsMoving) {
+  const initialPageX = useRef(0);
+  const initialPageY = useRef(0);
+  const mouseDown = useRef(false);
+  const imgElement = useRef(null);
+  const containerElement = useRef(null);
+
+  const stoppedMovingCallback = () => {
+    mouseDown.current = false;
+    initialPageX.current = 0;
+    initialPageY.current = 0;
+    imgElement.current.onmousemove = null;
+    imgElement.current.onmouseup = null;
+    imgElement.current = null;
+    containerElement.current.onmouseout = null;
+    containerElement.current = null;
+    setIsMoving(false);
+  };
+
+  const startedMovingCallback = (target, clientX, clientY, container) => {
+    mouseDown.current = true;
+    initialPageX.current = clientX;
+    initialPageY.current = clientY;
+    target.onmousemove = onMouseMoveCallback;
+    target.onmouseup = stoppedMovingCallback;
+    imgElement.current = target; // Should stop the movement when mouse leaves the preview
+
+    container.onmouseout = stoppedMovingCallback;
+    containerElement.current = container;
+    setIsMoving(true);
+  };
+
+  const onMouseMoveCallback = e => {
+    if (!mouseDown.current) {
+      return stoppedMovingCallback();
+    }
+
+    setTempTranslateX(tempTranslateX + e.clientX - initialPageX.current);
+    setTempTranslateY(tempTranslateY + e.clientY - initialPageY.current);
+  };
+
+  return (e, container) => startedMovingCallback(e.target, e.clientX, e.clientY, container);
+}
+
+export function useKeyMouseEvents(translateX, translateY, dispatch, imgRef) {
+  const [tempTranslateX, _setTempTranslateX] = useState(translateX);
+  const [tempTranslateY, _setTempTranslateY] = useState(translateY);
+  const [isMoving, setIsMoving] = useState(false); // These are used to get the current values when the callback is called from outside.
+
+  const tempTranslateXRef = useRef(tempTranslateX);
+  const tempTranslateYRef = useRef(tempTranslateY);
+
+  const setTempTranslateX = data => {
+    setIsMoving(true);
+    tempTranslateXRef.current = data;
+
+    _setTempTranslateX(data);
+  };
+
+  const setTempTranslateY = data => {
+    setIsMoving(true);
+    tempTranslateYRef.current = data;
+
+    _setTempTranslateY(data);
+  };
+
+  useKeysEvents(tempTranslateXRef, tempTranslateYRef, tempTranslateX, tempTranslateY, setTempTranslateX, setTempTranslateY, isMoving, setIsMoving);
+  const onMouseDownCallback = useMouseEvents(tempTranslateX, tempTranslateY, setTempTranslateX, setTempTranslateY, setIsMoving); // Updates the reducer state when user stops moving.
 
   useEffect(() => {
     if (isMoving) {
@@ -144,13 +195,17 @@ export function useArrowKeys(translateX, translateY, dispatch) {
     }
 
     if (translateX !== tempTranslateX) {
-      setTempTranslateX(translateX);
+      tempTranslateXRef.current = translateX;
+
+      _setTempTranslateX(translateX);
     }
 
     if (translateY !== tempTranslateY) {
-      setTempTranslateY(translateY);
+      tempTranslateYRef.current = translateY;
+
+      _setTempTranslateY(translateY);
     } // eslint-disable-next-line react-hooks/exhaustive-deps
 
   }, [translateX, translateY]);
-  return [tempTranslateX, tempTranslateY, onKeyDownCallback];
+  return [tempTranslateX, tempTranslateY, onMouseDownCallback];
 }

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageSection/Course.js

@@ -23,9 +23,24 @@ import { useStoreProps } from '../../../../shared/StoreContext';
 import useDataUrl from '../../../../shared/useDataUrl';
 import { actions } from '../../../reducers/imageSection';
 import { canCompressImage, compressImage, shouldCompressImage } from './compressionUtils';
+import { isAnUnsupportedGifPngImage, MAX_GIF_PNG_SIZE_BYTES } from './utils';
+import { actions as svgActions } from '../../../reducers/svgSettings';
+import formatMessage from '../../../../../../format-message';
 
-const dispatchImage = async (dispatch, dataUrl, dataBlob) => {
+const dispatchImage = async (dispatch, onChange, dataUrl, dataBlob) => {
   let image = dataUrl;
+
+  if (isAnUnsupportedGifPngImage(dataBlob)) {
+    dispatch({ ...actions.CLEAR_IMAGE
+    });
+    return onChange({
+      type: svgActions.SET_ERROR,
+      payload: formatMessage('GIF/PNG format images larger than {size} KB are not currently supported.', {
+        size: MAX_GIF_PNG_SIZE_BYTES / 1024
+      })
+    });
+  }
+
   dispatch({ ...actions.SET_IMAGE,
     payload: ''
   });
@@ -56,6 +71,7 @@ const dispatchImage = async (dispatch, dataUrl, dataBlob) => {
 const Course = _ref => {
   let {
     dispatch,
+    onChange,
     onLoading,
     onLoaded
   } = _ref;
@@ -77,7 +93,7 @@ const Course = _ref => {
   useEffect(() => {
     // Don't clear the current image on re-render
     if (!dataUrl || !dataBlob) return;
-    dispatchImage(dispatch, dataUrl, dataBlob); // eslint-disable-next-line react-hooks/exhaustive-deps
+    dispatchImage(dispatch, onChange, dataUrl, dataBlob); // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [dataUrl, dataBlob]); // Handle loading states
 
   useEffect(() => {
@@ -124,11 +140,13 @@ const Course = _ref => {
 
 Course.propTypes = {
   dispatch: PropTypes.func,
+  onChange: PropTypes.func,
   onLoading: PropTypes.func,
   onLoaded: PropTypes.func
 };
 Course.defaultProps = {
   dispatch: () => {},
+  onChange: () => {},
   onLoading: () => {},
   onLoaded: () => {}
 };

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageSection/ImageOptions.js

@@ -141,7 +141,7 @@ ImageOptions.propTypes = {
     loading: PropTypes.bool.isRequired,
     cropperOpen: PropTypes.bool.isRequired,
     cropperSettings: ImageCropperSettingsPropTypes,
-    compressed: PropTypes.string
+    compressed: PropTypes.bool.isRequired
   }).isRequired,
   dispatch: PropTypes.func.isRequired,
   rcsConfig: PropTypes.object.isRequired

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageSection/ImageSection.js

@@ -219,6 +219,7 @@ export const ImageSection = _ref => {
     dispatch: dispatch,
     editor: editor,
     data: state,
+    onChange: onChange,
     onLoading: scrollToBottom,
     onLoaded: scrollToBottom
   }))), state.icon && state.mode === modes.singleColorImages.type && /*#__PURE__*/React.createElement(Flex.Item, {

package/lib/rce/plugins/instructure_icon_maker/components/CreateIconMakerForm/ImageSection/Upload.js

@@ -16,10 +16,13 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 import React from 'react';
+import PropTypes from 'prop-types';
 import formatMessage from '../../../../../../format-message';
 import { actions } from '../../../reducers/imageSection';
+import { actions as svgActions } from '../../../reducers/svgSettings';
 import { UploadFile } from '../../../../shared/Upload/UploadFile';
 import { canCompressImage, compressImage, shouldCompressImage } from './compressionUtils';
+import { isAnUnsupportedGifPngImage, MAX_GIF_PNG_SIZE_BYTES } from './utils';
 
 function dispatchCompressedImage(theFile, dispatch) {
   dispatch({ ...actions.SET_IMAGE,
@@ -53,11 +56,23 @@ function dispatchCompressedImage(theFile, dispatch) {
   });
 }
 
-export const onSubmit = dispatch => (_editor, _accept, _selectedPanel, uploadData) => {
+export const onSubmit = (dispatch, onChange) => (_editor, _accept, _selectedPanel, uploadData) => {
   const {
     theFile
   } = uploadData;
 
+  if (isAnUnsupportedGifPngImage(theFile)) {
+    dispatch({ ...actions.SET_IMAGE_COLLECTION_OPEN,
+      payload: false
+    });
+    return onChange({
+      type: svgActions.SET_ERROR,
+      payload: formatMessage('GIF/PNG format images larger than {size} KB are not currently supported.', {
+        size: MAX_GIF_PNG_SIZE_BYTES / 1024
+      })
+    });
+  }
+
   if (canCompressImage() && shouldCompressImage(theFile)) {
     return dispatchCompressedImage(theFile, dispatch);
   }
@@ -79,7 +94,8 @@ export const onSubmit = dispatch => (_editor, _accept, _selectedPanel, uploadDat
 const Upload = _ref => {
   let {
     editor,
-    dispatch
+    dispatch,
+    onChange
   } = _ref;
   return /*#__PURE__*/React.createElement(UploadFile, {
     accept: "image/*",
@@ -90,8 +106,17 @@ const Upload = _ref => {
       dispatch(actions.CLEAR_MODE);
     },
     requireA11yAttributes: false,
-    onSubmit: onSubmit(dispatch)
+    onSubmit: onSubmit(dispatch, onChange)
   });
 };
 
+Upload.propTypes = {
+  editor: PropTypes.object.isRequired,
+  dispatch: PropTypes.func,
+  onChange: PropTypes.func
+};
+Upload.defaultProps = {
+  dispatch: () => {},
+  onChange: () => {}
+};
 export default Upload;