@instructure/canvas-rce 5.14.1 → 5.15.0

package/es/rce/plugins/instructure_links/plugin.js

@@ -1,5 +1,3 @@
-// @ts-nocheck
-
 /*
  * Copyright (C) 2019 - present Instructure, Inc.
  *
@@ -62,6 +60,7 @@
  *         href with the new URL.  if the link text is updated, replace the link's
  *         content with the new plain text (deleting the image)
  */
+
 import formatMessage from '../../../format-message';
 import clickCallback from './clickCallback';
 import bridge from '../../../bridge';
@@ -72,23 +71,17 @@ import tinymce from 'tinymce';
 const trayController = new LinkOptionsTrayController();
 const COURSE_PLUGIN_KEY = 'course_links';
 const GROUP_PLUGIN_KEY = 'group_links';
-
 function getCommandName(selectedNode) {
   const isCourseLink = selectedNode.getAttribute('data-course-type');
   return isCourseLink ? 'instructureTrayForCourseLinks' : 'instructureTrayToEditLink';
 }
-
 function selectedAnchorCount(ed) {
   return ed.selection.getRng().cloneContents().querySelectorAll('a').length;
 }
-
 function getMenuItems(ed) {
-  var _ed$settings$canvas_r;
-
-  const contextType = (_ed$settings$canvas_r = ed.settings.canvas_rce_containing_context) === null || _ed$settings$canvas_r === void 0 ? void 0 : _ed$settings$canvas_r.type;
+  const contextType = ed.settings.canvas_rce_containing_context?.type;
   const sel_anchors = ed.selection.isCollapsed() ? 0 : selectedAnchorCount(ed);
   let items;
-
   if (getAnchorElement(ed, ed.selection.getNode())) {
     // cursor is on an anchor, edit or remove it
     items = [{
@@ -103,7 +96,6 @@ function getMenuItems(ed) {
       text: formatMessage('External Link'),
       value: 'instructureLinkCreate'
     }];
-
     if (contextType === 'course') {
       items.push({
         text: formatMessage('Course Link'),
@@ -115,7 +107,6 @@ function getMenuItems(ed) {
         value: 'instructure_group_links'
       });
     }
-
     if (sel_anchors > 0) {
       // selection contains anchor(s), so the user can remove them
       items.push({
@@ -127,10 +118,8 @@ function getMenuItems(ed) {
       });
     }
   }
-
   return items;
 }
-
 function removeAnchorFromSelectedElement(ed) {
   const selectedElem = ed.selection.getNode();
   const anchorElem = getAnchorElement(ed, selectedElem);
@@ -138,7 +127,6 @@ function removeAnchorFromSelectedElement(ed) {
   ed.undoManager.add();
   ed.execCommand('Unlink');
 }
-
 function doMenuItem(ed, actionName) {
   switch (actionName) {
     case 'instructureTrayToEditLink':
@@ -146,30 +134,23 @@ function doMenuItem(ed, actionName) {
     case 'instructureLinkCreate':
       ed.execCommand(actionName);
       break;
-
     case 'instructureUnlink':
       removeAnchorFromSelectedElement(ed);
       break;
-
     case 'instructureUnlinkAll':
       ed.undoManager.add();
       ed.execCommand('unlink');
       break;
-
     case 'instructure_course_links':
       ed.focus(true); // activate the editor without changing focus
-
       ed.execCommand('instructureTrayForLinks', false, COURSE_PLUGIN_KEY);
       break;
-
     case 'instructure_group_links':
       ed.focus(true); // activate the editor without changing focus
-
       ed.execCommand('instructureTrayForLinks', false, GROUP_PLUGIN_KEY);
       break;
   }
 }
-
 tinymce.PluginManager.add('instructure_links', function (ed) {
   // Register commands
   ed.addCommand('instructureLinkCreate', () => clickCallback(ed, CREATE_LINK));
@@ -183,10 +164,12 @@ tinymce.PluginManager.add('instructure_links', function (ed) {
   ed.addCommand('instructureTrayForCourseLinks', () => {
     ed.selection.select(ed.selection.getNode());
     return bridge.showTrayForPlugin('course_link_edit', ed.id);
-  }); // Register shortcuts
+  });
 
-  ed.addShortcut('Meta+K', '', 'instructureLinkCreate'); // Register menu item
+  // Register shortcuts
+  ed.addShortcut('Meta+K', '', 'instructureLinkCreate');
 
+  // Register menu item
   ed.ui.registry.addNestedMenuItem('instructure_links', {
     text: formatMessage('Link'),
     icon: 'link',
@@ -201,8 +184,9 @@ tinymce.PluginManager.add('instructure_links', function (ed) {
         }
       };
     })
-  }); // Register toolbar button
+  });
 
+  // Register toolbar button
   ed.ui.registry.addMenuButton('instructure_links', {
     tooltip: formatMessage('Links'),
     icon: 'link',
@@ -212,52 +196,43 @@ tinymce.PluginManager.add('instructure_links', function (ed) {
       value: item.value,
       onAction: () => doMenuItem(ed, item.value)
     }))),
-
     onSetup(api) {
+      // @ts-expect-error
       function handleNodeChange(e) {
-        if (e !== null && e !== void 0 && e.element) {
+        if (e?.element) {
           api.setActive(!!getAnchorElement(ed, e.element));
         }
+        if (ed.selection) {
+          api.setDisabled(!isOKToLink(ed.selection.getContent()));
+        }
+      }
 
-        api.setDisabled(!isOKToLink(ed.selection.getContent()));
-      } // if the user selects all the content w/in a link and deletes it via the keyboard
+      // if the user selects all the content w/in a link and deletes it via the keyboard
       // make sure the surrounding <a> gets deleted too.
-
-
       function deleteEmptyLink() {
         let node = null;
-
         if (ed.selection.getNode().tagName === 'A') {
           node = ed.selection.getNode();
         } else {
-          var _rng$endContainer$nex, _rng$nextSibling;
-
           // Type checking is disabled here because the code below isn't type safe. The code below
           // should be updated, specifically rng.endContainer.nextSibling?.tagName
           const rng = ed.selection.getRng();
-
-          if (rng.commonAncestorContainer === rng.endContainer && ((_rng$endContainer$nex = rng.endContainer.nextSibling) === null || _rng$endContainer$nex === void 0 ? void 0 : _rng$endContainer$nex.tagName) === 'A') {
+          if (rng.commonAncestorContainer === rng.endContainer && rng.endContainer.nextSibling?.tagName === 'A') {
             node = rng.endContainer.nextSibling;
-          } else if (((_rng$nextSibling = rng.nextSibling) === null || _rng$nextSibling === void 0 ? void 0 : _rng$nextSibling.tagName) === 'A') {
+          } else if (rng.nextSibling?.tagName === 'A') {
             node = rng.nextSibling;
           }
         }
-
         if (node) {
-          var _node$textContent;
-
           if (node.firstElementChild) {
             return;
           }
-
-          const txt = (_node$textContent = node.textContent) === null || _node$textContent === void 0 ? void 0 : _node$textContent.trim();
-
-          if ((txt === null || txt === void 0 ? void 0 : txt.length) === 0) {
+          const txt = node.textContent?.trim();
+          if (txt?.length === 0) {
             ed.execCommand('Unlink');
           }
         }
       }
-
       setTimeout(handleNodeChange, 0, null);
       ed.on('NodeChange', handleNodeChange);
       ed.on('Change', deleteEmptyLink);
@@ -266,14 +241,14 @@ tinymce.PluginManager.add('instructure_links', function (ed) {
         ed.off('Change', deleteEmptyLink);
       };
     }
+  });
 
-  }); // the context toolbar buttons
-
+  // the context toolbar buttons
   ed.ui.registry.addButton('instructure-link-options', {
-    onAction() {
+    onAction(/* buttonApi */
+    ) {
       ed.execCommand(getCommandName(ed.selection.getNode()), false, ed);
     },
-
     text: formatMessage('Link Options'),
     tooltip: formatMessage('Show link options')
   });
@@ -282,7 +257,6 @@ tinymce.PluginManager.add('instructure_links', function (ed) {
     onAction() {
       removeAnchorFromSelectedElement(ed);
     },
-
     text: remButtonLabel
   });
   ed.ui.registry.addContextToolbar('instructure-link-toolbar', {

package/es/rce/plugins/instructure_links/validateURL.js

@@ -15,56 +15,101 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-import { parse } from 'url';
-import formatMessage from '../../../format-message'; // keep in sync with the protocols permitted for <a href>
-// as listed in gems/canvas_sanitize/lib/canvas_sanitize/canvas_sanitize.rb
 
-const allowed_protocols = ['ftp:', 'http:', 'https:', 'mailto:', 'tel:', 'skype:']; // weakly validate a url
-// return true if valid
-// return false if not valid yet, but incomplete
-// throw an Error if invalid
+import formatMessage from '../../../format-message';
 
+// Keep in sync with the protocols permitted for <a href>
+//   as listed in gems/canvas_sanitize/lib/canvas_sanitize/canvas_sanitize.rb
+const allowed_protocols = ['ftp:', 'http:', 'https:', 'mailto:', 'tel:', 'skype:'];
+
+/**
+ * Weakly validate a URL
+ * @param {string} url URL to validate
+ * @returns {boolean} true if valid, false if not valid yet, but incomplete, throws if invalid
+ */
 export default function validateURL(url) {
   const href = url.trim();
-  const parsed = parse(href, false, true);
-  const protocol = parsed.protocol;
 
-  if (!protocol) {
-    if (parsed.href[0] === ':') {
-      // ":anything" is invalid
-      // need this check as an artifact of parse(href)
+  // Handle special cases for partial URLs
+  if (href === '' || href === 'mailto:' || href === 'tel:' || href === 'skype:') {
+    return false;
+  }
+  if (/^\/\/$/.test(href)) {
+    return false;
+  }
+  try {
+    // Handle URLs starting with :// (invalid protocol)
+    if (href.startsWith('://')) {
       throw new Error(formatMessage('Protocol must be ftp, http, https, mailto, skype, tel or may be omitted'));
     }
 
-    if (/^\/\/$/.test(href)) {
-      // "//" by itself is not a URL yet
-      return false;
-    }
-  } else if (protocol) {
-    if (!allowed_protocols.includes(protocol)) {
-      throw new Error(formatMessage('{p} is not a valid protocol which must be ftp, http, https, mailto, skype, tel or may be omitted', {
-        p: protocol.replace(/:$/, '')
-      }));
-    } // ftp, http, https require ://anything
-
+    // For URLs with protocols, we can use the URL constructor directly
+    if (/^[a-zA-Z][a-zA-Z\d+.-]*:/.test(href)) {
+      const protocol = href.substring(0, href.indexOf(':') + 1);
+      if (!allowed_protocols.includes(protocol)) {
+        throw new Error(formatMessage('{p} is not a valid protocol.', {
+          p: protocol.slice(0, -1)
+        }));
+      }
 
-    if (/(?:ftp|http|https):\/\/.+/.test(href)) {
-      return true;
-    } // allow mailto:address, skype:participant, tel:911 or
-    // mailto://address, skype://participant, tel://911,
+      // For absolute URLs with protocols that require //, validate the format
+      if (['http:', 'https:', 'ftp:'].includes(protocol) && !href.startsWith(protocol + '//')) {
+        throw new Error(formatMessage('Invalid URL'));
+      }
 
+      // Special handling for mailto:, tel:, and skype: URLs
+      if (['mailto:', 'tel:', 'skype:'].includes(protocol)) {
+        // Consider protocol:// as incomplete for these protocols
+        if (href === protocol + '//' || href === protocol + '///') {
+          return false;
+        }
+        return href.length > protocol.length;
+      }
 
-    if (/(?:mailto|skype|tel):(\/\/)?[^/].*/.test(href)) {
-      return true;
-    } // http:/xyzzy is invalid
+      // Handle partial URLs
+      if (href === protocol || href === protocol + '/' || href === protocol + '//') {
+        return false;
+      }
 
+      // Try constructing the URL to validate the format
+      try {
+        if (href.includes('//')) {
+          new URL(href);
+        }
+        return true;
+      } catch {
+        // If URL construction fails but we have more than just protocol://, consider it valid
+        // This allows for test URLs like ftp://host:port/path
+        return href.length > protocol.length + 2;
+      }
+    }
 
-    if (/^(?:ftp|http|https):\/{0,1}[^/]/.test(href)) {
-      throw new Error(formatMessage('Invalid URL'));
+    // Handle protocol-relative URLs
+    if (href.startsWith('//')) {
+      if (href === '//' || href === '///') {
+        return false;
+      }
+      try {
+        new URL('http:' + href);
+        return true;
+      } catch {
+        // If URL construction fails but we have more than just //, consider it valid
+        return href.length > 2;
+      }
     }
 
-    return false;
+    // Handle relative paths
+    return true;
+  } catch (e) {
+    if (e instanceof Error) {
+      if (e.message.includes('Invalid URL')) {
+        if (href.match(/^(https?|ftp):\/?\/?$/)) {
+          return false;
+        }
+        throw new Error(formatMessage('Invalid URL'));
+      }
+      throw e;
+    }
+    throw e;
   }
-
-  return true;
 }

package/es/rce/plugins/instructure_media_embed/clickCallback.js

@@ -15,32 +15,28 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
+
 import React from 'react';
 import ReactDOM from 'react-dom';
 import Bridge from '../../../bridge';
 export default function (ed, document) {
-  return import('./components/Embed').then(_ref => {
-    let {
-      Embed
-    } = _ref;
+  return import('./components/Embed').then(({
+    Embed
+  }) => {
     let container = document.querySelector('.canvas-rce-embed-container');
-
     if (!container) {
       container = document.createElement('div');
       container.className = 'canvas-rce-embed-container';
       document.body.appendChild(container);
     }
-
     const handleDismiss = () => {
       ReactDOM.unmountComponentAtNode(container);
       ed.focus(false);
     };
-
     const handleEmbedCode = embedCode => {
       Bridge.insertEmbedCode(embedCode);
     };
-
-    ReactDOM.render( /*#__PURE__*/React.createElement(Embed, {
+    ReactDOM.render(/*#__PURE__*/React.createElement(Embed, {
       onSubmit: handleEmbedCode,
       onDismiss: handleDismiss
     }), container);

package/es/rce/plugins/instructure_media_embed/components/Embed.js

@@ -15,6 +15,7 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
+
 import React, { useState } from 'react';
 import { Modal } from '@instructure/ui-modal';
 import formatMessage from '../../../../format-message';
@@ -22,17 +23,16 @@ import { Button, CloseButton } from '@instructure/ui-buttons';
 import { Heading } from '@instructure/ui-heading';
 import { func } from 'prop-types';
 import { TextArea } from '@instructure/ui-text-area';
-import { instuiPopupMountNode } from '../../../../util/fullscreenHelpers';
-export function Embed(_ref) {
-  let {
-    onSubmit,
-    onDismiss
-  } = _ref;
+import { instuiPopupMountNodeFn } from '../../../../util/fullscreenHelpers';
+export function Embed({
+  onSubmit,
+  onDismiss
+}) {
   const [embedCode, setEmbedCode] = useState('');
   return /*#__PURE__*/React.createElement(Modal, {
     "data-mce-component": true,
     label: formatMessage('Embed'),
-    mountNode: instuiPopupMountNode,
+    mountNode: instuiPopupMountNodeFn,
     size: "medium",
     onDismiss: onDismiss,
     open: true,

package/es/rce/plugins/instructure_media_embed/plugin.js

@@ -15,19 +15,23 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
+
 import clickCallback from './clickCallback';
 import formatMessage from '../../../format-message';
-import tinymce from 'tinymce'; // Register plugin
+import tinymce from 'tinymce';
 
+// Register plugin
 tinymce.PluginManager.add('instructure_media_embed', function (ed) {
-  ed.addCommand('instructureMediaEmbed', () => clickCallback(ed, document)); // Register menu item
+  ed.addCommand('instructureMediaEmbed', () => clickCallback(ed, document));
 
+  // Register menu item
   ed.ui.registry.addMenuItem('instructure_media_embed', {
     text: formatMessage('Embed'),
     icon: 'embed',
     onAction: () => ed.execCommand('instructureMediaEmbed')
-  }); // Register toolbar button
+  });
 
+  // Register toolbar button
   ed.ui.registry.addButton('instructure_media_embed', {
     tooltip: formatMessage('Embed'),
     icon: 'embed',

package/es/rce/plugins/instructure_paste/pasteMenuCommand.js

@@ -23,6 +23,7 @@
  * because figuring this stuff out wasn't trivial and
  * I didn't want to lose it.
  ********************************************************* */
+
 import formatMessage from '../../../format-message';
 import { showFlashAlert } from '../../../common/FlashAlert';
 export function initPasteMenuCommand(ed, handlePasteOrDrop) {
@@ -39,7 +40,6 @@ export function initPasteMenuCommand(ed, handlePasteOrDrop) {
     text: formatMessage('Paste'),
     icon: 'paste',
     onAction: () => ed.execCommand('instructurePaste'),
-
     onSetup(_api) {
       // If I add the shortcut, then it overwrites the browsers
       // built-in keyboard shortcut for paste. we don't want that
@@ -47,15 +47,12 @@ export function initPasteMenuCommand(ed, handlePasteOrDrop) {
         ed.execCommand('instructurePaste');
       });
     }
-
   });
-
   async function handlePasteMenuCommand() {
     try {
       const cbitems = await window.navigator.clipboard.read();
       const cbitem = cbitems[0];
       const imageType = cbitem.types.find(t => /^image\//.test(t));
-
       if (imageType) {
         const blob = await cbitem.getType(imageType);
         const file = new File([blob], imageType.replace('/', '.'), {
@@ -92,7 +89,6 @@ export function initPasteMenuCommand(ed, handlePasteOrDrop) {
         });
       } else {
         const textType = cbitem.types.find(t => /^text\//.test(t));
-
         if (textType) {
           const blob = await cbitem.getType(textType);
           const text = await blob.text();

package/es/rce/plugins/instructure_paste/plugin.js

@@ -1,5 +1,3 @@
-// @ts-nocheck
-
 /*
  * Copyright (C) 2022 - present Instructure, Inc.
  *
@@ -17,6 +15,7 @@
  * You should have received a copy of the GNU Affero General Public License along
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
+
 import tinymce from 'tinymce';
 import bridge from '../../../bridge';
 import configureStore from '../../../sidebar/store/configureStore';
@@ -34,7 +33,9 @@ const config = {
   session: null,
   // null: we haven't gotten it yet, false: we don't need it
   sessionPromise: null
-}; // when UploadFile renders
+};
+
+// when UploadFile renders
 // <StoreProvider {...trayProps}>
 //  {contentProps => {
 //     return (
@@ -43,18 +44,18 @@ const config = {
 // (We don't seem to have a way to grab an existing store)
 // So the configureStore and getSession logic gets repeated here for the
 // automatic file upload when pasting or dropping a file on the RCE
-
+// @ts-expect-error
 function initStore(initProps) {
   if (config.store === null) {
     config.store = configureStore(initProps);
   }
-
   if (config.session === null) {
     if (initProps.host && initProps.jwt) {
       config.sessionPromise = getSession(config.store.dispatch, config.store.getState).then(() => {
         config.session = config.store.getState().session;
-      }).catch(_err => {
-        // eslint-disable-next-line no-console
+      })
+      // @ts-expect-error
+      .catch(_err => {
         console.error('The Paste plugin failed to get canvas session data.');
       });
     } else {
@@ -63,12 +64,11 @@ function initStore(initProps) {
       config.sessionPromise = Promise.resolve();
     }
   }
-
   return config.store;
 }
-
 tinymce.PluginManager.add('instructure_paste', function (editor) {
   const store = initStore(bridge.trayProps.get(editor));
+
   /**
    * Starts the file upload (and insertion) process for the given file.
    *
@@ -76,13 +76,11 @@ tinymce.PluginManager.add('instructure_paste', function (editor) {
    *
    * @returns a promise that resolves when the user has made their choice about uploading the file
    */
-
   async function requestFileInsertion(file) {
     // it's very doubtful that we won't have retrieved the session data yet,
     // since it takes a while for the RCE to initialize, but if we haven't
     // wait until we do to carry on and finish pasting.
     await config.sessionPromise;
-
     if (config.session === null) {
       // we failed to get the session and don't know if usage rights are required in this course|group
       // In all probability, the file upload will fail too, but I feel like we have to do something here.
@@ -90,12 +88,11 @@ tinymce.PluginManager.add('instructure_paste', function (editor) {
         message: formatMessage('If Usage Rights are required, the file will not publish until enabled in the Files page.'),
         type: 'info'
       });
-    } // even though usage rights might be required by the course, canvas has no place
-    // on the user to store it. Only Group and Course.
-
+    }
 
+    // even though usage rights might be required by the course, canvas has no place
+    // on the user to store it. Only Group and Course.
     const requiresUsageRights = config.session.usageRightsRequired && /course|group/.test(bridge.trayProps.get(editor).contextType);
-
     if (requiresUsageRights) {
       return doFileUpload(editor, document, {
         accept: file.type,
@@ -114,61 +111,60 @@ tinymce.PluginManager.add('instructure_paste', function (editor) {
         domObject: file
       };
       let tabContext = 'documents';
-
       if (isImage(file.type)) {
         tabContext = 'images';
       } else if (isAudioOrVideo(file.type)) {
         tabContext = 'media';
       }
-
       store.dispatch(uploadToMediaFolder(tabContext, fileMetaProps));
       return 'submitted';
     }
   }
-
   async function handlePasteOrDrop(event) {
-    var _bridge$activeEditor, _bridge$activeEditor$, _editor$rceWrapper;
-
     const isPaste = event.type === 'paste';
     const dataTransfer = isPaste ? event.clipboardData : event.dataTransfer;
-    const files = Array.from((dataTransfer === null || dataTransfer === void 0 ? void 0 : dataTransfer.files) || []);
-    const types = (dataTransfer === null || dataTransfer === void 0 ? void 0 : dataTransfer.types) || [];
-    const isAudioVideoDisabled = (_bridge$activeEditor = bridge.activeEditor()) === null || _bridge$activeEditor === void 0 ? void 0 : (_bridge$activeEditor$ = _bridge$activeEditor.props) === null || _bridge$activeEditor$ === void 0 ? void 0 : _bridge$activeEditor$.instRecordDisabled; // delegate to tiny if there aren't any files to handle
+    const files = Array.from(dataTransfer?.files || []);
+    const types = dataTransfer?.types || [];
+    const isAudioVideoDisabled = bridge.activeEditor()?.props?.instRecordDisabled;
+
+    // delegate to tiny if there aren't any files to handle
+    if (!types.includes('Files')) return;
 
-    if (!types.includes('Files')) return; // delegate to tiny if there is Microsoft Word content, because it may contain an image
+    // delegate to tiny if there is Microsoft Word content, because it may contain an image
     // rendering of the content and we don't want to incorrectly paste the image
     // instead of the actual rich content, which TinyMCE has special handing for
+    if (isMicrosoftWordContentInEvent(event)) return;
 
-    if (isMicrosoftWordContentInEvent(event)) return; // we're pasting file(s), prevent the default tinymce pasting behavior
+    // we're pasting file(s), prevent the default tinymce pasting behavior
+    event.preventDefault();
 
-    event.preventDefault(); // Ensure the editor has focus, because downstream code requires that it does, and drag-n-drop
+    // Ensure the editor has focus, because downstream code requires that it does, and drag-n-drop
     // events can be started when the editor doesn't have focus.
+    if (!editor.hasFocus()) editor.rceWrapper?.focus();
 
-    if (!editor.hasFocus()) (_editor$rceWrapper = editor.rceWrapper) === null || _editor$rceWrapper === void 0 ? void 0 : _editor$rceWrapper.focus(); // Checking if we've encountered an issue with file processing for paste events in the browser
+    // Checking if we've encountered an issue with file processing for paste events in the browser
     // Specifically implementing due to this bug in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1699743
     // However, there could be other issues that cause this condition so it's a nice safety net regardless
-
     if (isPaste && files.some(file => file.size === 0)) {
+      // @ts-expect-error
       showFlashAlert({
         message: formatMessage('One or more files failed to paste. Please try uploading or dragging and dropping files.'),
         type: 'error'
       });
       return;
     }
-
     for (const file of files) {
       if (isAudioVideoDisabled && isAudioOrVideo(file.type)) {
         // Skip audio and video files when disabled
         continue;
-      } // This will finish once the dialog is closed, if one was created, putting this in a loop allows us
-      // to show a dialog for each file without them conflicting.
-      // eslint-disable-next-line no-await-in-loop
+      }
 
+      // This will finish once the dialog is closed, if one was created, putting this in a loop allows us
+      // to show a dialog for each file without them conflicting.
 
       await requestFileInsertion(file);
     }
   }
-
   editor.on('paste', handlePasteOrDrop);
   editor.on('drop', handlePasteOrDrop);
 });