@instantdb/core 0.22.86-experimental.split-store.20243647937.1 → 0.22.86-experimental.split-store.20247691802.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instantdb/core",
-  "version": "0.22.86-experimental.split-store.20243647937.1",
+  "version": "0.22.86-experimental.split-store.20247691802.1",
   "description": "Instant's core local abstraction",
   "homepage": "https://github.com/instantdb/instant/tree/main/client/packages/core",
   "repository": {
@@ -53,7 +53,7 @@
   "dependencies": {
     "mutative": "^1.0.10",
     "uuid": "^11.1.0",
-    "@instantdb/version": "0.22.86-experimental.split-store.20243647937.1"
+    "@instantdb/version": "0.22.86-experimental.split-store.20247691802.1"
   },
   "scripts": {
     "test": "vitest",

package/src/Reactor.js

@@ -588,8 +588,9 @@ export default class Reactor {
         const pageInfo = result?.[0]?.data?.['page-info'];
         const aggregate = result?.[0]?.data?.['aggregate'];
         const triples = extractTriples(result);
+        const attrsStore = this.ensureAttrs();
         const store = sts.createStore(
-          this.ensureAttrs(),
+          attrsStore,
           triples,
           enableCardinalityInference,
           this.config.useDateObjects,
@@ -602,7 +603,7 @@ export default class Reactor {
           }
           prev[hash].result = {
             store,
-            attrsStore: this.ensureAttrs(),
+            attrsStore,
             pageInfo,
             aggregate,
             processedTxId: msg['processed-tx-id'],

package/src/instaml.ts

@@ -162,12 +162,14 @@ function expandLink({ attrsStore }: Ctx, [etype, eidA, obj]) {
             'add-triple',
             extractLookup(attrsStore, etype, eidA),
             fwdAttr.id,
-            // XXX: Better error here
-            extractLookup(attrsStore, fwdAttr!['reverse-identity']![1], eidB),
+            // Uses `!` because if we get here, we should have created the attr if it doesn't
+            // already exist
+            extractLookup(attrsStore, fwdAttr['reverse-identity']![1], eidB),
           ]
         : [
             'add-triple',
-            // XXX: Better error here
+            // Uses `!` because if we get here, we should have created the attr if it doesn't
+            // already exist
             extractLookup(attrsStore, revAttr!['forward-identity']![1], eidB),
             revAttr?.id,
             extractLookup(attrsStore, etype, eidA),
@@ -189,12 +191,14 @@ function expandUnlink({ attrsStore }: Ctx, [etype, eidA, obj]) {
             'retract-triple',
             extractLookup(attrsStore, etype, eidA),
             fwdAttr.id,
-            // XXX: Better error here
+            // Uses `!` because if we get here, we should have created the attr if it doesn't
+            // already exist
             extractLookup(attrsStore, fwdAttr!['reverse-identity']![1], eidB),
           ]
         : [
             'retract-triple',
-            // XXX: Better error here
+            // Uses `!` because if we get here, we should have created the attr if it doesn't
+            // already exist
             extractLookup(attrsStore, revAttr!['forward-identity'][1], eidB),
             revAttr!.id,
             extractLookup(attrsStore, etype, eidA),
@@ -218,7 +222,7 @@ function checkEntityExists(
       const ev = store?.aev.get(entity_a);
       if (ev) {
         // This would be a lot more efficient with a ave index
-        for (const [e_, a_, v] of allMapValues(ev, 2)) {
+        for (const [_e, _a, v] of allMapValues(ev, 2)) {
           if (v === entity_v) {
             return true;
           }
@@ -267,7 +271,7 @@ function expandCreate(ctx: Ctx, step) {
   const attrTuples = [['id', lookup]]
     .concat(Object.entries(obj))
     .map(([identName, value]: [string, any]) => {
-      // XXX: missing attr?
+      // Uses `!` because we should have optimistically created the attr if it doesn't exist
       const attr = getAttrByFwdIdentName(attrsStore, etype, identName)!;
 
       if (attr['checked-data-type'] === 'date' && ctx.useDateObjects) {

package/src/store.ts

@@ -100,13 +100,10 @@ export class AttrsStoreClass implements AttrsStore {
     return this.attrs[id];
   }
 
-  // XXX: Might be better to create all of the indexes at once as soon as someone
-  //      requests one index
   get blobAttrs(): Map<string, Map<string, InstantDBAttr>> {
     if (this._blobAttrs) {
       return this._blobAttrs;
     }
-    console.log('blobAttrs');
     this._blobAttrs = new Map();
     for (const attr of Object.values(this.attrs)) {
       if (isBlob(attr)) {
@@ -121,7 +118,6 @@ export class AttrsStoreClass implements AttrsStore {
     if (this._primaryKeys) {
       return this._primaryKeys;
     }
-    console.log('primayKeys');
     this._primaryKeys = new Map();
 
     for (const attr of Object.values(this.attrs)) {
@@ -137,7 +133,6 @@ export class AttrsStoreClass implements AttrsStore {
     if (this._forwardIdents) {
       return this._forwardIdents;
     }
-    console.log('fwdIdents');
     this._forwardIdents = new Map();
 
     for (const attr of Object.values(this.attrs)) {
@@ -152,7 +147,6 @@ export class AttrsStoreClass implements AttrsStore {
     if (this._revIdents) {
       return this._revIdents;
     }
-    console.log('revIdents');
     this._revIdents = new Map();
 
     for (const attr of Object.values(this.attrs)) {