@instana/shared-metrics 1.140.0 → 2.0.0-rc.1

package/CHANGELOG.md

@@ -3,6 +3,36 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [2.0.0-rc.1](https://github.com/instana/nodejs/compare/v1.140.1...v2.0.0-rc.1) (2022-04-04)
+
+
+### Bug Fixes
+
+* remove npm package instana-nodejs-sensor ([3bbf9cd](https://github.com/instana/nodejs/commit/3bbf9cdb6b1238e314f590601360460fd8101e55))
+
+
+### BREAKING CHANGES
+
+* Starting with version 2.0.0, consumers of the package who
+still use the deprecated package name instana-nodejs-sensor will need to follow
+https://www.ibm.com/docs/en/obi/current?topic=nodejs-collector-installation#change-of-package-name
+to receive updates in the future.
+
+
+
+
+
+## [1.140.1](https://github.com/instana/nodejs/compare/v1.140.0...v1.140.1) (2022-04-04)
+
+
+### Bug Fixes
+
+* **metrics:** do not report metrics from worker threads ([#517](https://github.com/instana/nodejs/issues/517)) ([bdf7869](https://github.com/instana/nodejs/commit/bdf7869e08d039e5769131d958e1037dc1748cd1)), closes [#500](https://github.com/instana/nodejs/issues/500)
+
+
+
+
+
 # [1.140.0](https://github.com/instana/nodejs/compare/v1.138.0...v1.140.0) (2022-03-24)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@instana/shared-metrics",
-  "version": "1.140.0",
+  "version": "2.0.0-rc.1",
   "description": "Internal metrics plug-in package for Node.js monitoring with Instana",
   "author": {
     "name": "Bastian Krol",
@@ -26,9 +26,9 @@
   },
   "scripts": {
     "audit": "bin/prepare-audit.sh && npm audit --production; AUDIT_RESULT=$?; git checkout package-lock.json; exit $AUDIT_RESULT",
-    "test": "npm run test:mocha",
-    "test:mocha": "echo \"******* Files to be tested:\n $CI_SHARED_METRICS_TEST_FILES\" && mocha --sort --reporter mocha-multi --reporter-options spec=-,xunit=../../test-results/shared-metrics/results.xml ${CI_SHARED_METRICS_TEST_FILES:=$(find test -iname '*test.js' -not -path '*node_modules*')} test/globalHooks_test.js",
-    "test:debug": "WITH_STDOUT=true npm run test:mocha",
+    "test": "mocha --sort test/globalHooks_test.js $(find test -iname '*test.js' -not -path '*node_modules*')",
+    "test:ci": "echo \"******* Files to be tested:\n $CI_SHARED_METRICS_TEST_FILES\" && if [ -z \"${CI_SHARED_METRICS_TEST_FILES}\" ]; then echo \"No Files to test in this node\"; else mocha --reporter mocha-multi-reporters --reporter-options configFile=reporter-config.json --sort test/globalHooks_test.js ${CI_SHARED_METRICS_TEST_FILES}; fi",
+    "test:debug": "WITH_STDOUT=true npm run test",
     "lint": "eslint src test",
     "verify": "npm run lint && npm test",
     "prettier": "prettier --write 'src/**/*.js' 'test/**/*.js'"
@@ -38,8 +38,7 @@
     "memory",
     "metrics",
     "monitoring",
-    "performance",
-    "sensor"
+    "performance"
   ],
   "contributors": [
     {
@@ -68,7 +67,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "@instana/core": "1.140.0",
+    "@instana/core": "2.0.0-rc.1",
     "detect-libc": "^1.0.3",
     "event-loop-lag": "^1.4.0",
     "recursive-copy": "^2.0.13",
@@ -83,5 +82,5 @@
     "event-loop-stats": "1.4.1",
     "gcstats.js": "1.0.0"
   },
-  "gitHead": "568758f47c8db228a681006652e0ad60d256e884"
+  "gitHead": "bf069e63f0d8a5600b575bf1aa85ba72c8b53370"
 }

package/src/util/nativeModuleRetry.js

@@ -11,7 +11,7 @@ const EventEmitter = require('events');
 const copy = require('recursive-copy');
 const fs = require('fs');
 const os = require('os');
-const semver = require('semver');
+const tar = require('tar');
 const path = require('path');
 const detectLibc = require('detect-libc');
 
@@ -61,7 +61,8 @@ function loadNativeAddOnInternal(opts, loaderEmitter) {
   try {
     const { isMainThread } = require('worker_threads');
     if (!isMainThread) {
-      logger.warn(opts.message + ' (Native addons are currently not loaded in worker threads)');
+      // Fail silently, we currently do not want to send any metrics from a worker thread.
+      // (But see https://instana.kanbanize.com/ctrl_board/56/cards/48699/details/)
       loaderEmitter.emit('failed');
       return;
     }
@@ -171,20 +172,6 @@ function copyPrecompiled(opts, loaderEmitter, callback) {
 
     logger.info(`Found a precompiled version for ${opts.nativeModuleName} ${label}, unpacking.`);
 
-    /**
-     * tar@6 has dropped support for Node < 10
-     * It might work to require tar@6 or to execute commands with tar@6 and Node < 10,
-     * but we don't want to risk that a customers application fails - especially if tar@6 adds
-     * breaking changes. We decided to disallow this feature.
-     */
-    if (semver.lt(process.version, '10.0.0')) {
-      logger.info(`Skipped copying precompiled version for ${opts.nativeModuleName} ${label} with Node < 10.`);
-      callback(false);
-      return;
-    }
-
-    const tar = require('tar');
-
     tar
       .x({
         cwd: os.tmpdir(),