@inseefr/lunatic 2.4.4 → 2.4.5-beta

package/lib/components/input-number/html/__snapshots__/input-number.spec.tsx.snap

@@ -16,8 +16,8 @@ exports[`InputNumber > renders without crashing 1`] = `
           lang="en"
           required=""
           step="1"
-          type="number"
-          value="input"
+          type="text"
+          value=""
         />
       </div>
     </div>
@@ -34,8 +34,8 @@ exports[`InputNumber > renders without crashing 1`] = `
         lang="en"
         required=""
         step="1"
-        type="number"
-        value="input"
+        type="text"
+        value=""
       />
     </div>
   </div>,

package/lib/components/input-number/html/input-number-thousand.js

@@ -1,27 +1,36 @@
 "use strict";
 
-function _typeof(obj) { "@babel/helpers - typeof"; return _typeof = "function" == typeof Symbol && "symbol" == typeof Symbol.iterator ? function (obj) { return typeof obj; } : function (obj) { return obj && "function" == typeof Symbol && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }, _typeof(obj); }
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports["default"] = void 0;
 var _classnames = _interopRequireDefault(require("classnames"));
-var _react = _interopRequireWildcard(require("react"));
+var _react = require("react");
 var _reactNumberFormat = require("react-number-format");
 var _i18n = require("../../../i18n");
 var _jsxRuntime = require("react/jsx-runtime");
-function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
-function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { "default": obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj["default"] = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
+function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _unsupportedIterableToArray(arr, i) || _nonIterableRest(); }
+function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); }
+function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
+function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
+function _iterableToArrayLimit(arr, i) { var _i = null == arr ? null : "undefined" != typeof Symbol && arr[Symbol.iterator] || arr["@@iterator"]; if (null != _i) { var _s, _e, _x, _r, _arr = [], _n = !0, _d = !1; try { if (_x = (_i = _i.call(arr)).next, 0 === i) { if (Object(_i) !== _i) return; _n = !1; } else for (; !(_n = (_s = _x.call(_i)).done) && (_arr.push(_s.value), _arr.length !== i); _n = !0); } catch (err) { _d = !0, _e = err; } finally { try { if (!_n && null != _i["return"] && (_r = _i["return"](), Object(_r) !== _r)) return; } finally { if (_d) throw _e; } } return _arr; } }
+function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
 var InputNumberThousand = function InputNumberThousand(_ref) {
   var id = _ref.id,
-    value = _ref.value,
     onChange = _ref.onChange,
+    value = _ref.value,
     disabled = _ref.disabled,
+    required = _ref.required,
     labelId = _ref.labelId,
     min = _ref.min,
     max = _ref.max,
     decimals = _ref.decimals;
+  // Decimals is a number indicates the number behind the separator of decimals
+  // Computing step attribute of input according to decimal number
+  var _useState = (0, _react.useState)(decimals ? 1 / Math.pow(10, decimals) : 1),
+    _useState2 = _slicedToArray(_useState, 1),
+    step = _useState2[0];
   var handleChange = (0, _react.useCallback)(function (e) {
     var _e$floatValue;
     var val = (_e$floatValue = e.floatValue) !== null && _e$floatValue !== void 0 ? _e$floatValue : null;
@@ -29,9 +38,9 @@ var InputNumberThousand = function InputNumberThousand(_ref) {
   }, [onChange]);
   var isAllowed = (0, _react.useCallback)(function (values) {
     var floatValue = values.floatValue;
-    if (Number.isInteger(min) && Number.isInteger(max) && floatValue && min && max) return floatValue >= min && floatValue <= max || false;
+    if (Number.isInteger(max) && floatValue && max) return floatValue <= max || false;
     return true;
-  }, [max, min]);
+  }, [max]);
   return /*#__PURE__*/(0, _jsxRuntime.jsx)(_reactNumberFormat.NumericFormat, {
     id: id,
     className: (0, _classnames["default"])({
@@ -39,8 +48,12 @@ var InputNumberThousand = function InputNumberThousand(_ref) {
     }),
     onValueChange: handleChange,
     value: value !== null && value !== void 0 ? value : '',
-    "aria-labbeledby": labelId,
+    min: min,
+    max: max,
+    step: step,
+    "aria-labelledby": labelId,
     disabled: disabled,
+    required: required,
     lang: "en",
     isAllowed: isAllowed,
     allowedDecimalSeparators: _i18n.inputNumberPropsI18N.allDecimalSeparators,

package/lib/components/input-number/html/input-number.js

@@ -4,20 +4,12 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports["default"] = void 0;
-var _react = require("react");
+var _function = require("../../../utils/function");
 var _commons = require("../../commons");
-var _inputNumberDefault = _interopRequireDefault(require("./input-number-default"));
 var _inputNumberThousand = _interopRequireDefault(require("./input-number-thousand"));
 require("./input-number.scss");
-var _function = require("../../../utils/function");
 var _jsxRuntime = require("react/jsx-runtime");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
-function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _unsupportedIterableToArray(arr, i) || _nonIterableRest(); }
-function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); }
-function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
-function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
-function _iterableToArrayLimit(arr, i) { var _i = null == arr ? null : "undefined" != typeof Symbol && arr[Symbol.iterator] || arr["@@iterator"]; if (null != _i) { var _s, _e, _x, _r, _arr = [], _n = !0, _d = !1; try { if (_x = (_i = _i.call(arr)).next, 0 === i) { if (Object(_i) !== _i) return; _n = !1; } else for (; !(_n = (_s = _x.call(_i)).done) && (_arr.push(_s.value), _arr.length !== i); _n = !0); } catch (err) { _d = !0, _e = err; } finally { try { if (!_n && null != _i["return"] && (_r = _i["return"](), Object(_r) !== _r)) return; } finally { if (_d) throw _e; } } return _arr; } }
-function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
 function InputNumber(_ref) {
   var id = _ref.id,
     _ref$value = _ref.value,
@@ -37,9 +29,6 @@ function InputNumber(_ref) {
     required = _ref$required === void 0 ? true : _ref$required,
     description = _ref.description;
   var labelId = "label-".concat(id);
-  var _useState = (0, _react.useState)(max && max > 1000),
-    _useState2 = _slicedToArray(_useState, 1),
-    useThousandSeparator = _useState2[0];
   return /*#__PURE__*/(0, _jsxRuntime.jsxs)("div", {
     className: "lunatic-input-number",
     children: [/*#__PURE__*/(0, _jsxRuntime.jsx)(_commons.Label, {
@@ -47,25 +36,15 @@ function InputNumber(_ref) {
       id: labelId,
       description: description,
       children: label
-    }), useThousandSeparator && /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumberThousand["default"], {
+    }), /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumberThousand["default"], {
       id: id,
       value: value,
       onChange: onChange,
       disabled: disabled,
       required: required,
       labelId: labelId,
-      max: max,
       min: min,
-      decimals: decimals
-    }), !useThousandSeparator && /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumberDefault["default"], {
-      id: id,
-      value: value,
-      onChange: onChange,
-      disabled: disabled,
-      required: required,
-      labelId: labelId,
       max: max,
-      min: min,
       decimals: decimals
     }), unit && /*#__PURE__*/(0, _jsxRuntime.jsx)("span", {
       children: unit

package/lib/components/input-number/html/input-number.spec.js

@@ -1,8 +1,8 @@
 "use strict";
 
 var _react = require("@testing-library/react");
-var _inputNumber = _interopRequireDefault(require("./input-number"));
 var _vitest = require("vitest");
+var _inputNumber = _interopRequireDefault(require("./input-number"));
 var _jsxRuntime = require("react/jsx-runtime");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
 (0, _vitest.describe)('InputNumber', function () {
@@ -16,7 +16,6 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "d
       id: "input",
       "aria-labelledby": "input"
     }));
-    (0, _vitest.expect)(_react.screen.getByRole('spinbutton')).toBeInTheDocument();
     (0, _vitest.expect)(container).toMatchSnapshot();
   });
   (0, _vitest.it)('renders label and input', function () {
@@ -28,7 +27,7 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "d
       })),
       container = _render.container;
     var label = _react.screen.getByText(labelText);
-    var input = container.querySelector('input[type="number"]');
+    var input = container.querySelector('input[type="text"]');
     (0, _vitest.expect)(label).toBeInTheDocument();
     (0, _vitest.expect)(input).toBeInTheDocument();
   });
@@ -38,17 +37,28 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "d
         value: 10,
         onChange: mockOnChange
       })),
-      getByRole = _render2.getByRole;
-    var input = getByRole('spinbutton');
-    (0, _vitest.expect)(input).toHaveValue(10);
+      container = _render2.container;
+    var input = container.querySelector('input[type="text"]');
+    (0, _vitest.expect)(input).toHaveValue('10');
   });
-  (0, _vitest.it)('calls onChange with parsed value', function () {
+  (0, _vitest.it)('renders with big value', function () {
     var _render3 = (0, _react.render)( /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumber["default"], {
         id: "number",
+        value: 10000.45,
+        decimals: 2,
         onChange: mockOnChange
       })),
       container = _render3.container;
-    var input = container.querySelector('input[type="number"]');
+    var input = container.querySelector('input[type="text"]');
+    (0, _vitest.expect)(input).toHaveValue('10,000.45');
+  });
+  (0, _vitest.it)('calls onChange with parsed value', function () {
+    var _render4 = (0, _react.render)( /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumber["default"], {
+        id: "number",
+        onChange: mockOnChange
+      })),
+      container = _render4.container;
+    var input = container.querySelector('input[type="text"]');
     _react.fireEvent.change(input, {
       target: {
         value: '10'
@@ -58,33 +68,17 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "d
     (0, _vitest.expect)(mockOnChange).toHaveBeenCalledWith(10);
   });
   (0, _vitest.it)('renders unit element if provided', function () {
-    var _render4 = (0, _react.render)( /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumber["default"], {
+    var _render5 = (0, _react.render)( /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumber["default"], {
         id: "input-number-test",
         value: 5,
         label: "Input Number",
         labelId: "input-number-label",
         unit: "kg"
       })),
-      getByText = _render4.getByText;
+      getByText = _render5.getByText;
     var unit = getByText('kg');
     (0, _vitest.expect)(unit).toBeInTheDocument();
   });
-  (0, _vitest.it)('calls onChange with new value when input value changes', function () {
-    var handleChange = _vitest.vi.fn();
-    var _render5 = (0, _react.render)( /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumber["default"], {
-        id: "input-number-test",
-        value: 5,
-        onChange: handleChange
-      })),
-      getByRole = _render5.getByRole;
-    var input = getByRole('spinbutton');
-    _react.fireEvent.change(input, {
-      target: {
-        value: '7'
-      }
-    });
-    (0, _vitest.expect)(handleChange).toHaveBeenCalledWith(7);
-  });
   (0, _vitest.it)('disables input when disabled prop is true', function () {
     var _render6 = (0, _react.render)( /*#__PURE__*/(0, _jsxRuntime.jsx)(_inputNumber["default"], {
         id: "number",
@@ -92,7 +86,7 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "d
         onChange: mockOnChange
       })),
       container = _render6.container;
-    var input = container.querySelector('input[type="number"]');
+    var input = container.querySelector('input[type="text"]');
     (0, _vitest.expect)(input).toBeDisabled();
   });
   (0, _vitest.it)('renders with unit', function () {

package/lib/src/components/input-number/html/input-number-thousand.d.ts

@@ -9,5 +9,5 @@ type Props = {
     max?: number;
     decimals?: number;
 };
-declare const InputNumberThousand: ({ id, value, onChange, disabled, labelId, min, max, decimals, }: Props) => import("react/jsx-runtime").JSX.Element;
+declare const InputNumberThousand: ({ id, onChange, value, disabled, required, labelId, min, max, decimals, }: Props) => import("react/jsx-runtime").JSX.Element;
 export default InputNumberThousand;

package/lib/src/components/input-number/html/input-number.d.ts

@@ -1,6 +1,6 @@
 import { ReactNode } from 'react';
-import './input-number.scss';
 import { LunaticBaseProps } from '../../type';
+import './input-number.scss';
 type Props = {
     id?: string;
     onChange?: (n: number | null) => void;

package/lib/stories/input-number/input-number.stories.js

@@ -49,7 +49,7 @@ exports.ThousandSeparator = ThousandSeparator;
 ThousandSeparator.args = {
   id: 'input-number-thousand',
   source: _sourceThansand["default"],
-  min: 0,
+  min: 10,
   max: 1000000,
   decimals: 0,
   thousandSeparator: true

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@inseefr/lunatic",
-	"version": "2.4.4",
+	"version": "2.4.5-beta",
 	"workersVersion": "0.2.5-experimental",
 	"description": "Library of questionnaire components",
 	"repository": {

package/lib/components/input-number/html/__snapshots__/inpute-number.spec.jsx.snap

@@ -1,92 +0,0 @@
-// Vitest Snapshot v1
-
-exports[`InputNumber > renders without crashing 1`] = `
-{
-  "asFragment": [Function],
-  "baseElement": <body>
-    <div>
-      <div
-        class="lunatic-input-number"
-      >
-        <input
-          class=""
-          id="input"
-          inputmode="numeric"
-          labelledby="label-input"
-          lang="en"
-          step="1"
-          type="number"
-          value="input"
-        />
-      </div>
-    </div>
-  </body>,
-  "container": <div>
-    <div
-      class="lunatic-input-number"
-    >
-      <input
-        class=""
-        id="input"
-        inputmode="numeric"
-        labelledby="label-input"
-        lang="en"
-        step="1"
-        type="number"
-        value="input"
-      />
-    </div>
-  </div>,
-  "debug": [Function],
-  "findAllByAltText": [Function],
-  "findAllByDisplayValue": [Function],
-  "findAllByLabelText": [Function],
-  "findAllByPlaceholderText": [Function],
-  "findAllByRole": [Function],
-  "findAllByTestId": [Function],
-  "findAllByText": [Function],
-  "findAllByTitle": [Function],
-  "findByAltText": [Function],
-  "findByDisplayValue": [Function],
-  "findByLabelText": [Function],
-  "findByPlaceholderText": [Function],
-  "findByRole": [Function],
-  "findByTestId": [Function],
-  "findByText": [Function],
-  "findByTitle": [Function],
-  "getAllByAltText": [Function],
-  "getAllByDisplayValue": [Function],
-  "getAllByLabelText": [Function],
-  "getAllByPlaceholderText": [Function],
-  "getAllByRole": [Function],
-  "getAllByTestId": [Function],
-  "getAllByText": [Function],
-  "getAllByTitle": [Function],
-  "getByAltText": [Function],
-  "getByDisplayValue": [Function],
-  "getByLabelText": [Function],
-  "getByPlaceholderText": [Function],
-  "getByRole": [Function],
-  "getByTestId": [Function],
-  "getByText": [Function],
-  "getByTitle": [Function],
-  "queryAllByAltText": [Function],
-  "queryAllByDisplayValue": [Function],
-  "queryAllByLabelText": [Function],
-  "queryAllByPlaceholderText": [Function],
-  "queryAllByRole": [Function],
-  "queryAllByTestId": [Function],
-  "queryAllByText": [Function],
-  "queryAllByTitle": [Function],
-  "queryByAltText": [Function],
-  "queryByDisplayValue": [Function],
-  "queryByLabelText": [Function],
-  "queryByPlaceholderText": [Function],
-  "queryByRole": [Function],
-  "queryByTestId": [Function],
-  "queryByText": [Function],
-  "queryByTitle": [Function],
-  "rerender": [Function],
-  "unmount": [Function],
-}
-`;

package/lib/components/input-number/html/input-number-default.js

@@ -1,57 +0,0 @@
-"use strict";
-
-Object.defineProperty(exports, "__esModule", {
-  value: true
-});
-exports["default"] = void 0;
-var _classnames = _interopRequireDefault(require("classnames"));
-var _react = require("react");
-var _jsxRuntime = require("react/jsx-runtime");
-function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
-function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _unsupportedIterableToArray(arr, i) || _nonIterableRest(); }
-function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); }
-function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
-function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
-function _iterableToArrayLimit(arr, i) { var _i = null == arr ? null : "undefined" != typeof Symbol && arr[Symbol.iterator] || arr["@@iterator"]; if (null != _i) { var _s, _e, _x, _r, _arr = [], _n = !0, _d = !1; try { if (_x = (_i = _i.call(arr)).next, 0 === i) { if (Object(_i) !== _i) return; _n = !1; } else for (; !(_n = (_s = _x.call(_i)).done) && (_arr.push(_s.value), _arr.length !== i); _n = !0); } catch (err) { _d = !0, _e = err; } finally { try { if (!_n && null != _i["return"] && (_r = _i["return"](), Object(_r) !== _r)) return; } finally { if (_d) throw _e; } } return _arr; } }
-function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
-function InputNumberDefault(_ref) {
-  var id = _ref.id,
-    value = _ref.value,
-    onChange = _ref.onChange,
-    _ref$disabled = _ref.disabled,
-    disabled = _ref$disabled === void 0 ? false : _ref$disabled,
-    _ref$required = _ref.required,
-    required = _ref$required === void 0 ? true : _ref$required,
-    labelId = _ref.labelId,
-    min = _ref.min,
-    max = _ref.max,
-    decimals = _ref.decimals;
-  // Decimals is a number indicates the number behind the separator of decimals
-  // Computing step attribute of input according to decimal number
-  var _useState = (0, _react.useState)(decimals ? 1 / Math.pow(10, decimals) : 1),
-    _useState2 = _slicedToArray(_useState, 1),
-    step = _useState2[0];
-  var handleChange = (0, _react.useCallback)(function (e) {
-    var val = e.target.valueAsNumber;
-    onChange(Number.isNaN(val) ? null : val);
-  }, [onChange]);
-  return /*#__PURE__*/(0, _jsxRuntime.jsx)("input", {
-    id: id,
-    className: (0, _classnames["default"])({
-      disabled: disabled
-    }),
-    type: "number",
-    inputMode: decimals ? 'decimal' : 'numeric',
-    onChange: handleChange,
-    value: value !== null && value !== void 0 ? value : '',
-    "aria-labelledby": labelId,
-    disabled: disabled,
-    required: required,
-    min: min,
-    max: max,
-    step: step,
-    lang: "en"
-  });
-}
-var _default = InputNumberDefault;
-exports["default"] = _default;

package/lib/src/components/input-number/html/input-number-default.d.ts

@@ -1,13 +0,0 @@
-type Props = {
-    id?: string;
-    onChange: (n: number | null) => void;
-    value?: number | null;
-    disabled?: boolean;
-    required?: boolean;
-    labelId?: string;
-    min?: number;
-    max?: number;
-    decimals?: number;
-};
-declare function InputNumberDefault({ id, value, onChange, disabled, required, labelId, min, max, decimals, }: Props): import("react/jsx-runtime").JSX.Element;
-export default InputNumberDefault;