@inrupt/solid-client-authn-browser 2.4.1 → 3.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@inrupt/solid-client-authn-browser",
-  "version": "2.4.1",
+  "version": "3.0.0",
   "license": "MIT",
   "types": "dist/index.d.ts",
   "browser": "dist/index.js",
@@ -26,12 +26,12 @@
     "build-docs-preview-site": "npm run build-api-docs; cd docs/api; make html"
   },
   "devDependencies": {
-    "@types/node": "^22.14.1",
+    "@types/node": "^24.0.7",
     "@types/uuid": "^10.0.0"
   },
   "dependencies": {
-    "@inrupt/oidc-client-ext": "^2.4.1",
-    "@inrupt/solid-client-authn-core": "^2.4.1",
+    "@inrupt/oidc-client-ext": "^3.0.0",
+    "@inrupt/solid-client-authn-core": "^3.0.0",
     "events": "^3.3.0",
     "jose": "^5.1.3",
     "uuid": "^11.1.0"
@@ -39,5 +39,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b01fdba3c141eb509557ab4c6f6fccf0a5ae79d6"
+  "gitHead": "af698e70dec2fe50f82ec6b85f7192161bbef482"
 }

package/src/login/oidc/ClientRegistrar.spec.ts

@@ -275,6 +275,38 @@ describe("ClientRegistrar", () => {
       ).toMatchObject(renewedClient);
     });
 
+    it("retrieves client information from storage if they are present and never expire", async () => {
+      const clientId = randomUUID();
+      const clientSecret = randomUUID();
+      const expiresAt = 0;
+      const clientRegistrar = getClientRegistrar({
+        storage: mockStorageUtility(
+          {
+            "solidClientAuthenticationUser:mySession": {
+              clientId,
+              clientSecret,
+              expiresAt: String(expiresAt),
+              clientType: "dynamic",
+            },
+          },
+          false,
+        ),
+      });
+      const client = await clientRegistrar.getClient(
+        {
+          sessionId: "mySession",
+          redirectUrl: "https://example.com",
+        },
+        {
+          ...IssuerConfigFetcherFetchConfigResponse,
+        },
+      );
+      expect(client.clientId).toBe(clientId);
+      expect(client.clientSecret).toBe(clientSecret);
+      expect(client.clientType).toBe("dynamic");
+      expect((client as IOpenIdDynamicClient).expiresAt).toBe(expiresAt);
+    });
+
     it("saves dynamic registration information", async () => {
       // Setup registration mock.
       const client: IOpenIdDynamicClient = {

package/src/login/oidc/ClientRegistrar.ts

@@ -75,9 +75,11 @@ export default class ClientRegistrar implements IClientRegistrar {
     const expirationDate =
       expiresAt !== undefined ? Number.parseInt(expiresAt, 10) : -1;
     // Expiration is only applicable to confidential clients.
+    // If the client registration never expires, then the expirationDate is 0.
     // Note that Date.now() is in milliseconds, and expirationDate in seconds.
     const expired =
       storedClientSecret !== undefined &&
+      expirationDate !== 0 &&
       Math.floor(Date.now() / 1000) > expirationDate;
     if (storedClientId && isKnownClientType(storedClientType) && !expired) {
       return storedClientSecret !== undefined

package/src/login/oidc/oidcHandlers/AuthorizationCodeWithPkceOidcHandler.ts

@@ -71,7 +71,7 @@ export default class AuthorizationCodeWithPkceOidcHandler
     try {
       const signingRequest = await oidcClientLibrary.createSigninRequest();
       // Make sure to await the promise before returning so that the error is caught.
-      return await this.handleRedirect({
+      return await this.setupRedirectHandler({
         oidcLoginOptions,
         // eslint-disable-next-line no-underscore-dangle
         state: signingRequest.state._id,