@inrupt/solid-client-authn-browser 2.2.4 → 2.2.5

package/dist/ClientAuthentication.d.ts

@@ -1,4 +1,3 @@
-/// <reference types="node" />
 /**
  * @hidden
  * @packageDocumentation

package/dist/login/oidc/incomingRedirectHandler/AuthCodeRedirectHandler.d.ts

@@ -1,4 +1,3 @@
-/// <reference types="node" />
 /**
  * @hidden
  * @packageDocumentation

package/dist/login/oidc/incomingRedirectHandler/ErrorOidcHandler.d.ts

@@ -1,4 +1,3 @@
-/// <reference types="node" />
 /**
  * @hidden
  * @packageDocumentation

package/dist/login/oidc/refresh/TokenRefresher.d.ts

@@ -1,4 +1,3 @@
-/// <reference types="node" />
 /**
  * @hidden
  * @packageDocumentation

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@inrupt/solid-client-authn-browser",
-  "version": "2.2.4",
+  "version": "2.2.5",
   "license": "MIT",
   "types": "dist/index.d.ts",
   "browser": "dist/index.js",
@@ -25,12 +25,12 @@
     "build-docs-preview-site": "npm run build-api-docs; cd docs/api; make html"
   },
   "devDependencies": {
-    "@types/node": "^20.14.2",
+    "@types/node": "^22.5.4",
     "@types/uuid": "^10.0.0"
   },
   "dependencies": {
-    "@inrupt/oidc-client-ext": "^2.2.4",
-    "@inrupt/solid-client-authn-core": "^2.2.4",
+    "@inrupt/oidc-client-ext": "^2.2.5",
+    "@inrupt/solid-client-authn-core": "^2.2.5",
     "events": "^3.3.0",
     "jose": "^5.1.3",
     "uuid": "^10.0.0"
@@ -38,5 +38,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "793acb2fc372fc299e64d5353200c714f31ab4e6"
+  "gitHead": "afb64c40f9f034e800c0c22db81492a5d8d6ceda"
 }

package/rollup.config.mjs

@@ -24,7 +24,7 @@ import commonjs from "@rollup/plugin-commonjs";
 import terser from "@rollup/plugin-terser";
 import createConfig, { createSharedConfig } from "@inrupt/base-rollup-config";
 // eslint-disable-next-line import/extensions
-import pkg from "./package.json" assert { type: "json" };
+import pkg from "./package.json" with { type: "json" };
 
 export default [
   ...createConfig(pkg),

package/src/login/oidc/ClientRegistrar.spec.ts

@@ -24,6 +24,7 @@ import {
   mockStorageUtility,
 } from "@inrupt/solid-client-authn-core/mocks";
 import { jest, it, describe, expect } from "@jest/globals";
+import { randomUUID } from "crypto";
 import ClientRegistrar from "./ClientRegistrar";
 import { IssuerConfigFetcherFetchConfigResponse } from "./__mocks__/IssuerConfigFetcher";
 
@@ -42,14 +43,16 @@ describe("ClientRegistrar", () => {
 
   describe("getClient", () => {
     it("properly performs dynamic registration", async () => {
+      const clientId = randomUUID();
+      const clientSecret = randomUUID();
       // FIXME: this should mock out oidc-client-ext, instead of mimicking the
       // actual OIDC provider response.
       const mockFetch = (jest.fn() as any).mockResolvedValueOnce(
         /* eslint-disable camelcase */
         new Response(
           JSON.stringify({
-            client_id: "abcd",
-            client_secret: "1234",
+            client_id: clientId,
+            client_secret: clientSecret,
             redirect_uris: ["https://example.com"],
             id_token_signed_response_alg: "RS256",
           }),
@@ -73,8 +76,8 @@ describe("ClientRegistrar", () => {
           },
         ),
       ).toMatchObject({
-        clientId: "abcd",
-        clientSecret: "1234",
+        clientId,
+        clientSecret,
       });
       expect(mockFetch).toHaveBeenCalledWith(registrationUrl.toString(), {
         method: "POST",
@@ -170,12 +173,14 @@ describe("ClientRegistrar", () => {
     });
 
     it("retrieves client id and secret from storage if they are present", async () => {
+      const clientId = randomUUID();
+      const clientSecret = randomUUID();
       const clientRegistrar = getClientRegistrar({
         storage: mockStorageUtility(
           {
             "solidClientAuthenticationUser:mySession": {
-              clientId: "an id",
-              clientSecret: "a secret",
+              clientId,
+              clientSecret,
               clientType: "dynamic",
             },
           },
@@ -191,17 +196,19 @@ describe("ClientRegistrar", () => {
           ...IssuerConfigFetcherFetchConfigResponse,
         },
       );
-      expect(client.clientId).toBe("an id");
-      expect(client.clientSecret).toBe("a secret");
+      expect(client.clientId).toBe(clientId);
+      expect(client.clientSecret).toBe(clientSecret);
     });
 
     it("saves dynamic registration information", async () => {
+      const clientId = randomUUID();
+      const clientSecret = randomUUID();
       const mockFetch = (jest.fn() as any).mockResolvedValueOnce(
         /* eslint-disable camelcase */
         new Response(
           JSON.stringify({
-            client_id: "some id",
-            client_secret: "some secret",
+            client_id: clientId,
+            client_secret: clientSecret,
             redirect_uris: ["https://example.com"],
           }),
         ),
@@ -227,10 +234,10 @@ describe("ClientRegistrar", () => {
 
       await expect(
         myStorage.getForUser("mySession", "clientId", { secure: false }),
-      ).resolves.toBe("some id");
+      ).resolves.toBe(clientId);
       await expect(
         myStorage.getForUser("mySession", "clientSecret", { secure: false }),
-      ).resolves.toBe("some secret");
+      ).resolves.toBe(clientSecret);
     });
   });
 });

package/src/login/oidc/OidcLoginHandler.spec.ts

@@ -26,6 +26,7 @@ import {
   StorageUtilityMock,
   mockStorage,
 } from "@inrupt/solid-client-authn-core/mocks";
+import { randomUUID } from "crypto";
 
 import { OidcHandlerMock } from "./__mocks__/IOidcHandler";
 import {
@@ -108,8 +109,8 @@ describe("OidcLoginHandler", () => {
   it("should lookup client ID if not provided, if not found do DCR", async () => {
     const mockedOidcModule = jest.requireMock("@inrupt/oidc-client-ext") as any;
     mockedOidcModule.registerClient = (jest.fn() as any).mockResolvedValue({
-      clientId: "some dynamically registered ID",
-      clientSecret: "some dynamically registered secret",
+      clientId: randomUUID(),
+      clientSecret: randomUUID(),
     });
 
     const mockedEmptyStorage = new StorageUtility(
@@ -135,10 +136,11 @@ describe("OidcLoginHandler", () => {
   });
 
   it("should perform DCR if a client WebID is provided, but the target IdP does not support Solid-OIDC", async () => {
+    const clientId = randomUUID();
     const mockedOidcModule = jest.requireMock("@inrupt/oidc-client-ext") as any;
     mockedOidcModule.registerClient = (jest.fn() as any).mockResolvedValue({
-      clientId: "some dynamically registered ID",
-      clientSecret: "some dynamically registered secret",
+      clientId,
+      clientSecret: randomUUID(),
     });
 
     const mockedEmptyStorage = new StorageUtility(
@@ -165,7 +167,7 @@ describe("OidcLoginHandler", () => {
     });
 
     const calledWith = actualHandler.handle.mock.calls[0][0];
-    expect(calledWith.client.clientId).toBe("some dynamically registered ID");
+    expect(calledWith.client.clientId).toBe(clientId);
   });
 
   it("should save statically registered client ID if given one as an input option", async () => {

package/src/login/oidc/incomingRedirectHandler/AuthCodeRedirectHandler.spec.ts

@@ -162,10 +162,7 @@ function mockOidcClient(
     .mockImplementationOnce(
       tokenType === "dpop"
         ? mockTokenEndpointDpopResponse
-        : () =>
-            new Promise<OidcClientExt.CodeExchangeResult>((resolve) => {
-              resolve(mockTokenEndpointBearerResponse());
-            }),
+        : () => Promise.resolve(mockTokenEndpointBearerResponse()),
     );
   mockedOidcClient.refresh = jest
     .fn<typeof mockedOidcClient.refresh>()