@inrupt/solid-client-authn-browser 1.13.1 → 1.13.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@inrupt/solid-client-authn-browser",
-  "version": "1.13.1",
+  "version": "1.13.3",
   "license": "MIT",
   "types": "dist/index",
   "browser": "dist/index.js",
@@ -25,11 +25,11 @@
     "cross-fetch": "^3.1.5"
   },
   "dependencies": {
-    "@inrupt/oidc-client-ext": "^1.13.1",
-    "@inrupt/solid-client-authn-core": "^1.13.1",
+    "@inrupt/oidc-client-ext": "^1.13.3",
+    "@inrupt/solid-client-authn-core": "^1.13.3",
     "@types/lodash.clonedeep": "^4.5.6",
     "@types/node": "^18.0.3",
-    "@types/uuid": "^8.3.0",
+    "@types/uuid": "^9.0.1",
     "events": "^3.3.0",
     "jose": "^4.3.7",
     "lodash.clonedeep": "^4.5.0",
@@ -41,5 +41,5 @@
   "engines": {
     "node": "^14.0.0 || ^16.0.0"
   },
-  "gitHead": "db1b8613648e96ef536374640421b318058551a3"
+  "gitHead": "46965b5ae611c9de77af67828ff814421e2ac7f3"
 }

package/src/login/oidc/IssuerConfigFetcher.spec.ts

@@ -119,4 +119,42 @@ describe("IssuerConfigFetcher", () => {
     );
     expect(fetchedConfig.scopesSupported).toContain("openid");
   });
+
+  it("should append the .well-known/openid-configuration path at the end of the issuer URL", async () => {
+    // The response value is irrelevant to this test.
+    const mockFetch = jest.fn<typeof fetch>().mockImplementation(
+      async () =>
+        new NodeResponse(
+          JSON.stringify({
+            issuer: "https://example.com",
+            // eslint-disable-next-line camelcase
+            claim_types_supported: "oidc",
+          })
+        )
+    );
+    window.fetch = mockFetch as typeof window.fetch;
+    const configFetcher = getIssuerConfigFetcher({
+      storageUtility: mockStorageUtility({}),
+    });
+    // No trailing slash
+    await configFetcher.fetchConfig("https://arbitrary.url");
+    expect(mockFetch).toHaveBeenLastCalledWith(
+      "https://arbitrary.url/.well-known/openid-configuration"
+    );
+    // A trailing slash
+    await configFetcher.fetchConfig("https://arbitrary.url/");
+    expect(mockFetch).toHaveBeenLastCalledWith(
+      "https://arbitrary.url/.well-known/openid-configuration"
+    );
+    // A path without a trailing slash
+    await configFetcher.fetchConfig("https://arbitrary.url/path");
+    expect(mockFetch).toHaveBeenLastCalledWith(
+      "https://arbitrary.url/path/.well-known/openid-configuration"
+    );
+    // A path with a trailing slash
+    await configFetcher.fetchConfig("https://arbitrary.url/path/");
+    expect(mockFetch).toHaveBeenLastCalledWith(
+      "https://arbitrary.url/path/.well-known/openid-configuration"
+    );
+  });
 });

package/src/login/oidc/IssuerConfigFetcher.ts

@@ -159,7 +159,12 @@ export default class IssuerConfigFetcher implements IIssuerConfigFetcher {
   async fetchConfig(issuer: string): Promise<IIssuerConfig> {
     let issuerConfig: IIssuerConfig;
 
-    const openIdConfigUrl = new URL(WELL_KNOWN_OPENID_CONFIG, issuer).href;
+    const openIdConfigUrl = new URL(
+      WELL_KNOWN_OPENID_CONFIG,
+      // Make sure to append a slash at issuer URL, so that the .well-known URL
+      // includes the full issuer path. See https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderConfig.
+      issuer.endsWith("/") ? issuer : `${issuer}/`
+    ).href;
     const issuerConfigRequestBody = await window.fetch(openIdConfigUrl);
     // Check the validity of the fetched config
     try {

package/tsconfig.json

@@ -9,7 +9,8 @@
   "typedocOptions": {
     "out": "website/docs/api/browser",
     "entryPoints": ["./src/index.ts"],
-    "entryDocument": "index.md"
+    "entryDocument": "index.md",
+    "hideInPageTOC": true,
   },
 
   "include": ["src/**/*"],