@innovastudio/contentbuilder 1.5.214 → 1.5.216

package/package.json

@@ -1,7 +1,7 @@
 {
   "type": "module",
   "name": "@innovastudio/contentbuilder",
-  "version": "1.5.214",
+  "version": "1.5.216",
   "description": "",
   "main": "public/contentbuilder/contentbuilder.esm.js",
   "types": "index.d.ts",

package/public/contentbuilder/contentbuilder.esm.js

@@ -7413,6 +7413,17 @@ class Util {
   hidePops() {
     const dom = this.dom;
     const builderStuff = this.builder.builderStuff;
+
+    /* Fast path. This runs on every scroll event (see the window 'scroll'
+     * handler in contentbuilder.js — its 10ms debounce is shorter than the
+     * ~16ms gap between scroll events, so it does not coalesce them), which
+     * meant two full querySelectorAll sweeps plus their loops ~60x/second
+     * even with nothing open. When nothing is showing, the loops below are
+     * no-ops, so skip straight to the image handles. */
+    if (!builderStuff.querySelector('.is-tool.active, .is-tool[style*="display"], .is-pop.active')) {
+      if (this.builder.editingEngine) this.builder.editingEngine.hideImageHandles();
+      return;
+    }
     let tools = builderStuff.querySelectorAll('.is-tool');
     Array.prototype.forEach.call(tools, tool => {
       // if(tool.classList.contains('is-row-tool')||
@@ -32222,11 +32233,23 @@ class Plugin {
       }
     };
     if (!this.builder.handlePluginClick_) {
-      document.addEventListener('click', handlePluginClick);
-      if (this.builder.iframeDocument) {
-        this.builder.doc.addEventListener('click', handlePluginClick);
-      }
       this.builder.handlePluginClick_ = true;
+      // Register on the NEXT task, not now. showPluginEditor() can be
+      // reached from a microtask inside the very click that opens the
+      // panel: the RTE button runs convertSelectionToPlugin(), whose
+      // runtime.reinitialize().then() resolves while that click is still
+      // propagating towards document. A listener added mid-propagation
+      // still receives that same click, so the panel was closed the
+      // instant it opened — and only on a first open, because afterwards
+      // the previous listener had already fired and removed itself.
+      // Deferring means this listener can never see the click that
+      // created it, whichever toolbar or panel opened the panel.
+      setTimeout(() => {
+        document.addEventListener('click', handlePluginClick);
+        if (this.builder.iframeDocument) {
+          this.builder.doc.addEventListener('click', handlePluginClick);
+        }
+      }, 0);
     }
   }
   hidePluginEditor() {
@@ -69542,16 +69565,42 @@ class Resize {
   enable() {
     const col = this.element;
     const row = col.parentNode;
+
+    // The builder injects its own elements into a row — tools, the add-row
+    // bar, and the row overlay that appears once the row is selected in the
+    // side panel. They are not columns, and measuring them as columns makes
+    // the totals below nonsense. Filter them out in ONE place so a new
+    // injected element can never silently break the maths again.
+    const isBuilderUI = item => item.nodeType !== 1 || item.classList.contains('is-tool') || item.classList.contains('is-row-tool') || item.classList.contains('is-col-tool') || item.classList.contains('is-rowadd-tool') || item.classList.contains('is-row-overlay');
+    const columnsOf = parent => Array.from(parent.children).filter(item => !isBuilderUI(item));
+
+    // A column width is only ever stored as a percentage; pixels are used
+    // purely while a drag is in progress. resizeEnd normally converts them
+    // back, but it does not run if the drag is interrupted — and pixel
+    // widths saved into the page push content off screen on smaller
+    // devices. This is the backstop for that: whatever happens to the drag,
+    // a leftover pixel width is converted on the next tick. Capture phase,
+    // so it still runs if something stops the event bubbling.
+    const normalizeToPercent = () => {
+      setTimeout(() => {
+        if (!col.style.width || col.style.width.indexOf('px') === -1) return;
+        const parent = col.parentNode;
+        if (!parent || !parent.offsetWidth) return;
+        const pct = col.offsetWidth / parent.offsetWidth * 100;
+        if (isFinite(pct) && pct > 0) col.style.width = pct + '%';
+      }, 0);
+    };
+    this.normalizeToPercent = normalizeToPercent;
+    this.eventTarget = col.ownerDocument;
+    this.eventTarget.addEventListener('mouseup', normalizeToPercent, true);
+    this.eventTarget.addEventListener('touchend', normalizeToPercent, true);
     this.resize = new Resizeable({
       pane: col,
       resizeHeight: this.builder.resizeHeight,
       onResize: (width, height) => {
         this.builder.util.hideControls();
         let numOfCols = 1;
-        Array.from(col.parentNode.children).map(item => {
-          if (item.classList.contains('is-row-tool')) return;
-          if (item.classList.contains('is-rowadd-tool')) return;
-          if (item.classList.contains('is-col-tool')) return;
+        columnsOf(col.parentNode).map(item => {
           if (item === col) return;
           numOfCols++;
         });
@@ -69562,10 +69611,7 @@ class Resize {
           // adjust others
           const maxWidth = () => {
             let otherWidth = 0;
-            Array.from(col.parentNode.children).map(item => {
-              if (item.classList.contains('is-row-tool')) return;
-              if (item.classList.contains('is-rowadd-tool')) return;
-              if (item.classList.contains('is-col-tool')) return;
+            columnsOf(col.parentNode).map(item => {
               // if(this.opts.filterSibling) if(item.classList.contains(this.opts.filterSibling)) return;
 
               if (item === col) return;
@@ -69579,10 +69625,7 @@ class Resize {
             // percentage = (max / row.offsetWidth) * 100;
             // Or make others auto
 
-            Array.from(col.parentNode.children).map(item => {
-              if (item.classList.contains('is-row-tool')) return;
-              if (item.classList.contains('is-rowadd-tool')) return;
-              if (item.classList.contains('is-col-tool')) return;
+            columnsOf(col.parentNode).map(item => {
               // if(this.opts.filterSibling) if(item.classList.contains(this.opts.filterSibling)) return;
 
               if (item === col) return;
@@ -69620,10 +69663,7 @@ class Resize {
             }
           } else {
             // New: if other cols has no width, set to 100%
-            Array.from(col.parentNode.children).map(item => {
-              if (item.classList.contains('is-row-tool')) return;
-              if (item.classList.contains('is-rowadd-tool')) return;
-              if (item.classList.contains('is-col-tool')) return;
+            columnsOf(col.parentNode).map(item => {
               // if(this.opts.filterSibling) if(item.classList.contains(this.opts.filterSibling)) return;
 
               if (item === col) return;
@@ -69653,10 +69693,7 @@ class Resize {
       },
       resizeEnd: () => {
         let numOfCols = 1;
-        Array.from(col.parentNode.children).map(item => {
-          if (item.classList.contains('is-row-tool')) return;
-          if (item.classList.contains('is-rowadd-tool')) return;
-          if (item.classList.contains('is-col-tool')) return;
+        columnsOf(col.parentNode).map(item => {
           if (item === col) return;
           numOfCols++;
         });
@@ -69668,13 +69705,9 @@ class Resize {
           // adjust others
           const maxWidth = () => {
             let otherWidth = 0;
-            Array.from(col.parentNode.children).map(item => {
-              if (item.classList.contains('is-row-tool')) return;
-              if (item.classList.contains('is-rowadd-tool')) return;
-              if (item.classList.contains('is-col-tool')) return;
+            columnsOf(col.parentNode).map(item => {
               // if(this.opts.filterSibling) if(item.classList.contains(this.opts.filterSibling)) return;
 
-              if (item.classList.contains('row-tool')) return;
               if (item === col) return;
               otherWidth += item.offsetWidth;
             });
@@ -69686,10 +69719,7 @@ class Resize {
             // percentage = (max / row.offsetWidth) * 100;
             // Or make others auto
 
-            Array.from(col.parentNode.children).map(item => {
-              if (item.classList.contains('is-row-tool')) return;
-              if (item.classList.contains('is-rowadd-tool')) return;
-              if (item.classList.contains('is-col-tool')) return;
+            columnsOf(col.parentNode).map(item => {
               // if(this.opts.filterSibling) if(item.classList.contains(this.opts.filterSibling)) return;
 
               if (item === col) return;
@@ -69719,10 +69749,7 @@ class Resize {
           // New: Final fix (if column resized exceeds its max)
           let othersWidth = 0;
           let activeColumnWidth = 0;
-          Array.from(col.parentNode.children).map(item => {
-            if (item.classList.contains('is-row-tool')) return;
-            if (item.classList.contains('is-rowadd-tool')) return;
-            if (item.classList.contains('is-col-tool')) return;
+          columnsOf(col.parentNode).map(item => {
             // if(this.opts.filterSibling) if(item.classList.contains(this.opts.filterSibling)) return;
 
             // // Refresh Module
@@ -69740,13 +69767,23 @@ class Resize {
           if (activeColumnWidth > maxResult) {
             percentage = maxResult / row.offsetWidth * 100;
           }
-          col.style.width = percentage + '%';
+
+          // The column is carrying a pixel width at this point (set
+          // just above, to measure it). A width is only ever stored as
+          // a percentage, so if the maths produced something CSS will
+          // reject — negative, zero, NaN, Infinity — the assignment
+          // would silently fail and leave those pixels behind, which
+          // then breaks the layout on smaller screens. Fall back to
+          // the column's real share of the row instead.
+          if (!isFinite(percentage) || percentage <= 0) {
+            percentage = col.offsetWidth / row.offsetWidth * 100;
+          }
+          if (isFinite(percentage) && percentage > 0) {
+            col.style.width = percentage + '%';
+          }
 
           // Refresh Module
-          Array.from(col.parentNode.children).map(item => {
-            if (item.classList.contains('is-row-tool')) return;
-            if (item.classList.contains('is-rowadd-tool')) return;
-            if (item.classList.contains('is-col-tool')) return;
+          columnsOf(col.parentNode).map(item => {
             if (item.getAttribute('data-html')) {
               let moduleWidth = item.offsetWidth / row.offsetWidth * 100;
               item.style.width = moduleWidth + '%';
@@ -69758,10 +69795,7 @@ class Resize {
         if (col.style.height) {
           col.style.minHeight = col.style.height;
           col.style.height = '';
-          Array.from(col.parentNode.children).map(item => {
-            if (item.classList.contains('is-row-tool')) return;
-            if (item.classList.contains('is-rowadd-tool')) return;
-            if (item.classList.contains('is-col-tool')) return;
+          columnsOf(col.parentNode).map(item => {
             // if(this.opts.filterSibling) if(item.classList.contains(this.opts.filterSibling)) return;
 
             if (item === col) return;
@@ -69781,6 +69815,10 @@ class Resize {
     });
   }
   destroy() {
+    if (this.eventTarget && this.normalizeToPercent) {
+      this.eventTarget.removeEventListener('mouseup', this.normalizeToPercent, true);
+      this.eventTarget.removeEventListener('touchend', this.normalizeToPercent, true);
+    }
     this.resize.destroy();
   }
 }