@inlang/sdk 0.8.0 → 0.9.0

package/dist/adapter/solidAdapter.test.js

@@ -143,7 +143,7 @@ describe("messages", () => {
             description: {
                 en: "wo",
             },
-            loadMessages: ({ languageTags }) => (languageTags.length ? exampleMessages : []),
+            loadMessages: ({ settings }) => (settings.languageTags.length ? exampleMessages : []),
             saveMessages: () => undefined,
         };
         const mockImport = async () => ({ default: mockPlugin });

package/dist/loadProject.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"loadProject.d.ts","sourceRoot":"","sources":["../src/loadProject.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EACX,aAAa,EAGb,YAAY,EACZ,MAAM,UAAU,CAAA;AACjB,OAAO,EAAE,KAAK,cAAc,EAAkB,MAAM,4BAA4B,CAAA;AAahF,OAAO,EAA4B,KAAK,uBAAuB,EAAE,MAAM,0BAA0B,CAAA;AAMjG;;;;;;GAMG;AACH,eAAO,MAAM,WAAW;sBACL,MAAM;eACb,uBAAuB;;qBAElB,MAAM,SAAS,OAAO,MAAM,EAAE,OAAO,CAAC,KAAK,IAAI;MAC5D,QAAQ,aAAa,CAmLxB,CAAA;AAsGD,wBAAgB,kBAAkB,CAAC,CAAC,EAAE,MAAM,EAAE,MAAM,CAAC,GAAG,YAAY,CAAC,CAAC,CAAC,CAQtE"}
+{"version":3,"file":"loadProject.d.ts","sourceRoot":"","sources":["../src/loadProject.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EACX,aAAa,EAGb,YAAY,EACZ,MAAM,UAAU,CAAA;AACjB,OAAO,EAAE,KAAK,cAAc,EAAkB,MAAM,4BAA4B,CAAA;AAahF,OAAO,EAA4B,KAAK,uBAAuB,EAAE,MAAM,0BAA0B,CAAA;AAMjG;;;;;;GAMG;AACH,eAAO,MAAM,WAAW;sBACL,MAAM;eACb,uBAAuB;;qBAElB,MAAM,SAAS,OAAO,MAAM,EAAE,OAAO,CAAC,KAAK,IAAI;MAC5D,QAAQ,aAAa,CAqLxB,CAAA;AAsGD,wBAAgB,kBAAkB,CAAC,CAAC,EAAE,MAAM,EAAE,MAAM,CAAC,GAAG,YAAY,CAAC,CAAC,CAAC,CAQtE"}

package/dist/loadProject.js

@@ -77,8 +77,7 @@ export const loadProject = async (args) => {
                 return;
             }
             makeTrulyAsync(_resolvedModules.resolvedPluginApi.loadMessages({
-                languageTags: settingsValue.languageTags,
-                sourceLanguageTag: settingsValue.sourceLanguageTag,
+                settings: settingsValue,
             }))
                 .then((messages) => {
                 setMessages(messages);
@@ -117,7 +116,10 @@ export const loadProject = async (args) => {
         const lintReportsQuery = createMessageLintReportsQuery(messages, settings, installedMessageLintRules, resolvedModules);
         const debouncedSave = skipFirst(debounce(500, async (newMessages) => {
             try {
-                await resolvedModules()?.resolvedPluginApi.saveMessages({ messages: newMessages });
+                await resolvedModules()?.resolvedPluginApi.saveMessages({
+                    settings: settingsValue,
+                    messages: newMessages,
+                });
             }
             catch (err) {
                 throw new PluginSaveMessagesError("Error in saving messages", {

package/dist/loadProject.test.js

@@ -399,14 +399,15 @@ describe("functionality", () => {
     describe("query", () => {
         it("should call saveMessages() on updates", async () => {
             const fs = createNodeishMemoryFs();
-            await fs.writeFile("./project.inlang.json", JSON.stringify({
+            const settings = {
                 sourceLanguageTag: "en",
                 languageTags: ["en", "de"],
                 modules: ["plugin.js"],
                 "plugin.project.json": {
                     pathPattern: "./resources/{languageTag}.json",
                 },
-            }));
+            };
+            await fs.writeFile("./project.inlang.json", JSON.stringify(settings));
             await fs.mkdir("./resources");
             const mockSaveFn = vi.fn();
             const _mockPlugin = {
@@ -486,9 +487,7 @@ describe("functionality", () => {
             });
             await new Promise((resolve) => setTimeout(resolve, 510));
             expect(mockSaveFn.mock.calls.length).toBe(1);
-            expect(mockSaveFn.mock.calls[0][0].settings).toStrictEqual({
-                pathPattern: "./resources/{languageTag}.json",
-            });
+            expect(mockSaveFn.mock.calls[0][0].settings).toStrictEqual(settings);
             expect(Object.values(mockSaveFn.mock.calls[0][0].messages)).toStrictEqual([
                 {
                     id: "a",

package/dist/resolve-modules/plugins/resolvePlugins.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"resolvePlugins.d.ts","sourceRoot":"","sources":["../../../src/resolve-modules/plugins/resolvePlugins.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,YAAY,CAAA;AAuBxD,eAAO,MAAM,cAAc,EAAE,sBAoJ5B,CAAA"}
+{"version":3,"file":"resolvePlugins.d.ts","sourceRoot":"","sources":["../../../src/resolve-modules/plugins/resolvePlugins.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,YAAY,CAAA;AAuBxD,eAAO,MAAM,cAAc,EAAE,sBAkJ5B,CAAA"}

package/dist/resolve-modules/plugins/resolvePlugins.js

@@ -27,7 +27,7 @@ export const resolvePlugins = async (args) => {
         // -- INVALID ID in META --
         const hasInvalidId = errors.some((error) => error.path === "/id");
         if (hasInvalidId) {
-            result.errors.push(new PluginHasInvalidIdError(`Plugin ${plugin.id} has an invalid id "${plugin.id}". It must be kebap-case and contain a namespace like project.my-plugin.`, { plugin: plugin.id }));
+            result.errors.push(new PluginHasInvalidIdError(`Plugin ${plugin.id} has an invalid id "${plugin.id}". It must be camelCase and contain a namespace like plugin.namespace.myPlugin.`, { plugin: plugin.id }));
         }
         // -- USES RESERVED NAMESPACE --
         if (plugin.id.includes("inlang") && !whitelistedPlugins.includes(plugin.id)) {
@@ -53,7 +53,7 @@ export const resolvePlugins = async (args) => {
         if (typeof plugin.addCustomApi === "function") {
             // TODO: why do we call this function 2 times (here for validation and later for retrieving the actual value)?
             const { data: customApi, error } = tryCatch(() => plugin.addCustomApi({
-                settings: args.settings?.[plugin.id] ?? {},
+                settings: args.settings,
             }));
             if (error) {
                 // @ts-ignore
@@ -74,20 +74,18 @@ export const resolvePlugins = async (args) => {
         if (typeof plugin.loadMessages === "function") {
             result.data.loadMessages = (_args) => plugin.loadMessages({
                 ..._args,
-                settings: args.settings?.[plugin.id] ?? {},
                 nodeishFs: args.nodeishFs,
             });
         }
         if (typeof plugin.saveMessages === "function") {
             result.data.saveMessages = (_args) => plugin.saveMessages({
                 ..._args,
-                settings: args.settings?.[plugin.id] ?? {},
                 nodeishFs: args.nodeishFs,
             });
         }
         if (typeof plugin.addCustomApi === "function") {
             const { data: customApi } = tryCatch(() => plugin.addCustomApi({
-                settings: args.settings?.[plugin.id] ?? {},
+                settings: args.settings,
             }));
             if (customApi) {
                 result.data.customApi = deepmerge(result.data.customApi, customApi);

package/dist/resolve-modules/plugins/resolvePlugins.test.js

@@ -2,56 +2,87 @@
 import { describe, expect, it } from "vitest";
 import { resolvePlugins } from "./resolvePlugins.js";
 import { PluginLoadMessagesFunctionAlreadyDefinedError, PluginSaveMessagesFunctionAlreadyDefinedError, PluginHasInvalidIdError, PluginUsesReservedNamespaceError, PluginReturnedInvalidCustomApiError, PluginHasInvalidSchemaError, PluginsDoNotProvideLoadOrSaveMessagesError, } from "./errors.js";
-describe("generally", () => {
-    it("should return an error if a plugin uses an invalid id", async () => {
-        const mockPlugin = {
-            // @ts-expect-error - invalid id
-            id: "no-namespace",
-            description: { en: "My plugin description" },
-            displayName: { en: "My plugin" },
-            loadMessages: () => undefined,
-            saveMessages: () => undefined,
-        };
-        const resolved = await resolvePlugins({
-            plugins: [mockPlugin],
-            settings: {},
-            nodeishFs: {},
-        });
-        expect(resolved.errors[0]).toBeInstanceOf(PluginHasInvalidIdError);
+it("should return an error if a plugin uses an invalid id", async () => {
+    const mockPlugin = {
+        // @ts-expect-error - invalid id
+        id: "no-namespace",
+        description: { en: "My plugin description" },
+        displayName: { en: "My plugin" },
+        loadMessages: () => undefined,
+        saveMessages: () => undefined,
+    };
+    const resolved = await resolvePlugins({
+        plugins: [mockPlugin],
+        settings: {},
+        nodeishFs: {},
     });
-    it("should return an error if a plugin uses APIs that are not available", async () => {
-        const mockPlugin = {
-            id: "plugin.namespace.undefinedApi",
-            description: { en: "My plugin description" },
-            displayName: { en: "My plugin" },
-            // @ts-expect-error the key is not available in type
-            nonExistentKey: {
-                nonexistentOptions: "value",
-            },
-            loadMessages: () => undefined,
-            saveMessages: () => undefined,
-        };
-        const resolved = await resolvePlugins({
-            plugins: [mockPlugin],
-            settings: {},
-            nodeishFs: {},
-        });
-        expect(resolved.errors[0]).toBeInstanceOf(PluginHasInvalidSchemaError);
+    expect(resolved.errors[0]).toBeInstanceOf(PluginHasInvalidIdError);
+});
+it("should return an error if a plugin uses APIs that are not available", async () => {
+    const mockPlugin = {
+        id: "plugin.namespace.undefinedApi",
+        description: { en: "My plugin description" },
+        displayName: { en: "My plugin" },
+        // @ts-expect-error the key is not available in type
+        nonExistentKey: {
+            nonexistentOptions: "value",
+        },
+        loadMessages: () => undefined,
+        saveMessages: () => undefined,
+    };
+    const resolved = await resolvePlugins({
+        plugins: [mockPlugin],
+        settings: {},
+        nodeishFs: {},
     });
-    it("should not initialize a plugin that uses the 'inlang' namespace except for inlang whitelisted plugins", async () => {
-        const mockPlugin = {
-            id: "plugin.inlang.notWhitelisted",
-            description: { en: "My plugin description" },
-            displayName: { en: "My plugin" },
-            loadMessages: () => undefined,
-        };
-        const resolved = await resolvePlugins({
-            plugins: [mockPlugin],
-            settings: {},
-            nodeishFs: {},
-        });
-        expect(resolved.errors[0]).toBeInstanceOf(PluginUsesReservedNamespaceError);
+    expect(resolved.errors[0]).toBeInstanceOf(PluginHasInvalidSchemaError);
+});
+it("should not initialize a plugin that uses the 'inlang' namespace except for inlang whitelisted plugins", async () => {
+    const mockPlugin = {
+        id: "plugin.inlang.notWhitelisted",
+        description: { en: "My plugin description" },
+        displayName: { en: "My plugin" },
+        loadMessages: () => undefined,
+    };
+    const resolved = await resolvePlugins({
+        plugins: [mockPlugin],
+        settings: {},
+        nodeishFs: {},
+    });
+    expect(resolved.errors[0]).toBeInstanceOf(PluginUsesReservedNamespaceError);
+});
+it("should expose the project settings including the plugin settings", async () => {
+    const settings = {
+        sourceLanguageTag: "en",
+        languageTags: ["en", "de"],
+        modules: [],
+        "plugin.namespace.placeholder": {
+            myPluginSetting: "value",
+        },
+    };
+    const mockPlugin = {
+        id: "plugin.namespace.placeholder",
+        description: { en: "My plugin description" },
+        displayName: { en: "My plugin" },
+        saveMessages: async ({ settings }) => {
+            expect(settings).toStrictEqual(settings);
+        },
+        addCustomApi: ({ settings }) => {
+            expect(settings).toStrictEqual(settings);
+            return {};
+        },
+        loadMessages: async ({ settings }) => {
+            expect(settings).toStrictEqual(settings);
+            return [];
+        },
+    };
+    const resolved = await resolvePlugins({
+        plugins: [mockPlugin],
+        settings: settings,
+        nodeishFs: {},
     });
+    await resolved.data.loadMessages({ settings });
+    await resolved.data.saveMessages({ settings, messages: [] });
 });
 describe("loadMessages", () => {
     it("should load messages from a local source", async () => {
@@ -67,8 +98,7 @@ describe("loadMessages", () => {
             nodeishFs: {},
         });
         expect(await resolved.data.loadMessages({
-            languageTags: ["en"],
-            sourceLanguageTag: "en",
+            settings: {},
         })).toEqual([{ id: "test", expressions: [], selectors: [], variants: [] }]);
     });
     it("should collect an error if function is defined twice in multiple plugins", async () => {

package/dist/resolve-modules/plugins/types.d.ts

@@ -1,9 +1,8 @@
-import type { LanguageTag } from "@inlang/language-tag";
 import type { NodeishFilesystem as LisaNodeishFilesystem } from "@lix-js/fs";
 import type { PluginReturnedInvalidCustomApiError, PluginLoadMessagesFunctionAlreadyDefinedError, PluginSaveMessagesFunctionAlreadyDefinedError, PluginHasInvalidIdError, PluginHasInvalidSchemaError, PluginUsesReservedNamespaceError, PluginsDoNotProvideLoadOrSaveMessagesError } from "./errors.js";
 import type { Message } from "@inlang/message";
-import type { JSONObject } from "@inlang/json-types";
 import type { CustomApiInlangIdeExtension, Plugin } from "@inlang/plugin";
+import type { ProjectSettings } from "@inlang/project-settings";
 /**
  * The filesystem is a subset of project lisa's nodeish filesystem.
  *
@@ -15,7 +14,7 @@ export type NodeishFilesystemSubset = Pick<LisaNodeishFilesystem, "readFile" | "
  */
 export type ResolvePluginsFunction = (args: {
     plugins: Array<Plugin>;
-    settings: Record<Plugin["id"], JSONObject>;
+    settings: ProjectSettings;
     nodeishFs: NodeishFilesystemSubset;
 }) => Promise<{
     data: ResolvedPluginApi;
@@ -26,10 +25,10 @@ export type ResolvePluginsFunction = (args: {
  */
 export type ResolvedPluginApi = {
     loadMessages: (args: {
-        languageTags: LanguageTag[];
-        sourceLanguageTag: LanguageTag;
+        settings: ProjectSettings;
     }) => Promise<Message[]> | Message[];
     saveMessages: (args: {
+        settings: ProjectSettings;
         messages: Message[];
     }) => Promise<void> | void;
     /**

package/dist/resolve-modules/plugins/types.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"types.d.ts","sourceRoot":"","sources":["../../../src/resolve-modules/plugins/types.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,sBAAsB,CAAA;AACvD,OAAO,KAAK,EAAE,iBAAiB,IAAI,qBAAqB,EAAE,MAAM,YAAY,CAAA;AAC5E,OAAO,KAAK,EACX,mCAAmC,EACnC,6CAA6C,EAC7C,6CAA6C,EAC7C,uBAAuB,EACvB,2BAA2B,EAC3B,gCAAgC,EAChC,0CAA0C,EAC1C,MAAM,aAAa,CAAA;AACpB,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,iBAAiB,CAAA;AAC9C,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,oBAAoB,CAAA;AACpD,OAAO,KAAK,EAAE,2BAA2B,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAA;AAEzE;;;;GAIG;AACH,MAAM,MAAM,uBAAuB,GAAG,IAAI,CACzC,qBAAqB,EACrB,UAAU,GAAG,SAAS,GAAG,OAAO,GAAG,WAAW,CAC9C,CAAA;AAED;;GAEG;AACH,MAAM,MAAM,sBAAsB,GAAG,CAAC,IAAI,EAAE;IAC3C,OAAO,EAAE,KAAK,CAAC,MAAM,CAAC,CAAA;IACtB,QAAQ,EAAE,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,UAAU,CAAC,CAAA;IAC1C,SAAS,EAAE,uBAAuB,CAAA;CAClC,KAAK,OAAO,CAAC;IACb,IAAI,EAAE,iBAAiB,CAAA;IACvB,MAAM,EAAE,KAAK,CACV,mCAAmC,GACnC,6CAA6C,GAC7C,6CAA6C,GAC7C,uBAAuB,GACvB,2BAA2B,GAC3B,gCAAgC,GAChC,0CAA0C,CAC5C,CAAA;CACD,CAAC,CAAA;AAEF;;GAEG;AACH,MAAM,MAAM,iBAAiB,GAAG;IAC/B,YAAY,EAAE,CAAC,IAAI,EAAE;QACpB,YAAY,EAAE,WAAW,EAAE,CAAA;QAC3B,iBAAiB,EAAE,WAAW,CAAA;KAC9B,KAAK,OAAO,CAAC,OAAO,EAAE,CAAC,GAAG,OAAO,EAAE,CAAA;IACpC,YAAY,EAAE,CAAC,IAAI,EAAE;QAAE,QAAQ,EAAE,OAAO,EAAE,CAAA;KAAE,KAAK,OAAO,CAAC,IAAI,CAAC,GAAG,IAAI,CAAA;IACrE;;;;;;;;;;;;;;;;OAgBG;IACH,SAAS,EAAE,MAAM,CAAC,OAAO,MAAM,IAAI,MAAM,EAAE,GAAG,WAAW,MAAM,IAAI,MAAM,EAAE,EAAE,OAAO,CAAC,GAAG;QACvF,yBAAyB,CAAC,EAAE,2BAA2B,CAAA;KACvD,CAAA;CACD,CAAA"}
+{"version":3,"file":"types.d.ts","sourceRoot":"","sources":["../../../src/resolve-modules/plugins/types.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,iBAAiB,IAAI,qBAAqB,EAAE,MAAM,YAAY,CAAA;AAC5E,OAAO,KAAK,EACX,mCAAmC,EACnC,6CAA6C,EAC7C,6CAA6C,EAC7C,uBAAuB,EACvB,2BAA2B,EAC3B,gCAAgC,EAChC,0CAA0C,EAC1C,MAAM,aAAa,CAAA;AACpB,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,iBAAiB,CAAA;AAC9C,OAAO,KAAK,EAAE,2BAA2B,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAA;AACzE,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,0BAA0B,CAAA;AAE/D;;;;GAIG;AACH,MAAM,MAAM,uBAAuB,GAAG,IAAI,CACzC,qBAAqB,EACrB,UAAU,GAAG,SAAS,GAAG,OAAO,GAAG,WAAW,CAC9C,CAAA;AAED;;GAEG;AACH,MAAM,MAAM,sBAAsB,GAAG,CAAC,IAAI,EAAE;IAC3C,OAAO,EAAE,KAAK,CAAC,MAAM,CAAC,CAAA;IACtB,QAAQ,EAAE,eAAe,CAAA;IACzB,SAAS,EAAE,uBAAuB,CAAA;CAClC,KAAK,OAAO,CAAC;IACb,IAAI,EAAE,iBAAiB,CAAA;IACvB,MAAM,EAAE,KAAK,CACV,mCAAmC,GACnC,6CAA6C,GAC7C,6CAA6C,GAC7C,uBAAuB,GACvB,2BAA2B,GAC3B,gCAAgC,GAChC,0CAA0C,CAC5C,CAAA;CACD,CAAC,CAAA;AAEF;;GAEG;AACH,MAAM,MAAM,iBAAiB,GAAG;IAC/B,YAAY,EAAE,CAAC,IAAI,EAAE;QAAE,QAAQ,EAAE,eAAe,CAAA;KAAE,KAAK,OAAO,CAAC,OAAO,EAAE,CAAC,GAAG,OAAO,EAAE,CAAA;IACrF,YAAY,EAAE,CAAC,IAAI,EAAE;QAAE,QAAQ,EAAE,eAAe,CAAC;QAAC,QAAQ,EAAE,OAAO,EAAE,CAAA;KAAE,KAAK,OAAO,CAAC,IAAI,CAAC,GAAG,IAAI,CAAA;IAChG;;;;;;;;;;;;;;;;OAgBG;IACH,SAAS,EAAE,MAAM,CAAC,OAAO,MAAM,IAAI,MAAM,EAAE,GAAG,WAAW,MAAM,IAAI,MAAM,EAAE,EAAE,OAAO,CAAC,GAAG;QACvF,yBAAyB,CAAC,EAAE,2BAA2B,CAAA;KACvD,CAAA;CACD,CAAA"}

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@inlang/sdk",
 	"type": "module",
-	"version": "0.8.0",
+	"version": "0.9.0",
 	"license": "Apache-2.0",
 	"publishConfig": {
 		"access": "public"

package/src/adapter/solidAdapter.test.ts

@@ -175,7 +175,7 @@ describe("messages", () => {
 			description: {
 				en: "wo",
 			},
-			loadMessages: ({ languageTags }) => (languageTags.length ? exampleMessages : []),
+			loadMessages: ({ settings }) => (settings.languageTags.length ? exampleMessages : []),
 			saveMessages: () => undefined,
 		}
 

package/src/loadProject.test.ts

@@ -482,17 +482,16 @@ describe("functionality", () => {
 		it("should call saveMessages() on updates", async () => {
 			const fs = createNodeishMemoryFs()
 
-			await fs.writeFile(
-				"./project.inlang.json",
-				JSON.stringify({
-					sourceLanguageTag: "en",
-					languageTags: ["en", "de"],
-					modules: ["plugin.js"],
-					"plugin.project.json": {
-						pathPattern: "./resources/{languageTag}.json",
-					},
-				})
-			)
+			const settings: ProjectSettings = {
+				sourceLanguageTag: "en",
+				languageTags: ["en", "de"],
+				modules: ["plugin.js"],
+				"plugin.project.json": {
+					pathPattern: "./resources/{languageTag}.json",
+				},
+			}
+
+			await fs.writeFile("./project.inlang.json", JSON.stringify(settings))
 
 			await fs.mkdir("./resources")
 
@@ -583,9 +582,7 @@ describe("functionality", () => {
 
 			expect(mockSaveFn.mock.calls.length).toBe(1)
 
-			expect(mockSaveFn.mock.calls[0][0].settings).toStrictEqual({
-				pathPattern: "./resources/{languageTag}.json",
-			})
+			expect(mockSaveFn.mock.calls[0][0].settings).toStrictEqual(settings)
 
 			expect(Object.values(mockSaveFn.mock.calls[0][0].messages)).toStrictEqual([
 				{

package/src/loadProject.ts

@@ -113,8 +113,7 @@ export const loadProject = async (args: {
 
 			makeTrulyAsync(
 				_resolvedModules.resolvedPluginApi.loadMessages({
-					languageTags: settingsValue!.languageTags,
-					sourceLanguageTag: settingsValue!.sourceLanguageTag,
+					settings: settingsValue,
 				})
 			)
 				.then((messages) => {
@@ -174,7 +173,10 @@ export const loadProject = async (args: {
 				500,
 				async (newMessages) => {
 					try {
-						await resolvedModules()?.resolvedPluginApi.saveMessages({ messages: newMessages })
+						await resolvedModules()?.resolvedPluginApi.saveMessages({
+							settings: settingsValue,
+							messages: newMessages,
+						})
 					} catch (err) {
 						throw new PluginSaveMessagesError("Error in saving messages", {
 							cause: err,

package/src/resolve-modules/plugins/resolvePlugins.test.ts

@@ -11,65 +11,98 @@ import {
 	PluginsDoNotProvideLoadOrSaveMessagesError,
 } from "./errors.js"
 import type { Plugin } from "@inlang/plugin"
+import type { ProjectSettings } from "@inlang/project-settings"
+
+it("should return an error if a plugin uses an invalid id", async () => {
+	const mockPlugin: Plugin = {
+		// @ts-expect-error - invalid id
+		id: "no-namespace",
+		description: { en: "My plugin description" },
+		displayName: { en: "My plugin" },
+		loadMessages: () => undefined as any,
+		saveMessages: () => undefined as any,
+	}
+
+	const resolved = await resolvePlugins({
+		plugins: [mockPlugin],
+		settings: {} as any as any,
+		nodeishFs: {} as any,
+	})
 
-describe("generally", () => {
-	it("should return an error if a plugin uses an invalid id", async () => {
-		const mockPlugin: Plugin = {
-			// @ts-expect-error - invalid id
-			id: "no-namespace",
-			description: { en: "My plugin description" },
-			displayName: { en: "My plugin" },
-			loadMessages: () => undefined as any,
-			saveMessages: () => undefined as any,
-		}
-
-		const resolved = await resolvePlugins({
-			plugins: [mockPlugin],
-			settings: {},
-			nodeishFs: {} as any,
-		})
+	expect(resolved.errors[0]).toBeInstanceOf(PluginHasInvalidIdError)
+})
 
-		expect(resolved.errors[0]).toBeInstanceOf(PluginHasInvalidIdError)
+it("should return an error if a plugin uses APIs that are not available", async () => {
+	const mockPlugin: Plugin = {
+		id: "plugin.namespace.undefinedApi",
+		description: { en: "My plugin description" },
+		displayName: { en: "My plugin" },
+		// @ts-expect-error the key is not available in type
+		nonExistentKey: {
+			nonexistentOptions: "value",
+		},
+		loadMessages: () => undefined as any,
+		saveMessages: () => undefined as any,
+	}
+
+	const resolved = await resolvePlugins({
+		plugins: [mockPlugin],
+		settings: {} as any,
+		nodeishFs: {} as any,
 	})
 
-	it("should return an error if a plugin uses APIs that are not available", async () => {
-		const mockPlugin: Plugin = {
-			id: "plugin.namespace.undefinedApi",
-			description: { en: "My plugin description" },
-			displayName: { en: "My plugin" },
-			// @ts-expect-error the key is not available in type
-			nonExistentKey: {
-				nonexistentOptions: "value",
-			},
-			loadMessages: () => undefined as any,
-			saveMessages: () => undefined as any,
-		}
-
-		const resolved = await resolvePlugins({
-			plugins: [mockPlugin],
-			settings: {},
-			nodeishFs: {} as any,
-		})
+	expect(resolved.errors[0]).toBeInstanceOf(PluginHasInvalidSchemaError)
+})
 
-		expect(resolved.errors[0]).toBeInstanceOf(PluginHasInvalidSchemaError)
+it("should not initialize a plugin that uses the 'inlang' namespace except for inlang whitelisted plugins", async () => {
+	const mockPlugin: Plugin = {
+		id: "plugin.inlang.notWhitelisted",
+		description: { en: "My plugin description" },
+		displayName: { en: "My plugin" },
+		loadMessages: () => undefined as any,
+	}
+
+	const resolved = await resolvePlugins({
+		plugins: [mockPlugin],
+		settings: {} as any,
+		nodeishFs: {} as any,
 	})
 
-	it("should not initialize a plugin that uses the 'inlang' namespace except for inlang whitelisted plugins", async () => {
-		const mockPlugin: Plugin = {
-			id: "plugin.inlang.notWhitelisted",
-			description: { en: "My plugin description" },
-			displayName: { en: "My plugin" },
-			loadMessages: () => undefined as any,
-		}
-
-		const resolved = await resolvePlugins({
-			plugins: [mockPlugin],
-			settings: {},
-			nodeishFs: {} as any,
-		})
+	expect(resolved.errors[0]).toBeInstanceOf(PluginUsesReservedNamespaceError)
+})
 
-		expect(resolved.errors[0]).toBeInstanceOf(PluginUsesReservedNamespaceError)
+it("should expose the project settings including the plugin settings", async () => {
+	const settings: ProjectSettings = {
+		sourceLanguageTag: "en",
+		languageTags: ["en", "de"],
+		modules: [],
+		"plugin.namespace.placeholder": {
+			myPluginSetting: "value",
+		},
+	}
+	const mockPlugin: Plugin = {
+		id: "plugin.namespace.placeholder",
+		description: { en: "My plugin description" },
+		displayName: { en: "My plugin" },
+		saveMessages: async ({ settings }) => {
+			expect(settings).toStrictEqual(settings)
+		},
+		addCustomApi: ({ settings }) => {
+			expect(settings).toStrictEqual(settings)
+			return {}
+		},
+		loadMessages: async ({ settings }) => {
+			expect(settings).toStrictEqual(settings)
+			return []
+		},
+	}
+	const resolved = await resolvePlugins({
+		plugins: [mockPlugin],
+		settings: settings,
+		nodeishFs: {} as any,
 	})
+	await resolved.data.loadMessages!({ settings })
+	await resolved.data.saveMessages!({ settings, messages: [] })
 })
 
 describe("loadMessages", () => {
@@ -83,14 +116,13 @@ describe("loadMessages", () => {
 
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin],
-			settings: {},
+			settings: {} as any,
 			nodeishFs: {} as any,
 		})
 
 		expect(
 			await resolved.data.loadMessages!({
-				languageTags: ["en"],
-				sourceLanguageTag: "en",
+				settings: {} as any,
 			})
 		).toEqual([{ id: "test", expressions: [], selectors: [], variants: [] }])
 	})
@@ -112,7 +144,7 @@ describe("loadMessages", () => {
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin, mockPlugin2],
 			nodeishFs: {} as any,
-			settings: {},
+			settings: {} as any,
 		})
 
 		expect(resolved.errors[0]).toBeInstanceOf(PluginLoadMessagesFunctionAlreadyDefinedError)
@@ -129,7 +161,7 @@ describe("loadMessages", () => {
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin],
 			nodeishFs: {} as any,
-			settings: {},
+			settings: {} as any,
 		})
 
 		expect(resolved.errors).toHaveLength(1)
@@ -150,7 +182,7 @@ describe("saveMessages", () => {
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin],
 			nodeishFs: {} as any,
-			settings: {},
+			settings: {} as any,
 		})
 
 		expect(resolved.errors).toHaveLength(0)
@@ -173,7 +205,7 @@ describe("saveMessages", () => {
 
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin, mockPlugin2],
-			settings: {},
+			settings: {} as any,
 			nodeishFs: {} as any,
 		})
 
@@ -191,7 +223,7 @@ describe("saveMessages", () => {
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin],
 			nodeishFs: {} as any,
-			settings: {},
+			settings: {} as any,
 		})
 		expect(resolved.errors).toHaveLength(1)
 		expect(resolved.errors[0]).toBeInstanceOf(PluginsDoNotProvideLoadOrSaveMessagesError)
@@ -214,7 +246,7 @@ describe("addCustomApi", () => {
 
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin],
-			settings: {},
+			settings: {} as any,
 			nodeishFs: {} as any,
 		})
 
@@ -249,7 +281,7 @@ describe("addCustomApi", () => {
 
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin, mockPlugin2],
-			settings: {},
+			settings: {} as any,
 			nodeishFs: {} as any,
 		})
 
@@ -269,7 +301,7 @@ describe("addCustomApi", () => {
 
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin],
-			settings: {},
+			settings: {} as any,
 			nodeishFs: {} as any,
 		})
 
@@ -292,7 +324,7 @@ describe("addCustomApi", () => {
 
 		const resolved = await resolvePlugins({
 			plugins: [mockPlugin],
-			settings: {},
+			settings: {} as any,
 			nodeishFs: {} as any,
 		})
 

package/src/resolve-modules/plugins/resolvePlugins.ts

@@ -44,7 +44,7 @@ export const resolvePlugins: ResolvePluginsFunction = async (args) => {
 		if (hasInvalidId) {
 			result.errors.push(
 				new PluginHasInvalidIdError(
-					`Plugin ${plugin.id} has an invalid id "${plugin.id}". It must be kebap-case and contain a namespace like project.my-plugin.`,
+					`Plugin ${plugin.id} has an invalid id "${plugin.id}". It must be camelCase and contain a namespace like plugin.namespace.myPlugin.`,
 					{ plugin: plugin.id }
 				)
 			)
@@ -99,7 +99,7 @@ export const resolvePlugins: ResolvePluginsFunction = async (args) => {
 			// TODO: why do we call this function 2 times (here for validation and later for retrieving the actual value)?
 			const { data: customApi, error } = tryCatch(() =>
 				plugin.addCustomApi!({
-					settings: args.settings?.[plugin.id] ?? {},
+					settings: args.settings,
 				})
 			)
 			if (error) {
@@ -130,7 +130,6 @@ export const resolvePlugins: ResolvePluginsFunction = async (args) => {
 			result.data.loadMessages = (_args) =>
 				plugin.loadMessages!({
 					..._args,
-					settings: args.settings?.[plugin.id] ?? {},
 					nodeishFs: args.nodeishFs,
 				})
 		}
@@ -139,7 +138,6 @@ export const resolvePlugins: ResolvePluginsFunction = async (args) => {
 			result.data.saveMessages = (_args) =>
 				plugin.saveMessages!({
 					..._args,
-					settings: args.settings?.[plugin.id] ?? {},
 					nodeishFs: args.nodeishFs,
 				})
 		}
@@ -147,7 +145,7 @@ export const resolvePlugins: ResolvePluginsFunction = async (args) => {
 		if (typeof plugin.addCustomApi === "function") {
 			const { data: customApi } = tryCatch(() =>
 				plugin.addCustomApi!({
-					settings: args.settings?.[plugin.id] ?? {},
+					settings: args.settings,
 				})
 			)
 			if (customApi) {

package/src/resolve-modules/plugins/types.ts

@@ -1,4 +1,3 @@
-import type { LanguageTag } from "@inlang/language-tag"
 import type { NodeishFilesystem as LisaNodeishFilesystem } from "@lix-js/fs"
 import type {
 	PluginReturnedInvalidCustomApiError,
@@ -10,8 +9,8 @@ import type {
 	PluginsDoNotProvideLoadOrSaveMessagesError,
 } from "./errors.js"
 import type { Message } from "@inlang/message"
-import type { JSONObject } from "@inlang/json-types"
 import type { CustomApiInlangIdeExtension, Plugin } from "@inlang/plugin"
+import type { ProjectSettings } from "@inlang/project-settings"
 
 /**
  * The filesystem is a subset of project lisa's nodeish filesystem.
@@ -28,7 +27,7 @@ export type NodeishFilesystemSubset = Pick<
  */
 export type ResolvePluginsFunction = (args: {
 	plugins: Array<Plugin>
-	settings: Record<Plugin["id"], JSONObject>
+	settings: ProjectSettings
 	nodeishFs: NodeishFilesystemSubset
 }) => Promise<{
 	data: ResolvedPluginApi
@@ -47,11 +46,8 @@ export type ResolvePluginsFunction = (args: {
  * The API after resolving the plugins.
  */
 export type ResolvedPluginApi = {
-	loadMessages: (args: {
-		languageTags: LanguageTag[]
-		sourceLanguageTag: LanguageTag
-	}) => Promise<Message[]> | Message[]
-	saveMessages: (args: { messages: Message[] }) => Promise<void> | void
+	loadMessages: (args: { settings: ProjectSettings }) => Promise<Message[]> | Message[]
+	saveMessages: (args: { settings: ProjectSettings; messages: Message[] }) => Promise<void> | void
 	/**
 	 * App specific APIs.
 	 *