@inlang/sdk 0.34.3 → 0.34.4

package/LICENSE

@@ -0,0 +1,201 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [2024] [Opral US Inc.]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

package/dist/adapter/solidAdapter.test.js

@@ -177,7 +177,7 @@ describe("messages", () => {
         project.setSettings({ ...project.settings(), languageTags: ["en"] });
         // TODO: how can we await `setConfig` correctly
         await new Promise((resolve) => setTimeout(resolve, 510));
-        expect(effectOnMessagesCounter).toBe(1); // 2 times because effect creation + set
+        expect(effectOnMessagesCounter).toBe(7); // 7 = initial effect, setSetting, loadMessage (2x - one per message), setResolvedPlugins, loadMessages (2x - one per message)
         expect(Object.values(project.query.messages.getAll()).length).toBe(2);
     });
     it("should react to message udpate", async () => {

package/dist/createMessagesQuery.d.ts

@@ -1,7 +1,19 @@
-import type { Message } from "@inlang/message";
 import type { InlangProject } from "./api.js";
+import type { resolveModules } from "./resolve-modules/resolveModules.js";
+import type { NodeishFilesystem } from "@lix-js/fs";
+import type { ProjectSettings } from "@inlang/project-settings";
+type createMessagesQueryParameters = {
+    projectPath: string;
+    nodeishFs: NodeishFilesystem;
+    settings: () => ProjectSettings | undefined;
+    resolvedModules: () => Awaited<ReturnType<typeof resolveModules>> | undefined;
+    onInitialMessageLoadResult: (e?: Error) => void;
+    onLoadMessageResult: (e?: Error) => void;
+    onSaveMessageResult: (e?: Error) => void;
+};
 /**
  * Creates a reactive query API for messages.
  */
-export declare function createMessagesQuery(messages: () => Array<Message>): InlangProject["query"]["messages"];
+export declare function createMessagesQuery({ projectPath, nodeishFs, settings, resolvedModules, onInitialMessageLoadResult, onLoadMessageResult, onSaveMessageResult, }: createMessagesQueryParameters): InlangProject["query"]["messages"];
+export {};
 //# sourceMappingURL=createMessagesQuery.d.ts.map

package/dist/createMessagesQuery.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"createMessagesQuery.d.ts","sourceRoot":"","sources":["../src/createMessagesQuery.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,iBAAiB,CAAA;AAI9C,OAAO,KAAK,EAAE,aAAa,EAAmB,MAAM,UAAU,CAAA;AAE9D;;GAEG;AACH,wBAAgB,mBAAmB,CAClC,QAAQ,EAAE,MAAM,KAAK,CAAC,OAAO,CAAC,GAC5B,aAAa,CAAC,OAAO,CAAC,CAAC,UAAU,CAAC,CAiFpC"}
+{"version":3,"file":"createMessagesQuery.d.ts","sourceRoot":"","sources":["../src/createMessagesQuery.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,aAAa,EAAmB,MAAM,UAAU,CAAA;AAE9D,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qCAAqC,CAAA;AAEzE,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,YAAY,CAAA;AAKnD,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,0BAA0B,CAAA;AAwB/D,KAAK,6BAA6B,GAAG;IACpC,WAAW,EAAE,MAAM,CAAA;IACnB,SAAS,EAAE,iBAAiB,CAAA;IAC5B,QAAQ,EAAE,MAAM,eAAe,GAAG,SAAS,CAAA;IAC3C,eAAe,EAAE,MAAM,OAAO,CAAC,UAAU,CAAC,OAAO,cAAc,CAAC,CAAC,GAAG,SAAS,CAAA;IAC7E,0BAA0B,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,KAAK,IAAI,CAAA;IAC/C,mBAAmB,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,KAAK,IAAI,CAAA;IACxC,mBAAmB,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,KAAK,IAAI,CAAA;CACxC,CAAA;AACD;;GAEG;AACH,wBAAgB,mBAAmB,CAAC,EACnC,WAAW,EACX,SAAS,EACT,QAAQ,EACR,eAAe,EACf,0BAA0B,EAC1B,mBAAmB,EACnB,mBAAmB,GACnB,EAAE,6BAA6B,GAAG,aAAa,CAAC,OAAO,CAAC,CAAC,UAAU,CAAC,CA6LpE"}

package/dist/createMessagesQuery.js

@@ -1,29 +1,112 @@
 import { ReactiveMap } from "./reactivity/map.js";
 import { createEffect } from "./reactivity/solid.js";
 import { createSubscribable } from "./loadProject.js";
+import { createNodeishFsWithWatcher } from "./createNodeishFsWithWatcher.js";
+import { onCleanup } from "solid-js";
+import { stringifyMessage } from "./storage/helper.js";
+import { acquireFileLock } from "./persistence/filelock/acquireFileLock.js";
+import _debug from "debug";
+import { releaseLock } from "./persistence/filelock/releaseLock.js";
+import { PluginLoadMessagesError, PluginSaveMessagesError } from "./errors.js";
+import { humanIdHash } from "./storage/human-id/human-readable-id.js";
+const debug = _debug("sdk:createMessagesQuery");
 /**
  * Creates a reactive query API for messages.
  */
-export function createMessagesQuery(messages) {
+export function createMessagesQuery({ projectPath, nodeishFs, settings, resolvedModules, onInitialMessageLoadResult, onLoadMessageResult, onSaveMessageResult, }) {
     // @ts-expect-error
     const index = new ReactiveMap();
+    // filepath for the lock folder
+    const messageLockDirPath = projectPath + "/messagelock";
     // Map default alias to message
     // Assumes that aliases are only created and deleted, not updated
     // TODO #2346 - handle updates to aliases
     // TODO #2346 - refine to hold messageId[], if default alias is not unique
     // @ts-expect-error
     const defaultAliasIndex = new ReactiveMap();
+    const messageStates = {
+        messageDirtyFlags: {},
+        messageLoadHash: {},
+        isSaving: false,
+        currentSaveMessagesViaPlugin: undefined,
+        sheduledSaveMessages: undefined,
+        isLoading: false,
+        sheduledLoadMessagesViaPlugin: undefined,
+    };
+    // triggered whenever settings or resolved modules change
     createEffect(() => {
+        // we clear the index independent from the change for
         index.clear();
-        for (const message of structuredClone(messages())) {
-            index.set(message.id, message);
-            if ("default" in message.alias) {
-                defaultAliasIndex.set(message.alias.default, message);
-            }
+        defaultAliasIndex.clear();
+        // Load messages -> use settings to subscribe to signals from the settings
+        const _settings = settings();
+        if (!_settings)
+            return;
+        // wait for first effect excution until modules are resolved
+        const resolvedPluginApi = resolvedModules()?.resolvedPluginApi;
+        if (!resolvedPluginApi)
+            return;
+        const abortController = new AbortController();
+        // called between executions of effects as well as on disposal
+        onCleanup(() => {
+            // stop listening on fs events
+            abortController.abort();
+        });
+        const fsWithWatcher = createNodeishFsWithWatcher({
+            nodeishFs: nodeishFs,
+            // this message is called whenever a file changes that was read earlier by this filesystem
+            // - the plugin loads messages -> reads the file messages.json -> start watching on messages.json -> updateMessages
+            updateMessages: () => {
+                // reload
+                loadMessagesViaPlugin(fsWithWatcher, messageLockDirPath, messageStates, index, _settings, // NOTE we bang here - we don't expect the settings to become null during the livetime of a project
+                resolvedPluginApi)
+                    .catch((e) => {
+                    onLoadMessageResult(e);
+                })
+                    .then(() => {
+                    onLoadMessageResult();
+                });
+            },
+            abortController,
+        });
+        if (!resolvedPluginApi.loadMessages) {
+            onInitialMessageLoadResult(new Error("no loadMessages in resolved Modules found"));
+            return;
         }
+        loadMessagesViaPlugin(fsWithWatcher, messageLockDirPath, messageStates, index, _settings, // NOTE we bang here - we don't expect the settings to become null during the livetime of a project
+        resolvedPluginApi)
+            .catch((e) => {
+            // propagate initial load error to calling laodProject function
+            onInitialMessageLoadResult(new PluginLoadMessagesError({ cause: e }));
+        })
+            .then(() => {
+            onInitialMessageLoadResult();
+        });
     });
     const get = (args) => index.get(args.where.id);
     const getByDefaultAlias = (alias) => defaultAliasIndex.get(alias);
+    const scheduleSave = function () {
+        // NOTE: we ignore save calls on a project without settings for now
+        const _settings = settings();
+        if (!_settings)
+            return;
+        // wait for first effect excution until modules are resolved
+        const resolvedPluginApi = resolvedModules()?.resolvedPluginApi;
+        if (!resolvedPluginApi)
+            return;
+        saveMessagesViaPlugin(nodeishFs, messageLockDirPath, messageStates, index, _settings, // NOTE we bang here - we don't expect the settings to become null during the livetime of a project
+        resolvedPluginApi)
+            .catch((e) => {
+            debug.log("error during saveMessagesViaPlugin");
+            debug.log(e);
+        })
+            .catch((e) => {
+            onSaveMessageResult(e);
+        })
+            .then(() => {
+            onSaveMessageResult();
+        });
+    };
     return {
         create: ({ data }) => {
             if (index.has(data.id))
@@ -32,6 +115,8 @@ export function createMessagesQuery(messages) {
             if ("default" in data.alias) {
                 defaultAliasIndex.set(data.alias.default, data);
             }
+            messageStates.messageDirtyFlags[data.id] = true;
+            scheduleSave();
             return true;
         },
         get: Object.assign(get, {
@@ -51,6 +136,8 @@ export function createMessagesQuery(messages) {
             if (message === undefined)
                 return false;
             index.set(where.id, { ...message, ...data });
+            messageStates.messageDirtyFlags[where.id] = true;
+            scheduleSave();
             return true;
         },
         upsert: ({ where, data }) => {
@@ -64,6 +151,8 @@ export function createMessagesQuery(messages) {
             else {
                 index.set(where.id, { ...message, ...data });
             }
+            messageStates.messageDirtyFlags[where.id] = true;
+            scheduleSave();
             return true;
         },
         delete: ({ where }) => {
@@ -74,7 +163,250 @@ export function createMessagesQuery(messages) {
                 defaultAliasIndex.delete(message.alias.default);
             }
             index.delete(where.id);
+            messageStates.messageDirtyFlags[where.id] = true;
+            scheduleSave();
             return true;
         },
     };
 }
+// --- serialization of loading / saving messages.
+// 1. A plugin saveMessage call can not be called simultaniously to avoid side effects - its an async function not controlled by us
+// 2. loading and saving must not run in "parallel".
+// - json plugin exports into separate file per language.
+// - saving a message in two different languages would lead to a write in de.json first
+// - This will leads to a load of the messages and since en.json has not been saved yet the english variant in the message would get overritten with the old state again
+/**
+ * Messsage that loads messages from a plugin - this method synchronizes with the saveMessage funciton.
+ * If a save is in progress loading will wait until saving is done. If another load kicks in during this load it will queue the
+ * load and execute it at the end of this load. subsequential loads will not be queued but the same promise will be reused
+ *
+ * - NOTE: this means that the parameters used to load like settingsValue and loadPlugin might not take into account. this has to be refactored
+ * with the loadProject restructuring
+ * @param fs
+ * @param messagesQuery
+ * @param settingsValue
+ * @param loadPlugin
+ * @returns void - updates the files and messages in of the project in place
+ */
+async function loadMessagesViaPlugin(fs, lockDirPath, messageState, messages, settingsValue, resolvedPluginApi) {
+    const experimentalAliases = !!settingsValue.experimental?.aliases;
+    // loading is an asynchronous process - check if another load is in progress - queue this call if so
+    if (messageState.isLoading) {
+        if (!messageState.sheduledLoadMessagesViaPlugin) {
+            messageState.sheduledLoadMessagesViaPlugin = createAwaitable();
+        }
+        // another load will take place right after the current one - its goingt to be idempotent form the current requested one - don't reschedule
+        return messageState.sheduledLoadMessagesViaPlugin.promise;
+    }
+    // set loading flag
+    messageState.isLoading = true;
+    let lockTime = undefined;
+    try {
+        lockTime = await acquireFileLock(fs, lockDirPath, "loadMessage");
+        const loadedMessages = await makeTrulyAsync(resolvedPluginApi.loadMessages({
+            settings: settingsValue,
+            nodeishFs: fs,
+        }));
+        for (const loadedMessage of loadedMessages) {
+            const loadedMessageClone = structuredClone(loadedMessage);
+            const currentMessages = [...messages.values()]
+                // TODO #1585 here we match using the id to support legacy load message plugins - after we introduced import / export methods we will use importedMessage.alias
+                .filter((message) => (experimentalAliases ? message.alias["default"] : message.id) === loadedMessage.id);
+            if (currentMessages.length > 1) {
+                // NOTE: if we happen to find two messages witht the sam alias we throw for now
+                // - this could be the case if one edits the aliase manualy
+                throw new Error("more than one message with the same id or alias found ");
+            }
+            else if (currentMessages.length === 1) {
+                // update message in place - leave message id and alias untouched
+                loadedMessageClone.alias = {};
+                // TODO #1585 we have to map the id of the importedMessage to the alias and fill the id property with the id of the existing message - change when import mesage provides importedMessage.alias
+                if (experimentalAliases) {
+                    loadedMessageClone.alias["default"] = loadedMessageClone.id;
+                    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- length has checked beforhand
+                    loadedMessageClone.id = currentMessages[0].id;
+                }
+                // NOTE stringifyMessage encodes messages independent from key order!
+                const importedEnecoded = stringifyMessage(loadedMessageClone);
+                // NOTE could use hash instead of the whole object JSON to save memory...
+                if (messageState.messageLoadHash[loadedMessageClone.id] === importedEnecoded) {
+                    // debug("skipping upsert!")
+                    continue;
+                }
+                // This logic is preventing cycles - could also be handled if update api had a parameter for who triggered update
+                // e.g. when FS was updated, we don't need to write back to FS
+                // update is synchronous, so update effect will be triggered immediately
+                // NOTE: this might trigger a save before we have the chance to delete - but since save is async and waits for the lock acquired by this method - its save to set the flags afterwards
+                messages.set(loadedMessageClone.id, loadedMessageClone);
+                // NOTE could use hash instead of the whole object JSON to save memory...
+                messageState.messageLoadHash[loadedMessageClone.id] = importedEnecoded;
+            }
+            else {
+                // message with the given alias does not exist so far
+                loadedMessageClone.alias = {};
+                // TODO #1585 we have to map the id of the importedMessage to the alias - change when import mesage provides importedMessage.alias
+                if (experimentalAliases) {
+                    loadedMessageClone.alias["default"] = loadedMessageClone.id;
+                    let currentOffset = 0;
+                    let messsageId;
+                    do {
+                        messsageId = humanIdHash(loadedMessageClone.id, currentOffset);
+                        if (messages.get(messsageId)) {
+                            currentOffset += 1;
+                            messsageId = undefined;
+                        }
+                    } while (messsageId === undefined);
+                    // create a humanId based on a hash of the alias
+                    loadedMessageClone.id = messsageId;
+                }
+                const importedEnecoded = stringifyMessage(loadedMessageClone);
+                // we don't have to check - done before hand if (messages.has(loadedMessageClone.id)) return false
+                messages.set(loadedMessageClone.id, loadedMessageClone);
+                messageState.messageLoadHash[loadedMessageClone.id] = importedEnecoded;
+            }
+        }
+        await releaseLock(fs, lockDirPath, "loadMessage", lockTime);
+        lockTime = undefined;
+        debug("loadMessagesViaPlugin: " + loadedMessages.length + " Messages processed ");
+        messageState.isLoading = false;
+    }
+    finally {
+        if (lockTime !== undefined) {
+            await releaseLock(fs, lockDirPath, "loadMessage", lockTime);
+        }
+        messageState.isLoading = false;
+    }
+    const executingScheduledMessages = messageState.sheduledLoadMessagesViaPlugin;
+    if (executingScheduledMessages) {
+        // a load has been requested during the load - executed it
+        // reset sheduling to except scheduling again
+        messageState.sheduledLoadMessagesViaPlugin = undefined;
+        // recall load unawaited to allow stack to pop
+        loadMessagesViaPlugin(fs, lockDirPath, messageState, messages, settingsValue, resolvedPluginApi)
+            .then(() => {
+            // resolve the scheduled load message promise
+            executingScheduledMessages.resolve();
+        })
+            .catch((e) => {
+            // reject the scheduled load message promise
+            executingScheduledMessages.reject(e);
+        });
+    }
+}
+async function saveMessagesViaPlugin(fs, lockDirPath, messageState, messages, settingsValue, resolvedPluginApi) {
+    // queue next save if we have a save ongoing
+    if (messageState.isSaving) {
+        if (!messageState.sheduledSaveMessages) {
+            messageState.sheduledSaveMessages = createAwaitable();
+        }
+        return messageState.sheduledSaveMessages.promise;
+    }
+    // set isSavingFlag
+    messageState.isSaving = true;
+    messageState.currentSaveMessagesViaPlugin = (async function () {
+        const saveMessageHashes = {};
+        // check if we have any dirty message - witho
+        if (Object.keys(messageState.messageDirtyFlags).length == 0) {
+            // nothing to save :-)
+            debug("save was skipped - no messages marked as dirty... build!");
+            messageState.isSaving = false;
+            return;
+        }
+        let messageDirtyFlagsBeforeSave;
+        let lockTime;
+        try {
+            lockTime = await acquireFileLock(fs, lockDirPath, "saveMessage");
+            // since it may takes some time to acquire the lock we check if the save is required still (loadMessage could have happend in between)
+            if (Object.keys(messageState.messageDirtyFlags).length == 0) {
+                debug("save was skipped - no messages marked as dirty... releasing lock again");
+                messageState.isSaving = false;
+                // release lock in finally block
+                return;
+            }
+            const currentMessages = [...messages.values()];
+            const messagesToExport = [];
+            for (const message of currentMessages) {
+                if (messageState.messageDirtyFlags[message.id]) {
+                    const importedEnecoded = stringifyMessage(message);
+                    // NOTE: could use hash instead of the whole object JSON to save memory...
+                    saveMessageHashes[message.id] = importedEnecoded;
+                }
+                const fixedExportMessage = { ...message };
+                // TODO #1585 here we match using the id to support legacy load message plugins - after we introduced import / export methods we will use importedMessage.alias
+                if (settingsValue.experimental?.aliases) {
+                    fixedExportMessage.id = fixedExportMessage.alias["default"] ?? fixedExportMessage.id;
+                }
+                messagesToExport.push(fixedExportMessage);
+            }
+            // wa are about to save the messages to the plugin - reset all flags now
+            messageDirtyFlagsBeforeSave = { ...messageState.messageDirtyFlags };
+            messageState.messageDirtyFlags = {};
+            // NOTE: this assumes that the plugin will handle message ordering
+            await resolvedPluginApi.saveMessages({
+                settings: settingsValue,
+                messages: messagesToExport,
+                nodeishFs: fs,
+            });
+            for (const [messageId, messageHash] of Object.entries(saveMessageHashes)) {
+                messageState.messageLoadHash[messageId] = messageHash;
+            }
+            if (lockTime !== undefined) {
+                await releaseLock(fs, lockDirPath, "saveMessage", lockTime);
+                lockTime = undefined;
+            }
+            // if there is a queued load, allow it to take the lock before we run additional saves.
+            if (messageState.sheduledLoadMessagesViaPlugin) {
+                debug("saveMessagesViaPlugin calling queued loadMessagesViaPlugin to share lock");
+                await loadMessagesViaPlugin(fs, lockDirPath, messageState, messages, settingsValue, resolvedPluginApi);
+            }
+            messageState.isSaving = false;
+        }
+        catch (err) {
+            // something went wrong - add dirty flags again
+            if (messageDirtyFlagsBeforeSave !== undefined) {
+                for (const dirtyMessageId of Object.keys(messageDirtyFlagsBeforeSave)) {
+                    messageState.messageDirtyFlags[dirtyMessageId] = true;
+                }
+            }
+            if (lockTime !== undefined) {
+                await releaseLock(fs, lockDirPath, "saveMessage", lockTime);
+                lockTime = undefined;
+            }
+            messageState.isSaving = false;
+            // ok an error
+            throw new PluginSaveMessagesError({
+                cause: err,
+            });
+        }
+        finally {
+            if (lockTime !== undefined) {
+                await releaseLock(fs, lockDirPath, "saveMessage", lockTime);
+                lockTime = undefined;
+            }
+            messageState.isSaving = false;
+        }
+    })();
+    await messageState.currentSaveMessagesViaPlugin;
+    if (messageState.sheduledSaveMessages) {
+        const executingSheduledSaveMessages = messageState.sheduledSaveMessages;
+        messageState.sheduledSaveMessages = undefined;
+        saveMessagesViaPlugin(fs, lockDirPath, messageState, messages, settingsValue, resolvedPluginApi)
+            .then(() => {
+            executingSheduledSaveMessages.resolve();
+        })
+            .catch((e) => {
+            executingSheduledSaveMessages.reject(e);
+        });
+    }
+}
+const makeTrulyAsync = (fn) => (async () => fn)();
+const createAwaitable = () => {
+    let resolve;
+    let reject;
+    const promise = new Promise((res, rej) => {
+        resolve = res;
+        reject = rej;
+    });
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- those properties get set by new Promise, TS can't know this
+    return { promise, resolve: resolve, reject: reject };
+};