@infodb/p3 0.10.0 → 0.12.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +6 -1
- package/dist/web/assets/ImprovementDialog-kQaVBGWH.js +1 -0
- package/dist/web/assets/Outputs-_nU_p3nu.js +1 -0
- package/dist/web/assets/{RequestStatus-DGaoQoIa.js → RequestStatus-RG-OVQYY.js} +1 -1
- package/dist/web/assets/{Tabs-D16MqQxu.js → Tabs-ew9i5SKX.js} +1 -1
- package/dist/web/assets/TagInput-BtlJTF7i.js +1 -0
- package/dist/web/assets/TaskDrawer-DW8GyJqI.js +6 -0
- package/dist/web/assets/_requestId-6Nb727dD.js +1 -0
- package/dist/web/assets/_requestId-BykTgPax.js +1 -0
- package/dist/web/assets/appCtx-CxDdXABS.js +1 -0
- package/dist/web/assets/archive-Ckh295Xe.js +1 -0
- package/dist/web/assets/board-BVAIjK-Y.js +1 -0
- package/dist/web/assets/done-BGfA-3MA.js +1 -0
- package/dist/web/assets/index-CgRU744I.css +2 -0
- package/dist/web/assets/index-DacQ0yl4.js +12 -0
- package/dist/web/assets/{new-ChFzBoL2.js → new-DVygWvVc.js} +1 -1
- package/dist/web/assets/outputs-B6xDsLZf.js +1 -0
- package/dist/web/assets/preload-helper-DyCqp21K.js +1 -0
- package/dist/web/assets/quality-Pu6EISAM.js +1 -0
- package/dist/web/assets/release-notes-CCpzyiNf.js +5 -0
- package/dist/web/assets/requestData-D5vBnuMh.js +1 -0
- package/dist/web/assets/routes-Q91zvNc0.js +4 -0
- package/dist/web/assets/settings-BzRgcmUm.js +1 -0
- package/dist/web/assets/taskReview-_WCgnQit.js +1 -0
- package/dist/web/assets/workTarget-C9c57JAO.js +30 -0
- package/dist/web/index.html +4 -4
- package/docs/architecture.md +392 -3
- package/docs/development.md +1 -1
- package/docs/how-to-use.md +261 -5
- package/docs/installation.md +5 -5
- package/lib/cli/args.js +45 -0
- package/lib/cli/help.js +43 -1
- package/lib/cli/main.js +42 -4
- package/lib/cli/output.js +9 -1
- package/lib/cli/preflightCommands.js +7 -1
- package/lib/cli/project.js +3 -0
- package/lib/cli/qualityCommands.js +163 -0
- package/lib/cli/readOnly.js +2 -0
- package/lib/cli/requestCommands.js +219 -14
- package/lib/cli/showView.js +69 -3
- package/lib/cli/taskCommands.js +312 -17
- package/lib/cli/taskReviewCommands.js +178 -0
- package/lib/core/context.js +7 -1
- package/lib/core/milestoneReview/code.js +129 -0
- package/lib/core/milestoneReview/material.js +148 -0
- package/lib/core/milestoneReview/mockReviewer.js +28 -0
- package/lib/core/milestoneReview/review.js +325 -0
- package/lib/core/milestoneReview/service.js +214 -0
- package/lib/core/milestoneReview/store.js +176 -0
- package/lib/core/ops.js +9 -2
- package/lib/core/preflight/carryover.js +1 -1
- package/lib/core/preflight/codexEngine.js +20 -6
- package/lib/core/preflight/engine.js +6 -0
- package/lib/core/preflight/instructions.js +18 -1
- package/lib/core/preflight/mockEngine.js +4 -0
- package/lib/core/preflight/service.js +45 -4
- package/lib/core/projectRegistry.js +3 -3
- package/lib/core/quality.js +21 -0
- package/lib/core/qualityImprovement.js +221 -0
- package/lib/core/requestOps.js +101 -6
- package/lib/core/reviewRuns.js +205 -0
- package/lib/core/store/archivedTasks.js +74 -0
- package/lib/core/store/collection.js +12 -2
- package/lib/core/store/normalize.js +43 -2
- package/lib/core/store/preflightStore.js +9 -1
- package/lib/core/store/projectFile.js +18 -1
- package/lib/core/store/workspace.js +122 -14
- package/lib/core/taskReview/material.js +452 -0
- package/lib/core/taskReview/mockReviewer.js +30 -0
- package/lib/core/taskReview/paths.js +15 -0
- package/lib/core/taskReview/review.js +305 -0
- package/lib/core/taskReview/service.js +187 -0
- package/lib/core/taskReview/store.js +214 -0
- package/lib/server/api/manifest.js +74 -5
- package/lib/server/api/milestoneReviewRoutes.js +70 -0
- package/lib/server/api/routes.js +164 -20
- package/lib/server/api/taskReviewRoutes.js +66 -0
- package/lib/server/server.js +2 -2
- package/lib/shared/acceptance.js +378 -0
- package/lib/shared/milestoneGoals.js +57 -0
- package/lib/shared/milestoneReview.js +27 -0
- package/lib/shared/quality.js +391 -0
- package/lib/shared/qualityImprovement.js +1 -0
- package/lib/shared/qualityTemplates.js +31 -0
- package/lib/shared/taskBlock.js +142 -0
- package/lib/shared/taskReview.js +56 -0
- package/package.json +1 -1
- package/skills/p3/SKILL.md +31 -2
- package/dist/web/assets/Outputs-B4Tr7JzU.js +0 -1
- package/dist/web/assets/TagInput-pSYxm4bz.js +0 -1
- package/dist/web/assets/TaskDrawer-1Ev3RpRV.js +0 -3
- package/dist/web/assets/_requestId-BKhn019m.js +0 -1
- package/dist/web/assets/_requestId-Btpvuu7-.js +0 -30
- package/dist/web/assets/appCtx-D_Iaoh2e.js +0 -1
- package/dist/web/assets/board-DeHdxbN4.js +0 -1
- package/dist/web/assets/done-BFaHGt03.js +0 -1
- package/dist/web/assets/index-BF1xMdJo.css +0 -2
- package/dist/web/assets/index-CDWcKy1L.js +0 -12
- package/dist/web/assets/preload-helper-hSId95YD.js +0 -1
- package/dist/web/assets/release-notes-BWNDFDkH.js +0 -3
- package/dist/web/assets/requestData-B_320uxL.js +0 -1
- package/dist/web/assets/routes-BBD464IS.js +0 -3
- package/dist/web/assets/settings-D7PPrGjT.js +0 -1
- package/dist/web/assets/workTarget-Cijqq4yH.js +0 -1
|
@@ -0,0 +1,221 @@
|
|
|
1
|
+
import { createHash, randomBytes } from "node:crypto";
|
|
2
|
+
import { readFile } from "node:fs/promises";
|
|
3
|
+
import { join } from "node:path";
|
|
4
|
+
import { checkLine } from "../shared/quality.js";
|
|
5
|
+
import { createRequest } from "./requestOps.js";
|
|
6
|
+
import { withFileLock, writeFileAtomic } from "./store/fsutil.js";
|
|
7
|
+
/**
|
|
8
|
+
* 品質の不足から改善要望を作る(CLI の p3 quality improve・API の /quality/improvements)。
|
|
9
|
+
*
|
|
10
|
+
* - 診断: 品質基準の設定(未設定・読めない・除外)、タスクのレビュー・マイルストーンレビューの1回分(違反・判断できない・除外)から、
|
|
11
|
+
* 不足を区別して出す(読むだけ)。検査が未実行だから未導入とは判定しない(判断できないのまま)。除外は不足に数えず、選べるだけ
|
|
12
|
+
* - 原稿: 人が選んだ不足だけで要望の題と本文の案を作る(品質 ID・版・元の run・指摘・根拠・目指す差・完了条件の案)。原稿は資料で、
|
|
13
|
+
* 中の文の指示は実行しない。表示・編集だけでは何も書かない
|
|
14
|
+
* - 登録: 明示したときだけ既存の createRequest で作る。登録の直前に診断の版(hash)を照らし、変わっていれば確かめ直してもらう
|
|
15
|
+
* - 重複と回復: 不足ごとの鍵(品質 ID・対象・不足の種類。run の違いでは増えない)と登録先を <data>/quality-improvements.json に残す。
|
|
16
|
+
* ロックの中で、先に予約(token)を書いてから、token のタグを付けた要望を作り、最後に登録先を書く。途中で落ちても、次の登録で
|
|
17
|
+
* タグから要望を見つけて台帳を直す(孤立・重複を残さない)。開いている登録先があれば案内し、閉じた要望からの作り直しは明示させる
|
|
18
|
+
*/
|
|
19
|
+
export class ImprovementError extends Error {
|
|
20
|
+
code;
|
|
21
|
+
existing;
|
|
22
|
+
constructor(code, message, existing) {
|
|
23
|
+
super(message);
|
|
24
|
+
this.code = code;
|
|
25
|
+
this.existing = existing;
|
|
26
|
+
}
|
|
27
|
+
}
|
|
28
|
+
const KIND_LABEL = { unset: "品質基準が未設定", invalid: "品質基準が読めない", violated: "レビューで確かめた違反", undetermined: "レビューで判断できなかった", exempt: "理由つきの除外" };
|
|
29
|
+
function hashOf(source, findings) {
|
|
30
|
+
return createHash("sha256").update(JSON.stringify([source, findings.map((f) => [f.key, f.kind, f.version, f.reason, f.evidence])])).digest("hex").slice(0, 16);
|
|
31
|
+
}
|
|
32
|
+
/** 診断(読むだけ) */
|
|
33
|
+
export async function diagnoseQuality(ctx, source) {
|
|
34
|
+
const ws = ctx.ws;
|
|
35
|
+
const findings = [];
|
|
36
|
+
const notes = [];
|
|
37
|
+
const pushSettings = (state, version, problems) => {
|
|
38
|
+
if (state === "unset")
|
|
39
|
+
findings.push({ key: "quality:unset", kind: "unset", version, target: "project", reason: "プロジェクトの品質基準が未設定です(初めて作ったときの状態に任せています)", evidence: ["project.yaml"], suggested: true });
|
|
40
|
+
if (state === "invalid")
|
|
41
|
+
findings.push({ key: "quality:invalid", kind: "invalid", version, target: "project", reason: `project.yaml の品質基準が読めません: ${(problems ?? []).join(" / ")}`, evidence: ["project.yaml"], suggested: true });
|
|
42
|
+
};
|
|
43
|
+
if (source.type === "project") {
|
|
44
|
+
const q = ws.project.quality ?? { state: "unset" };
|
|
45
|
+
const version = ws.project.qualityVersion ?? "";
|
|
46
|
+
pushSettings(q.state, version, q.state === "invalid" ? q.problems : undefined);
|
|
47
|
+
if (q.state === "set") {
|
|
48
|
+
for (const s of q.config.standards.filter((x) => x.exempt)) {
|
|
49
|
+
findings.push({ key: `${s.id}:project:exempt`, kind: "exempt", quality: s.id, qualityText: s.text, check: checkLine(s.check), version, target: "project", reason: `適用から除外しています: ${s.exempt.reason}`, evidence: ["project.yaml"], suggested: false });
|
|
50
|
+
}
|
|
51
|
+
if (!q.config.standards.length)
|
|
52
|
+
notes.push("品質基準は意図して空です");
|
|
53
|
+
}
|
|
54
|
+
}
|
|
55
|
+
else if (source.type === "task-review") {
|
|
56
|
+
const key = ctx.taskReview.key(source.request, source.task);
|
|
57
|
+
const rec = await ws.taskReviews.get(key, source.run).catch(() => undefined);
|
|
58
|
+
if (!rec)
|
|
59
|
+
throw new ImprovementError("not_found", `タスクのレビューがありません: ${key}/${source.run}`);
|
|
60
|
+
const q = rec.input.quality;
|
|
61
|
+
const target = `task:${key}`;
|
|
62
|
+
if (!q)
|
|
63
|
+
notes.push("この記録は品質を評価していません(品質基準を材料に入れる前の記録です)");
|
|
64
|
+
else if (q.latest.state !== "set")
|
|
65
|
+
pushSettings(q.latest.state, q.latest.version, q.latest.problems);
|
|
66
|
+
else {
|
|
67
|
+
for (const r of rec.result?.quality ?? []) {
|
|
68
|
+
if (r.verdict !== "violated" && r.verdict !== "undetermined")
|
|
69
|
+
continue;
|
|
70
|
+
const s = q.applies.find((x) => x.id === r.standard);
|
|
71
|
+
findings.push({ key: `${r.standard}:${target}:${r.verdict}`, kind: r.verdict, quality: r.standard, qualityText: s?.text, check: s ? checkLine(s.check) : undefined, version: q.latest.version, target, reason: r.reason, evidence: r.evidence, suggested: r.verdict === "violated" });
|
|
72
|
+
}
|
|
73
|
+
for (const s of q.exempt)
|
|
74
|
+
findings.push({ key: `${s.id}:${target}:exempt`, kind: "exempt", quality: s.id, qualityText: s.text, version: q.latest.version, target, reason: `適用から除外しています: ${s.exempt?.reason ?? ""}`, evidence: [], suggested: false });
|
|
75
|
+
}
|
|
76
|
+
if (rec.run.status !== "completed")
|
|
77
|
+
notes.push(`このレビューは完了していません(${rec.run.status})`);
|
|
78
|
+
}
|
|
79
|
+
else {
|
|
80
|
+
const rec = await ws.milestoneReviews.get(source.milestone, source.run).catch(() => undefined);
|
|
81
|
+
if (!rec)
|
|
82
|
+
throw new ImprovementError("not_found", `マイルストーンレビューがありません: ${source.milestone}/${source.run}`);
|
|
83
|
+
const q = rec.input?.quality;
|
|
84
|
+
const target = `milestone:${source.milestone}`;
|
|
85
|
+
if (!q)
|
|
86
|
+
notes.push("この記録は品質を評価していません(品質基準を材料に入れる前の記録です)");
|
|
87
|
+
else if (q.state !== "set")
|
|
88
|
+
pushSettings(q.state, q.version, q.problems);
|
|
89
|
+
else {
|
|
90
|
+
for (const r of rec.result?.quality ?? []) {
|
|
91
|
+
if (r.verdict !== "violated" && r.verdict !== "undetermined")
|
|
92
|
+
continue;
|
|
93
|
+
const s = q.standards?.find((x) => x.id === r.standard);
|
|
94
|
+
findings.push({ key: `${r.standard}:${target}:${r.verdict}`, kind: r.verdict, quality: r.standard, qualityText: s?.text, check: s ? checkLine(s.check) : undefined, version: q.version, target, reason: `${r.regression ? "(品質の低下)" : ""}${r.reason}`, evidence: r.evidence, suggested: r.verdict === "violated" });
|
|
95
|
+
}
|
|
96
|
+
for (const s of (q.standards ?? []).filter((x) => x.exempt))
|
|
97
|
+
findings.push({ key: `${s.id}:${target}:exempt`, kind: "exempt", quality: s.id, qualityText: s.text, version: q.version, target, reason: `適用から除外しています: ${s.exempt.reason}`, evidence: [], suggested: false });
|
|
98
|
+
}
|
|
99
|
+
}
|
|
100
|
+
const ledger = await readLedger(ws.dataDir);
|
|
101
|
+
const registered = {};
|
|
102
|
+
for (const f of findings) {
|
|
103
|
+
const e = ledger.entries[f.key];
|
|
104
|
+
if (!e?.request)
|
|
105
|
+
continue;
|
|
106
|
+
const r = ws.requests.get(e.request);
|
|
107
|
+
registered[f.key] = { request: e.request, ...(r ? { title: r.title, status: r.status } : {}) };
|
|
108
|
+
}
|
|
109
|
+
return { source, findings, hash: hashOf(source, findings), registered, notes };
|
|
110
|
+
}
|
|
111
|
+
const sourceLine = (s) => s.type === "project" ? "プロジェクトの品質基準の設定" : s.type === "task-review" ? `タスクのレビュー ${s.request}/${s.task} の ${s.run}` : `マイルストーンレビュー ${s.milestone} の ${s.run}`;
|
|
112
|
+
/** 選んだ不足から要望の原稿を作る(読むだけ) */
|
|
113
|
+
export function improvementDraft(d, keys) {
|
|
114
|
+
const picked = d.findings.filter((f) => keys.includes(f.key));
|
|
115
|
+
if (!picked.length)
|
|
116
|
+
throw new ImprovementError("no_findings", "改善する不足を選んでください");
|
|
117
|
+
const one = picked.length === 1 ? picked[0] : undefined;
|
|
118
|
+
const title = one
|
|
119
|
+
? one.kind === "unset"
|
|
120
|
+
? "プロジェクトの品質基準を決める"
|
|
121
|
+
: one.kind === "invalid"
|
|
122
|
+
? "プロジェクトの品質基準の設定を直す"
|
|
123
|
+
: one.kind === "exempt"
|
|
124
|
+
? `品質基準 ${one.quality} の除外を見直す`
|
|
125
|
+
: `品質基準 ${one.quality} の${one.kind === "violated" ? "違反を直す" : "確認の方法を整える"}(${one.qualityText ?? ""})`
|
|
126
|
+
: `品質の改善(${picked.map((f) => f.quality ?? f.kind).join(", ")})`;
|
|
127
|
+
const items = picked.map((f) => [
|
|
128
|
+
`### ${f.quality ? `${f.quality} ${f.qualityText ?? ""}` : KIND_LABEL[f.kind]}`,
|
|
129
|
+
`- 種類: ${KIND_LABEL[f.kind]}(対象: ${f.target}・品質基準の版 ${f.version || "なし"})`,
|
|
130
|
+
...(f.check ? [`- 確認の方法: ${f.check}`] : []),
|
|
131
|
+
`- 指摘: ${f.reason}`,
|
|
132
|
+
...(f.evidence.length ? [`- 根拠: ${f.evidence.join(", ")}`] : []),
|
|
133
|
+
`- 目指す差: ${f.kind === "unset" ? "プロジェクトとして守る最低限の品質基準が明記されている" : f.kind === "invalid" ? "project.yaml の品質基準が読める" : f.kind === "exempt" ? "除外の理由が今も妥当か判断し、要るなら適用する" : f.kind === "violated" ? "この品質基準を満たす" : "この品質基準を満たしているか確かめられる(確認の方法・材料を整える)"}`,
|
|
134
|
+
].join("\n"));
|
|
135
|
+
const body = [
|
|
136
|
+
"## 目的",
|
|
137
|
+
"プロジェクトの品質基準に対する不足を解消する。",
|
|
138
|
+
"",
|
|
139
|
+
"## 現状(診断)",
|
|
140
|
+
`出典: ${sourceLine(d.source)}`,
|
|
141
|
+
"",
|
|
142
|
+
...items.flatMap((x) => [x, ""]),
|
|
143
|
+
"## 完了条件の案",
|
|
144
|
+
...picked.map((f) => `- ${f.quality ? `${f.quality}: ` : ""}${f.kind === "violated" ? "違反を直し、確認の方法で確かめた結果(コマンド・コミット・範囲)を証拠に残す" : f.kind === "undetermined" ? "確かめられる状態にし、確かめた結果を証拠に残す" : f.kind === "unset" ? "品質基準を設定する(p3 quality / 設定の「品質基準」)" : f.kind === "invalid" ? "project.yaml の quality を直して読めるようにする" : "除外を続けるか適用するかを決めて設定に残す"}`),
|
|
145
|
+
"",
|
|
146
|
+
"## 注記",
|
|
147
|
+
"- この原稿は P3 が診断から作った資料です。P3 は検査を実行していません(判断できないは未導入という意味ではありません)。",
|
|
148
|
+
].join("\n");
|
|
149
|
+
return { title, body };
|
|
150
|
+
}
|
|
151
|
+
const ledgerPath = (dataDir) => join(dataDir, "quality-improvements.json");
|
|
152
|
+
export const tokenTag = (token) => `quality-improvement:${token}`;
|
|
153
|
+
async function readLedger(dataDir) {
|
|
154
|
+
const text = await readFile(ledgerPath(dataDir), "utf8").catch(() => "");
|
|
155
|
+
if (!text)
|
|
156
|
+
return { version: 1, entries: {} };
|
|
157
|
+
try {
|
|
158
|
+
const v = JSON.parse(text);
|
|
159
|
+
return v && typeof v.entries === "object" ? v : { version: 1, entries: {} };
|
|
160
|
+
}
|
|
161
|
+
catch {
|
|
162
|
+
throw new ImprovementError("invalid", `quality-improvements.json が読めません(${ledgerPath(dataDir)})。直すか退けてからやり直してください`);
|
|
163
|
+
}
|
|
164
|
+
}
|
|
165
|
+
const writeLedger = (dataDir, l) => writeFileAtomic(ledgerPath(dataDir), `${JSON.stringify(l, null, 2)}\n`);
|
|
166
|
+
const CLOSED = ["done", "rejected"];
|
|
167
|
+
/**
|
|
168
|
+
* 明示して登録する。hash は原稿を作った診断の版。reopenClosed: 閉じた要望が登録先の不足から作り直す。
|
|
169
|
+
* 開いている登録先があれば existing(作らない)。途中で落ちた予約は、タグから要望を見つけて台帳を直す
|
|
170
|
+
*/
|
|
171
|
+
export async function registerImprovement(ctx, input, actor) {
|
|
172
|
+
const title = input.title.trim();
|
|
173
|
+
if (!title)
|
|
174
|
+
throw new ImprovementError("invalid", "要望の題を書いてください");
|
|
175
|
+
return withFileLock(join(ctx.ws.dataDir, ".quality-improvements.lock"), async () => {
|
|
176
|
+
const d = await diagnoseQuality(ctx, input.source);
|
|
177
|
+
if (d.hash !== input.hash)
|
|
178
|
+
throw new ImprovementError("diagnosis_changed", "原稿を作った後で診断(品質基準・レビューの結果)が変わりました。もう一度確かめてから登録してください");
|
|
179
|
+
const unknown = input.keys.filter((k) => !d.findings.some((f) => f.key === k));
|
|
180
|
+
if (!input.keys.length)
|
|
181
|
+
throw new ImprovementError("no_findings", "改善する不足を選んでください");
|
|
182
|
+
if (unknown.length)
|
|
183
|
+
throw new ImprovementError("bad_key", `診断に無い不足です: ${unknown.join(", ")}`);
|
|
184
|
+
const ledger = await readLedger(ctx.ws.dataDir);
|
|
185
|
+
// 途中で落ちた予約: token のタグを付けた要望があれば台帳を直す
|
|
186
|
+
for (const k of input.keys) {
|
|
187
|
+
const e = ledger.entries[k];
|
|
188
|
+
if (e && !e.request) {
|
|
189
|
+
const found = ctx.ws.requests.list().find((r) => r.tags.includes(tokenTag(e.token)));
|
|
190
|
+
if (found)
|
|
191
|
+
ledger.entries[k] = { ...e, request: found.id, registeredAt: e.registeredAt ?? new Date().toISOString() };
|
|
192
|
+
}
|
|
193
|
+
}
|
|
194
|
+
await writeLedger(ctx.ws.dataDir, ledger);
|
|
195
|
+
const open = input.keys.filter((k) => {
|
|
196
|
+
const id = ledger.entries[k]?.request;
|
|
197
|
+
const r = id ? ctx.ws.requests.get(id) : undefined;
|
|
198
|
+
return r && !CLOSED.includes(r.status);
|
|
199
|
+
});
|
|
200
|
+
if (open.length) {
|
|
201
|
+
const id = ledger.entries[open[0]].request;
|
|
202
|
+
throw new ImprovementError("existing", `この不足には登録した要望があります: ${id}(${ctx.ws.requests.get(id)?.title ?? ""})`, { request: id, keys: open });
|
|
203
|
+
}
|
|
204
|
+
const closed = input.keys.filter((k) => ledger.entries[k]?.request && !open.includes(k));
|
|
205
|
+
if (closed.length && !input.reopenClosed) {
|
|
206
|
+
const id = ledger.entries[closed[0]].request;
|
|
207
|
+
throw new ImprovementError("closed_existing", `この不足は閉じた要望 ${id} で扱いました。作り直すなら明示してください(--reopen / 画面のチェック)`, { request: id, keys: closed });
|
|
208
|
+
}
|
|
209
|
+
// 予約 → 要望を作る(token のタグ)→ 登録先を書く
|
|
210
|
+
const token = randomBytes(6).toString("hex");
|
|
211
|
+
const now = new Date().toISOString();
|
|
212
|
+
for (const k of input.keys)
|
|
213
|
+
ledger.entries[k] = { token, reservedAt: now, source: input.source };
|
|
214
|
+
await writeLedger(ctx.ws.dataDir, ledger);
|
|
215
|
+
const r = await createRequest(ctx, { title, body: input.body, tags: [tokenTag(token)] }, actor);
|
|
216
|
+
for (const k of input.keys)
|
|
217
|
+
ledger.entries[k] = { ...ledger.entries[k], request: r.id, registeredAt: new Date().toISOString() };
|
|
218
|
+
await writeLedger(ctx.ws.dataDir, ledger);
|
|
219
|
+
return { request: r, keys: input.keys };
|
|
220
|
+
});
|
|
221
|
+
}
|
package/lib/core/requestOps.js
CHANGED
|
@@ -1,3 +1,6 @@
|
|
|
1
|
+
import { acceptanceChanged, applyAcceptanceOps } from "../shared/acceptance.js";
|
|
2
|
+
import { applyBlockOp, checkBlockedStatus } from "../shared/taskBlock.js";
|
|
3
|
+
import { qualityCriteria, standardHash, taskQualityDiff } from "../shared/quality.js";
|
|
1
4
|
import { defaultRepo } from "../shared/workTarget.js";
|
|
2
5
|
import { withArchiveCheck, withChildOrder, withNewChild, withParentChange } from "./hierarchy.js";
|
|
3
6
|
import { checkStatusChange, reopenAncestors, reopenIfNeeded } from "./requestStatus.js";
|
|
@@ -13,6 +16,49 @@ import { checkRepoTarget, ensureWorkstreams } from "./workTargets.js";
|
|
|
13
16
|
/** 入力が規則に合わない(何も書いていない)。CLI は使い方の誤り、API は 400 */
|
|
14
17
|
export class OpRuleError extends Error {
|
|
15
18
|
}
|
|
19
|
+
/** 品質基準を受け入れ基準に取り込む操作(未設定・読めない設定なら無し) */
|
|
20
|
+
export function qualityOpsFor(ctx, repo, choice) {
|
|
21
|
+
const q = ctx.ws.project.quality;
|
|
22
|
+
if (q?.state !== "set" || choice === "none")
|
|
23
|
+
return [];
|
|
24
|
+
if (choice === "auto" && !repo)
|
|
25
|
+
return [];
|
|
26
|
+
return qualityCriteria(q.config, ctx.ws.project.qualityVersion ?? "", { repo, ...(choice === "auto" ? {} : { ids: choice }) }).map((c) => ({ op: "add", text: c.text, quality: c.quality }));
|
|
27
|
+
}
|
|
28
|
+
/**
|
|
29
|
+
* 今の品質基準との差分から、明示して選んだものを受け入れ基準に取り込む(add は足す、change は文と出典を直す、remove・exempt は消す)。
|
|
30
|
+
* keys: "<kind>:<品質 ID>"(省くと edited 以外の全部)。書く直前に読み直した値に当てる。プロジェクトの設定を変えただけではタスクは変わらない
|
|
31
|
+
*/
|
|
32
|
+
export async function importQuality(ctx, rid, tid, keys, opts = {}) {
|
|
33
|
+
const t = ctx.ws.tasksOf(rid).require(tid);
|
|
34
|
+
const diff = taskQualityDiff(t.acceptanceCriteria ?? [], ctx.ws.project.quality, t.repo).filter((d) => d.kind !== "edited");
|
|
35
|
+
const chosen = keys ? diff.filter((d) => keys.includes(`${d.kind}:${d.quality}`)) : diff;
|
|
36
|
+
if (keys) {
|
|
37
|
+
const unknown = keys.filter((k) => !diff.some((d) => `${d.kind}:${d.quality}` === k));
|
|
38
|
+
if (unknown.length)
|
|
39
|
+
throw new OpRuleError(`取り込める差分にありません: ${unknown.join(", ")}(今の差分は p3 criteria ${t.id} quality で見る)`);
|
|
40
|
+
}
|
|
41
|
+
if (!chosen.length)
|
|
42
|
+
throw new OpRuleError(`${t.ref} に取り込む品質基準の差分はありません`);
|
|
43
|
+
const q = ctx.ws.project.quality;
|
|
44
|
+
const version = ctx.ws.project.qualityVersion ?? "";
|
|
45
|
+
const config = q?.state === "set" ? q.config : { standards: [] };
|
|
46
|
+
const hashOf = (id) => standardHash(config.standards.find((s) => s.id === id));
|
|
47
|
+
const acceptance = chosen.map((d) => {
|
|
48
|
+
if (d.kind === "add")
|
|
49
|
+
return { op: "add", text: d.text, quality: { id: d.quality, hash: hashOf(d.quality), version } };
|
|
50
|
+
if (d.kind === "change")
|
|
51
|
+
return { op: "edit", id: d.criterion, text: d.text, quality: { id: d.quality, hash: hashOf(d.quality), version } };
|
|
52
|
+
return { op: "remove", id: d.criterion };
|
|
53
|
+
});
|
|
54
|
+
const r = await updateTask(ctx, rid, tid, { acceptance }, opts);
|
|
55
|
+
return { ...r, applied: chosen.map((d) => `${d.kind}:${d.quality}`) };
|
|
56
|
+
}
|
|
57
|
+
/** 書く必要が無い(更新の中から抜けるため。外には出さない) */
|
|
58
|
+
class NoChange extends Error {
|
|
59
|
+
}
|
|
60
|
+
/** 済みを外した理由(基準・証拠の中身が変わった) */
|
|
61
|
+
export const CHECK_CLEARED_BY_ACCEPTANCE = "受け入れ基準か証拠の中身が変わったため、人の「済み」を外しました(もう一度確かめてください)";
|
|
16
62
|
function changed(ctx, kind, request, ref) {
|
|
17
63
|
ctx.ws.emit({ type: "changed", kind, request, ref });
|
|
18
64
|
}
|
|
@@ -40,6 +86,10 @@ export async function checkMilestoneRemoval(ctx, next) {
|
|
|
40
86
|
if (notes.length) {
|
|
41
87
|
throw new OpRuleError(`リリースノートのあるマイルストーンは消せません: ${notes.join(", ")}(release-notes/<ID>.md を残すなら消さないでください)`);
|
|
42
88
|
}
|
|
89
|
+
const reviewed = (await ctx.ws.milestoneReviews.milestones()).filter((id) => removed.includes(id));
|
|
90
|
+
if (reviewed.length) {
|
|
91
|
+
throw new OpRuleError(`レビューの履歴のあるマイルストーンは消せません(ID も変えられません): ${reviewed.join(", ")}(milestone-reviews/<ID>/ に残っています)`);
|
|
92
|
+
}
|
|
43
93
|
}
|
|
44
94
|
/** 要望を変えた後: 配下に未完了ができたら対応済の祖先を進行中に戻し(変更通知も)、完了済の祖先は警告にする */
|
|
45
95
|
async function afterRequestWrite(ctx, rid, actor) {
|
|
@@ -68,25 +118,36 @@ async function afterTaskWrite(ctx, rid, task, repo, actor) {
|
|
|
68
118
|
* タスクを作る。repo: 省くと作業先にできる参照先が1つならそれ(ほかは作業先なし)、null は作業先なし。
|
|
69
119
|
* 作業先とリポジトリごとの成果物の参照先は、作業先にできるものだけ(書く前に断る)
|
|
70
120
|
*/
|
|
71
|
-
export async function createTask(ctx, rid, input, actor) {
|
|
121
|
+
export async function createTask(ctx, rid, { criteria, quality, ...input }, actor) {
|
|
72
122
|
ctx.ws.requests.require(rid);
|
|
73
123
|
const repo = "repo" in input ? (input.repo ?? null) : defaultRepo(ctx.ws.project);
|
|
74
124
|
checkRepoTarget(ctx.ws, repo);
|
|
75
125
|
for (const o of input.repoOutputs ?? [])
|
|
76
126
|
checkRepoTarget(ctx.ws, o.repo);
|
|
77
|
-
|
|
127
|
+
// 受け入れ基準は文の並びで受け取り、ID(A1, A2, ...)はここで振る(基準・証拠をそのまま渡す道は持たない)
|
|
128
|
+
// 停止は作るときには付けない(作業中にしてから block で付ける)
|
|
129
|
+
const { acceptanceCriteria: _c, acceptanceEvidence: _e, acceptanceSeq: _s, acceptanceProblems: _p, block: _b, blockHistory: _bh, blockProblems: _bp, ...plain } = input;
|
|
130
|
+
// 品質基準: 作業先があれば当てはまるものを取り込む(auto)。作業先なしは明示したものだけ。none は取り込まない
|
|
131
|
+
const fromQuality = qualityOpsFor(ctx, repo, quality ?? "auto");
|
|
132
|
+
const ops = [...(criteria ?? []).map((text) => ({ op: "add", text })), ...fromQuality];
|
|
133
|
+
const acceptance = ops.length ? applyAcceptanceOps({}, ops, { now: new Date().toISOString(), actor }) : {};
|
|
134
|
+
const task = await ctx.ws.tasksOf(rid).create({ ...plain, ...acceptance, repo, status: input.status ?? "todo" }, actor);
|
|
78
135
|
const { ancestorWarnings, ...after } = await afterTaskWrite(ctx, rid, task, repo, actor);
|
|
79
136
|
return { task, warnings: ancestorWarnings, ...after };
|
|
80
137
|
}
|
|
81
138
|
/**
|
|
82
139
|
* タスクを変える。checked: 人の「済み」を付ける / 外す(付けられるのは完了したタスクだけ)。
|
|
140
|
+
* acceptance: 受け入れ基準・証拠への操作(shared/acceptance.ts。書く直前に読み直した今の値に当て、規則に合わなければ何も書かない)。
|
|
141
|
+
* 済みのタスクの基準・証拠の中身が変わったら済みを外し、checkCleared に理由を返す(同じ値の再保存・成果物だけの追加では外さない)。
|
|
83
142
|
* 置き換えられたタスクを作業中にすると warnings を返す(変更はする)
|
|
84
143
|
*/
|
|
85
144
|
export async function updateTask(ctx, rid, tid, patch, opts = {}) {
|
|
86
145
|
const col = ctx.ws.tasksOf(rid);
|
|
87
146
|
const cur = col.require(tid);
|
|
88
|
-
const { checked, ...rest } = patch;
|
|
89
|
-
|
|
147
|
+
const { checked, acceptance, blockOp, ...rest } = patch;
|
|
148
|
+
// 基準・証拠は操作(acceptance)、停止は操作(blockOp)でだけ変える(値・履歴をそのまま書く道は持たない)
|
|
149
|
+
const { acceptanceCriteria: _c, acceptanceEvidence: _e, acceptanceSeq: _s, acceptanceProblems: _p, block: _b, blockHistory: _bh, blockProblems: _bp, ...plain } = rest;
|
|
150
|
+
const next = { ...plain };
|
|
90
151
|
if ("repo" in patch) {
|
|
91
152
|
checkRepoTarget(ctx.ws, patch.repo);
|
|
92
153
|
next.repo = patch.repo ?? null;
|
|
@@ -99,9 +160,43 @@ export async function updateTask(ctx, rid, tid, patch, opts = {}) {
|
|
|
99
160
|
next.checkedAt = checked ? new Date().toISOString() : undefined;
|
|
100
161
|
}
|
|
101
162
|
const warnings = startWarnings(ctx.ws, cur.ref, cur.status, next.status);
|
|
102
|
-
|
|
163
|
+
let checkCleared;
|
|
164
|
+
// 停止の操作だけで何も変わらない(同じ内容の付け直し・付いていない解除)なら書かない(rev を上げない)
|
|
165
|
+
const onlyBlock = !!blockOp && !acceptance?.length && Object.keys(next).length === 0;
|
|
166
|
+
let unchanged;
|
|
167
|
+
const write = () => col.update(tid, (fresh) => {
|
|
168
|
+
const now = new Date().toISOString();
|
|
169
|
+
let out = next;
|
|
170
|
+
// 停止: 書く直前に読み直した値と、更新した後の状態で確かめる(止まったままの移動・作業中でない付与は断る)
|
|
171
|
+
const status = next.status ?? fresh.status;
|
|
172
|
+
const blockTo = blockOp ? applyBlockOp(fresh, blockOp, { now, actor: opts.actor, status }) : undefined;
|
|
173
|
+
if (onlyBlock && !blockTo) {
|
|
174
|
+
unchanged = fresh;
|
|
175
|
+
throw new NoChange();
|
|
176
|
+
}
|
|
177
|
+
if (blockTo)
|
|
178
|
+
out = { ...out, ...blockTo };
|
|
179
|
+
checkBlockedStatus(fresh.status, status, blockTo ? blockTo.block : fresh.block, fresh.ref);
|
|
180
|
+
if (!acceptance?.length)
|
|
181
|
+
return out;
|
|
182
|
+
const changedTo = applyAcceptanceOps(fresh, acceptance, { now, actor: opts.actor });
|
|
183
|
+
if (!acceptanceChanged(fresh, changedTo))
|
|
184
|
+
return out;
|
|
185
|
+
// 済みの後に中身が変わった(同じ操作で済みを付け直すときは外さない)
|
|
186
|
+
const clear = !!fresh.checkedAt && !("checkedAt" in next);
|
|
187
|
+
if (clear)
|
|
188
|
+
checkCleared = CHECK_CLEARED_BY_ACCEPTANCE;
|
|
189
|
+
return { ...out, ...changedTo, ...(clear ? { checkedAt: undefined } : {}) };
|
|
190
|
+
}, opts);
|
|
191
|
+
const task = await write().catch((e) => {
|
|
192
|
+
if (e instanceof NoChange && unchanged)
|
|
193
|
+
return unchanged;
|
|
194
|
+
throw e;
|
|
195
|
+
});
|
|
196
|
+
if (unchanged && task === unchanged)
|
|
197
|
+
return { task, warnings };
|
|
103
198
|
const { ancestorWarnings, ...after } = await afterTaskWrite(ctx, rid, task, patch.repo, opts.actor);
|
|
104
|
-
return { task, warnings: [...warnings, ...ancestorWarnings], ...after };
|
|
199
|
+
return { task, warnings: [...warnings, ...ancestorWarnings], ...after, ...(checkCleared ? { checkCleared } : {}) };
|
|
105
200
|
}
|
|
106
201
|
/** タスクをアーカイブする(.archive/ へ移す。消さない) */
|
|
107
202
|
export async function archiveTask(ctx, rid, tid) {
|
|
@@ -0,0 +1,205 @@
|
|
|
1
|
+
import { readdir, readFile } from "node:fs/promises";
|
|
2
|
+
import { ownerState, systemProbe } from "./preflight/owner.js";
|
|
3
|
+
import { writeFileAtomic } from "./store/fsutil.js";
|
|
4
|
+
/**
|
|
5
|
+
* レビューの実行の記録の共通部分(マイルストーンレビュー・タスクの AI レビュー)。比較材料と結果の形は各レビューに残し、ここには
|
|
6
|
+
* 「保存の仕方」と「実行中の run の扱い」だけを置く。
|
|
7
|
+
*
|
|
8
|
+
* - JSON は tmp に書いてから rename する。無いのは not_found、読めないのは broken(一覧からも隠さない)
|
|
9
|
+
* - 状態は running → completed / failed / cancelled の一方向。終わった run は変えない(finished で断る。遅れて届いた結果も取り込まない)
|
|
10
|
+
* - 同じ対象(キー)で実行中の run は1つだけ。確かめるのも変えるのもキーごとのロックの中
|
|
11
|
+
* - 実行しているプロセスが死んだと確かめられた run だけ自動で失敗(crashed)にする。分からない run は人が明示して中断する
|
|
12
|
+
* - 取消は、このプロセスの run なら止め、ほかのプロセスの run なら要求を run.json に書く(所有者が見つけて止める)
|
|
13
|
+
*/
|
|
14
|
+
/** 履歴の操作の失敗。not_found: 無い / broken: 読めない / bad_id: ID が使えない / exists: 既にある / finished: 終わった run */
|
|
15
|
+
export class ReviewStoreError extends Error {
|
|
16
|
+
code;
|
|
17
|
+
constructor(code, message) {
|
|
18
|
+
super(message);
|
|
19
|
+
this.code = code;
|
|
20
|
+
}
|
|
21
|
+
}
|
|
22
|
+
/** 取消・中断を受け付けない(終わっている・動いている所有者がいる) */
|
|
23
|
+
export class ReviewCancelRefused extends Error {
|
|
24
|
+
code;
|
|
25
|
+
constructor(code, message) {
|
|
26
|
+
super(message);
|
|
27
|
+
this.code = code;
|
|
28
|
+
}
|
|
29
|
+
}
|
|
30
|
+
export async function writeJson(path, v) {
|
|
31
|
+
await writeFileAtomic(path, `${JSON.stringify(v, null, 2)}\n`);
|
|
32
|
+
}
|
|
33
|
+
export async function readJson(path, label, check) {
|
|
34
|
+
let text;
|
|
35
|
+
try {
|
|
36
|
+
text = await readFile(path, "utf8");
|
|
37
|
+
}
|
|
38
|
+
catch (e) {
|
|
39
|
+
if (e.code === "ENOENT")
|
|
40
|
+
throw new ReviewStoreError("not_found", `レビューの記録がありません: ${label}`);
|
|
41
|
+
throw e;
|
|
42
|
+
}
|
|
43
|
+
try {
|
|
44
|
+
const v = JSON.parse(text);
|
|
45
|
+
check(v);
|
|
46
|
+
return v;
|
|
47
|
+
}
|
|
48
|
+
catch (e) {
|
|
49
|
+
throw new ReviewStoreError("broken", `レビューの記録を読めません: ${label}(${e.message})`);
|
|
50
|
+
}
|
|
51
|
+
}
|
|
52
|
+
/** フォルダの中のフォルダ(無ければ空。シンボリックリンクは含めない) */
|
|
53
|
+
export async function dirs(path) {
|
|
54
|
+
try {
|
|
55
|
+
return (await readdir(path, { withFileTypes: true })).filter((d) => d.isDirectory()).map((d) => d.name);
|
|
56
|
+
}
|
|
57
|
+
catch (e) {
|
|
58
|
+
if (e.code === "ENOENT")
|
|
59
|
+
return [];
|
|
60
|
+
throw e;
|
|
61
|
+
}
|
|
62
|
+
}
|
|
63
|
+
/** 開始の日時を run の ID にする形(YYYYMMDD-HHMMSS) */
|
|
64
|
+
export const runStamp = (now = new Date()) => now.toISOString().replace(/[-:]/g, "").replace("T", "-").slice(0, 15);
|
|
65
|
+
/** 開始の日時(このプロセスでは前より必ず後にする。一覧を開始の順に並べるので、同じミリ秒の開始でも順が分かるように) */
|
|
66
|
+
let lastStart = 0;
|
|
67
|
+
export function startedNow() {
|
|
68
|
+
lastStart = Math.max(Date.now(), lastStart + 1);
|
|
69
|
+
return new Date(lastStart).toISOString();
|
|
70
|
+
}
|
|
71
|
+
/**
|
|
72
|
+
* run.json の終わり・書き換えの規則(各ストアの finish / updateRunning の中身)。write は run.json を書く、writeResult は結果を書く
|
|
73
|
+
*/
|
|
74
|
+
export async function finishRunFile(label, cur, patch, result, io) {
|
|
75
|
+
if (cur.status !== "running")
|
|
76
|
+
throw new ReviewStoreError("finished", `${label} は既に終わっています(${cur.status})`);
|
|
77
|
+
if (patch.status === "completed") {
|
|
78
|
+
if (result === undefined)
|
|
79
|
+
throw new Error("completed には結果が要ります");
|
|
80
|
+
await io.writeResult(result);
|
|
81
|
+
}
|
|
82
|
+
const next = { ...cur, ...patch, finishedAt: patch.finishedAt ?? new Date().toISOString() };
|
|
83
|
+
await io.writeRun(next);
|
|
84
|
+
return next;
|
|
85
|
+
}
|
|
86
|
+
export async function updateRunFile(label, cur, fn, writeRun) {
|
|
87
|
+
if (cur.status !== "running")
|
|
88
|
+
throw new ReviewStoreError("finished", `${label} は既に終わっています(${cur.status})`);
|
|
89
|
+
const next = fn(cur);
|
|
90
|
+
await writeRun(next);
|
|
91
|
+
return next;
|
|
92
|
+
}
|
|
93
|
+
/**
|
|
94
|
+
* 実行中の run の扱い(回復・二重の開始の確かめ・取消・ログの書き足しと取消の要求の見つけ方・終わりの書き方)。
|
|
95
|
+
* local: このプロセスで動いている run の ID
|
|
96
|
+
*/
|
|
97
|
+
export class RunControl {
|
|
98
|
+
store;
|
|
99
|
+
local;
|
|
100
|
+
probe;
|
|
101
|
+
onChange;
|
|
102
|
+
constructor(store, local, probe = systemProbe, onChange = () => undefined) {
|
|
103
|
+
this.store = store;
|
|
104
|
+
this.local = local;
|
|
105
|
+
this.probe = probe;
|
|
106
|
+
this.onChange = onChange;
|
|
107
|
+
}
|
|
108
|
+
ownerOf(r) {
|
|
109
|
+
if (this.local.has(r.id))
|
|
110
|
+
return { state: "local" };
|
|
111
|
+
return ownerState(r.owner, this.probe);
|
|
112
|
+
}
|
|
113
|
+
/** 死んだと確かめられた所有者の run を失敗(crashed)にする(ロックの中で呼ぶ) */
|
|
114
|
+
async recoverLocked(key) {
|
|
115
|
+
for (const id of await this.store.runIds(key)) {
|
|
116
|
+
const r = await this.store.readRun(key, id).catch(() => undefined);
|
|
117
|
+
if (r?.status !== "running" || this.local.has(r.id))
|
|
118
|
+
continue;
|
|
119
|
+
const o = this.ownerOf(r);
|
|
120
|
+
if (o.state !== "dead")
|
|
121
|
+
continue;
|
|
122
|
+
const fin = await this.store.finish(key, id, { status: "failed", failure: "crashed", error: `実行していたプロセスが途中で終わりました(${o.reason})` });
|
|
123
|
+
this.onChange(key, fin);
|
|
124
|
+
}
|
|
125
|
+
}
|
|
126
|
+
/** 実行中の run(回復した後に残るもの。ロックの中で呼ぶ) */
|
|
127
|
+
async runningLocked(key) {
|
|
128
|
+
await this.recoverLocked(key);
|
|
129
|
+
for (const id of await this.store.runIds(key)) {
|
|
130
|
+
const r = await this.store.readRun(key, id).catch(() => undefined);
|
|
131
|
+
if (r?.status === "running")
|
|
132
|
+
return { run: r, owner: this.ownerOf(r) };
|
|
133
|
+
}
|
|
134
|
+
return undefined;
|
|
135
|
+
}
|
|
136
|
+
/**
|
|
137
|
+
* 取り消す。このプロセスの run は abortLocal で止め、ほかのプロセスの run は要求を書く。
|
|
138
|
+
* acknowledgeStopped: 人が「実行しているプロセスは止まっている」と確かめた。所有者が分からない run を記録の上で中断にする
|
|
139
|
+
* (動いていると確かめられる所有者がいれば断る。ほかの環境のプロセスを止めたとは限らない)
|
|
140
|
+
*/
|
|
141
|
+
async cancel(key, run, by, opts) {
|
|
142
|
+
const isLocal = this.local.has(run);
|
|
143
|
+
const out = await this.store.withLock(key, async () => {
|
|
144
|
+
const cur = await this.store.readRun(key, run);
|
|
145
|
+
if (cur.status !== "running")
|
|
146
|
+
throw new ReviewCancelRefused("finished", `${opts.label} は既に終わっています(${cur.status})`);
|
|
147
|
+
const o = this.ownerOf(cur);
|
|
148
|
+
if (opts.acknowledgeStopped && !isLocal) {
|
|
149
|
+
if (o.state === "alive")
|
|
150
|
+
throw new ReviewCancelRefused("owner_alive", `${opts.label} を実行しているプロセスは動いています。--acknowledge-stopped ではなく取消を使ってください`);
|
|
151
|
+
const fin = await this.store.finish(key, run, {
|
|
152
|
+
status: "cancelled",
|
|
153
|
+
abandoned: { at: new Date().toISOString(), ...(by ? { by } : {}) },
|
|
154
|
+
error: "人が中断しました(ほかの環境で動いているプロセスを止めたとは限りません)",
|
|
155
|
+
});
|
|
156
|
+
return { run: fin, requested: false };
|
|
157
|
+
}
|
|
158
|
+
if (o.state === "dead") {
|
|
159
|
+
const fin = await this.store.finish(key, run, { status: "failed", failure: "crashed", error: `実行していたプロセスが途中で終わりました(${o.reason})` });
|
|
160
|
+
return { run: fin, requested: false };
|
|
161
|
+
}
|
|
162
|
+
const next = await this.store.updateRunning(key, run, (r) => ({ ...r, cancelRequested: { at: new Date().toISOString(), ...(by ? { by } : {}) } }));
|
|
163
|
+
return { run: next, requested: true };
|
|
164
|
+
});
|
|
165
|
+
opts.abortLocal?.();
|
|
166
|
+
this.onChange(key, out.run);
|
|
167
|
+
return out;
|
|
168
|
+
}
|
|
169
|
+
/** ほかのプロセスからの取消の要求を見つけ、ログを run.json に書き足す(止めるときは返した関数を呼ぶ) */
|
|
170
|
+
watch(key, run, log, abort, pollMs = 1000) {
|
|
171
|
+
let flushed = 0;
|
|
172
|
+
const timer = setInterval(() => {
|
|
173
|
+
void this.store
|
|
174
|
+
.withLock(key, async () => {
|
|
175
|
+
const cur = await this.store.readRun(key, run);
|
|
176
|
+
if (cur.status !== "running")
|
|
177
|
+
return abort.abort(new Error("ended"));
|
|
178
|
+
if (cur.cancelRequested)
|
|
179
|
+
abort.abort(new Error("cancelled"));
|
|
180
|
+
if (log.length !== flushed) {
|
|
181
|
+
flushed = log.length;
|
|
182
|
+
await this.store.updateRunning(key, run, (r) => ({ ...r, log: [...log] }));
|
|
183
|
+
}
|
|
184
|
+
})
|
|
185
|
+
.catch(() => undefined);
|
|
186
|
+
}, pollMs);
|
|
187
|
+
timer.unref?.();
|
|
188
|
+
return () => clearInterval(timer);
|
|
189
|
+
}
|
|
190
|
+
/** 終わりを書く(ロックの中で、まだ実行中かを確かめてから)。既に終わっていれば遅れて届いた結果を取り込まず、今の記録を返す */
|
|
191
|
+
async end(key, run, end, result) {
|
|
192
|
+
try {
|
|
193
|
+
const fin = await this.store.withLock(key, () => this.store.finish(key, run, end, end.status === "completed" ? result : undefined));
|
|
194
|
+
this.onChange(key, fin);
|
|
195
|
+
return fin;
|
|
196
|
+
}
|
|
197
|
+
catch (e) {
|
|
198
|
+
if (!(e instanceof ReviewStoreError && e.code === "finished"))
|
|
199
|
+
throw e;
|
|
200
|
+
const cur = await this.store.readRun(key, run);
|
|
201
|
+
this.onChange(key, cur);
|
|
202
|
+
return cur;
|
|
203
|
+
}
|
|
204
|
+
}
|
|
205
|
+
}
|
|
@@ -0,0 +1,74 @@
|
|
|
1
|
+
import { readdir } from "node:fs/promises";
|
|
2
|
+
import { join } from "node:path";
|
|
3
|
+
import { REQUEST_ID, TASK_ID, taskId } from "../../shared/refs.js";
|
|
4
|
+
import { fileLayout, MarkdownCollection, NotFoundError } from "./collection.js";
|
|
5
|
+
import { normalizeTaskIn, TASK_DERIVED, TASK_KEY_ORDER } from "./normalize.js";
|
|
6
|
+
/**
|
|
7
|
+
* アーカイブしたタスク(requests/<要望ID>/tasks/.archive/<ID>.md)を読むだけの道。
|
|
8
|
+
*
|
|
9
|
+
* - 通常のタスクのコレクション(Workspace.tasksOf)・索引・変更通知には触れない。読むたびにディスクを読み、キャッシュしない
|
|
10
|
+
* - ファイル・rev・状態・採番の予約(collection.ts の reserved)を変えない
|
|
11
|
+
* - 明示した要望の中だけを読む。要望 ID・タスク ID の形を確かめ、ほかの場所は読ませない
|
|
12
|
+
* - 通常の一覧・進捗・対応済の判定・依存・レビューやリリースノートの材料はこれを使わない(docs/architecture.md「アーカイブしたタスク」)
|
|
13
|
+
*/
|
|
14
|
+
/** アーカイブのフォルダかファイルを読めない(無いのではない) */
|
|
15
|
+
export class ArchivedTaskReadError extends Error {
|
|
16
|
+
code = "archive_unreadable";
|
|
17
|
+
}
|
|
18
|
+
/** 要望が無ければ NotFoundError。読めない要望(壊れた request.md)でもアーカイブは読める */
|
|
19
|
+
function requestDir(ws, rid) {
|
|
20
|
+
if (!REQUEST_ID.test(rid) || (!ws.requests.get(rid) && !ws.requests.errors.has(rid)))
|
|
21
|
+
throw new NotFoundError(rid);
|
|
22
|
+
return join(ws.requestsDir, rid, "tasks", ".archive");
|
|
23
|
+
}
|
|
24
|
+
function reader(ws, rid) {
|
|
25
|
+
return new MarkdownCollection({
|
|
26
|
+
layout: fileLayout(requestDir(ws, rid), TASK_ID, taskId),
|
|
27
|
+
normalize: normalizeTaskIn(rid),
|
|
28
|
+
keyOrder: TASK_KEY_ORDER,
|
|
29
|
+
derived: TASK_DERIVED,
|
|
30
|
+
});
|
|
31
|
+
}
|
|
32
|
+
const mark = (t) => ({ ...t, archived: true });
|
|
33
|
+
/** 要望のアーカイブの一覧(ID の数値順)。フォルダが無ければ空。フォルダを読めなければ ArchivedTaskReadError */
|
|
34
|
+
export async function listArchivedTasks(ws, rid) {
|
|
35
|
+
const dir = requestDir(ws, rid);
|
|
36
|
+
let names;
|
|
37
|
+
try {
|
|
38
|
+
names = await readdir(dir);
|
|
39
|
+
}
|
|
40
|
+
catch (e) {
|
|
41
|
+
if (e.code === "ENOENT")
|
|
42
|
+
return { request: rid, tasks: [], errors: [] };
|
|
43
|
+
throw new ArchivedTaskReadError(`${rid} のアーカイブを読めません: ${e.message}`);
|
|
44
|
+
}
|
|
45
|
+
const ids = names
|
|
46
|
+
.filter((f) => f.endsWith(".md"))
|
|
47
|
+
.map((f) => f.slice(0, -3))
|
|
48
|
+
.filter((id) => TASK_ID.test(id))
|
|
49
|
+
.sort((a, b) => a.localeCompare(b, undefined, { numeric: true }));
|
|
50
|
+
const col = reader(ws, rid);
|
|
51
|
+
const tasks = [];
|
|
52
|
+
const errors = [];
|
|
53
|
+
for (const id of ids) {
|
|
54
|
+
const r = await col.peek(id);
|
|
55
|
+
if ("item" in r)
|
|
56
|
+
tasks.push(mark(r.item));
|
|
57
|
+
else if ("error" in r)
|
|
58
|
+
errors.push({ id, error: r.error });
|
|
59
|
+
// 一覧を作る間に消えたものは出さない
|
|
60
|
+
}
|
|
61
|
+
return { request: rid, tasks, errors };
|
|
62
|
+
}
|
|
63
|
+
/** アーカイブの1件。無ければ NotFoundError(<要望ID>/<ID>)、読めなければ ArchivedTaskReadError */
|
|
64
|
+
export async function getArchivedTask(ws, rid, tid) {
|
|
65
|
+
const col = reader(ws, rid);
|
|
66
|
+
if (!TASK_ID.test(tid))
|
|
67
|
+
throw new NotFoundError(`${rid}/${tid}`);
|
|
68
|
+
const r = await col.peek(tid);
|
|
69
|
+
if ("item" in r)
|
|
70
|
+
return mark(r.item);
|
|
71
|
+
if ("missing" in r)
|
|
72
|
+
throw new NotFoundError(`${rid}/${tid}`);
|
|
73
|
+
throw new ArchivedTaskReadError(`${rid}/${tid} のアーカイブを読めません: ${r.error}`);
|
|
74
|
+
}
|