@infinitedusky/indusk-mcp 1.24.4 → 1.24.5

package/dist/lib/eval/findings.js

@@ -6,6 +6,7 @@
  */
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
 import { dirname, join } from "node:path";
+import { getScorecardQuestions } from "./scorecard-extractor.js";
 function getFindingsPath(projectRoot) {
     return join(projectRoot, ".indusk", "eval", "findings.json");
 }
@@ -47,13 +48,9 @@ export function ingestScorecard(projectRoot, scorecard) {
     const findings = readFindings(projectRoot);
     let added = 0;
     // Defensive: the model occasionally returns a scorecard with a missing,
-    // null, or non-array `questions` field (it invents its own schema). The
-    // outer wrapper has already written the (wrong-shape) scorecard to
-    // results.log by this point — if we throw here, a misleading `error: true`
-    // entry lands right after, falsely implying the scorecard was lost.
-    // Tolerate the malformed shape silently; downstream consumers can still
-    // see the raw scorecard in results.log.
-    const questions = Array.isArray(scorecard.questions) ? scorecard.questions : [];
+    // null, or non-array `questions` field (it invents its own schema). See
+    // `scorecard-extractor.ts` getScorecardQuestions for the central guard.
+    const questions = getScorecardQuestions(scorecard);
     for (const q of questions) {
         if (q.answer === "yes")
             continue; // no finding for passing questions

package/dist/lib/eval/persistent-evaluator.js

@@ -16,7 +16,7 @@ import { EvalLogWriter } from "./log-writer.js";
 import { initEvalOtel, initEvalOtelLogs, logEvalContent, shutdownEvalOtel, withSpan, } from "./otel.js";
 import { buildEvaluatorPrompt } from "./prompt-builder.js";
 import { V1_RUBRIC } from "./rubric.js";
-import { extractScorecardJson, formatParseError } from "./scorecard-extractor.js";
+import { extractScorecardJson, formatParseError, getScorecardQuestions, } from "./scorecard-extractor.js";
 function getSessionPath(projectRoot) {
     return join(projectRoot, ".indusk", "eval", "evaluator-session.json");
 }
@@ -263,7 +263,11 @@ Output ONLY the JSON scorecard as before — no commentary.`;
                 rootSpan.setAttribute("scorecard.output_tokens", scorecard.usage.outputTokens);
             }
             const answerCounts = { yes: 0, no: 0, partial: 0 };
-            for (const q of scorecard.questions ?? []) {
+            // Use the central guard from scorecard-extractor — `?? []` here was
+            // the bug: it only catches null/undefined, not non-array shapes like
+            // `{}` (which the model has been observed to return — e.g. on Numero
+            // 2026-04-19 19:54 with `questions: { conventions: {...} }` keyed by id).
+            for (const q of getScorecardQuestions(scorecard)) {
                 if (q.answer in answerCounts)
                     answerCounts[q.answer]++;
             }

package/dist/lib/eval/scorecard-extractor.d.ts

@@ -26,6 +26,26 @@
  * This function only locates the JSON; it doesn't validate it.
  */
 export declare function extractScorecardJson(text: string): string | null;
+/**
+ * Defensive accessor for `scorecard.questions`. Returns the array if the
+ * field is array-shaped; returns `[]` for any other shape (missing, null,
+ * boolean, number, object-keyed-by-id, etc.). The model occasionally invents
+ * its own scorecard schema and puts non-arrays here — the wrapper must not
+ * crash when that happens.
+ *
+ * Use this everywhere the wrapper iterates `scorecard.questions`. Never
+ * iterate the field directly (with `?? []` or otherwise) — `?? []` only
+ * catches null/undefined, not falsy-but-not-nullish values like `false`,
+ * `0`, `""`, or non-array objects.
+ *
+ * Surfaced bugs this prevents:
+ *   - `for (const q of scorecard.questions)` when `questions` is missing
+ *   - `for (const q of scorecard.questions ?? [])` when `questions` is `{}`
+ *     (e.g., model returned `questions: { conventions: {...} }` keyed by id)
+ */
+export declare function getScorecardQuestions<T>(scorecard: {
+    questions?: unknown;
+}): T[];
 /**
  * Build an error message for the case where scorecard parsing failed.
  * Includes the underlying error and a snippet of the raw stdout so post-

package/dist/lib/eval/scorecard-extractor.js

@@ -118,6 +118,26 @@ function findFirstBalancedJsonObject(text) {
     // Walked to end of string without closing the outermost brace.
     return null;
 }
+/**
+ * Defensive accessor for `scorecard.questions`. Returns the array if the
+ * field is array-shaped; returns `[]` for any other shape (missing, null,
+ * boolean, number, object-keyed-by-id, etc.). The model occasionally invents
+ * its own scorecard schema and puts non-arrays here — the wrapper must not
+ * crash when that happens.
+ *
+ * Use this everywhere the wrapper iterates `scorecard.questions`. Never
+ * iterate the field directly (with `?? []` or otherwise) — `?? []` only
+ * catches null/undefined, not falsy-but-not-nullish values like `false`,
+ * `0`, `""`, or non-array objects.
+ *
+ * Surfaced bugs this prevents:
+ *   - `for (const q of scorecard.questions)` when `questions` is missing
+ *   - `for (const q of scorecard.questions ?? [])` when `questions` is `{}`
+ *     (e.g., model returned `questions: { conventions: {...} }` keyed by id)
+ */
+export function getScorecardQuestions(scorecard) {
+    return Array.isArray(scorecard.questions) ? scorecard.questions : [];
+}
 /**
  * Build an error message for the case where scorecard parsing failed.
  * Includes the underlying error and a snippet of the raw stdout so post-

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@infinitedusky/indusk-mcp",
-	"version": "1.24.4",
+	"version": "1.24.5",
 	"description": "InDusk development system — skills, MCP tools, and CLI for structured AI-assisted development",
 	"type": "module",
 	"files": [