@inetafrica/open-claudia 3.5.70 → 3.5.71

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 3.5.71
+
+3.5.70 plus a fix to its one-time effort reset, found during the 3.5.70 fleet roll on 20 Oct.
+
+- **Effort reset now sticks** (`core/state.js`, `bot.js`): the reset ran when the state module loaded. On the pods the switchboard (the front process that holds calls) loads it first, so it used the file up; the bot then loaded the old max/xhigh levels from disk and saved them back (maya-cloud: "4 stored level(s) back to the default", yet all four still set). The bot now applies the reset itself at boot, saves the cleared levels at once, and only then retires the file. A plain module load (switchboard, CLI) leaves it alone.
+
+Tests: `test-effort-reset.js` now checks the levels on disk and that a plain load leaves the file.
+
 ## 3.5.70
 
 3.5.69 plus three things Sumeet asked for on 20 Oct: a card answer ("Hidden text and thread hand-offs") and a message after seeing the Opus 5.5 cost chart.

package/bot.js

@@ -62,6 +62,9 @@ require("./core/provider-migration").completeProviderMigration({
   sources: migrationSources,
   snapshot: migrationSnapshot,
 });
+// One-shot effort reset (core/state.js): here, in the bot, so the switchboard
+// or a CLI that loads the state module first cannot use it up.
+require("./core/state").applyEffortResetFile();
 const { readRuntimeMode, sideChatCoordinator } = require("./core/side-chat");
 const runtimeMode = readRuntimeMode(CONFIG_DIR);
 const { vault } = require("./core/vault-store");

package/core/state.js

@@ -380,8 +380,11 @@ const savedState = (() => {
 // One-shot "every chat back to the default effort" request, dropped into the
 // config dir by whoever runs the bot (Sumeet, 20 Oct 2026: high on every bot;
 // chats pinned to xhigh or max would otherwise keep beating the new default).
-// Applied once at boot, before anyone's settings load, so the next save writes
-// it; the file is then renamed so a level someone picks later is never undone.
+// Applied by the bot itself at boot (bot.js), never on module load: under a
+// switchboard the front process loads this module first, and on 20 Oct it used
+// the file up while the bot loaded the old levels from disk and saved them
+// back. The cleared levels are saved at once; only then is the file renamed,
+// so a level someone picks later is never undone.
 // Format: {"providers": ["claude"]}.
 const EFFORT_RESET_FILE = path.join(CONFIG_DIR, "effort-reset.json");
 
@@ -404,10 +407,16 @@ function applyEffortReset(state, request) {
   return cleared;
 }
 
-function applyEffortResetFile(state, file = EFFORT_RESET_FILE) {
+function applyEffortResetFile(file = EFFORT_RESET_FILE) {
   if (!fs.existsSync(file)) return null;
   try {
-    const cleared = applyEffortReset(state, JSON.parse(fs.readFileSync(file, "utf8")));
+    const request = JSON.parse(fs.readFileSync(file, "utf8"));
+    const cleared = applyEffortReset(savedState, request)
+      + applyEffortReset({ users: Object.fromEntries(userStates) }, request);
+    if (cleared > 0 && !saveState()) {
+      console.error(`Effort reset: ${cleared} level(s) cleared for now, but the save failed; trying again next boot`);
+      return cleared;
+    }
     fs.renameSync(file, `${file}.done-${Date.now()}`);
     console.error(`Effort reset: ${cleared} stored level(s) back to the default`);
     return cleared;
@@ -417,8 +426,6 @@ function applyEffortResetFile(state, file = EFFORT_RESET_FILE) {
   }
 }
 
-applyEffortResetFile(savedState);
-
 const userStates = new Map();
 
 let cachedFreshDefaultProvider;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@inetafrica/open-claudia",
-  "version": "3.5.70",
+  "version": "3.5.71",
   "description": "An always-on, provider-agnostic coding-agent harness for Claude Code and OpenAI Codex via chat",
   "main": "bot.js",
   "bin": {

package/test-effort-reset.js

@@ -18,23 +18,48 @@ fs.writeFileSync(stateFile, JSON.stringify({
   },
 }));
 
-// Without a request file nothing changes.
 const env = { ...process.env, OPEN_CLAUDIA_TEST: "1", OPEN_CLAUDIA_CONFIG_DIR: dir, HOME: dir };
-const probe = `
-  require(${JSON.stringify(path.join(__dirname, "core/state.js"))});
-  process.stdout.write("loaded");
-`;
-let run = spawnSync(process.execPath, ["-e", probe], { env, encoding: "utf8" });
-assert.strictEqual(run.status, 0, run.stderr);
-assert.doesNotMatch(run.stderr, /Effort reset:/);
-
-// With one: Claude levels cleared at boot, Codex untouched, file retired.
+const statePath = JSON.stringify(path.join(__dirname, "core/state.js"));
+const run = (code) => {
+  const result = spawnSync(process.execPath, ["-e", code], { env, encoding: "utf8" });
+  assert.strictEqual(result.status, 0, result.stderr);
+  return result;
+};
+const boot = `require(${statePath}).applyEffortResetFile(); process.stdout.write("booted");`;
+const levelsOnDisk = () => {
+  const disk = JSON.parse(fs.readFileSync(stateFile, "utf8"));
+  return [
+    disk.users["kazee:owner"].providerSettings.claude.effort,
+    disk.rooms["kazee:room-a"].providerSettings.claude.effort,
+    disk.users["kazee:owner"].providerSettings.codex.effort,
+    disk.rooms["kazee:room-a"].providerSettings.codex.effort,
+  ];
+};
+
+// Without a request file nothing changes.
+let result = run(boot);
+assert.doesNotMatch(result.stderr, /Effort reset:/);
+assert.deepStrictEqual(levelsOnDisk(), ["max", "xhigh", "max", "xhigh"]);
+
+// Loading the module alone (the switchboard, a CLI) must not use the file up:
+// on 20 Oct the switchboard did, and the bot then saved the old levels back.
 fs.writeFileSync(resetFile, JSON.stringify({ providers: ["claude"] }));
-run = spawnSync(process.execPath, ["-e", probe], { env, encoding: "utf8" });
-assert.strictEqual(run.status, 0, run.stderr);
-assert.match(run.stderr, /Effort reset: 2 stored level\(s\) back to the default/);
+result = run(`require(${statePath}); process.stdout.write("loaded");`);
+assert.doesNotMatch(result.stderr, /Effort reset:/);
+assert.ok(fs.existsSync(resetFile), "a plain module load leaves the request for the bot");
+
+// The bot applies it: Claude levels cleared ON DISK, Codex untouched, file retired.
+result = run(boot);
+assert.match(result.stderr, /Effort reset: 2 stored level\(s\) back to the default/);
 assert.ok(!fs.existsSync(resetFile), "request file is retired after use");
 assert.ok(fs.readdirSync(dir).some((name) => name.startsWith("effort-reset.json.done-")));
+assert.deepStrictEqual(levelsOnDisk(), [null, null, "max", "xhigh"]);
+
+// A fresh process (the next boot) reads the cleared levels, and nothing runs twice.
+result = run(`const s = require(${statePath}); s.applyEffortResetFile();
+  process.stdout.write(String(s.savedState.rooms["kazee:room-a"].providerSettings.claude.effort));`);
+assert.strictEqual(result.stdout, "null");
+assert.doesNotMatch(result.stderr, /Effort reset:/);
 
 // The pure function: users and rooms, only the named providers.
 const { applyEffortReset } = require("./core/state");

package/test-provider-language.js

@@ -660,7 +660,10 @@ assert.match(pkg.description, /provider-agnostic coding-agent harness/i);
 // of saved login details removed ("Nothing: remove it completely"), thread
 // hand-off ("Yes, build it"), and high effort as the default on every bot
 // ("let's set high on all the bots instead and make it the default").
-assert.strictEqual(pkg.version, "3.5.70", "release version must remain unchanged without explicit approval");
+// 3.5.71 = 3.5.70 + the effort-reset fix: on the pods the switchboard used the
+// reset file up and the bot saved the old max/xhigh back. Same approved
+// rollout (Sumeet, 20 Oct: "set high on all the bots"), now working.
+assert.strictEqual(pkg.version, "3.5.71", "release version must remain unchanged without explicit approval");
 for (const keyword of ["claude", "codex", "coding-agent", "provider-agnostic"]) {
   assert.ok(pkg.keywords.includes(keyword), `package keyword missing: ${keyword}`);
 }