@inetafrica/open-claudia 2.14.8 → 3.0.0

package/core/ideas.js

@@ -10,6 +10,7 @@
 const fs = require("fs");
 const path = require("path");
 const crypto = require("crypto");
+const { atomicWriteFileSync } = require("./fsutil");
 const CONFIG_DIR = require("../config-dir");
 const { dayStamp } = require("./day-seeds");
 
@@ -66,7 +67,7 @@ function writeIdeas(ideas) {
   const body = ideas.map(ideaLine).join("\n");
   const content = FILE_HEADER + "\n" + body + (body ? "\n" : "");
   fs.mkdirSync(path.dirname(IDEAS_FILE), { recursive: true, mode: 0o700 });
-  fs.writeFileSync(IDEAS_FILE, content, { mode: 0o600 });
+  atomicWriteFileSync(IDEAS_FILE, content, { mode: 0o600, backup: true });
   return IDEAS_FILE;
 }
 

package/core/identity.js

@@ -3,8 +3,8 @@
 // transport. Default canonical is `<transport>:<channelId>`; the user
 // can override with /link <email-or-id> to merge state across channels.
 
-const fs = require("fs");
 const { IDENTITIES_FILE } = require("./config");
+const { atomicWriteFileSync, readJsonWithFallback } = require("./fsutil");
 
 function normalizeCanonicalUserId(value) {
   return String(value || "").trim().toLowerCase();
@@ -19,21 +19,18 @@ function defaultCanonicalForChannel(transport, channelId) {
 }
 
 function loadIdentities() {
-  try {
-    const raw = JSON.parse(fs.readFileSync(IDENTITIES_FILE, "utf-8"));
-    return {
-      channels: raw && typeof raw.channels === "object" ? raw.channels : {},
-      preferred: raw && typeof raw.preferred === "object" ? raw.preferred : {},
-    };
-  } catch (e) {
-    return { channels: {}, preferred: {} };
-  }
+  const raw = readJsonWithFallback(IDENTITIES_FILE, null);
+  return {
+    channels: raw && typeof raw.channels === "object" ? raw.channels : {},
+    preferred: raw && typeof raw.preferred === "object" ? raw.preferred : {},
+  };
 }
 
 const identities = loadIdentities();
 
 function saveIdentities() {
-  try { fs.writeFileSync(IDENTITIES_FILE, JSON.stringify(identities, null, 2)); } catch (e) {}
+  try { atomicWriteFileSync(IDENTITIES_FILE, JSON.stringify(identities, null, 2), { backup: true }); }
+  catch (e) { console.error("saveIdentities: write failed:", e.message); }
 }
 
 // A channel is a "configured owner channel" when its (transport, channelId)

package/core/io.js

@@ -4,14 +4,35 @@
 
 const { currentAdapter, currentChannelId, currentUserId } = require("./context");
 
+// Adapters historically overloaded their send() return value: a message id
+// (Telegram numeric, Kazee ObjectId string) on success, a bare `true` when
+// delivery succeeded but no editable id came back (server fast-ack), or a
+// falsy value (null/false/undefined) on failure. Callers then guessed —
+// `if (!sent)` read an idless success as a failure (the Kazee double-send),
+// and a `typeof === "string"` edit-guard silently rejected Telegram's numeric
+// id. Collapse every adapter's raw return into ONE explicit shape so no caller
+// has to guess: { ok, messageId, editable }. messageId is always a string or
+// null, so downstream typeof/edit-target checks are uniform across transports.
+function normalizeSendResult(raw) {
+  if (raw === null || raw === undefined || raw === false) {
+    return { ok: false, messageId: null, editable: false };
+  }
+  if (raw === true) {
+    return { ok: true, messageId: null, editable: false };
+  }
+  const id = String(raw);
+  if (!id) return { ok: true, messageId: null, editable: false };
+  return { ok: true, messageId: id, editable: true };
+}
+
 async function send(text, opts = {}) {
   const adapter = currentAdapter();
   const channelId = opts.channelId || currentChannelId();
   if (!adapter || !channelId) {
     console.error("send() called outside chat context");
-    return null;
+    return { ok: false, messageId: null, editable: false };
   }
-  return adapter.send(channelId, text, opts);
+  return normalizeSendResult(await adapter.send(channelId, text, opts));
 }
 
 async function editMessage(messageId, text, opts = {}) {
@@ -75,4 +96,4 @@ function splitMessage(text, maxLen = 4000) {
   return chunks;
 }
 
-module.exports = { send, editMessage, deleteMessage, sendVoice, sendVoiceEnd, sendFile, typing, splitMessage };
+module.exports = { send, editMessage, deleteMessage, sendVoice, sendVoiceEnd, sendFile, typing, splitMessage, normalizeSendResult };