@inetafrica/open-claudia 2.14.6 → 2.14.7

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v2.14.7
+- **New `/link remove <key>` — prune a single identity link through the code path, not by hand-editing `identities.json`.** Until now the only identity commands were `/links` (list) and `/link` (create); there was no way to drop a specific channel→canonical mapping. `/channel remove <transport>` clears a whole transport's links, but only when that adapter is currently live (`removeAdapter` bails with *"No adapter …"* otherwise), and it never touches `telegram` entries by design — so a stray or stale link (e.g. a leftover test fixture, or a link whose transport is no longer added) had no clean removal path, and hand-editing the file doesn't stick because `identity.js` loads the map once into a shared in-memory object and re-serializes the whole thing on every write (a disk-only edit is resurrected by the cache). New `identity.removeIdentityMapping(key)` removes one channel key from the in-memory map **then** persists (memory + disk consistent), and prunes the canonical's `preferred`-channel pointer only when that was its last remaining channel. Owner-only; refuses to remove your own configured owner channel (`identity.isConfiguredOwnerChannel` — a live Telegram chat id or Kazee owner id) so you can't accidentally drop yourself out of unified identity — re-point with `/link` instead. `/links` now shows a *"Remove one with /link remove <key>"* hint.
+- **Agent-space / OpenClaw:** no new deps, no new env, no schema change; Docker image builds identically. Purely an owner-driven identity-maintenance command — inert for any deployment that never runs it. New hermetic test `test-identity-prune.js` (last-link pruning + memory/disk consistency + unknown-key no-op) wired into `npm test`; full suite green.
+
 ## v2.14.6
 - **`/channel add kazee` started from the inline "Add Kazee" button now completes — owner-capture confirm lands on the operator's channel, not on Kazee.** The wizard's owner-confirm prompt (*"Is this you — the owner?"*) is meant to go back to the channel the operator ran `/channel` from, via `channel-wizard.sayToOrigin`, which needs `session.origin` — captured from the envelope passed to `start()`. The typed `/channel add kazee` path (`handlers.js`) passed the envelope; the button path (`actions.js` `chn:add:kazee`) did **not**, so `origin` was null and the prompt fell back to ambient `io.send` scope — which, while processing the operator's inbound Kazee trigger message, is the Kazee room. The Yes/No/Skip buttons then rendered on Kazee, where a tap can never resolve the session: it's keyed by the operator's canonical id, but a Kazee tap resolves to the owner's *unlinked* Kazee user id (the very thing owner-capture is establishing) → `handleAction` finds no session → *"That setup step expired."* `actions.js` now passes the envelope to `wizard.start`, exactly like the typed path.
 - **`/channel remove` and the inline "Remove <id>" button now share one teardown, so they can't drift.** v2.14.5 made the typed `/channel remove` a complete teardown (adapter + `.env` + `people.unlinkAdapterHandles` + `identity.removeTransportIdentities`), but the button (`actions.js` `chn:rm:`) still ran the pre-v2.14.5 version that cleared only `.env` — so removing via the button left exactly the handle/identity residue v2.14.5 was built to clear. The full teardown is now a single `channel-wizard.removeChannel(id)` called by both entry points; callers only guard `telegram` and format `r.summary` / `r.error`. Net −10 lines.

package/core/handlers.js

@@ -14,7 +14,7 @@ const {
 const { register } = require("./commands");
 const { send, deleteMessage } = require("./io");
 const { currentState, resetSettings, resetSessionUsage, saveState, getProjectSessions, getLastProjectSession, recordSession, linkIdentity } = require("./state");
-const { canonicalForChannel, canonicalForTelegram, normalizeCanonicalUserId, channelKey, identities } = require("./identity");
+const { canonicalForChannel, canonicalForTelegram, normalizeCanonicalUserId, channelKey, identities, isConfiguredOwnerChannel, removeIdentityMapping } = require("./identity");
 const { isChatAuthorized, isChatOwner, recordPendingAuthRequest, authRequestLabel, hasOwner, bootstrapOwner } = require("./access");
 const { isOnboarded, startOnboarding } = require("./onboarding");
 const { listProjects, findProject, projectKeyboard, workspacePath } = require("./projects");
@@ -247,20 +247,35 @@ register({
     const rows = Object.entries(identities.channels)
       .sort(([a], [b]) => a.localeCompare(b))
       .map(([channel, userId]) => `${channel} -> ${userId}`);
-    send(rows.length ? rows.join("\n") : "No explicit identity links. Unlinked chats use <transport>:<channelId>.");
+    send(rows.length
+      ? `${rows.join("\n")}\n\nRemove one with /link remove <key>.`
+      : "No explicit identity links. Unlinked chats use <transport>:<channelId>.");
   },
 });
 
 register({
-  name: "link", description: "Link this chat to a canonical user id", args: "[<chat-id>] <email-or-id>",
+  name: "link", description: "Link this chat to a canonical user id", args: "[<chat-id>] <email-or-id> | remove <key>",
   handler: async (env, { tail }) => {
     if (!authorized(env)) return;
     if (!tail) {
       send(ownerEnv(env)
-        ? "Usage:\n/link <email-or-user-id>\n/link <chat-id> <email-or-user-id>\n/link <transport>:<chat-id> <email-or-user-id>\n\nOwner can link any chat; other users can link only their current chat."
+        ? "Usage:\n/link <email-or-user-id>\n/link <chat-id> <email-or-user-id>\n/link <transport>:<chat-id> <email-or-user-id>\n/link remove <transport>:<chat-id>\n\nOwner can link any chat; other users can link only their current chat."
         : "Usage:\n/link <email-or-user-id>\n\nThis links your chat to a canonical user id.");
       return;
     }
+    const removeMatch = tail.match(/^remove\s+(\S+)$/i);
+    if (removeMatch) {
+      if (!ownerEnv(env)) return send("Only the owner can remove identity links.");
+      const key = removeMatch[1];
+      const [t, ...rest] = key.split(":");
+      const chId = rest.join(":");
+      if (isConfiguredOwnerChannel(t, chId)) {
+        return send(`Refusing to remove ${key} — that's your own configured owner channel. Use /link to re-point it if you really need to.`);
+      }
+      const r = removeIdentityMapping(key);
+      if (!r.removed) return send(`No identity link for ${key}. Run /links to see current links.`);
+      return send(`Removed link ${r.key} -> ${r.canonical}${r.prunedPreferred ? " (also cleared its preferred-channel pointer)" : ""}.`);
+    }
     const parts = tail.split(/\s+/).filter(Boolean);
     if (parts.length === 0 || parts.length > 2) return send("Usage: /link <email-or-user-id>");
 

package/core/identity.js

@@ -156,6 +156,28 @@ function removeTransportIdentities(transport) {
   return changed;
 }
 
+// Remove a single channel→canonical link by its exact key (the left-hand side
+// shown in /links, e.g. "telegram:1111"). Also prunes the canonical's
+// preferred-channel pointer when this was its last remaining channel, so no
+// orphaned pointer lingers. Same memory-then-disk discipline as the transport
+// sweep: a disk-only edit would be resurrected by the cached in-memory object.
+function removeIdentityMapping(key) {
+  const k = String(key || "").trim();
+  if (!k || !Object.prototype.hasOwnProperty.call(identities.channels, k)) {
+    return { removed: false, key: k };
+  }
+  const canonical = identities.channels[k];
+  delete identities.channels[k];
+  let prunedPreferred = false;
+  const stillReferenced = Object.values(identities.channels).some((c) => c === canonical);
+  if (!stillReferenced && Object.prototype.hasOwnProperty.call(identities.preferred, canonical)) {
+    delete identities.preferred[canonical];
+    prunedPreferred = true;
+  }
+  saveIdentities();
+  return { removed: true, key: k, canonical, prunedPreferred };
+}
+
 module.exports = {
   identities,
   normalizeCanonicalUserId,
@@ -169,5 +191,6 @@ module.exports = {
   canonicalForStoredUserKey,
   setIdentityMapping,
   removeTransportIdentities,
+  removeIdentityMapping,
   saveIdentities,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@inetafrica/open-claudia",
-  "version": "2.14.6",
+  "version": "2.14.7",
   "description": "Your always-on AI coding assistant — Claude Code, Cursor Agent, and OpenAI Codex via Telegram or Kazee Chat",
   "main": "bot.js",
   "bin": {
@@ -9,7 +9,7 @@
   "scripts": {
     "setup": "node setup.js",
     "start": "node bot.js",
-    "test": "OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node -e \"require('./vault'); console.log('OK')\" && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-runner-watchdog-static.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-usage-accounting.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-engine.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-graph.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-discoverer.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-project-transcripts-smoke.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-abilities.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-extraction.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-couse.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-transfer.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-tiers.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-merge-guard.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-learning-e2e.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-pack-nesting.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-journal-dedupe.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-read-signal.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tools.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tool-graph.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tool-guard.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tooling-mode.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tool-manifest.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-evolution.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-approval-async.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-unified-identity.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-queue-routing.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-persona-packs.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-speaker-persona.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-persona-pipeline.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-relationship-gate.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-relationship.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-enforcer.js"
+    "test": "OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node -e \"require('./vault'); console.log('OK')\" && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-runner-watchdog-static.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-usage-accounting.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-engine.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-graph.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-discoverer.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-project-transcripts-smoke.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-abilities.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-extraction.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-couse.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-transfer.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-tiers.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-ability-merge-guard.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-learning-e2e.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-pack-nesting.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-journal-dedupe.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-read-signal.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tools.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tool-graph.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tool-guard.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tooling-mode.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-tool-manifest.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-evolution.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-approval-async.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-unified-identity.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-queue-routing.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-persona-packs.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-speaker-persona.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-persona-pipeline.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-recall-relationship-gate.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-relationship.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-enforcer.js && OPEN_CLAUDIA_TEST=1 WORKSPACE=/tmp/open-claudia-test CLAUDE_PATH=node node test-identity-prune.js"
   },
   "files": [
     "bot.js",
@@ -59,7 +59,8 @@
     "test-persona-pipeline.js",
     "test-recall-relationship-gate.js",
     "test-relationship.js",
-    "test-enforcer.js"
+    "test-enforcer.js",
+    "test-identity-prune.js"
   ],
   "keywords": [
     "claude",

package/test-identity-prune.js

@@ -0,0 +1,66 @@
+// Targeted identity-link removal (/link remove <key> → identity.removeIdentityMapping).
+// Verifies, in a hermetic temp HOME so the real config is never touched, that:
+//   • removing a channel key drops it from BOTH memory and disk;
+//   • the canonical's preferred pointer is pruned only when no other channel
+//     still references it (last-link semantics);
+//   • a shared canonical keeps its preferred pointer until the last link goes;
+//   • removing an unknown key is a no-op (removed:false), not a throw.
+// Isolation matches test-unified-identity.js: temp HOME → config-dir points at a
+// throwaway .open-claudia; require identity AFTER HOME is set so its load-once
+// cache reads the seeded file.
+
+const fs = require("fs");
+const path = require("path");
+const os = require("os");
+const assert = require("assert");
+
+const REPO = __dirname;
+
+const HOME = fs.mkdtempSync(path.join(os.tmpdir(), "oc-prunetest-"));
+const CFG = path.join(HOME, ".open-claudia");
+fs.mkdirSync(CFG, { recursive: true });
+fs.writeFileSync(path.join(CFG, ".env"), [
+  `WORKSPACE=${path.join(HOME, "ws")}`,
+  `CLAUDE_PATH=${process.execPath}`,
+  `TELEGRAM_BOT_TOKEN=dummy`,
+  `TELEGRAM_CHAT_ID=6251055967`,
+  ``,
+].join("\n"));
+// Two channels sharing one canonical + that canonical's preferred pointer —
+// the exact shape of the stray fixtures the command exists to clean.
+const IDFILE = path.join(CFG, "identities.json");
+fs.writeFileSync(IDFILE, JSON.stringify({
+  channels: { "telegram:1111": "telegram:111", "kazee:owner-linked-kazee": "telegram:111" },
+  preferred: { "telegram:111": { transport: "kazee", channelId: "owner-linked-kazee" } },
+}));
+
+process.env.HOME = HOME;
+const id = require(path.join(REPO, "core/identity"));
+
+// Unknown key → no-op.
+const miss = id.removeIdentityMapping("telegram:does-not-exist");
+assert.deepStrictEqual(miss, { removed: false, key: "telegram:does-not-exist" }, "unknown key is a no-op");
+
+// First removal: canonical still referenced by the kazee link → preferred kept.
+const r1 = id.removeIdentityMapping("telegram:1111");
+assert.strictEqual(r1.removed, true, "first: removed");
+assert.strictEqual(r1.canonical, "telegram:111", "first: canonical reported");
+assert.strictEqual(r1.prunedPreferred, false, "first: preferred kept (still referenced)");
+let disk = JSON.parse(fs.readFileSync(IDFILE, "utf-8"));
+assert.ok(!("telegram:1111" in disk.channels), "first: channel gone from disk");
+assert.ok("kazee:owner-linked-kazee" in disk.channels, "first: sibling link intact on disk");
+assert.ok("telegram:111" in disk.preferred, "first: preferred still on disk");
+assert.ok(!("telegram:1111" in id.identities.channels), "first: channel gone from memory");
+
+// Second removal: last link to the canonical → preferred pruned.
+const r2 = id.removeIdentityMapping("kazee:owner-linked-kazee");
+assert.strictEqual(r2.removed, true, "second: removed");
+assert.strictEqual(r2.prunedPreferred, true, "second: preferred pruned (last link)");
+disk = JSON.parse(fs.readFileSync(IDFILE, "utf-8"));
+assert.deepStrictEqual(disk.channels, {}, "second: channels empty on disk");
+assert.deepStrictEqual(disk.preferred, {}, "second: preferred empty on disk");
+assert.deepStrictEqual(id.identities.channels, {}, "second: channels empty in memory");
+assert.deepStrictEqual(id.identities.preferred, {}, "second: preferred empty in memory");
+
+fs.rmSync(HOME, { recursive: true, force: true });
+console.log("identity-prune OK");