@inetafrica/open-claudia 1.14.7 → 1.14.9

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # Changelog
 
+## v1.14.9
+- Fix `/upgrade`: `latest` was const-scoped to the version-check try
+  block, so the install step ran with `latest` undefined and threw
+  `ReferenceError: latest is not defined`. Hoist the variable and fall
+  back to npm's `latest` dist-tag if `npm view` fails. Regression
+  introduced in 745c6cf — broke v1.14.7 and v1.14.8 upgrades.
+
+## v1.14.8
+- Fix: `/stop` and the 6h hard-timeout now walk the full descendant
+  process tree, not just the Claude CLI's process group. Background
+  bashes started with `run_in_background: true` (and other detached
+  children) used to survive the kill and keep running indefinitely —
+  e.g. a polling `until` loop with a broken grep would burn CPU and
+  network for hours after the agent was already dead.
+- Fix: on bot startup, sweep stale `claude login` / `claude setup-token`
+  processes older than 30 minutes. These were left over from previous
+  bot crashes (blocked on stdin forever) and could hold Keychain locks.
+
 ## v1.14.0
 - Claude Code auth management from Telegram: `/auth_status`, `/login`, `/setup_token`, `/use_oauth_token`, and `/clear_oauth_token`
 - Claude subprocesses now receive `CLAUDE_CODE_OAUTH_TOKEN` from config/env/vault when available, avoiding launchd/macOS Keychain auth failures

package/bot.js

@@ -7,16 +7,51 @@ const cron = require("node-cron");
 const Vault = require("./vault");
 const CONFIG_DIR = require("./config-dir");
 
+// ── Process tree helpers ───────────────────────────────────────────
+// Background tools (e.g. Bash run_in_background, /stop on a dev server)
+// often spawn into their own session/group, so a single PGID kill on the
+// Claude CLI doesn't reach them. We walk the descendant tree explicitly
+// and signal each PID. Without this, runaway poll-loops survive
+// indefinitely after the parent CLI is SIGTERMed.
+function descendantPids(rootPid) {
+  const seen = new Set();
+  const queue = [Number(rootPid)];
+  while (queue.length) {
+    const pid = queue.shift();
+    if (!pid || seen.has(pid)) continue;
+    seen.add(pid);
+    try {
+      const out = execSync(`pgrep -P ${pid}`, { encoding: "utf-8", stdio: ["ignore", "pipe", "ignore"] });
+      for (const line of out.split("\n")) {
+        const child = Number(line.trim());
+        if (child) queue.push(child);
+      }
+    } catch (e) {
+      // pgrep exits 1 when no children — ignore.
+    }
+  }
+  seen.delete(Number(rootPid));
+  return [...seen];
+}
+
+function killProcessTree(rootPid, signal = "SIGTERM") {
+  if (!rootPid) return;
+  const descendants = descendantPids(rootPid);
+  // Kill the process group first (covers the common case quickly).
+  try { process.kill(-rootPid, signal); } catch (e) {}
+  try { process.kill(rootPid, signal); } catch (e) {}
+  // Then mop up any descendants that escaped the group (detached
+  // children with their own session — e.g. bash run_in_background).
+  for (const pid of descendants) {
+    try { process.kill(pid, signal); } catch (e) {}
+  }
+}
+
 // ── Graceful shutdown & error handling ─────────────────────────────
 async function gracefulShutdown(signal) {
   console.log(`Received ${signal}, shutting down gracefully...`);
-  // Stop any running Claude process
   if (typeof runningProcess !== "undefined" && runningProcess) {
-    try {
-      process.kill(-runningProcess.pid, "SIGTERM");
-    } catch (e) {
-      try { runningProcess.kill("SIGTERM"); } catch (e2) {}
-    }
+    killProcessTree(runningProcess.pid, "SIGTERM");
   }
   // Clean up temp media files older than 1 hour
   try {
@@ -1178,17 +1213,13 @@ async function runClaude(prompt, cwd, replyToMsgId, opts = {}) {
   const startTime = Date.now();
   let longRunningNotified = false;
 
-  // Hard timeout to prevent runaway processes
+  // Hard timeout to prevent runaway processes. We walk the descendant
+  // tree (not just the PGID) so that detached background bashes — like
+  // `run_in_background: true` poll loops — get cleaned up too.
   const processTimeout = setTimeout(async () => {
     if (runningProcess === proc) {
-      try {
-        process.kill(-proc.pid, "SIGTERM");
-        setTimeout(() => {
-          try { process.kill(-proc.pid, "SIGKILL"); } catch (e) {}
-        }, 5000);
-      } catch (e) {
-        try { proc.kill("SIGKILL"); } catch (e2) {}
-      }
+      killProcessTree(proc.pid, "SIGTERM");
+      setTimeout(() => killProcessTree(proc.pid, "SIGKILL"), 5000);
       await send(`Task timed out after ${MAX_PROCESS_TIMEOUT / 60000} minutes. Stopped.`);
     }
   }, MAX_PROCESS_TIMEOUT);
@@ -1517,9 +1548,12 @@ bot.onText(/\/upgrade$/, async (msg) => {
   // Change to HOME first — npm install -g replaces the package directory
   // which can delete the cwd out from under the running process
   try { process.chdir(process.env.HOME || require("os").homedir()); } catch (e) { /* already gone */ }
-  // Check if there's actually a newer version
+  // Check if there's actually a newer version. `latest` is hoisted so
+  // the install step below can reference it; if `npm view` fails we
+  // fall back to npm's `latest` dist-tag.
+  let latest = null;
   try {
-    const latest = execSync("npm view @inetafrica/open-claudia version", {
+    latest = execSync("npm view @inetafrica/open-claudia version", {
       encoding: "utf-8", timeout: 15000,
       env: { ...process.env, PATH: FULL_PATH, HOME: process.env.HOME || require("os").homedir() },
     }).trim();
@@ -1531,8 +1565,9 @@ bot.onText(/\/upgrade$/, async (msg) => {
   } catch (e) {
     await send("Upgrading...");
   }
+  const installTarget = latest || "latest";
   try {
-    execSync(`npm install -g @inetafrica/open-claudia@${latest} 2>&1`, {
+    execSync(`npm install -g @inetafrica/open-claudia@${installTarget} 2>&1`, {
       encoding: "utf-8", timeout: 120000,
       cwd: process.env.HOME || require("os").homedir(),
       env: { ...process.env, PATH: FULL_PATH, HOME: process.env.HOME || require("os").homedir() },
@@ -1697,16 +1732,10 @@ bot.onText(/\/stop/, async (msg) => {
   if (!isAuthorized(msg)) return;
   if (runningProcess) {
     const pid = runningProcess.pid;
-    try {
-      // Kill entire process group to catch child processes (dev servers, etc.)
-      process.kill(-pid, "SIGTERM");
-    } catch (e) {
-      try { runningProcess.kill("SIGTERM"); } catch (e2) {}
-    }
-    // Force kill after 3 seconds if still alive
-    setTimeout(() => {
-      try { process.kill(-pid, "SIGKILL"); } catch (e) {}
-    }, 3000);
+    // Walk the descendant tree so detached children (background bashes,
+    // dev servers) get cleaned up, not just the PGID.
+    killProcessTree(pid, "SIGTERM");
+    setTimeout(() => killProcessTree(pid, "SIGKILL"), 3000);
     runningProcess = null;
     if (streamInterval) clearTimeout(streamInterval);
     messageQueue = [];
@@ -2206,6 +2235,36 @@ try {
   console.warn("Setup check skipped:", e.message);
 }
 
+// Sweep stale `claude login` / `claude setup-token` processes that
+// survived a previous bot crash. They're blocked on stdin forever and
+// can hold keychain locks / resources. Anything older than 30 minutes
+// is assumed to be abandoned.
+try {
+  const out = execSync(
+    `ps -axo pid,etime,command | awk '/claude (login|setup-token)/ && !/awk/'`,
+    { encoding: "utf-8", stdio: ["ignore", "pipe", "ignore"] },
+  );
+  for (const line of out.split("\n")) {
+    const m = line.trim().match(/^(\d+)\s+(\S+)\s/);
+    if (!m) continue;
+    const pid = Number(m[1]);
+    const elapsed = m[2]; // [DD-]HH:MM:SS or MM:SS
+    const minutes = elapsed.includes("-")
+      ? Number(elapsed.split("-")[0]) * 24 * 60 + 60 // any "DD-" form is ≥1 day
+      : elapsed.split(":").length === 3
+        ? Number(elapsed.split(":")[0]) * 60 + Number(elapsed.split(":")[1])
+        : Number(elapsed.split(":")[0]);
+    if (minutes >= 30) {
+      try {
+        process.kill(pid, "SIGTERM");
+        console.log(`Swept stale auth process pid=${pid} elapsed=${elapsed}`);
+      } catch (e) {}
+    }
+  }
+} catch (e) {
+  // ps/awk not available or no matches — fine.
+}
+
 initCrons();
 console.log("Claude Code Telegram bot running");
 console.log(`Workspace: ${WORKSPACE}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@inetafrica/open-claudia",
-  "version": "1.14.7",
+  "version": "1.14.9",
   "description": "Your always-on AI coding assistant — Claude Code via Telegram",
   "main": "bot.js",
   "bin": {