@indigoai-us/hq-cloud 6.18.18 → 6.18.19

package/dist/cli/sync.test.js

@@ -174,7 +174,7 @@ vi.mock("../sync/mass-delete-guards.js", async (importOriginal) => {
     return { ...actual, resolveMassDeleteGuards: vi.fn().mockResolvedValue(false) };
 });
 import { resolveMassDeleteGuards } from "../sync/mass-delete-guards.js";
-import { sync, reportNewFilesToNotify, applyRealtimeDeltaPage, isSyncMutationStdinCommand, runSyncMutationStdinJson, SYNC_MUTATION_STDIN_COMMAND, FULL_PULL_COOPERATIVE_CHECKPOINT_BATCH_SIZE, FULL_PULL_LIST_PAGE_CHECKPOINT_SIZE, setListCooperativeYieldMsForTesting, targetedJournalSessionCensusSizes, win32SymlinkFlavorBroken, _testing as syncTesting, } from "./sync.js";
+import { sync, reportNewFilesToNotify, applyRealtimeDeltaPage, isSyncMutationStdinCommand, runSyncMutationStdinJson, SYNC_MUTATION_STDIN_COMMAND, FULL_PULL_COOPERATIVE_CHECKPOINT_BATCH_SIZE, FULL_PULL_LIST_PAGE_CHECKPOINT_SIZE, setListCooperativeYieldMsForTesting, setNewFilesEnrichmentBulkCapForTesting, targetedJournalSessionCensusSizes, win32SymlinkFlavorBroken, _testing as syncTesting, } from "./sync.js";
 import { share } from "./share.js";
 import * as s3Module from "../s3.js";
 import { resolvePersonalConnectorSettingsSync } from "../lib/personal-connector-settings-sync.js";
@@ -7145,6 +7145,94 @@ describe("sync", () => {
         const newFilesIdx = eventTypes.indexOf("new-files");
         expect(newFilesIdx).toBeGreaterThan(lastProgressIdx);
     });
+    // ── Bulk-sync post-pull tail bypass ─────────────────────────────────
+    // Regression for the 2026-09-30 first-sync case
+    // (i-0b8c4677512e81136 · agt_3FZG3TC9GEEMRVWSRF9NJ7Q98C, hq-cloud
+    // 6.18.18): 63,836 new files kept the runner ~20 minutes past
+    // filesDone == filesTotal doing per-file HEAD enrichment
+    // + /v1/notify/file-added POST, while the wizard already showed
+    // "Sync did not finish". Above the bulk cap, the enrichment and the
+    // notify POST are skipped so the pull tail after the last download is
+    // O(1); new-files still emits (with addedBy: null) so downstream
+    // consumers see the full list.
+    describe("bulk-sync post-pull tail bypass (new-files > cap)", () => {
+        const bulkFiles = Array.from({ length: 3 }, (_, i) => ({
+            key: `bulk/file-${i}.md`,
+            size: 10,
+            lastModified: new Date(),
+            etag: `"bulk-${i}"`,
+        }));
+        beforeEach(() => {
+            // Cap at 2 so a 3-file remote trips the bypass in this test suite.
+            setNewFilesEnrichmentBulkCapForTesting(2);
+        });
+        afterEach(() => {
+            setNewFilesEnrichmentBulkCapForTesting(undefined);
+        });
+        it("skips per-file HeadObject enrichment when new files exceed the cap", async () => {
+            vi.mocked(s3Module.listRemoteFiles).mockResolvedValueOnce(bulkFiles);
+            vi.mocked(s3Module.headRemoteFile).mockResolvedValue({
+                lastModified: new Date(),
+                etag: '"any"',
+                size: 10,
+                metadata: { "created-by": "should-not-be-read@example.com" },
+            });
+            const newFilesEvents = [];
+            await sync({
+                company: "acme",
+                vaultConfig: mockConfig,
+                hqRoot: tmpDir,
+                onEvent: (e) => {
+                    if (e.type === "new-files")
+                        newFilesEvents.push(e);
+                },
+            });
+            // Bypass path: enrichment loop does not run for any of the 3 new
+            // files, and the entire pull tail (HEAD + notify POST) is O(1).
+            expect(vi.mocked(s3Module.headRemoteFile)).not.toHaveBeenCalled();
+            expect(newFilesEvents).toHaveLength(1);
+            expect(newFilesEvents[0].files).toHaveLength(3);
+            for (const f of newFilesEvents[0].files) {
+                expect(f.addedBy).toBeNull();
+            }
+        });
+        it("skips the /v1/notify/file-added POST when new files exceed the cap", async () => {
+            vi.mocked(s3Module.listRemoteFiles).mockResolvedValueOnce(bulkFiles);
+            await sync({
+                company: "acme",
+                vaultConfig: mockConfig,
+                hqRoot: tmpDir,
+                onEvent: () => { },
+            });
+            const calls = vi.mocked(globalThis.fetch).mock.calls;
+            const notifyCalls = calls.filter(([u]) => String(u).includes("/v1/notify/file-added"));
+            expect(notifyCalls).toHaveLength(0);
+        });
+        it("still enriches when new files fit under the cap", async () => {
+            // Two default remote files, cap 2 → NOT over cap → enrichment runs.
+            vi.mocked(s3Module.headRemoteFile).mockResolvedValue({
+                lastModified: new Date(),
+                etag: '"any"',
+                size: 10,
+                metadata: { "created-by": "author@example.com" },
+            });
+            const newFilesEvents = [];
+            await sync({
+                company: "acme",
+                vaultConfig: mockConfig,
+                hqRoot: tmpDir,
+                onEvent: (e) => {
+                    if (e.type === "new-files")
+                        newFilesEvents.push(e);
+                },
+            });
+            expect(vi.mocked(s3Module.headRemoteFile)).toHaveBeenCalled();
+            expect(newFilesEvents).toHaveLength(1);
+            for (const f of newFilesEvents[0].files) {
+                expect(f.addedBy).toBe("author@example.com");
+            }
+        });
+    });
     it("stamps progress.author from the downloaded object's created-by metadata", async () => {
         vi.mocked(s3Module.listRemoteFiles).mockResolvedValueOnce([
             { key: "docs/authored.md", size: 10, lastModified: new Date(), etag: '"e1"' },