@indigoai-us/hq-cloud 6.18.17 → 6.18.19

package/dist/cli/sync.test.js

@@ -174,7 +174,7 @@ vi.mock("../sync/mass-delete-guards.js", async (importOriginal) => {
     return { ...actual, resolveMassDeleteGuards: vi.fn().mockResolvedValue(false) };
 });
 import { resolveMassDeleteGuards } from "../sync/mass-delete-guards.js";
-import { sync, reportNewFilesToNotify, applyRealtimeDeltaPage, isSyncMutationStdinCommand, runSyncMutationStdinJson, SYNC_MUTATION_STDIN_COMMAND, FULL_PULL_COOPERATIVE_CHECKPOINT_BATCH_SIZE, FULL_PULL_LIST_PAGE_CHECKPOINT_SIZE, setListCooperativeYieldMsForTesting, targetedJournalSessionCensusSizes, win32SymlinkFlavorBroken, _testing as syncTesting, } from "./sync.js";
+import { sync, reportNewFilesToNotify, applyRealtimeDeltaPage, isSyncMutationStdinCommand, runSyncMutationStdinJson, SYNC_MUTATION_STDIN_COMMAND, FULL_PULL_COOPERATIVE_CHECKPOINT_BATCH_SIZE, FULL_PULL_LIST_PAGE_CHECKPOINT_SIZE, setListCooperativeYieldMsForTesting, setNewFilesEnrichmentBulkCapForTesting, targetedJournalSessionCensusSizes, win32SymlinkFlavorBroken, _testing as syncTesting, } from "./sync.js";
 import { share } from "./share.js";
 import * as s3Module from "../s3.js";
 import { resolvePersonalConnectorSettingsSync } from "../lib/personal-connector-settings-sync.js";
@@ -2314,6 +2314,50 @@ describe("sync", () => {
         expect(result.filesDownloaded).toBe(0);
         expect(getEntry(readJournal("acme"), vanishedKey)).toBeUndefined();
     });
+    /**
+     * REGRESSION: New Flow Test 1 (agt_529GZC4SD0874S43QR29FWCG1M) 2026-09-30.
+     * On the indigo first pull, 18 planned `chat/attachments/chan/...` keys
+     * failed presign with FILES_PRESIGN_FORBIDDEN — the caller is a hosted
+     * bot with no read grant on those channels. object-io throws the
+     * accessDeniedError shape (`name: "Forbidden"`), sync.ts's pull loop
+     * previously incremented `filesSkipped` silently, and the progress
+     * recorder never advanced `filesDone` — leaving 63787/63805 forever
+     * and paging the wizard's inactivity watch. Emit a proper
+     * `skip-access-denied` event so both the recorder and any downstream
+     * summary can count the key.
+     */
+    it("REGRESSION: a presign-denied GET emits skip-access-denied (never type:error) so filesDone can advance", async () => {
+        const deniedKey = "chat/attachments/chan/chn_01M2G9Y0SW73N7T6S5V6YW0XZ9/fe890ae2-5e95-4694-af5c-f5334422b8e2-pasted-2026-09-15T14-22-42-1.png";
+        vi.mocked(s3Module.listRemoteFiles).mockResolvedValueOnce([
+            { key: deniedKey, size: 4096, lastModified: new Date(), etag: '"denied"' },
+        ]);
+        // object-io's accessDeniedError shape: name: "Forbidden" with the
+        // presign code embedded in the message. Mirrors the exact failure
+        // sync.ts's isAccessDenied catches (New Flow Test 1 evidence).
+        vi.mocked(s3Module.downloadFile).mockRejectedValueOnce(Object.assign(new Error(`Access denied for ${deniedKey}: no get access to '${deniedKey}' (server get denied: FILES_PRESIGN_FORBIDDEN)`), { name: "Forbidden" }));
+        const events = [];
+        const result = await sync({
+            company: "acme",
+            vaultConfig: mockConfig,
+            hqRoot: tmpDir,
+            skipReindex: true,
+            onEvent: (e) => events.push(e),
+        });
+        const skip = events.find((e) => e.type === "skip-access-denied");
+        expect(skip).toMatchObject({
+            type: "skip-access-denied",
+            path: deniedKey,
+            reason: "FILES_PRESIGN_FORBIDDEN",
+        });
+        // Load-bearing: no non-diagnostic type:"error" — the runner must keep
+        // exit 0 and the company must stay `complete` on ACL denials.
+        expect(events.some((e) => e.type === "error" && e.diagnostic !== true)).toBe(false);
+        expect(result.filesSkipped).toBeGreaterThanOrEqual(1);
+        expect(result.filesDownloaded).toBe(0);
+        // Deliberate skip contract: no journal entry, so a later pass that
+        // gains access materializes the file with no manual reset.
+        expect(getEntry(readJournal("acme"), deniedKey)).toBeUndefined();
+    });
     it("a 403 GET error still surfaces as type:error — only a vanished remote is downgraded", async () => {
         vi.mocked(s3Module.listRemoteFiles).mockResolvedValueOnce([
             { key: "docs/secret.md", size: 10, lastModified: new Date(), etag: '"x"' },
@@ -7101,6 +7145,94 @@ describe("sync", () => {
         const newFilesIdx = eventTypes.indexOf("new-files");
         expect(newFilesIdx).toBeGreaterThan(lastProgressIdx);
     });
+    // ── Bulk-sync post-pull tail bypass ─────────────────────────────────
+    // Regression for the 2026-09-30 first-sync case
+    // (i-0b8c4677512e81136 · agt_3FZG3TC9GEEMRVWSRF9NJ7Q98C, hq-cloud
+    // 6.18.18): 63,836 new files kept the runner ~20 minutes past
+    // filesDone == filesTotal doing per-file HEAD enrichment
+    // + /v1/notify/file-added POST, while the wizard already showed
+    // "Sync did not finish". Above the bulk cap, the enrichment and the
+    // notify POST are skipped so the pull tail after the last download is
+    // O(1); new-files still emits (with addedBy: null) so downstream
+    // consumers see the full list.
+    describe("bulk-sync post-pull tail bypass (new-files > cap)", () => {
+        const bulkFiles = Array.from({ length: 3 }, (_, i) => ({
+            key: `bulk/file-${i}.md`,
+            size: 10,
+            lastModified: new Date(),
+            etag: `"bulk-${i}"`,
+        }));
+        beforeEach(() => {
+            // Cap at 2 so a 3-file remote trips the bypass in this test suite.
+            setNewFilesEnrichmentBulkCapForTesting(2);
+        });
+        afterEach(() => {
+            setNewFilesEnrichmentBulkCapForTesting(undefined);
+        });
+        it("skips per-file HeadObject enrichment when new files exceed the cap", async () => {
+            vi.mocked(s3Module.listRemoteFiles).mockResolvedValueOnce(bulkFiles);
+            vi.mocked(s3Module.headRemoteFile).mockResolvedValue({
+                lastModified: new Date(),
+                etag: '"any"',
+                size: 10,
+                metadata: { "created-by": "should-not-be-read@example.com" },
+            });
+            const newFilesEvents = [];
+            await sync({
+                company: "acme",
+                vaultConfig: mockConfig,
+                hqRoot: tmpDir,
+                onEvent: (e) => {
+                    if (e.type === "new-files")
+                        newFilesEvents.push(e);
+                },
+            });
+            // Bypass path: enrichment loop does not run for any of the 3 new
+            // files, and the entire pull tail (HEAD + notify POST) is O(1).
+            expect(vi.mocked(s3Module.headRemoteFile)).not.toHaveBeenCalled();
+            expect(newFilesEvents).toHaveLength(1);
+            expect(newFilesEvents[0].files).toHaveLength(3);
+            for (const f of newFilesEvents[0].files) {
+                expect(f.addedBy).toBeNull();
+            }
+        });
+        it("skips the /v1/notify/file-added POST when new files exceed the cap", async () => {
+            vi.mocked(s3Module.listRemoteFiles).mockResolvedValueOnce(bulkFiles);
+            await sync({
+                company: "acme",
+                vaultConfig: mockConfig,
+                hqRoot: tmpDir,
+                onEvent: () => { },
+            });
+            const calls = vi.mocked(globalThis.fetch).mock.calls;
+            const notifyCalls = calls.filter(([u]) => String(u).includes("/v1/notify/file-added"));
+            expect(notifyCalls).toHaveLength(0);
+        });
+        it("still enriches when new files fit under the cap", async () => {
+            // Two default remote files, cap 2 → NOT over cap → enrichment runs.
+            vi.mocked(s3Module.headRemoteFile).mockResolvedValue({
+                lastModified: new Date(),
+                etag: '"any"',
+                size: 10,
+                metadata: { "created-by": "author@example.com" },
+            });
+            const newFilesEvents = [];
+            await sync({
+                company: "acme",
+                vaultConfig: mockConfig,
+                hqRoot: tmpDir,
+                onEvent: (e) => {
+                    if (e.type === "new-files")
+                        newFilesEvents.push(e);
+                },
+            });
+            expect(vi.mocked(s3Module.headRemoteFile)).toHaveBeenCalled();
+            expect(newFilesEvents).toHaveLength(1);
+            for (const f of newFilesEvents[0].files) {
+                expect(f.addedBy).toBe("author@example.com");
+            }
+        });
+    });
     it("stamps progress.author from the downloaded object's created-by metadata", async () => {
         vi.mocked(s3Module.listRemoteFiles).mockResolvedValueOnce([
             { key: "docs/authored.md", size: 10, lastModified: new Date(), etag: '"e1"' },