@indigoai-us/hq-cloud 6.14.49 → 6.15.0

package/src/sync/push-receiver.test.ts

@@ -25,7 +25,6 @@
 import { describe, expect, it } from "vitest";
 
 import { encodePushEvent, type PushEvent } from "./push-event.js";
-import { StaticFlagProvider } from "./feature-flags.js";
 import {
   InMemoryFanout,
   InMemoryPushReceiver,
@@ -155,7 +154,6 @@ describe("US-009: SqsPushReceiver — subscribe lifecycle", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn,
-      enabled: true,
       sleep: fastSleep,
     });
 
@@ -176,7 +174,6 @@ describe("US-009: SqsPushReceiver — subscribe lifecycle", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn: async () => undefined,
-      enabled: true,
       sleep: fastSleep,
     });
     await receiver.start();
@@ -203,7 +200,6 @@ describe("US-009: SqsPushReceiver — subscribe lifecycle", () => {
       queueUrl: QUEUE_URL,
       sqs: spy,
       syncFn: async () => undefined,
-      enabled: true,
       sleep: fastSleep,
     });
     await receiver.start();
@@ -220,7 +216,6 @@ describe("US-009: SqsPushReceiver — subscribe lifecycle", () => {
           queueUrl: QUEUE_URL,
           sqs: new FakeSqs(),
           syncFn: async () => undefined,
-          enabled: true,
         }),
     ).toThrow(/tenantId is required/);
     expect(
@@ -230,7 +225,6 @@ describe("US-009: SqsPushReceiver — subscribe lifecycle", () => {
           queueUrl: "",
           sqs: new FakeSqs(),
           syncFn: async () => undefined,
-          enabled: true,
         }),
     ).toThrow(/queueUrl is required/);
   });
@@ -253,7 +247,6 @@ describe("US-009: SqsPushReceiver — dedupe", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn,
-      enabled: true,
       sleep: fastSleep,
     });
     await receiver.start();
@@ -281,7 +274,6 @@ describe("US-009: SqsPushReceiver — dedupe", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn,
-      enabled: true,
       sleep: fastSleep,
     });
     await receiver.start();
@@ -302,7 +294,6 @@ describe("US-009: SqsPushReceiver — dedupe", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn: async () => undefined,
-      enabled: true,
       sleep: fastSleep,
     });
     await receiver.start();
@@ -324,7 +315,6 @@ describe("US-009: SqsPushReceiver — reconnect / catch-up replay", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn: async () => undefined,
-      enabled: true,
       sleep: fastSleep,
       reconnect: { initialMs: 1, maxMs: 4, jitter: false },
     });
@@ -349,7 +339,6 @@ describe("US-009: SqsPushReceiver — reconnect / catch-up replay", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn,
-      enabled: true,
       sleep: fastSleep,
     });
     await receiver.start();
@@ -383,7 +372,6 @@ describe("US-009: SqsPushReceiver — reconnect / catch-up replay", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn,
-      enabled: true,
       sleep: fastSleep,
     });
     await receiver.start();
@@ -414,7 +402,6 @@ describe("US-009: SqsPushReceiver — reconnect / catch-up replay", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn,
-      enabled: true,
       sleep: fastSleep,
       dedupeMaxPaths: 2,
     });
@@ -433,25 +420,8 @@ describe("US-009: SqsPushReceiver — reconnect / catch-up replay", () => {
   });
 });
 
-describe("US-009: SqsPushReceiver — flag gating", () => {
-  it("is dormant when the per-tenant flag is OFF (no queue polled, connected stays false)", async () => {
-    const sqs = new FakeSqs();
-    const receiver = new SqsPushReceiver({
-      tenantId: TENANT,
-      queueUrl: QUEUE_URL,
-      sqs,
-      syncFn: async () => undefined,
-      flagProvider: new StaticFlagProvider([]), // tenant NOT enabled
-      sleep: fastSleep,
-    });
-    await receiver.start();
-    await new Promise((r) => setTimeout(r, 20));
-    expect(receiver.connected).toBe(false);
-    expect(sqs.receiveCalls).toBe(0);
-    await receiver.dispose();
-  });
-
-  it("is active when the per-tenant flag includes the tenant", async () => {
+describe("U15: SqsPushReceiver — server-granted handoff", () => {
+  it("starts from supplied server queue material with no tenant client gate", async () => {
     const sqs = new FakeSqs();
     sqs.enqueue([msg(makeEvent({ sequenceNumber: 1 }))]);
     const receiver = new SqsPushReceiver({
@@ -459,7 +429,6 @@ describe("US-009: SqsPushReceiver — flag gating", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn: async () => undefined,
-      flagProvider: new StaticFlagProvider([TENANT]),
       sleep: fastSleep,
     });
     await receiver.start();
@@ -468,23 +437,6 @@ describe("US-009: SqsPushReceiver — flag gating", () => {
     await receiver.dispose();
   });
 
-  it("explicit enabled wins over the provider", async () => {
-    const sqs = new FakeSqs();
-    const receiver = new SqsPushReceiver({
-      tenantId: TENANT,
-      queueUrl: QUEUE_URL,
-      sqs,
-      syncFn: async () => undefined,
-      enabled: false,
-      flagProvider: new StaticFlagProvider([TENANT]),
-      sleep: fastSleep,
-    });
-    await receiver.start();
-    await new Promise((r) => setTimeout(r, 20));
-    expect(receiver.connected).toBe(false);
-    expect(sqs.receiveCalls).toBe(0);
-    await receiver.dispose();
-  });
 });
 
 describe("US-009: SqsPushReceiver — dispose drain", () => {
@@ -506,7 +458,6 @@ describe("US-009: SqsPushReceiver — dispose drain", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn,
-      enabled: true,
       sleep: fastSleep,
       disposeDrainMs: 200,
     });
@@ -524,7 +475,6 @@ describe("US-009: SqsPushReceiver — dispose drain", () => {
       queueUrl: QUEUE_URL,
       sqs,
       syncFn: async () => undefined,
-      enabled: true,
       sleep: fastSleep,
     });
     await receiver.start();
@@ -542,7 +492,6 @@ describe("US-009: InMemoryPushReceiver — disconnect buffering + reconnect drai
     const receiver = new InMemoryPushReceiver({
       tenantId: TENANT,
       fanout,
-      enabled: true,
       syncFn: async (ctx) => {
         processed.push(ctx.event.sequenceNumber);
       },
@@ -568,13 +517,12 @@ describe("US-009: InMemoryPushReceiver — disconnect buffering + reconnect drai
     expect(receiver.dedupedCount).toBe(1);
   });
 
-  it("is dormant when the flag is OFF", async () => {
+  it("does not derive activation from a tenant flag", async () => {
     const fanout = new InMemoryFanout();
     let calls = 0;
     const receiver = new InMemoryPushReceiver({
       tenantId: TENANT,
       fanout,
-      flagProvider: new StaticFlagProvider([]),
       syncFn: async () => {
         calls += 1;
       },
@@ -582,8 +530,9 @@ describe("US-009: InMemoryPushReceiver — disconnect buffering + reconnect drai
     await receiver.start();
     fanout.publish(encodePushEvent(makeEvent()));
     await new Promise((r) => setTimeout(r, 20));
-    expect(receiver.connected).toBe(false);
-    expect(calls).toBe(0);
+    await waitFor(() => calls === 1);
+    expect(receiver.connected).toBe(true);
+    expect(calls).toBe(1);
     await receiver.dispose();
   });
 });
@@ -602,7 +551,6 @@ describe("US-009: createPushReceiver factory", () => {
       queueUrl: QUEUE_URL,
       sqs: new FakeSqs(),
       syncFn: async () => undefined,
-      enabled: true,
     });
     expect(r).toBeInstanceOf(SqsPushReceiver);
   });

package/src/sync/push-receiver.ts

@@ -71,13 +71,11 @@
  * events are absorbed by the dedupe path. The in-memory fake's
  * `simulateDisconnect()` / `simulateReconnect()` model exactly this buffering.
  *
- * Feature flag (AC#4)
- * ───────────────────
- * Gated by the per-tenant {@link EventDrivenPushFlagProvider} (US-008's
- * feature-flags.ts) — honors `HQ_SYNC_EVENT_DRIVEN_PUSH_ENABLED_TENANTS`
- * (per-tenant) + the legacy global `HQ_SYNC_EVENT_DRIVEN_PUSH_ENABLED=true`.
- * Default DISABLED. Resolution precedence: explicit `enabled` > injected
- * `flagProvider.isEnabled(tenantId)` > default env-driven provider.
+ * Authority
+ * ─────────
+ * This receiver is created only after the event-sync wiring obtains
+ * authenticated server inventory/credentials. It has no tenant, environment,
+ * or queued-hint-derived positive gate.
  *
  * Cross-tenant isolation (US-010)
  * ───────────────────────────────
@@ -98,10 +96,6 @@
  */
 
 import { decodePushEvent, type PushEvent } from "./push-event.js";
-import {
-  defaultFlagProvider,
-  type EventDrivenPushFlagProvider,
-} from "./feature-flags.js";
 import {
   publishSyncLatencyMetric,
   type SyncLatencyMetric,
@@ -290,27 +284,6 @@ export class NoopPushReceiver implements PushReceiver {
   }
 }
 
-// ─── Feature-flag resolution ─────────────────────────────────────────────────
-
-/**
- * Resolve the enabled boolean from layered config. Precedence (highest first):
- *   1. `explicit` — `enabled: true|false` wins outright (test contract).
- *   2. `flagProvider.isEnabled(tenantId)` — injected per-tenant provider.
- *   3. default {@link EnvTenantListFlagProvider} from `env ?? process.env`.
- */
-function resolveEnabled(args: {
-  explicit: boolean | undefined;
-  flagProvider: EventDrivenPushFlagProvider | undefined;
-  tenantId: string;
-  env: Record<string, string | undefined> | undefined;
-}): boolean {
-  if (args.explicit !== undefined) return args.explicit;
-  if (args.flagProvider !== undefined) {
-    return args.flagProvider.isEnabled(args.tenantId);
-  }
-  return defaultFlagProvider(args.env ?? process.env).isEnabled(args.tenantId);
-}
-
 // ─── SQS receiver ─────────────────────────────────────────────────────────
 
 /**
@@ -339,15 +312,10 @@ export interface SqsPushReceiverOptions {
   /** Structured logger. Default: a no-op (quiet). */
   logger?: ReceiverLogger;
   /**
-   * Feature-flag override — wins over provider + env when set explicitly.
-   * When the resolved value is false, `start()` is a no-op, `connected` stays
-   * false, and NO queue is polled. (AC#4)
+   * Deprecated compatibility field. It is intentionally ignored: it can no
+   * longer enable or disable a receiver after server authorization.
    */
   enabled?: boolean;
-  /** Per-tenant flag provider (US-008). Consulted when `enabled` is unset. */
-  flagProvider?: EventDrivenPushFlagProvider;
-  /** Env snapshot for flag resolution. Default: `process.env`. */
-  env?: Record<string, string | undefined>;
   /** SQS long-poll wait seconds. Default {@link DEFAULT_WAIT_TIME_SECONDS}. */
   waitTimeSeconds?: number;
   /** Max messages per receive. Default {@link DEFAULT_MAX_MESSAGES}. */
@@ -394,7 +362,6 @@ export class SqsPushReceiver implements PushReceiver {
   private readonly sqs: SqsClientLike;
   private readonly syncFn: SyncEngineFn;
   private readonly logger: ReceiverLogger;
-  private readonly enabled: boolean;
   private readonly waitTimeSeconds: number;
   private readonly maxMessages: number;
   private readonly disposeDrainMs: number;
@@ -438,12 +405,6 @@ export class SqsPushReceiver implements PushReceiver {
     this.sqs = opts.sqs;
     this.syncFn = opts.syncFn;
     this.logger = opts.logger ?? NOOP_LOGGER;
-    this.enabled = resolveEnabled({
-      explicit: opts.enabled,
-      flagProvider: opts.flagProvider,
-      tenantId: opts.tenantId,
-      env: opts.env,
-    });
     this.waitTimeSeconds = opts.waitTimeSeconds ?? DEFAULT_WAIT_TIME_SECONDS;
     this.maxMessages = opts.maxMessages ?? DEFAULT_MAX_MESSAGES;
     this.disposeDrainMs =
@@ -467,17 +428,6 @@ export class SqsPushReceiver implements PushReceiver {
 
   async start(): Promise<void> {
     if (this.disposed) return;
-    if (!this.enabled) {
-      this.logger.info(
-        {
-          event: "receiver.start.disabled",
-          tenantId: this.tenantId,
-          reason: "feature flag off",
-        },
-        "push receiver disabled by feature flag",
-      );
-      return;
-    }
     if (this.loopAbort !== null) {
       // Double-start is a no-op — matches PushTransport idempotency posture.
       this.logger.debug(
@@ -853,9 +803,8 @@ export interface InMemoryPushReceiverOptions {
   fanout: InMemoryFanout;
   syncFn: SyncEngineFn;
   logger?: ReceiverLogger;
+  /** Deprecated compatibility field; intentionally ignored. */
   enabled?: boolean;
-  flagProvider?: EventDrivenPushFlagProvider;
-  env?: Record<string, string | undefined>;
   disposeDrainMs?: number;
   /** Maximum distinct paths retained in dedupe state. */
   dedupeMaxPaths?: number;
@@ -873,7 +822,6 @@ export class InMemoryPushReceiver implements PushReceiver {
   private readonly fanout: InMemoryFanout;
   private readonly syncFn: SyncEngineFn;
   private readonly logger: ReceiverLogger;
-  private readonly enabled: boolean;
   private readonly disposeDrainMs: number;
 
   private _connected = false;
@@ -901,12 +849,6 @@ export class InMemoryPushReceiver implements PushReceiver {
     this.disposeDrainMs =
       opts.disposeDrainMs ?? DEFAULT_RECEIVER_DISPOSE_DRAIN_MS;
     this.seenSequencePerPath = new BoundedSequenceDedupe(opts.dedupeMaxPaths);
-    this.enabled = resolveEnabled({
-      explicit: opts.enabled,
-      flagProvider: opts.flagProvider,
-      tenantId: opts.tenantId,
-      env: opts.env,
-    });
   }
 
   get connected(): boolean {
@@ -915,13 +857,6 @@ export class InMemoryPushReceiver implements PushReceiver {
 
   async start(): Promise<void> {
     if (this.disposed) return;
-    if (!this.enabled) {
-      this.logger.info(
-        { event: "receiver.start.disabled", tenantId: this.tenantId },
-        "push receiver disabled by feature flag",
-      );
-      return;
-    }
     if (this.unsubscribe !== null) return; // double-start no-op
 
     this.unsubscribe = this.fanout.subscribe((raw) => {
@@ -1013,7 +948,7 @@ export class InMemoryPushReceiver implements PushReceiver {
 
   /** Emulate a network blip — events buffer instead of dispatching. */
   simulateDisconnect(): void {
-    if (!this.enabled || this.unsubscribe === null) return;
+    if (this.unsubscribe === null) return;
     this.disconnectedFlag = true;
     this._connected = false;
   }

package/src/sync/realtime-rollout.test.ts

@@ -0,0 +1,86 @@
+import { describe, expect, it, vi } from "vitest";
+
+import {
+  MAX_REALTIME_ROLLOUT_CACHE_MS,
+  RealtimeRolloutClient,
+  parseRealtimeInventory,
+  type RealtimeCapabilityVector,
+} from "./realtime-rollout.js";
+
+const capability: RealtimeCapabilityVector = {
+  hqCloud: "6.14.49",
+  hqDesktop: "none",
+  protocol: 2,
+  journal: 3,
+  durableApply: 1,
+};
+
+function jsonResponse(body: unknown, status = 200) {
+  return { ok: status >= 200 && status < 300, status, text: async () => JSON.stringify(body) };
+}
+
+function request(overrides: Partial<Parameters<RealtimeRolloutClient["inventory"]>[0]> = {}) {
+  return {
+    bearer: "token-a",
+    deviceId: "machine_a",
+    capabilityVector: capability,
+    configurationFingerprint: "config-a",
+    scopeFingerprint: "personal:prs_1",
+    ...overrides,
+  };
+}
+
+const readyInventory = {
+  scopes: [{ scopeUid: "prs_1", scopeHandle: "handle_1", scopeRevision: "rev_1", state: "v2-ready", cursor: "cursor_1" }],
+};
+
+describe("RealtimeRolloutClient", () => {
+  it("never reuses a cached positive across bearer, configuration, or scope changes", async () => {
+    let now = 1_000;
+    const requests: Array<{ headers?: Record<string, string> }> = [];
+    const fetchImpl = async (_url: string, init?: { headers?: Record<string, string> }) => {
+      requests.push({ headers: init?.headers });
+      return jsonResponse(readyInventory);
+    };
+    const client = new RealtimeRolloutClient({ apiUrl: "https://api.example/", fetchImpl, now: () => now });
+
+    await client.inventory(request());
+    await client.inventory(request());
+    await client.inventory(request({ bearer: "token-b" }));
+    await client.inventory(request({ configurationFingerprint: "config-b" }));
+    await client.inventory(request({ scopeFingerprint: "company:cmp_1" }));
+    now += MAX_REALTIME_ROLLOUT_CACHE_MS;
+    await client.inventory(request());
+
+    expect(requests).toHaveLength(5);
+    expect(requests[0]?.headers).toMatchObject({
+      Authorization: "Bearer token-a",
+      "X-HQ-Sync-Contract": "2",
+      "X-HQ-Device-ID": "machine_a",
+      "X-HQ-Cloud-Version": "6.14.49",
+      "X-HQ-Desktop-Version": "none",
+      "X-HQ-Sync-Journal": "3",
+      "X-HQ-Sync-Durable-Apply": "1",
+    });
+  });
+
+  it("fails closed for malformed or non-explicit legacy inventory", () => {
+    expect(() => parseRealtimeInventory({ scopes: [{ scopeUid: "prs_1", scopeHandle: "h", scopeRevision: "r", state: "legacy", v1Allowed: false }] })).toThrow("legacy must explicitly allow v1");
+    expect(() => parseRealtimeInventory({ scopes: [{ scopeUid: "prs_1", scopeHandle: "h", scopeRevision: "r", state: "v2-ready", cursor: "c", surprise: true }] })).toThrow("unknown field");
+    expect(() => parseRealtimeInventory({ scopes: [{ scopeUid: "prs_1", scopeHandle: "h", scopeRevision: "r", state: "unknown" }] })).toThrow("unsupported scope state");
+  });
+
+  it("rejects cache durations greater than the protocol maximum", () => {
+    expect(() => new RealtimeRolloutClient({ apiUrl: "https://api.example", maxCacheAgeMs: MAX_REALTIME_ROLLOUT_CACHE_MS + 1 })).toThrow("maxCacheAgeMs");
+  });
+
+  it("honors transitional retryAfterMs instead of holding a stale negative state", async () => {
+    const fetchImpl = vi.fn(async () => jsonResponse({ scopes: [
+      { scopeUid: "prs_1", scopeHandle: "handle_1", scopeRevision: "rev_1", state: "restoring", retryAfterMs: 0 },
+    ] }));
+    const client = new RealtimeRolloutClient({ apiUrl: "https://api.example", fetchImpl });
+    await client.inventory(request());
+    await client.inventory(request());
+    expect(fetchImpl).toHaveBeenCalledTimes(2);
+  });
+});