@indigoai-us/hq-cloud 5.11.3 → 5.13.0

package/src/s3.test.ts

@@ -15,6 +15,11 @@ import * as path from "path";
 // in beforeEach so per-test assertions don't leak from neighbours.
 const sentCommands: Array<{ name: string; input: Record<string, unknown> }> = [];
 
+// Per-test override for the ListObjectsV2Command response. Tests of
+// `listRemoteFiles` push the Contents shape they want returned; the default
+// is an empty bucket. Reset in beforeEach so cross-test leakage is impossible.
+let nextListObjectsResponse: Record<string, unknown> = { Contents: [] };
+
 vi.mock("@aws-sdk/client-s3", () => {
   class FakeS3Client {
     async send(command: { constructor: { name: string }; input: Record<string, unknown> }): Promise<Record<string, unknown>> {
@@ -27,6 +32,9 @@ vi.mock("@aws-sdk/client-s3", () => {
       if (command.constructor.name === "PutObjectCommand") {
         return { ETag: '"fake-etag"' };
       }
+      if (command.constructor.name === "ListObjectsV2Command") {
+        return nextListObjectsResponse;
+      }
       return {};
     }
   }
@@ -58,7 +66,7 @@ vi.mock("@aws-sdk/client-s3", () => {
   };
 });
 
-import { uploadFile } from "./s3.js";
+import { uploadFile, listRemoteFiles } from "./s3.js";
 import type { EntityContext } from "./types.js";
 
 function makeCtx(): EntityContext {
@@ -164,3 +172,47 @@ describe("uploadFile", () => {
     expect(meta["created-by-sub"]).toBeUndefined();
   });
 });
+
+describe("listRemoteFiles", () => {
+  beforeEach(() => {
+    sentCommands.length = 0;
+    nextListObjectsResponse = { Contents: [] };
+  });
+
+  // Regression: pre-fix, `if (!obj.Key || !obj.Size) continue;` skipped every
+  // 0-byte object on the listing. The user's personal vault stored
+  // `projects/.gitkeep` (a 0-byte placeholder) and the sync pull plan never
+  // saw it — the file existed on S3 but was invisible to the runner, so the
+  // box never created `projects/` on first pull. The fix narrows the guard
+  // to `if (!obj.Key) continue;` so Size === 0 passes through with its real
+  // value (handled `?? 0` to keep TS Size?: number happy).
+  it("includes 0-byte objects in the result (no implicit skip-on-empty)", async () => {
+    nextListObjectsResponse = {
+      Contents: [
+        { Key: "projects/.gitkeep", Size: 0, LastModified: new Date(), ETag: '"d41d8cd98f00b204e9800998ecf8427e"' },
+        { Key: "AGENTS.md", Size: 100, LastModified: new Date(), ETag: '"e1"' },
+      ],
+    };
+
+    const files = await listRemoteFiles(makeCtx());
+
+    expect(files).toHaveLength(2);
+    const gitkeep = files.find((f) => f.key === "projects/.gitkeep");
+    expect(gitkeep).toBeDefined();
+    expect(gitkeep!.size).toBe(0);
+  });
+
+  it("still skips Contents entries with no Key (defensive against malformed responses)", async () => {
+    nextListObjectsResponse = {
+      Contents: [
+        { Size: 100, LastModified: new Date(), ETag: '"e1"' }, // no Key
+        { Key: "real.md", Size: 100, LastModified: new Date(), ETag: '"e2"' },
+      ],
+    };
+
+    const files = await listRemoteFiles(makeCtx());
+
+    expect(files).toHaveLength(1);
+    expect(files[0].key).toBe("real.md");
+  });
+});

package/src/s3.ts

@@ -173,11 +173,16 @@ export async function listRemoteFiles(
     );
 
     for (const obj of response.Contents || []) {
-      if (!obj.Key || !obj.Size) continue;
+      // Pre-fix this guard was `!obj.Key || !obj.Size`. The `!obj.Size` test
+      // is truthy when Size === 0 (a real 0-byte object like `.gitkeep`),
+      // silently filtering legitimate placeholder files out of every pull
+      // plan. Narrow the guard to "no key" only; surface real 0-byte
+      // objects to the planner.
+      if (!obj.Key) continue;
 
       files.push({
         key: obj.Key,
-        size: obj.Size,
+        size: obj.Size ?? 0,
         lastModified: obj.LastModified || new Date(),
         etag: obj.ETag || "",
       });