@indigoai-us/hq-cli 5.45.0 → 5.45.1

package/dist/commands/files.js

@@ -1,5 +1,5 @@
 
-!function(){try{var e="undefined"!=typeof window?window:"undefined"!=typeof global?global:"undefined"!=typeof globalThis?globalThis:"undefined"!=typeof self?self:{},n=(new e.Error).stack;n&&(e._sentryDebugIds=e._sentryDebugIds||{},e._sentryDebugIds[n]="c72d8e20-42a6-5818-b5d3-985e53954430")}catch(e){}}();
+!function(){try{var e="undefined"!=typeof window?window:"undefined"!=typeof global?global:"undefined"!=typeof globalThis?globalThis:"undefined"!=typeof self?self:{},n=(new e.Error).stack;n&&(e._sentryDebugIds=e._sentryDebugIds||{},e._sentryDebugIds[n]="8068c3b8-ee9c-5296-9b49-aa10bf38ccbd")}catch(e){}}();
 import chalk from "chalk";
 import open from "open";
 import { ensureCognitoToken } from "../utils/cognito-session.js";
@@ -178,7 +178,20 @@ export function registerFilesCommand(program) {
                     console.error(chalk.red("Not authorized to modify this file prefix's ACL"));
                 }
                 else if (res.status === 404) {
-                    console.log(chalk.green(`Grant already absent for '${canonicalPrefix}' / ${principalLabel}`));
+                    // A 404 means ZERO rows were removed — never report a green success
+                    // that implies a revoke happened. Distinguish the two causes:
+                    //   ACL_NOT_FOUND  — the prefix has no ACL at all (nothing was ever
+                    //                    shared here): genuinely, benignly absent.
+                    //   GRANT_NOT_FOUND (or an older server with no code) — the ACL
+                    //                    exists but no grant matched this principal:
+                    //                    surface it as a warning so a typo'd/stale
+                    //                    principal isn't mistaken for a real removal.
+                    if (body.code === "ACL_NOT_FOUND") {
+                        console.log(chalk.dim(`Nothing to remove — '${canonicalPrefix}' has no sharing grants.`));
+                    }
+                    else {
+                        console.warn(chalk.yellow(`No matching grant for ${principalLabel} on '${canonicalPrefix}' — nothing was removed.`));
+                    }
                     return;
                 }
                 else if (res.status >= 500) {
@@ -460,4 +473,4 @@ async function runShareSession(params) {
     }
 }
 //# sourceMappingURL=files.js.map
-//# debugId=c72d8e20-42a6-5818-b5d3-985e53954430
+//# debugId=8068c3b8-ee9c-5296-9b49-aa10bf38ccbd

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@indigoai-us/hq-cli",
-  "version": "5.45.0",
+  "version": "5.45.1",
   "description": "HQ by Indigo management CLI — modules and cloud sync",
   "main": "dist/index.js",
   "bin": {

package/src/commands/files.test.ts

@@ -502,3 +502,91 @@ describe("hq files share — direct-grant fork (with --with)", () => {
     expect(fetchSpy).not.toHaveBeenCalled();
   });
 });
+
+// ---------------------------------------------------------------------------
+// hq files unshare — never reports a false "removed" on a zero-row revoke
+// (Ridge / Connor #5, CLI side)
+// ---------------------------------------------------------------------------
+
+describe("hq files unshare", () => {
+  function mockCompanyResolution() {
+    // /membership/me for getCompanyUid
+    fetchSpy.mockResolvedValueOnce(
+      jsonResponse(200, {
+        memberships: [
+          { membershipKey: "k1", companyUid: "cmp_acme", role: "member", status: "active" },
+        ],
+      }),
+    );
+  }
+
+  it("prints a green success ONLY when the server actually removed a grant (200)", async () => {
+    mockCompanyResolution();
+    fetchSpy.mockResolvedValueOnce(jsonResponse(200, { acl: { path: "fooPath" } }));
+
+    const program = buildProgram();
+    await program.parseAsync(
+      ["files", "unshare", "fooPath", "--with", "user@example.com"],
+      { from: "user" },
+    );
+
+    const logs = logSpy.mock.calls.map((c) => String(c[0])).join("\n");
+    expect(logs).toMatch(/Removed grant for user@example.com on 'fooPath'/);
+  });
+
+  it("#5: does NOT print a green 'removed' success when the revoke matched zero rows (GRANT_NOT_FOUND)", async () => {
+    mockCompanyResolution();
+    fetchSpy.mockResolvedValueOnce(
+      jsonResponse(404, { error: "grant not found", code: "GRANT_NOT_FOUND" }),
+    );
+    const warnSpy = vi.spyOn(console, "warn").mockImplementation(() => undefined);
+
+    const program = buildProgram();
+    // Must NOT exit non-zero (idempotent no-op), and must NOT throw.
+    await program.parseAsync(
+      ["files", "unshare", "fooPath", "--with", "user@example.com"],
+      { from: "user" },
+    );
+
+    const logs = logSpy.mock.calls.map((c) => String(c[0])).join("\n");
+    const warns = warnSpy.mock.calls.map((c) => String(c[0])).join("\n");
+    // The dangerous false-success line must be absent.
+    expect(logs).not.toMatch(/Removed grant/);
+    // A truthful "nothing was removed" warning is surfaced instead.
+    expect(warns).toMatch(/nothing was removed/i);
+  });
+
+  it("treats a prefix with no ACL (ACL_NOT_FOUND) as benignly absent, not a removal", async () => {
+    mockCompanyResolution();
+    fetchSpy.mockResolvedValueOnce(
+      jsonResponse(404, { error: "ACL not found", code: "ACL_NOT_FOUND" }),
+    );
+
+    const program = buildProgram();
+    await program.parseAsync(
+      ["files", "unshare", "never-shared", "--with", "user@example.com"],
+      { from: "user" },
+    );
+
+    const logs = logSpy.mock.calls.map((c) => String(c[0])).join("\n");
+    expect(logs).not.toMatch(/Removed grant/);
+    expect(logs).toMatch(/has no sharing grants/);
+  });
+
+  it("falls back to a warning for an older server that returns 404 without a code", async () => {
+    mockCompanyResolution();
+    fetchSpy.mockResolvedValueOnce(jsonResponse(404, { error: "grant not found" }));
+    const warnSpy = vi.spyOn(console, "warn").mockImplementation(() => undefined);
+
+    const program = buildProgram();
+    await program.parseAsync(
+      ["files", "unshare", "fooPath", "--with", "user@example.com"],
+      { from: "user" },
+    );
+
+    const logs = logSpy.mock.calls.map((c) => String(c[0])).join("\n");
+    const warns = warnSpy.mock.calls.map((c) => String(c[0])).join("\n");
+    expect(logs).not.toMatch(/Removed grant/);
+    expect(warns).toMatch(/nothing was removed/i);
+  });
+});

package/src/commands/files.ts

@@ -243,7 +243,25 @@ export function registerFilesCommand(program: Command): Command {
           } else if (res.status === 403) {
             console.error(chalk.red("Not authorized to modify this file prefix's ACL"));
           } else if (res.status === 404) {
-            console.log(chalk.green(`Grant already absent for '${canonicalPrefix}' / ${principalLabel}`));
+            // A 404 means ZERO rows were removed — never report a green success
+            // that implies a revoke happened. Distinguish the two causes:
+            //   ACL_NOT_FOUND  — the prefix has no ACL at all (nothing was ever
+            //                    shared here): genuinely, benignly absent.
+            //   GRANT_NOT_FOUND (or an older server with no code) — the ACL
+            //                    exists but no grant matched this principal:
+            //                    surface it as a warning so a typo'd/stale
+            //                    principal isn't mistaken for a real removal.
+            if (body.code === "ACL_NOT_FOUND") {
+              console.log(
+                chalk.dim(`Nothing to remove — '${canonicalPrefix}' has no sharing grants.`),
+              );
+            } else {
+              console.warn(
+                chalk.yellow(
+                  `No matching grant for ${principalLabel} on '${canonicalPrefix}' — nothing was removed.`,
+                ),
+              );
+            }
             return;
           } else if (res.status >= 500) {
             console.error(chalk.red(`Server error: ${body.error ?? res.statusText}`));