@indiekitai/pg-dash 0.4.4 → 0.4.6

package/dist/cli.js

@@ -300,30 +300,44 @@ SHOW shared_buffers;`,
     }
     try {
       const r = await client.query(`
-        SELECT pid, state, now() - state_change AS idle_duration,
+        SELECT pid,
           client_addr::text, application_name,
           extract(epoch from now() - state_change)::int AS idle_seconds
         FROM pg_stat_activity
-        WHERE state IN ('idle', 'idle in transaction')
+        WHERE state = 'idle in transaction'
           AND now() - state_change > $1 * interval '1 minute'
           AND pid != pg_backend_pid()
+        ORDER BY idle_seconds DESC
       `, [longQueryThreshold]);
-      for (const row of r.rows) {
-        const isIdleTx = row.state === "idle in transaction";
+      if (r.rows.length === 1) {
+        const row = r.rows[0];
         issues.push({
-          id: `maint-idle-${row.pid}`,
-          severity: isIdleTx ? "warning" : "info",
+          id: `maint-idle-tx-${row.pid}`,
+          severity: "warning",
           category: "maintenance",
-          title: `${isIdleTx ? "Idle in transaction" : "Idle connection"} (PID ${row.pid})`,
-          description: `PID ${row.pid} from ${row.client_addr || "local"} (${row.application_name || "unknown"}) has been ${row.state} for ${Math.round(row.idle_seconds / 60)} minutes.`,
+          title: `Idle-in-transaction connection (PID ${row.pid})`,
+          description: `PID ${row.pid} from ${row.client_addr || "local"} (${row.application_name || "unknown"}) has been idle in transaction for ${Math.round(row.idle_seconds / 60)} minutes. This holds locks and blocks VACUUM.`,
           fix: `SELECT pg_terminate_backend(${row.pid});`,
-          impact: isIdleTx ? "Idle-in-transaction connections hold locks and prevent VACUUM." : "Idle connections consume connection slots.",
+          impact: "Idle-in-transaction connections hold locks and prevent VACUUM.",
+          effort: "quick"
+        });
+      } else if (r.rows.length > 1) {
+        const pids = r.rows.map((row) => row.pid);
+        const maxMin = Math.round(r.rows[0].idle_seconds / 60);
+        issues.push({
+          id: `maint-idle-tx-multi`,
+          severity: "warning",
+          category: "maintenance",
+          title: `${r.rows.length} idle-in-transaction connections (longest: ${maxMin}m)`,
+          description: `${r.rows.length} connections have been idle in transaction for over ${longQueryThreshold} minutes. These hold locks and prevent VACUUM from running.`,
+          fix: `SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE state = 'idle in transaction' AND now() - state_change > interval '${longQueryThreshold} minutes';`,
+          impact: "Idle-in-transaction connections hold locks and prevent VACUUM.",
           effort: "quick"
         });
       }
     } catch (err) {
-      console.error("[advisor] Error checking idle connections:", err.message);
-      skipped.push("idle connections: " + err.message);
+      console.error("[advisor] Error checking idle-in-transaction connections:", err.message);
+      skipped.push("idle-in-transaction: " + err.message);
     }
     try {
       const r = await client.query(`
@@ -2741,7 +2755,7 @@ var RANGE_MAP = {
   "7d": 7 * 24 * 60 * 60 * 1e3
 };
 function registerMetricsRoutes(app, store, collector) {
-  app.get("/api/metrics", (c) => {
+  app.get("/api/metrics", async (c) => {
     try {
       const metric = c.req.query("metric");
       const range = c.req.query("range") || "1h";
@@ -2754,7 +2768,7 @@ function registerMetricsRoutes(app, store, collector) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/metrics/latest", (_c) => {
+  app.get("/api/metrics/latest", async (_c) => {
     try {
       const snapshot = collector.getLastSnapshot();
       return _c.json(snapshot);
@@ -2845,7 +2859,7 @@ function registerAdvisorRoutes(app, pool, longQueryThreshold, store) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/advisor/ignored", (c) => {
+  app.get("/api/advisor/ignored", async (c) => {
     try {
       return c.json(getIgnoredIssues());
     } catch (err) {
@@ -2863,7 +2877,7 @@ function registerAdvisorRoutes(app, pool, longQueryThreshold, store) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.delete("/api/advisor/ignore/:issueId", (c) => {
+  app.delete("/api/advisor/ignore/:issueId", async (c) => {
     try {
       const issueId = c.req.param("issueId");
       unignoreIssue(issueId);
@@ -2872,7 +2886,7 @@ function registerAdvisorRoutes(app, pool, longQueryThreshold, store) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/advisor/history", (c) => {
+  app.get("/api/advisor/history", async (c) => {
     if (!store) return c.json([]);
     try {
       const range = c.req.query("range") || "24h";
@@ -2953,7 +2967,7 @@ function registerSchemaRoutes(app, pool, schemaTracker) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/schema/history", (c) => {
+  app.get("/api/schema/history", async (c) => {
     try {
       const limit = parseInt(c.req.query("limit") || "30");
       return c.json(schemaTracker.getHistory(limit));
@@ -2961,7 +2975,7 @@ function registerSchemaRoutes(app, pool, schemaTracker) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/schema/changes", (c) => {
+  app.get("/api/schema/changes", async (c) => {
     try {
       const since = c.req.query("since");
       return c.json(schemaTracker.getChanges(since ? parseInt(since) : void 0));
@@ -2969,14 +2983,14 @@ function registerSchemaRoutes(app, pool, schemaTracker) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/schema/changes/latest", (c) => {
+  app.get("/api/schema/changes/latest", async (c) => {
     try {
       return c.json(schemaTracker.getLatestChanges());
     } catch (err) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/schema/diff", (c) => {
+  app.get("/api/schema/diff", async (c) => {
     try {
       const from = parseInt(c.req.query("from") || "0");
       const to = parseInt(c.req.query("to") || "0");
@@ -3000,7 +3014,7 @@ function registerSchemaRoutes(app, pool, schemaTracker) {
 
 // src/server/routes/alerts.ts
 function registerAlertsRoutes(app, alertManager) {
-  app.get("/api/alerts/rules", (c) => {
+  app.get("/api/alerts/rules", async (c) => {
     try {
       return c.json(alertManager.getRules());
     } catch (err) {
@@ -3027,7 +3041,7 @@ function registerAlertsRoutes(app, alertManager) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.delete("/api/alerts/rules/:id", (c) => {
+  app.delete("/api/alerts/rules/:id", async (c) => {
     try {
       const id = parseInt(c.req.param("id"));
       const ok = alertManager.deleteRule(id);
@@ -3037,7 +3051,7 @@ function registerAlertsRoutes(app, alertManager) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/alerts/webhook-info", (c) => {
+  app.get("/api/alerts/webhook-info", async (c) => {
     try {
       const url = alertManager.getWebhookUrl();
       const type = alertManager.getWebhookType();
@@ -3055,7 +3069,7 @@ function registerAlertsRoutes(app, alertManager) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/alerts/history", (c) => {
+  app.get("/api/alerts/history", async (c) => {
     try {
       const limit = parseInt(c.req.query("limit") || "50");
       return c.json(alertManager.getHistory(limit));
@@ -3335,8 +3349,13 @@ function registerDiskRoutes(app, pool, store) {
                  (SELECT setting FROM pg_settings WHERE name = 'data_directory') AS data_dir
         `);
         const { db_size, data_dir } = dbRes.rows[0];
-        const tsRes = await client.query(`SELECT spcname, pg_tablespace_size(oid) AS size FROM pg_tablespace`);
-        const tablespaces = tsRes.rows.map((r) => ({
+        const tsRes = await client.query(`
+          SELECT spcname,
+            CASE WHEN has_tablespace_privilege(spcname, 'CREATE')
+              THEN pg_tablespace_size(oid) ELSE NULL END AS size
+          FROM pg_tablespace
+        `);
+        const tablespaces = tsRes.rows.filter((r) => r.size !== null).map((r) => ({
           name: r.spcname,
           size: parseInt(r.size)
         }));
@@ -3369,7 +3388,7 @@ function registerDiskRoutes(app, pool, store) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/disk/prediction", (c) => {
+  app.get("/api/disk/prediction", async (c) => {
     try {
       const days = parseInt(c.req.query("days") || "30");
       const maxDisk = c.req.query("maxDisk") ? parseInt(c.req.query("maxDisk")) : void 0;
@@ -3379,7 +3398,7 @@ function registerDiskRoutes(app, pool, store) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/disk/table-history/:table", (c) => {
+  app.get("/api/disk/table-history/:table", async (c) => {
     try {
       const table = c.req.param("table");
       const range = c.req.query("range") || "24h";
@@ -3391,7 +3410,7 @@ function registerDiskRoutes(app, pool, store) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/disk/history", (c) => {
+  app.get("/api/disk/history", async (c) => {
     try {
       const range = c.req.query("range") || "24h";
       const rangeMs = RANGE_MAP3[range] || RANGE_MAP3["24h"];
@@ -3600,7 +3619,7 @@ var RANGE_MAP4 = {
   "7d": 7 * 24 * 60 * 60 * 1e3
 };
 function registerQueryStatsRoutes(app, store) {
-  app.get("/api/query-stats/top", (c) => {
+  app.get("/api/query-stats/top", async (c) => {
     try {
       const range = c.req.query("range") || "1h";
       const orderBy = c.req.query("orderBy") || "total_time";
@@ -3613,7 +3632,7 @@ function registerQueryStatsRoutes(app, store) {
       return c.json({ error: err.message }, 500);
     }
   });
-  app.get("/api/query-stats/trend/:queryid", (c) => {
+  app.get("/api/query-stats/trend/:queryid", async (c) => {
     try {
       const queryid = c.req.param("queryid");
       const range = c.req.query("range") || "1h";