@indianic/dialout 1.12.1 → 1.13.1

package/node_modules/@indianic/dialout-shared/src/session-announce.test.ts

@@ -0,0 +1,48 @@
+import { describe, it, expect } from 'vitest';
+import { shouldAnnounceSession } from './session-announce';
+
+describe('shouldAnnounceSession', () => {
+  it('announces a session with no prior row at all', () => {
+    expect(shouldAnnounceSession(null, '2026-10-29T09:00:00Z')).toBe(true);
+    expect(shouldAnnounceSession(null, null)).toBe(true);
+  });
+
+  // The reported bug. The agent reconnects, the row was marked ended, and the
+  // same tmux session is re-reported — it is not news.
+  it('stays quiet when the prior row is the same session by creation time', () => {
+    expect(shouldAnnounceSession(
+      { endedAt: '2026-10-29T08:00:00Z', createdLocal: '2026-10-29T07:00:00Z', notifiedAt: null },
+      '2026-10-29T07:00:00Z',
+    )).toBe(false);
+  });
+
+  it('announces a genuinely new session that reuses a name', () => {
+    expect(shouldAnnounceSession(
+      { endedAt: '2026-10-29T08:00:00Z', createdLocal: '2026-10-29T07:00:00Z', notifiedAt: '2026-10-29T07:00:01Z' },
+      '2026-10-29T09:30:00Z',
+    )).toBe(true);
+  });
+
+  // Durable suppression: lastNewNotifiedAt is in memory, so a ws-server
+  // restart must not replay an announcement the database already recorded.
+  it('stays quiet when the prior row was already announced and is still live', () => {
+    expect(shouldAnnounceSession(
+      { endedAt: null, createdLocal: '2026-10-29T07:00:00Z', notifiedAt: '2026-10-29T07:00:01Z' },
+      '2026-10-29T07:00:00Z',
+    )).toBe(false);
+  });
+
+  // The documented reversal of the original push spec. Without a creation time
+  // there is no way to tell a revival from a new session, and the complaint is
+  // bursts, so silence is the right direction here.
+  it('treats a missing creation time on either side as the same session', () => {
+    expect(shouldAnnounceSession(
+      { endedAt: '2026-10-29T08:00:00Z', createdLocal: null, notifiedAt: null },
+      '2026-10-29T09:00:00Z',
+    )).toBe(false);
+    expect(shouldAnnounceSession(
+      { endedAt: '2026-10-29T08:00:00Z', createdLocal: '2026-10-29T07:00:00Z', notifiedAt: null },
+      null,
+    )).toBe(false);
+  });
+});

package/node_modules/@indianic/dialout-shared/src/session-announce.ts

@@ -0,0 +1,40 @@
+// packages/devdash-shared/src/session-announce.ts
+
+/**
+ * Whether a tmux session the agent just reported is news.
+ *
+ * The bug this exists to kill: the daemon's close handler used to set
+ * `ended_at` on every session, so a reconnect made the registry's UPDATE miss,
+ * take the INSERT branch, and push "New terminal" for every terminal that was
+ * already open. Task 2 stops writing `ended_at` there; this is the second
+ * line of defence, for a session the vanish-pass legitimately ended and that
+ * then came back.
+ */
+export interface PriorSession {
+  /** Null while the session is live. */
+  endedAt: string | null;
+  /** When tmux created the session, as the agent reported it. */
+  createdLocal: string | null;
+  /** When a push for this row went out, or null if none ever did. */
+  notifiedAt: string | null;
+}
+
+export function shouldAnnounceSession(
+  prior: PriorSession | null,
+  createdLocal: string | null,
+): boolean {
+  // Never seen on this machine under this name: unambiguously new.
+  if (!prior) return true;
+
+  // Both creation times known and different: tmux really did make a new
+  // session that happens to reuse the name.
+  if (prior.createdLocal && createdLocal && prior.createdLocal !== createdLocal) return true;
+
+  // Everything else is the same session returning — including the case where
+  // either creation time is missing. The original push spec said a missed
+  // notification is worse than an extra one; for this trigger that is
+  // backwards, because the failure being fixed is a burst. The cost is that an
+  // agent too old to report a creation time cannot announce a genuinely new
+  // session that reuses an old name.
+  return false;
+}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@indianic/dialout",
-  "version": "1.12.1",
-  "description": "Dialout agent \u2014 reach your office, home or build machine from any browser or phone. Remote tmux terminals, live port checks, filesystem browsing, process control and HTTP tunnels. The agent dials out: no inbound ports, no VPN, no port forwarding.",
+  "version": "1.13.1",
+  "description": "Dialout agent — reach your office, home or build machine from any browser or phone. Remote tmux terminals, live port checks, filesystem browsing, process control and HTTP tunnels. The agent dials out: no inbound ports, no VPN, no port forwarding.",
   "bin": {
     "dialout": "./bin/devdash-agent.js"
   },

package/scripts/postinstall.js

@@ -1,6 +1,5 @@
 #!/usr/bin/env node
 
-const { execSync } = require('child_process');
 const os = require('os');
 
 const GREEN = '\x1b[32m';
@@ -51,7 +50,7 @@ console.log('');
 
 if (!ptyOk) {
   console.log(`${YELLOW}  node-pty failed to load. Try rebuilding:${NC}`);
-  console.log(`  npm rebuild node-pty`);
+  console.log('  npm rebuild node-pty');
   console.log('');
 }
 
@@ -64,16 +63,16 @@ if (nodeOk && platformOk && ptyOk) {
 console.log('');
 console.log(`${CYAN}Next steps:${NC}`);
 console.log('');
-console.log('  1. Generate an API key in the DevDash web UI (MACHINES tab)');
+console.log('  1. Generate an API key in Dialout (Settings → Machines)');
 console.log('');
-console.log('  2. Configure the agent:');
-console.log(`     ${BOLD}devdash-agent init${NC}`);
+console.log('  2. Configure the agent (includes remote-control setup):');
+console.log(`     ${BOLD}dialout init${NC}`);
 console.log('');
-console.log('  3. Start the agent:');
-console.log(`     ${BOLD}devdash-agent start${NC}`);
+console.log('  3. Or wrap terminals later:');
+console.log(`     ${BOLD}dialout rc${NC}`);
 console.log('');
-console.log('  4. Install as service (auto-start on boot):');
-console.log(`     ${BOLD}devdash-agent install-service${NC}`);
+console.log('  4. Install as a service (auto-start):');
+console.log(`     ${BOLD}dialout install-service${NC}`);
 console.log('');
 console.log(`${BOLD}━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━${NC}`);
 console.log('');