@indexnetwork/protocol 4.15.0-rc.357.1 → 4.16.1-rc.359.1

package/dist/opportunity/opportunity.graph.js

@@ -17,8 +17,11 @@ import { resolveInitialStatus } from './opportunity.state.js';
 import { OpportunityEvaluator } from './opportunity.evaluator.js';
 import { IntentIndexer } from '../intent/intent.indexer.js';
 import { getModelName } from '../shared/agent/model.config.js';
+import { selectHydeDocumentsForGeneration } from '../shared/hyde/hyde.documents.js';
+import { getHydeGenerationMode } from '../shared/hyde/hyde.env.js';
 import { validateOpportunityActors } from './opportunity.utils.js';
-import { viewerCentricCardSummary } from './opportunity.presentation.js';
+import { safeFallbackSummary } from './opportunity.safe-presentation.js';
+import { hasUnsupportedOpportunityClaim } from './opportunity.claim-safety.js';
 import { persistOpportunities } from './opportunity.persist.js';
 import { INTRODUCER_DISCOVERY_SOURCE } from './opportunity.introducer.js';
 import { negotiateCandidates } from "../negotiation/negotiation.graph.js";
@@ -52,6 +55,9 @@ const routingLog = protocolLogger('OpportunityGraph:Routing');
 const DEDUP_WINDOW_MS = 30 * 24 * 60 * 60 * 1000;
 /** Default cap for source premises used by premise-to-premise discovery. Prevents BACKEND-5-style fan-out. */
 const DEFAULT_SOURCE_PREMISE_DISCOVERY_LIMIT = 40;
+function networkMembershipPairKey(userId, networkId) {
+    return `${userId}\u0000${networkId}`;
+}
 /** Per-source cap for candidate premise matches. */
 const PREMISE_MATCH_LIMIT_PER_SOURCE = 20;
 /** Resolve the source premise discovery cap from env, preserving 0 as an explicit disable switch. */
@@ -273,6 +279,7 @@ export class OpportunityGraphFactory {
                 .map((c) => ({
                 contextId: c.id,
                 networkId: c.networkId,
+                text: c.text,
                 embedding: c.embedding,
             }));
             return {
@@ -334,10 +341,11 @@ export class OpportunityGraphFactory {
                         }
                         targetIndexIds = [state.networkId];
                     }
-                    else if (state.indexScope && state.indexScope.length > 0) {
+                    else if (state.indexScope !== undefined) {
                         // Bounded scope (e.g. a network-scoped agent's reachable networks):
                         // intersect with the user's actual memberships so discovery never
-                        // reaches networks outside the agent's bound scope.
+                        // reaches networks outside the agent's bound scope. An explicit
+                        // empty scope is authoritative and must fail closed.
                         const allowed = new Set(state.indexScope);
                         targetIndexIds = state.userNetworks.filter((n) => allowed.has(n));
                         scopeLog.verbose('Applied indexScope intersection', {
@@ -350,6 +358,19 @@ export class OpportunityGraphFactory {
                         // Search all user's indexes
                         targetIndexIds = state.userNetworks;
                     }
+                    if (state.triggerIntentId) {
+                        // A trigger intent is an authoritative discovery boundary, not just
+                        // ranking context. Recompute the intersection at the graph edge so
+                        // direct chat/MCP callers cannot bypass FromIntentQueue admission.
+                        const assignedNetworkIds = new Set(await this.database.getNetworkIdsForIntent(state.triggerIntentId));
+                        const activeOwnerNetworkIds = new Set(state.userNetworks);
+                        targetIndexIds = targetIndexIds.filter((networkId) => assignedNetworkIds.has(networkId) && activeOwnerNetworkIds.has(networkId));
+                        scopeLog.verbose('Applied trigger-intent network intersection', {
+                            triggerIntentId: state.triggerIntentId,
+                            assignedCount: assignedNetworkIds.size,
+                            targetCount: targetIndexIds.length,
+                        });
+                    }
                     // Fetch index details
                     const targetNetworks = await Promise.all(targetIndexIds.map(async (networkId) => {
                         const index = await this.database.getNetwork(networkId);
@@ -483,6 +504,19 @@ export class OpportunityGraphFactory {
                 try {
                     let resolvedIntentId;
                     if (state.triggerIntentId) {
+                        const isOwnedActiveIntent = state.indexedIntents.some((intent) => intent.intentId === state.triggerIntentId);
+                        if (!isOwnedActiveIntent) {
+                            resolveLog.warn('Trigger intent is not an active intent owned by the discovery user', {
+                                triggerIntentId: state.triggerIntentId,
+                                userId: state.userId,
+                            });
+                            return {
+                                resolvedTriggerIntentId: undefined,
+                                resolvedIntentInIndex: false,
+                                discoverySource: 'context',
+                                error: 'Trigger intent is not available for discovery.',
+                            };
+                        }
                         const inNetwork = await this.database.getNetworkIdsForIntent(state.triggerIntentId);
                         const inTarget = inNetwork.some((id) => targetIndexIds.includes(id));
                         resolvedIntentId = state.triggerIntentId;
@@ -961,7 +995,8 @@ export class OpportunityGraphFactory {
                         const contextCandidates = [];
                         for (const ctx of state.sourceContexts.filter(c => targetNetworkIds.includes(c.networkId))) {
                             // Attempt HyDE-enhanced search first
-                            const hydeDocs = await self.database.getHydeDocumentsForSource('context', ctx.contextId);
+                            const persistedHydeDocs = await self.database.getHydeDocumentsForSource('context', ctx.contextId);
+                            const hydeDocs = selectHydeDocumentsForGeneration(persistedHydeDocs, getHydeGenerationMode(), ctx.text);
                             const lensEmbeddings = hydeDocs
                                 .filter(d => d.hydeEmbedding?.length > 0)
                                 .map(d => ({
@@ -1319,6 +1354,38 @@ export class OpportunityGraphFactory {
                 const dedupedCandidates = Array.from(bestByUser.values());
                 // Re-sort by similarity descending (Map iteration order doesn't guarantee sort)
                 dedupedCandidates.sort((a, b) => b.similarity - a.similarity);
+                const discoveryUserId = state.onBehalfOfUserId ?? state.userId;
+                let eligibleCandidates;
+                try {
+                    const requestedPairs = dedupedCandidates.flatMap((candidate) => [
+                        { userId: discoveryUserId, networkId: candidate.networkId },
+                        { userId: candidate.candidateUserId, networkId: candidate.networkId },
+                    ]);
+                    const activePairs = await this.database.getActiveNetworkMembershipPairs(requestedPairs);
+                    const activePairKeys = new Set(activePairs.map((pair) => networkMembershipPairKey(pair.userId, pair.networkId)));
+                    eligibleCandidates = dedupedCandidates.filter((candidate) => activePairKeys.has(networkMembershipPairKey(discoveryUserId, candidate.networkId))
+                        && activePairKeys.has(networkMembershipPairKey(candidate.candidateUserId, candidate.networkId)));
+                }
+                catch (error) {
+                    evaluationLog.error('Active network membership recheck failed; skipping evaluation', { error });
+                    return {
+                        candidates: [],
+                        evaluatedOpportunities: [],
+                        remainingCandidates: [],
+                        error: 'Failed to validate candidate network memberships.',
+                        agentTimings: [],
+                    };
+                }
+                if (eligibleCandidates.length < dedupedCandidates.length) {
+                    evaluationLog.info('Removed candidates without active network pairs before evaluation', {
+                        before: dedupedCandidates.length,
+                        after: eligibleCandidates.length,
+                        removed: dedupedCandidates.length - eligibleCandidates.length,
+                    });
+                }
+                if (eligibleCandidates.length === 0) {
+                    return { candidates: [], evaluatedOpportunities: [], remainingCandidates: [], agentTimings: [] };
+                }
                 if (dedupedCandidates.length < sortedCandidates.length) {
                     evaluationLog.info("Deduped candidates by userId", {
                         before: sortedCandidates.length,
@@ -1326,8 +1393,8 @@ export class OpportunityGraphFactory {
                         removed: sortedCandidates.length - dedupedCandidates.length,
                     });
                 }
-                const batchToEvaluate = dedupedCandidates.slice(0, EVAL_BATCH_SIZE);
-                const remaining = dedupedCandidates.slice(EVAL_BATCH_SIZE);
+                const batchToEvaluate = eligibleCandidates.slice(0, EVAL_BATCH_SIZE);
+                const remaining = eligibleCandidates.slice(EVAL_BATCH_SIZE);
                 // Early termination: if search was query-driven and no query-sourced candidates remain,
                 // clear remaining to prevent pointless pagination through non-query leftovers
                 const isQueryDriven = !!state.searchQuery?.trim();
@@ -1347,7 +1414,6 @@ export class OpportunityGraphFactory {
                 }
                 const agentTimingsAccum = [];
                 try {
-                    const discoveryUserId = state.onBehalfOfUserId ?? state.userId;
                     const sourceProfile = await this.database.getProfile(discoveryUserId);
                     const sourceEntity = {
                         userId: discoveryUserId,
@@ -1686,6 +1752,7 @@ export class OpportunityGraphFactory {
                     // Only pass opportunities that passed the threshold to downstream nodes
                     const passedOpportunities = evaluatedOpportunities.filter((o) => o.score >= minScore);
                     return {
+                        candidates: eligibleCandidates,
                         evaluatedOpportunities: passedOpportunities,
                         remainingCandidates: effectiveRemaining,
                         trace: traceEntries,
@@ -1940,11 +2007,21 @@ export class OpportunityGraphFactory {
                     const counterpartName = candidate.candidateUser.profile?.name ?? '';
                     const viewerName = sourceUser.profile.name;
                     const rawReasoning = updated.interpretation?.reasoning ?? '';
-                    const personalizedSummary = viewerCentricCardSummary(rawReasoning, counterpartName, undefined, viewerName);
+                    const personalizedSummary = safeFallbackSummary(rawReasoning, {
+                        counterpartName,
+                        viewerName,
+                        emptyText: 'A suggested connection.',
+                    });
                     traceEmitter?.({
                         type: 'opportunity_draft_ready',
                         opportunityId: candidate.opportunityId,
-                        opportunity: updated,
+                        opportunity: {
+                            ...updated,
+                            interpretation: {
+                                ...updated.interpretation,
+                                reasoning: personalizedSummary,
+                            },
+                        },
                         personalizedSummary,
                         counterparty: {
                             userId: candidate.candidateUser.id,
@@ -2347,6 +2424,77 @@ export class OpportunityGraphFactory {
                     return { opportunities: [] };
                 }
                 try {
+                    // Recompute the authoritative owner-side scope at the final boundary.
+                    // The adapter receives this immutable request scope and locks current
+                    // memberships plus trigger-intent assignments through commit.
+                    const currentOwnerMemberships = await this.database.getNetworkMemberships(state.userId);
+                    let finalAllowedNetworkIds = currentOwnerMemberships.map((membership) => membership.networkId);
+                    // Only an explicit trigger intent is an authoritative network boundary.
+                    // Ad-hoc global discovery may heuristically resolve a matching intent
+                    // for ranking, but must retain its all-membership reach.
+                    const finalTriggerIntentId = state.triggerIntentId;
+                    if (finalTriggerIntentId) {
+                        const currentAssignments = new Set(await this.database.getNetworkIdsForIntent(finalTriggerIntentId));
+                        finalAllowedNetworkIds = finalAllowedNetworkIds.filter((networkId) => currentAssignments.has(networkId));
+                    }
+                    const explicitScope = state.networkId
+                        ? [state.networkId]
+                        : state.indexScope;
+                    if (explicitScope !== undefined) {
+                        const explicitlyAllowed = new Set(explicitScope);
+                        finalAllowedNetworkIds = finalAllowedNetworkIds.filter((networkId) => explicitlyAllowed.has(networkId));
+                    }
+                    finalAllowedNetworkIds = [...new Set(finalAllowedNetworkIds)];
+                    if (finalAllowedNetworkIds.length === 0) {
+                        persistLog.info('Skipped persistence because final discovery scope is empty', {
+                            userId: state.userId,
+                            triggerIntentId: finalTriggerIntentId,
+                        });
+                        return { opportunities: [] };
+                    }
+                    const finalAllowedNetworks = new Set(finalAllowedNetworkIds);
+                    const networkEligibility = {
+                        ownerUserId: state.userId,
+                        allowedNetworkIds: finalAllowedNetworkIds,
+                        ...(finalTriggerIntentId ? { triggerIntentId: finalTriggerIntentId } : {}),
+                    };
+                    // Recheck evaluator participants before any dedup/reactivation/write.
+                    // Persistence-only introducers are deliberately absent here: personal-
+                    // network contact discovery validates the evaluated owner/candidate
+                    // pairs without requiring the owner actor that is added below.
+                    const requestedPairs = state.evaluatedOpportunities.flatMap((evaluated) => evaluated.actors.flatMap((actor) => actor.networkId
+                        ? [{ userId: actor.userId, networkId: actor.networkId }]
+                        : []));
+                    const activePairs = await this.database.getActiveNetworkMembershipPairs(requestedPairs);
+                    const activePairKeys = new Set(activePairs.map((pair) => networkMembershipPairKey(pair.userId, pair.networkId)));
+                    const evaluatedToPersist = state.evaluatedOpportunities.filter((evaluated) => evaluated.actors.length > 0
+                        && evaluated.actors.every((actor) => actor.networkId != null
+                            && finalAllowedNetworks.has(actor.networkId)
+                            && activePairKeys.has(networkMembershipPairKey(actor.userId, actor.networkId))));
+                    if (evaluatedToPersist.length < state.evaluatedOpportunities.length) {
+                        persistLog.info('Skipped opportunities with inactive participant network pairs', {
+                            before: state.evaluatedOpportunities.length,
+                            after: evaluatedToPersist.length,
+                            removed: state.evaluatedOpportunities.length - evaluatedToPersist.length,
+                        });
+                    }
+                    if (evaluatedToPersist.length === 0)
+                        return { opportunities: [] };
+                    const updateStatusIfStillEligible = async (opportunityId, status, existingActors) => {
+                        // Reactivation preserves the existing opportunity row, so lock the
+                        // existing participant anchors rather than the evaluator's current
+                        // (often network-less) actor output. Introducers do not participate
+                        // in matching eligibility and must not suppress a valid pair.
+                        const anchors = existingActors.filter((actor) => actor.role !== 'introducer');
+                        if (anchors.length === 0 || anchors.some((actor) => !finalAllowedNetworks.has(actor.networkId))) {
+                            return null;
+                        }
+                        if (!this.database.updateOpportunityStatusIfNetworkEligible) {
+                            persistLog.error('Network-eligible status update adapter is unavailable; failing closed');
+                            return null;
+                        }
+                        return this.database.updateOpportunityStatusIfNetworkEligible(opportunityId, status, anchors, networkEligibility);
+                    };
                     const itemsToPersist = [];
                     const reactivatedOpportunities = [];
                     const existingBetweenActors = [];
@@ -2374,7 +2522,7 @@ export class OpportunityGraphFactory {
                         // counterparty, not between the introducer and the counterparty.
                         const dedupUserId = (state.onBehalfOfUserId ?? state.userId);
                         const uniqueCounterparts = new Set();
-                        for (const evaluated of state.evaluatedOpportunities) {
+                        for (const evaluated of evaluatedToPersist) {
                             const candidateUserId = evaluated.actors.find(a => a.userId !== dedupUserId)?.userId;
                             if (candidateUserId)
                                 uniqueCounterparts.add(candidateUserId);
@@ -2394,7 +2542,7 @@ export class OpportunityGraphFactory {
                         }));
                         dedupAlreadyAccepted.push(...lookups.flat());
                     }
-                    for (const evaluated of state.evaluatedOpportunities) {
+                    for (const evaluated of evaluatedToPersist) {
                         const indexIdForActors = state.networkId ?? evaluated.actors[0]?.networkId;
                         let actors;
                         let data;
@@ -2493,7 +2641,7 @@ export class OpportunityGraphFactory {
                                     if (existing.status === 'stalled' || sameIntroducer) {
                                         // Introduction path always targets 'draft' (chat-only surface) rather than using
                                         // initialStatus, because introductions are always chat-initiated, not background-discovered.
-                                        const reactivated = await this.database.updateOpportunityStatus(existing.id, 'draft');
+                                        const reactivated = await updateStatusIfStillEligible(existing.id, 'draft', existing.actors);
                                         if (reactivated) {
                                             persistLog.verbose('Reactivated opportunity (introduction path)', {
                                                 opportunityId: existing.id,
@@ -2526,7 +2674,7 @@ export class OpportunityGraphFactory {
                                             continue;
                                         }
                                     }
-                                    const reactivated = await this.database.updateOpportunityStatus(existing.id, 'draft');
+                                    const reactivated = await updateStatusIfStillEligible(existing.id, 'draft', existing.actors);
                                     if (reactivated) {
                                         persistLog.info('Resuming orphaned negotiating opportunity (introduction path)', {
                                             opportunityId: existing.id,
@@ -2539,7 +2687,7 @@ export class OpportunityGraphFactory {
                                 }
                                 else if (existing.status === 'latent') {
                                     // Upgrade latent to draft for introduction path
-                                    const upgraded = await this.database.updateOpportunityStatus(existing.id, 'draft');
+                                    const upgraded = await updateStatusIfStillEligible(existing.id, 'draft', existing.actors);
                                     if (upgraded) {
                                         persistLog.verbose('Upgraded latent opportunity to draft (introduction path)', {
                                             opportunityId: existing.id,
@@ -2655,7 +2803,7 @@ export class OpportunityGraphFactory {
                                     // Reactivate expired or stalled opportunities.
                                     // Stalled opportunities are reactivated regardless of age: a stalled negotiation
                                     // is still in-flight for this pair, so we resume it rather than create a parallel one.
-                                    const reactivated = await this.database.updateOpportunityStatus(existing.id, initialStatus);
+                                    const reactivated = await updateStatusIfStillEligible(existing.id, initialStatus, existing.actors);
                                     if (reactivated) {
                                         persistLog.verbose('Reactivated opportunity', {
                                             opportunityId: existing.id,
@@ -2691,7 +2839,7 @@ export class OpportunityGraphFactory {
                                         }
                                     }
                                     // Task is stale or missing — reactivate the orphaned negotiating opportunity
-                                    const reactivated = await this.database.updateOpportunityStatus(existing.id, initialStatus);
+                                    const reactivated = await updateStatusIfStillEligible(existing.id, initialStatus, existing.actors);
                                     if (reactivated) {
                                         persistLog.info('Resuming orphaned negotiating opportunity', {
                                             opportunityId: existing.id,
@@ -2704,7 +2852,7 @@ export class OpportunityGraphFactory {
                                 }
                                 else if (existing.status === 'latent' && initialStatus !== 'latent') {
                                     // Upgrade latent (background-discovered) to the higher-priority status (e.g. pending)
-                                    const upgraded = await this.database.updateOpportunityStatus(existing.id, initialStatus);
+                                    const upgraded = await updateStatusIfStillEligible(existing.id, initialStatus, existing.actors);
                                     if (upgraded) {
                                         persistLog.verbose('Upgraded latent opportunity to higher-priority status', {
                                             opportunityId: existing.id,
@@ -2774,6 +2922,13 @@ export class OpportunityGraphFactory {
                                 },
                             };
                         }
+                        if (hasUnsupportedOpportunityClaim(data.interpretation.reasoning)) {
+                            persistLog.warn('Skipping opportunity with unsupported affiliation/presence claim at persistence boundary', {
+                                source: data.detection.source,
+                                triggerIntentId: data.detection.triggeredBy,
+                            });
+                            continue;
+                        }
                         try {
                             validateOpportunityActors(data.actors);
                         }
@@ -2841,6 +2996,7 @@ export class OpportunityGraphFactory {
                         database: this.database,
                         embedder: this.embedder,
                         items: itemsForPersistence,
+                        networkEligibility,
                     });
                     const allOpportunities = [...reactivatedOpportunities, ...createdList];
                     persistLog.verbose('Persistence complete', {
@@ -2990,7 +3146,10 @@ export class OpportunityGraphFactory {
                             indexName: indexRecord?.title ?? (actorIndexId ?? ''),
                             connectedWith,
                             suggestedBy,
-                            reasoning: opp.interpretation?.reasoning ?? 'Connection opportunity',
+                            reasoning: safeFallbackSummary(opp.interpretation?.reasoning, {
+                                counterpartName: connectedWith.join(' and '),
+                                emptyText: 'Connection opportunity',
+                            }),
                             status: opp.status,
                             category,
                             confidence: confidence != null ? confidence : null,