@inco/lightning 0.8.0-devnet-2 → 0.8.0-devnet-3

package/src/test/TestUpgrade.t.sol

@@ -9,6 +9,10 @@ import {IOwnerManager} from "safe-smart-account/interfaces/IOwnerManager.sol";
 import {IncoTest} from "./IncoTest.sol";
 import {inco} from "../Lib.sol";
 import {IncoLightning} from "../IncoLightning.sol";
+import {IncoVerifier} from "../IncoVerifier.sol";
+import {SessionVerifier, Session} from "../periphery/SessionVerifier.sol";
+import {ALLOWANCE_GRANTED_MAGIC_VALUE} from "../Types.sol";
+import {ERC1967Proxy} from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy.sol";
 import {IVersion} from "../version/interfaces/IVersion.sol";
 import {Version} from "../version/Version.sol";
 import {IIncoVerifier} from "../interfaces/IIncoVerifier.sol";
@@ -196,6 +200,116 @@ contract TestUpgrade is IncoTest {
         inco.upgradeToAndCall(address(v2Impl), "");
     }
 
+    // ============ IncoVerifier Tests ============
+
+    function test_IncoVerifier_GetEIP712Name() public view {
+        IncoVerifier verifier = IncoVerifier(address(inco.incoVerifier()));
+        string memory name = verifier.getEIP712Name();
+        // Name should not be empty
+        assertGt(bytes(name).length, 0, "EIP712 name should not be empty");
+    }
+
+    function test_IncoVerifier_GetEIP712Version() public view {
+        IncoVerifier verifier = IncoVerifier(address(inco.incoVerifier()));
+        string memory version = verifier.getEIP712Version();
+        // Version should not be empty
+        assertGt(bytes(version).length, 0, "EIP712 version should not be empty");
+    }
+
+    function test_IncoVerifier_Upgrade_ByOwner_Succeeds() public {
+        IncoVerifier verifier = IncoVerifier(address(inco.incoVerifier()));
+
+        // Deploy a new IncoVerifier implementation
+        IncoVerifier newImpl = new IncoVerifier(address(inco));
+
+        // Upgrade by owner should succeed
+        vm.prank(owner);
+        verifier.upgradeToAndCall(address(newImpl), "");
+    }
+
+    function test_IncoVerifier_Upgrade_ByNonOwner_Fails() public {
+        IncoVerifier verifier = IncoVerifier(address(inco.incoVerifier()));
+
+        // Deploy a new IncoVerifier implementation
+        IncoVerifier newImpl = new IncoVerifier(address(inco));
+
+        // Upgrade by non-owner should fail
+        vm.prank(alice);
+        vm.expectRevert();
+        verifier.upgradeToAndCall(address(newImpl), "");
+    }
+
+    // ============ SessionVerifier Tests ============
+
+    function test_SessionVerifier_ValidSession_ReturnsAllowanceGranted() public {
+        SessionVerifier verifier = new SessionVerifier("");
+
+        bytes memory sharerArgData = abi.encode(Session({decrypter: bob, expiresAt: block.timestamp + 1 days}));
+
+        bytes32 result = verifier.canUseSession(bytes32(0), bob, sharerArgData, "");
+        assertEq(result, ALLOWANCE_GRANTED_MAGIC_VALUE, "Valid session should return ALLOWANCE_GRANTED_MAGIC_VALUE");
+    }
+
+    function test_SessionVerifier_ExpiredSession_ReturnsZero() public {
+        SessionVerifier verifier = new SessionVerifier("");
+
+        // Create session that expired 1 second ago
+        bytes memory sharerArgData = abi.encode(Session({decrypter: bob, expiresAt: block.timestamp - 1}));
+
+        bytes32 result = verifier.canUseSession(bytes32(0), bob, sharerArgData, "");
+        assertEq(result, bytes32(0), "Expired session should return bytes32(0)");
+    }
+
+    function test_SessionVerifier_WrongDecrypter_ReturnsZero() public {
+        SessionVerifier verifier = new SessionVerifier("");
+
+        // Session is valid but decrypter doesn't match caller
+        bytes memory sharerArgData = abi.encode(Session({decrypter: alice, expiresAt: block.timestamp + 1 days}));
+
+        bytes32 result = verifier.canUseSession(bytes32(0), bob, sharerArgData, "");
+        assertEq(result, bytes32(0), "Wrong decrypter should return bytes32(0)");
+    }
+
+    function test_SessionVerifier_Initialize() public {
+        SessionVerifier impl = new SessionVerifier("");
+        ERC1967Proxy proxy = new ERC1967Proxy(address(impl), "");
+        SessionVerifier verifier = SessionVerifier(address(proxy));
+
+        verifier.initialize(alice);
+        assertEq(verifier.owner(), alice, "Owner should be alice after initialize");
+    }
+
+    function test_SessionVerifier_Upgrade_ByOwner_Succeeds() public {
+        SessionVerifier impl = new SessionVerifier("");
+        ERC1967Proxy proxy = new ERC1967Proxy(address(impl), "");
+        SessionVerifier verifier = SessionVerifier(address(proxy));
+
+        verifier.initialize(alice);
+
+        // Deploy new implementation
+        SessionVerifier newImpl = new SessionVerifier("");
+
+        // Upgrade by owner should succeed
+        vm.prank(alice);
+        verifier.upgradeToAndCall(address(newImpl), "");
+    }
+
+    function test_SessionVerifier_Upgrade_ByNonOwner_Fails() public {
+        SessionVerifier impl = new SessionVerifier("");
+        ERC1967Proxy proxy = new ERC1967Proxy(address(impl), "");
+        SessionVerifier verifier = SessionVerifier(address(proxy));
+
+        verifier.initialize(alice);
+
+        // Deploy new implementation
+        SessionVerifier newImpl = new SessionVerifier("");
+
+        // Upgrade by non-owner should fail
+        vm.prank(bob);
+        vm.expectRevert();
+        verifier.upgradeToAndCall(address(newImpl), "");
+    }
+
     // Helpers
     function _txHash(Safe _safe, address to, uint256 value, bytes memory data) internal view returns (bytes32) {
         return _safe.getTransactionHash(

package/src/test/TestVersion.t.sol

@@ -25,6 +25,7 @@ contract TestVersion is Test {
         assertEq(someContract.getName(), "SomeContract");
         assertEq(someContract.getVersion(), "1_2_3");
         assertEq(someContract.getVersionedName(), "SomeContract_1_2_3__12345678");
+        assertEq(someContract.salt(), bytes32(uint256(12345678)));
     }
 
 }